Re: [PATCH 2/4] Accept Both ESC and F8 as user interrupt keys

2018-04-05 Thread Daniel Kiper
On Wed, Mar 28, 2018 at 05:58:16PM +0200, Hans de Goede wrote: > Hi, > > On 28-03-18 17:11, Lennart Sorensen wrote: > >On Wed, Mar 28, 2018 at 05:06:53PM +0200, Hans de Goede wrote: > >>Hmm, well people will still be able to use ESC to get the grub boot > >>menu, rather then the firmware boot-menu

Re: [PATCH 2/4] Accept Both ESC and F8 as user interrupt keys

2018-03-28 Thread Hans de Goede
Hi, On 28-03-18 17:11, Lennart Sorensen wrote: On Wed, Mar 28, 2018 at 05:06:53PM +0200, Hans de Goede wrote: Hmm, well people will still be able to use ESC to get the grub boot menu, rather then the firmware boot-menu on those. The problem is that our current check for ESC only approach is

Re: [PATCH 2/4] Accept Both ESC and F8 as user interrupt keys

2018-03-28 Thread Lennart Sorensen
On Wed, Mar 28, 2018 at 05:06:53PM +0200, Hans de Goede wrote: > Hmm, well people will still be able to use ESC to get the grub boot > menu, rather then the firmware boot-menu on those. > > The problem is that our current check for ESC only approach is problematic > because it conflicts with the

Re: [PATCH 2/4] Accept Both ESC and F8 as user interrupt keys

2018-03-28 Thread Hans de Goede
Hi, On 28-03-18 16:56, Lennart Sorensen wrote: On Wed, Mar 28, 2018 at 04:50:26PM +0200, Hans de Goede wrote: On most Bay Trail, Cherry Trail and Apollo Lake devices the ESC key is the hotkey to enter the BIOS/EFI setup screen. This makes it hard for the user to show the grub-menu when it is

Re: [PATCH 2/4] Accept Both ESC and F8 as user interrupt keys

2018-03-28 Thread Lennart Sorensen
On Wed, Mar 28, 2018 at 04:50:26PM +0200, Hans de Goede wrote: > On most Bay Trail, Cherry Trail and Apollo Lake devices the ESC key is > the hotkey to enter the BIOS/EFI setup screen. > > This makes it hard for the user to show the grub-menu when it is hidden > and a short timeout is used,

[PATCH 2/4] Accept Both ESC and F8 as user interrupt keys

2018-03-28 Thread Hans de Goede
On most Bay Trail, Cherry Trail and Apollo Lake devices the ESC key is the hotkey to enter the BIOS/EFI setup screen. This makes it hard for the user to show the grub-menu when it is hidden and a short timeout is used, because pressing ESC too early leads to the user entering the BIOS/EFI setup