Re: [PATCH 4/4] Allow protocol to be separated from host with a semicolon

On Wed, Jan 25, 2017 at 9:30 AM, Andrei Borzenkov wrote: > 24.01.2017 23:50, Matthew Garrett пишет: >> The DHCP server will return a string in the boot_file field. If you >> want to indicate that this file should be obtained over http, the >> easiest way to handle this is to

Re: [PATCH 4/4] Allow protocol to be separated from host with a semicolon

24.01.2017 23:50, Matthew Garrett пишет: > On Mon, Jan 23, 2017 at 8:02 PM, Andrei Borzenkov wrote: >> 24.01.2017 03:36, Matthew Garrett пишет: >>> Some DHCP servers (such as dnsmasq) tokenise parameters with commas, making >>> it impossible to pass boot files with commas in

Re: [PATCH 4/4] Allow protocol to be separated from host with a semicolon

On Wed, Jan 25, 2017 at 12:35 AM, Michael Chang wrote: > On Tue, Jan 24, 2017 at 10:21:22PM -0800, Matthew Garrett wrote: >> We're passing the bootfile to grub in order to obtain further >> configuration, so the firmware isn't relevant here. > > I mean that firmware may not be

Re: [PATCH 4/4] Allow protocol to be separated from host with a semicolon

On Tue, Jan 24, 2017 at 11:37 PM, Andrei Borzenkov wrote: > On Wed, Jan 25, 2017 at 10:16 AM, Matthew Garrett wrote: >> My experience is that configfile (http,example.com)grub/config works >> as you'd expect it to, and that set >>

Re: [PATCH 4/4] Allow protocol to be separated from host with a semicolon

On Tue, Jan 24, 2017 at 10:21:22PM -0800, Matthew Garrett wrote: > On Tue, Jan 24, 2017 at 10:18 PM, Michael Chang wrote: > > On Tue, Jan 24, 2017 at 12:50:37PM -0800, Matthew Garrett wrote: > >> The DHCP server will return a string in the boot_file field. If you > >> want to

Re: [PATCH 4/4] Allow protocol to be separated from host with a semicolon

On Wed, Jan 25, 2017 at 10:16 AM, Matthew Garrett wrote: > On Tue, Jan 24, 2017 at 10:56 PM, Andrei Borzenkov > wrote: >> On Wed, Jan 25, 2017 at 7:25 AM, Matthew Garrett wrote: >>> If prefix isn't set then won't bootfile be interpreted

Re: [PATCH 4/4] Allow protocol to be separated from host with a semicolon

On Tue, Jan 24, 2017 at 10:56 PM, Andrei Borzenkov wrote: > On Wed, Jan 25, 2017 at 7:25 AM, Matthew Garrett wrote: >> If prefix isn't set then won't bootfile be interpreted as the device plus >> file? >> > > No. That would mean "parsing URI" that I

Re: [PATCH 4/4] Allow protocol to be separated from host with a semicolon

On Wed, Jan 25, 2017 at 7:25 AM, Matthew Garrett wrote: > On Tue, Jan 24, 2017 at 8:15 PM, Andrei Borzenkov wrote: >> 25.01.2017 07:06, Matthew Garrett пишет: >>> I don't understand - grub_net_open_real() already handles this case: >> >> Because bootfile

Re: [PATCH 4/4] Allow protocol to be separated from host with a semicolon

On Tue, Jan 24, 2017 at 10:18 PM, Michael Chang wrote: > On Tue, Jan 24, 2017 at 12:50:37PM -0800, Matthew Garrett wrote: >> The DHCP server will return a string in the boot_file field. If you >> want to indicate that this file should be obtained over http, the >> easiest way to

Re: [PATCH 4/4] Allow protocol to be separated from host with a semicolon

On Tue, Jan 24, 2017 at 12:50:37PM -0800, Matthew Garrett wrote: > On Mon, Jan 23, 2017 at 8:02 PM, Andrei Borzenkov wrote: > > 24.01.2017 03:36, Matthew Garrett пишет: > >> Some DHCP servers (such as dnsmasq) tokenise parameters with commas, making > >> it impossible to pass

Re: [PATCH 4/4] Allow protocol to be separated from host with a semicolon

On Tue, Jan 24, 2017 at 8:15 PM, Andrei Borzenkov wrote: > 25.01.2017 07:06, Matthew Garrett пишет: >> I don't understand - grub_net_open_real() already handles this case: > > Because bootfile from DHCP packet is not used to set device part of > $prefix. Setting bootfile to

Re: [PATCH 4/4] Allow protocol to be separated from host with a semicolon

25.01.2017 07:06, Matthew Garrett пишет: > On Tue, Jan 24, 2017 at 7:48 PM, Andrei Borzenkov wrote: >> 24.01.2017 23:50, Matthew Garrett пишет: >>> On Mon, Jan 23, 2017 at 8:02 PM, Andrei Borzenkov >>> wrote: 24.01.2017 03:36, Matthew Garrett

Re: [PATCH 4/4] Allow protocol to be separated from host with a semicolon

On Tue, Jan 24, 2017 at 7:48 PM, Andrei Borzenkov wrote: > 24.01.2017 23:50, Matthew Garrett пишет: >> On Mon, Jan 23, 2017 at 8:02 PM, Andrei Borzenkov >> wrote: >>> 24.01.2017 03:36, Matthew Garrett пишет: Some DHCP servers (such as dnsmasq)

Re: [PATCH 4/4] Allow protocol to be separated from host with a semicolon

24.01.2017 23:50, Matthew Garrett пишет: > On Mon, Jan 23, 2017 at 8:02 PM, Andrei Borzenkov wrote: >> 24.01.2017 03:36, Matthew Garrett пишет: >>> Some DHCP servers (such as dnsmasq) tokenise parameters with commas, making >>> it impossible to pass boot files with commas in

Re: [PATCH 4/4] Allow protocol to be separated from host with a semicolon

On Mon, Jan 23, 2017 at 8:02 PM, Andrei Borzenkov wrote: > 24.01.2017 03:36, Matthew Garrett пишет: >> Some DHCP servers (such as dnsmasq) tokenise parameters with commas, making >> it impossible to pass boot files with commas in them. Allow using a > > grub_net_open()

[PATCH 4/4] Allow protocol to be separated from host with a semicolon

Some DHCP servers (such as dnsmasq) tokenise parameters with commas, making it impossible to pass boot files with commas in them. Allow using a semicolon to separate the protocol from host if a comma wasn't found. --- grub-core/net/net.c | 4 1 file changed, 4 insertions(+) diff --git

Re: [PATCH 4/4] Allow protocol to be separated from host with a semicolon

24.01.2017 03:36, Matthew Garrett пишет: > Some DHCP servers (such as dnsmasq) tokenise parameters with commas, making > it impossible to pass boot files with commas in them. Allow using a grub_net_open() operates on devices, not files. Please give more details about your problem. > semicolon to

[PATCH 4/4] Allow protocol to be separated from host with a semicolon

Some DHCP servers (such as dnsmasq) tokenise parameters with commas, making it impossible to pass boot files with commas in them. Allow using a semicolon to separate the protocol from host if a comma wasn't found. --- grub-core/net/net.c | 4 1 file changed, 4 insertions(+) diff --git