Rules for committers? (was Re: [PATCH v2] Fix syslinux_test in out-of-tree builds)

2019-03-02 Thread Colin Watson
On Fri, Mar 01, 2019 at 12:52:37PM +0100, Daniel Kiper wrote: > On Wed, Feb 27, 2019 at 10:26:30AM +, Colin Watson wrote: > > Signed-off-by: Colin Watson > > Reviewed-by: Daniel Kiper This reminds me: as somebody who has direct GRUB commit access but hasn't used it much directly since the n

Re: [PATCH v2] Fix syslinux_test in out-of-tree builds

2019-03-01 Thread Daniel Kiper
On Wed, Feb 27, 2019 at 10:26:30AM +, Colin Watson wrote: > syslinux_parse simplifies some filenames by removing things like ".." > segments, but the tests assumed that @abs_top_srcdir@ would be > untouched, which is not true in the case of out-of-tree builds where > @abs_top_srcdir@ may contai

[PATCH v2] Fix syslinux_test in out-of-tree builds

2019-02-27 Thread Colin Watson
syslinux_parse simplifies some filenames by removing things like ".." segments, but the tests assumed that @abs_top_srcdir@ would be untouched, which is not true in the case of out-of-tree builds where @abs_top_srcdir@ may contain ".." segments. Performing the substitution requires some awkwardnes