Re: [PATCH v2] grub-file: fix segmentation fault

On Tue, Nov 22, 2016 at 09:39:43PM +0300, Andrei Borzenkov wrote: > 22.11.2016 10:10, Michael Chang пишет: > > What about attached patch? It does not increase size of kernel. Just some nitpicks in comments and a potential leak in fail path (See below), otherwise LGTM. > > I am not thrilled as

Re: [PATCH v2] grub-file: fix segmentation fault

22.11.2016 10:10, Michael Chang пишет: > On Fri, Nov 18, 2016 at 11:50:25AM +0300, Andrei Borzenkov wrote: >> Hmm ... I must admit I am confused how we can get NULL here. Filters >> are called after primary file->name is set and each filter copies >> previous struct file, which means returned file

Re: [PATCH v2] grub-file: fix segmentation fault

I have to resend the mail as the attached kernel image is too big that may not reach the list eventually. Sorry if you get duplicated mail. If you still have problem with reproducing the problem please let me know. I could provide download link for the kernel file. On Fri, Nov 18, 2016 at

Re: [PATCH v2] grub-file: fix segmentation fault

On Thu, Nov 17, 2016 at 10:08 PM, Daniel Kiper wrote: > On Tue, Apr 12, 2016 at 02:24:12PM +0800, Michael Chang wrote: >> In grub_file_open the file handle returned by file filters has no file->name >> set which leads to segmentation fault later referenced by grub_elf_file.

Re: [PATCH v2] grub-file: fix segmentation fault

On Tue, Apr 12, 2016 at 02:24:12PM +0800, Michael Chang wrote: > In grub_file_open the file handle returned by file filters has no file->name > set which leads to segmentation fault later referenced by grub_elf_file. This > patch tries to fix the problem. > > gdb --args ./grub-file

[PATCH v2] grub-file: fix segmentation fault

In grub_file_open the file handle returned by file filters has no file->name set which leads to segmentation fault later referenced by grub_elf_file. This patch tries to fix the problem. gdb --args ./grub-file --is-x86_64-xen-domu /boot/vmlinux-4.1.12-1-default.gz (gdb) bt #0