Re: [PATCH v2 07/10] cryptodisk: Replace some literals with constants in grub_cryptodisk_endecrypt.

2020-10-19 Thread Daniel Kiper
Hi Glenn, I will be looking at the patches on the grub-devel this week. I will send you my comments then. Daniel On Sun, Oct 18, 2020 at 01:23:25PM -0500, Glenn Washburn wrote: > Daniel, Patrick, > > Have either of you had a chance to review this patch? Daniel, this is > my interpretation of

[PATCH v2 07/10] cryptodisk: Replace some literals with constants in grub_cryptodisk_endecrypt.

2020-10-03 Thread Glenn Washburn
This should improve readability of code by providing clues as to what the value represents. Signed-off-by: Glenn Washburn --- grub-core/disk/cryptodisk.c | 12 +++- include/grub/types.h| 3 +++ 2 files changed, 10 insertions(+), 5 deletions(-) diff --git