Re: [PATCH v2 08/12] kern: Make grub_error() more verbose

2020-03-09 Thread Daniel Kiper
On Fri, Mar 06, 2020 at 02:37:43PM +0100, Vladimir 'phcoder' Serbinenko wrote: > Le ven. 6 mars 2020 à 13:43, Daniel Kiper a écrit : > > > Re-adding grub-devel@gnu.org... > > > > On Fri, Mar 06, 2020 at 12:44:05PM +0100, Vladimir 'phcoder' Serbinenko > > wrote: > > > Le ven. 6 mars 2020 à 12:42,

Re: [PATCH v2 08/12] kern: Make grub_error() more verbose

2020-03-06 Thread Vladimir 'phcoder' Serbinenko
> It would be best to use a boot partition so the core.img space is > reserved by the GPT, but I once wanted to tack i386-pc GRUB onto an > existing UEFI GPT disk, so I wrote the commands that do what you're > describing here: > >

Re: [PATCH v2 08/12] kern: Make grub_error() more verbose

2020-03-06 Thread Didier Spaier
Le 06/03/2020 à 18:03, David Michael a écrit : > On Fri, Mar 6, 2020 at 9:02 AM Didier Spaier wrote: >> Le 06/03/2020 à 13:43, Daniel Kiper a écrit : >>> If we go that way then we have to care about them by the end of the >>> universe. And this means more and more issues like [1]. If somebody >>>

Re: [PATCH v2 08/12] kern: Make grub_error() more verbose

2020-03-06 Thread Lennart Sorensen
On Fri, Mar 06, 2020 at 06:10:58PM +0100, Didier Spaier wrote: > My mistake, I should have written starting at 24 KiB as that is the > start address of the first usable LBA if I read correctly the UEFI > specification. Am I wrong? > > Thanks for the heads-up. I was wrong about 32KB, it is 32

Re: [PATCH v2 08/12] kern: Make grub_error() more verbose

2020-03-06 Thread Lennart Sorensen
On Fri, Mar 06, 2020 at 11:12:14AM -0600, Bruce Dubbs wrote: > Just a terminology issue here. Please don't call it a boot partition. It > conflicts with those who mount /boot as a separate partition. Please call > it a grub partition. Well the official name is "BIOS boot partition", so I can

Re: [PATCH v2 08/12] kern: Make grub_error() more verbose

2020-03-06 Thread Bruce Dubbs
On 3/6/20 11:03 AM, David Michael wrote: On Fri, Mar 6, 2020 at 9:02 AM Didier Spaier wrote: Le 06/03/2020 à 13:43, Daniel Kiper a écrit : If we go that way then we have to care about them by the end of the universe. And this means more and more issues like [1]. If somebody wants to use new

Re: [PATCH v2 08/12] kern: Make grub_error() more verbose

2020-03-06 Thread Didier Spaier
Le 06/03/2020 à 17:39, Lennart Sorensen a écrit : > On Fri, Mar 06, 2020 at 05:30:23PM +0100, Didier Spaier wrote: >> That'd be just one less thing to care about for the Slint installer >> in case of an 'automatic' installation, nothing major. >> >> Do you confirm that a Bios Boot partition

Re: [PATCH v2 08/12] kern: Make grub_error() more verbose

2020-03-06 Thread David Michael
On Fri, Mar 6, 2020 at 9:02 AM Didier Spaier wrote: > Le 06/03/2020 à 13:43, Daniel Kiper a écrit : > > If we go that way then we have to care about them by the end of the > > universe. And this means more and more issues like [1]. If somebody > > wants to use new GRUB then he/she have to

Re: [PATCH v2 08/12] kern: Make grub_error() more verbose

2020-03-06 Thread Lennart Sorensen
On Fri, Mar 06, 2020 at 05:30:23PM +0100, Didier Spaier wrote: > That'd be just one less thing to care about for the Slint installer > in case of an 'automatic' installation, nothing major. > > Do you confirm that a Bios Boot partition starting at 1 KiB > and ending at 1 MiB won't overlap the

Re: [PATCH v2 08/12] kern: Make grub_error() more verbose

2020-03-06 Thread Didier Spaier
Le 06/03/2020 à 15:38, Vladimir 'phcoder' Serbinenko a écrit : > What's the problem with having bios boot partition? You can put it > exactly in the spot you describe (in fact I do so) and it works as > well, just additionally it marks this space as occupied That'd be just one less thing to care

Re: [PATCH v2 08/12] kern: Make grub_error() more verbose

2020-03-06 Thread Vladimir 'phcoder' Serbinenko
On Fri, Mar 6, 2020 at 3:02 PM Didier Spaier wrote: > > Le 06/03/2020 à 13:43, Daniel Kiper a écrit : > > If we go that way then we have to care about them by the end of the > > universe. And this means more and more issues like [1]. If somebody > > wants to use new GRUB then he/she have to

Re: [PATCH v2 08/12] kern: Make grub_error() more verbose

2020-03-06 Thread Didier Spaier
Le 06/03/2020 à 13:43, Daniel Kiper a écrit : > If we go that way then we have to care about them by the end of the > universe. And this means more and more issues like [1]. If somebody > wants to use new GRUB then he/she have to reinstall the machine or > something like that. IMO we should not

Re: [PATCH v2 08/12] kern: Make grub_error() more verbose

2020-03-06 Thread Vladimir 'phcoder' Serbinenko
Le ven. 6 mars 2020 à 13:43, Daniel Kiper a écrit : > Re-adding grub-devel@gnu.org... > > On Fri, Mar 06, 2020 at 12:44:05PM +0100, Vladimir 'phcoder' Serbinenko > wrote: > > Le ven. 6 mars 2020 à 12:42, Daniel Kiper a écrit > : > > > > > On Thu, Mar 05, 2020 at 03:22:31PM +0100, Vladimir

Re: [PATCH v2 08/12] kern: Make grub_error() more verbose

2020-03-06 Thread Daniel Kiper
Re-adding grub-devel@gnu.org... On Fri, Mar 06, 2020 at 12:44:05PM +0100, Vladimir 'phcoder' Serbinenko wrote: > Le ven. 6 mars 2020 à 12:42, Daniel Kiper a écrit : > > > On Thu, Mar 05, 2020 at 03:22:31PM +0100, Vladimir 'phcoder' Serbinenko > > wrote: > > > Please evaluate size increase for

Re: [PATCH v2 08/12] kern: Make grub_error() more verbose

2020-03-06 Thread Javier Martinez Canillas
On 3/6/20 12:41 PM, Vladimir 'phcoder' Serbinenko wrote: > Le ven. 6 mars 2020 à 12:38, Javier Martinez Canillas > a écrit : > >> Hello Vladimir, >> >> Thanks a lot for your feedback. >> >> On 3/5/20 3:22 PM, Vladimir 'phcoder' Serbinenko wrote: >>> Please evaluate size increase for this. In the

Re: [PATCH v2 08/12] kern: Make grub_error() more verbose

2020-03-06 Thread Vladimir 'phcoder' Serbinenko
Le ven. 6 mars 2020 à 12:38, Javier Martinez Canillas a écrit : > Hello Vladimir, > > Thanks a lot for your feedback. > > On 3/5/20 3:22 PM, Vladimir 'phcoder' Serbinenko wrote: > > Please evaluate size increase for this. In the past passing file and line > > number to grub_dprintf was a huge

Re: [PATCH v2 08/12] kern: Make grub_error() more verbose

2020-03-06 Thread Daniel Kiper
On Thu, Mar 05, 2020 at 03:22:31PM +0100, Vladimir 'phcoder' Serbinenko wrote: > Please evaluate size increase for this. In the past passing file and line > number to grub_dprintf was a huge source of increased Kern and core size I think it does not matter much if we stop pretending that we

Re: [PATCH v2 08/12] kern: Make grub_error() more verbose

2020-03-06 Thread Javier Martinez Canillas
Hello Vladimir, Thanks a lot for your feedback. On 3/5/20 3:22 PM, Vladimir 'phcoder' Serbinenko wrote: > Please evaluate size increase for this. In the past passing file and line > number to grub_dprintf was a huge source of increased Kern and core size > > Le mer. 4 mars 2020 à 13:01, Javier

Re: [PATCH v2 08/12] kern: Make grub_error() more verbose

2020-03-05 Thread Vladimir 'phcoder' Serbinenko
Please evaluate size increase for this. In the past passing file and line number to grub_dprintf was a huge source of increased Kern and core size Le mer. 4 mars 2020 à 13:01, Javier Martinez Canillas a écrit : > From: Peter Jones > > Add file and line to grub_error() output to make

Re: [PATCH v2 08/12] kern: Make grub_error() more verbose

2020-03-05 Thread Daniel Kiper
On Wed, Mar 04, 2020 at 12:58:47PM +0100, Javier Martinez Canillas wrote: > From: Peter Jones > > Add file and line to grub_error() output to make troubleshooting easier. > > Signed-off-by: Peter Jones > Signed-off-by: Javier Martinez Canillas Reviewed-by: Daniel Kiper Daniel

[PATCH v2 08/12] kern: Make grub_error() more verbose

2020-03-04 Thread Javier Martinez Canillas
From: Peter Jones Add file and line to grub_error() output to make troubleshooting easier. Signed-off-by: Peter Jones Signed-off-by: Javier Martinez Canillas --- grub-core/kern/err.c | 13 +++-- include/grub/err.h | 5 - 2 files changed, 15 insertions(+), 3 deletions(-) diff