Re: [Xen-devel] [PATCH v2 08/18] xen: add basic hooks for PVH in current code

2018-10-22 Thread Juergen Gross
On 22/10/2018 13:16, Daniel Kiper wrote: > On Fri, Oct 19, 2018 at 05:52:44PM +0200, Juergen Gross wrote: >> On 19/10/2018 17:33, Roger Pau Monné wrote: >>> On Tue, Oct 09, 2018 at 01:03:07PM +0200, Juergen Gross wrote: Add the hooks to current code needed for Xen PVH. Signed-off-by:

Re: [Xen-devel] [PATCH v2 08/18] xen: add basic hooks for PVH in current code

2018-10-22 Thread Daniel Kiper
On Fri, Oct 19, 2018 at 05:52:44PM +0200, Juergen Gross wrote: > On 19/10/2018 17:33, Roger Pau Monné wrote: > > On Tue, Oct 09, 2018 at 01:03:07PM +0200, Juergen Gross wrote: > >> Add the hooks to current code needed for Xen PVH. > >> > >> Signed-off-by: Juergen Gross > >> --- > >> grub-core/ker

Re: [Xen-devel] [PATCH v2 08/18] xen: add basic hooks for PVH in current code

2018-10-19 Thread Juergen Gross
On 19/10/2018 17:33, Roger Pau Monné wrote: > On Tue, Oct 09, 2018 at 01:03:07PM +0200, Juergen Gross wrote: >> Add the hooks to current code needed for Xen PVH. >> >> Signed-off-by: Juergen Gross >> --- >> grub-core/kern/i386/xen/pvh.c | 36 >> +++ >> gru

Re: [Xen-devel] [PATCH v2 08/18] xen: add basic hooks for PVH in current code

2018-10-19 Thread Roger Pau Monné
On Tue, Oct 09, 2018 at 01:03:07PM +0200, Juergen Gross wrote: > Add the hooks to current code needed for Xen PVH. > > Signed-off-by: Juergen Gross > --- > grub-core/kern/i386/xen/pvh.c | 36 > +++ > grub-core/kern/i386/xen/startup_pvh.S | 29

Re: [Xen-devel] [PATCH v2 08/18] xen: add basic hooks for PVH in current code

2018-10-19 Thread Juergen Gross
On 19/10/2018 14:05, Daniel Kiper wrote: > On Tue, Oct 09, 2018 at 01:03:07PM +0200, Juergen Gross wrote: >> Add the hooks to current code needed for Xen PVH. > > I am not against the code itself but it would be nice to know why you > add, AIUI, just stubs here which will be filled with proper cod

Re: [PATCH v2 08/18] xen: add basic hooks for PVH in current code

2018-10-19 Thread Daniel Kiper
On Tue, Oct 09, 2018 at 01:03:07PM +0200, Juergen Gross wrote: > Add the hooks to current code needed for Xen PVH. I am not against the code itself but it would be nice to know why you add, AIUI, just stubs here which will be filled with proper code later. Daniel

[PATCH v2 08/18] xen: add basic hooks for PVH in current code

2018-10-09 Thread Juergen Gross
Add the hooks to current code needed for Xen PVH. Signed-off-by: Juergen Gross --- grub-core/kern/i386/xen/pvh.c | 36 +++ grub-core/kern/i386/xen/startup_pvh.S | 29 grub-core/kern/xen/init.c | 6 ++ include/g