Re: [PATCH v3 04/10] luks2: grub_cryptodisk_t->total_length is the max number of device native sectors

2020-10-23 Thread Patrick Steinhardt
On Mon, Oct 19, 2020 at 06:09:52PM -0500, Glenn Washburn wrote: > The total_length field is named confusingly because length usually refers to > bytes, whereas in this case its really the total number of sectors on the > device. Also counter-intuitively, grub_disk_get_size returns the total >

[PATCH v3 04/10] luks2: grub_cryptodisk_t->total_length is the max number of device native sectors

2020-10-19 Thread Glenn Washburn
The total_length field is named confusingly because length usually refers to bytes, whereas in this case its really the total number of sectors on the device. Also counter-intuitively, grub_disk_get_size returns the total number of device native sectors. We need to convert the sectors from the