Re: [PATCH v3 2/4] tests: Do not occlude subshell error codes

2021-10-12 Thread Glenn Washburn
On Tue, 12 Oct 2021 21:40:45 +0200 Daniel Kiper wrote: > On Mon, Oct 11, 2021 at 01:06:17PM -0500, Glenn Washburn wrote: > > On Mon, 11 Oct 2021 16:20:46 +0200 > > Daniel Kiper wrote: > > > > > On Thu, Oct 07, 2021 at 03:33:25PM -0500, Glenn Washburn wrote: > > > > When a subshell's output is

Re: [PATCH v3 2/4] tests: Do not occlude subshell error codes

2021-10-12 Thread Daniel Kiper
On Mon, Oct 11, 2021 at 01:06:17PM -0500, Glenn Washburn wrote: > On Mon, 11 Oct 2021 16:20:46 +0200 > Daniel Kiper wrote: > > > On Thu, Oct 07, 2021 at 03:33:25PM -0500, Glenn Washburn wrote: > > > When a subshell's output is used as input to a "simple command", its > > > return I think you

Re: [PATCH v3 2/4] tests: Do not occlude subshell error codes

2021-10-11 Thread Glenn Washburn
On Mon, 11 Oct 2021 16:20:46 +0200 Daniel Kiper wrote: > On Thu, Oct 07, 2021 at 03:33:25PM -0500, Glenn Washburn wrote: > > When a subshell's output is used as input to a "simple command", its return > > code is not checked. These subshells contain an execution of the grub-shell > > script

Re: [PATCH v3 2/4] tests: Do not occlude subshell error codes

2021-10-11 Thread Daniel Kiper
On Thu, Oct 07, 2021 at 03:33:25PM -0500, Glenn Washburn wrote: > When a subshell's output is used as input to a "simple command", its return > code is not checked. These subshells contain an execution of the grub-shell > script which does the work of the actual test. If grub-shell returns an >

[PATCH v3 2/4] tests: Do not occlude subshell error codes

2021-10-07 Thread Glenn Washburn
When a subshell's output is used as input to a "simple command", its return code is not checked. These subshells contain an execution of the grub-shell script which does the work of the actual test. If grub-shell returns an error code, the test should fail. So refactor to not have the subshell