Re: [PATCH v3 4/9] luks2: grub_cryptodisk_t->total_length is the max number of device native sectors

2020-11-05 Thread Glenn Washburn
Nov 4, 2020 7:15:30 AM Daniel Kiper : > On Tue, Nov 03, 2020 at 08:21:15PM +, Glenn Washburn wrote: >> Oct 30, 2020 7:50:08 AM Daniel Kiper : >>> On Thu, Oct 29, 2020 at 02:53:34PM -0500, Glenn Washburn wrote: On Tue, 27 Oct 2020 20:11:56 +0100 Daniel Kiper wrote: > On Sat, Oct

Re: [PATCH v3 4/9] luks2: grub_cryptodisk_t->total_length is the max number of device native sectors

2020-11-04 Thread Daniel Kiper
On Tue, Nov 03, 2020 at 08:21:15PM +, Glenn Washburn wrote: > Oct 30, 2020 7:50:08 AM Daniel Kiper : > > On Thu, Oct 29, 2020 at 02:53:34PM -0500, Glenn Washburn wrote: > >> On Tue, 27 Oct 2020 20:11:56 +0100 > >> Daniel Kiper wrote: > >>> On Sat, Oct 03, 2020 at 12:42:55AM -0500, Glenn

Re: [PATCH v3 4/9] luks2: grub_cryptodisk_t->total_length is the max number of device native sectors

2020-11-03 Thread Glenn Washburn
Oct 30, 2020 7:50:08 AM Daniel Kiper : > On Thu, Oct 29, 2020 at 02:53:34PM -0500, Glenn Washburn wrote: >> On Tue, 27 Oct 2020 20:11:56 +0100 >> Daniel Kiper wrote: >>> On Sat, Oct 03, 2020 at 12:42:55AM -0500, Glenn Washburn wrote: On Mon, 21 Sep 2020 13:23:04 +0200 Daniel Kiper

Re: [PATCH v3 4/9] luks2: grub_cryptodisk_t->total_length is the max number of device native sectors

2020-10-30 Thread Daniel Kiper
On Thu, Oct 29, 2020 at 02:53:34PM -0500, Glenn Washburn wrote: > On Tue, 27 Oct 2020 20:11:56 +0100 > Daniel Kiper wrote: > > On Sat, Oct 03, 2020 at 12:42:55AM -0500, Glenn Washburn wrote: > > > On Mon, 21 Sep 2020 13:23:04 +0200 > > > Daniel Kiper wrote: > > > > On Mon, Sep 21, 2020 at

Re: [PATCH v3 4/9] luks2: grub_cryptodisk_t->total_length is the max number of device native sectors

2020-10-29 Thread Glenn Washburn
On Tue, 27 Oct 2020 20:11:56 +0100 Daniel Kiper wrote: > On Sat, Oct 03, 2020 at 12:42:55AM -0500, Glenn Washburn wrote: > > On Mon, 21 Sep 2020 13:23:04 +0200 > > Daniel Kiper wrote: > > > > > On Mon, Sep 21, 2020 at 06:28:28AM +, Glenn Washburn wrote: > > > > Sep 8, 2020 7:21:31 AM Daniel

Re: [PATCH v3 4/9] luks2: grub_cryptodisk_t->total_length is the max number of device native sectors

2020-10-27 Thread Daniel Kiper
On Sat, Oct 03, 2020 at 12:42:55AM -0500, Glenn Washburn wrote: > On Mon, 21 Sep 2020 13:23:04 +0200 > Daniel Kiper wrote: > > > On Mon, Sep 21, 2020 at 06:28:28AM +, Glenn Washburn wrote: > > > Sep 8, 2020 7:21:31 AM Daniel Kiper : > > > > On Mon, Sep 07, 2020 at 05:27:46PM +0200, Patrick

Re: [PATCH v3 4/9] luks2: grub_cryptodisk_t->total_length is the max number of device native sectors

2020-10-02 Thread Glenn Washburn
On Mon, 21 Sep 2020 13:23:04 +0200 Daniel Kiper wrote: > On Mon, Sep 21, 2020 at 06:28:28AM +, Glenn Washburn wrote: > > Sep 8, 2020 7:21:31 AM Daniel Kiper : > > > On Mon, Sep 07, 2020 at 05:27:46PM +0200, Patrick Steinhardt > > > wrote: > > >> From: Glenn Washburn > > >> > > >> The

Re: [PATCH v3 4/9] luks2: grub_cryptodisk_t->total_length is the max number of device native sectors

2020-09-21 Thread Daniel Kiper
On Mon, Sep 21, 2020 at 06:28:28AM +, Glenn Washburn wrote: > Sep 8, 2020 7:21:31 AM Daniel Kiper : > > On Mon, Sep 07, 2020 at 05:27:46PM +0200, Patrick Steinhardt wrote: > >> From: Glenn Washburn > >> > >> The total_length field is named confusingly because length usually refers > >> to >

Re: [PATCH v3 4/9] luks2: grub_cryptodisk_t->total_length is the max number of device native sectors

2020-09-21 Thread Glenn Washburn
Sep 8, 2020 7:21:31 AM Daniel Kiper : > On Mon, Sep 07, 2020 at 05:27:46PM +0200, Patrick Steinhardt wrote: >> From: Glenn Washburn >> >> The total_length field is named confusingly because length usually refers to >> bytes, whereas in this case its really the total number of sectors on the >>

Re: [PATCH v3 4/9] luks2: grub_cryptodisk_t->total_length is the max number of device native sectors

2020-09-08 Thread Daniel Kiper
On Mon, Sep 07, 2020 at 05:27:46PM +0200, Patrick Steinhardt wrote: > From: Glenn Washburn > > The total_length field is named confusingly because length usually refers to > bytes, whereas in this case its really the total number of sectors on the > device. Also counter-intuitively,

[PATCH v3 4/9] luks2: grub_cryptodisk_t->total_length is the max number of device native sectors

2020-09-07 Thread Patrick Steinhardt
From: Glenn Washburn The total_length field is named confusingly because length usually refers to bytes, whereas in this case its really the total number of sectors on the device. Also counter-intuitively, grub_disk_get_size returns the total number of device native sectors sectors. We need to