Re: [Regression] efi: Don't display a uefi-firmware entry if it's not supported

2022-10-28 Thread Daniel Kiper
On Mon, Sep 05, 2022 at 05:49:47PM -0500, Glenn Washburn wrote: > On Wed, 31 Aug 2022 16:14:42 +0100 > Dimitri John Ledkov wrote: > > On Tue, 30 Aug 2022 at 21:22, Robbie Harwood wrote: > > > Philip Müller writes: > > > > > > >> Hello Robbie, hello Daniel, > > > >> > > > >> with the commit

Re: [Regression] efi: Don't display a uefi-firmware entry if it's not supported

2022-09-05 Thread Glenn Washburn
On Wed, 31 Aug 2022 16:14:42 +0100 Dimitri John Ledkov wrote: > On Tue, 30 Aug 2022 at 21:22, Robbie Harwood wrote: > > > > Philip Müller writes: > > > > >> Hello Robbie, hello Daniel, > > >> > > >> with the commit 26031d3b101648352e4e427f04bf69d320088e77 > > >> 30_uefi-firmware will always

Re: [Regression] efi: Don't display a uefi-firmware entry if it's not supported

2022-09-01 Thread Philip Müller via Grub-devel
On 31.08.22 20:44, Robbie Harwood wrote: While we could revert the entire --is-supported logic as well, since this is upstream pre-release code, it's probably easier for the downstreams that pulled this change if we don't, so: Reviewed-by: Robbie Harwood. Yep, that would also work. For

Re: [Regression] efi: Don't display a uefi-firmware entry if it's not supported

2022-08-31 Thread Robbie Harwood
Javier Martinez Canillas writes: > On 8/31/22 00:07, Philip Müller wrote: >> On 30.08.22 23:34, Javier Martinez Canillas wrote: You could add a feature flag, which causes grub-core to set an environment variable when a new feature is supported. See the features array in

Re: [Regression] efi: Don't display a uefi-firmware entry if it's not supported

2022-08-31 Thread Dimitri John Ledkov
On Tue, 30 Aug 2022 at 21:22, Robbie Harwood wrote: > > Philip Müller writes: > > >> Hello Robbie, hello Daniel, > >> > >> with the commit 26031d3b101648352e4e427f04bf69d320088e77 > >> 30_uefi-firmware will always call `fwsetup --is-supported' to check > >> if the system supports EFI or not.

Re: [Regression] efi: Don't display a uefi-firmware entry if it's not supported

2022-08-31 Thread Morten Linderud
On Wed, Aug 31, 2022 at 12:07:33AM +0200, Philip Müller wrote: > On 30.08.22 23:34, Javier Martinez Canillas wrote: > > > You could add a feature flag, which causes grub-core to set an > > > environment variable when a new feature is supported. See the features > > > array in

Re: [Regression] efi: Don't display a uefi-firmware entry if it's not supported

2022-08-31 Thread Mihai Moldovan
* On 8/30/22 22:16, Robbie Harwood wrote: > Philip Müller writes: > >>> What would be the best approach with older installations of grub via >>> grub-install not having to reinstall grub to MBR as some users don't >>> even know on how to install grub properly as that job a graphical >>> installer

Re: [Regression] efi: Don't display a uefi-firmware entry if it's not supported

2022-08-30 Thread Luna Jernberg
Had this problem on my Arch Linux and EOS setup had to chroot in and fiddle with this last week: https://youtu.be/b_KHtK2b5cA On 8/31/22, Philip Müller via Grub-devel wrote: > On 31.08.22 00:43, Javier Martinez Canillas wrote: >> To prevent that, let's partially revert the mentioned commit and

Re: [Regression] efi: Don't display a uefi-firmware entry if it's not supported

2022-08-30 Thread Philip Müller via Grub-devel
On 31.08.22 00:43, Javier Martinez Canillas wrote: To prevent that, let's partially revert the mentioned commit and keep the old logic that didn't execute the `fwsetup` command and just included an entry for it if GRUB is executed in an EFI platform. I was about to do the same on my end when

Re: [Regression] efi: Don't display a uefi-firmware entry if it's not supported

2022-08-30 Thread Javier Martinez Canillas
On 8/31/22 00:07, Philip Müller wrote: > On 30.08.22 23:34, Javier Martinez Canillas wrote: >>> You could add a feature flag, which causes grub-core to set an >>> environment variable when a new feature is supported. See the features >>> array in grub-core/normal/main.c. >>> >>> You would then

Re: [Regression] efi: Don't display a uefi-firmware entry if it's not supported

2022-08-30 Thread Philip Müller via Grub-devel
On 30.08.22 23:34, Javier Martinez Canillas wrote: You could add a feature flag, which causes grub-core to set an environment variable when a new feature is supported. See the features array in grub-core/normal/main.c. You would then check for this feature flag in the grub.d snippet before

Re: [Regression] efi: Don't display a uefi-firmware entry if it's not supported

2022-08-30 Thread Javier Martinez Canillas
On 8/30/22 23:14, Mike Gilbert wrote:> On Tue, Aug 30, 2022 at 4:16 PM Robbie Harwood wrote: >> Why doesn't grub on the MBR get updated when you install a new grub >> package? That seems like the real issue here - what am I missing? > > I think the grub project tries to maintain config file

Re: [Regression] efi: Don't display a uefi-firmware entry if it's not supported

2022-08-30 Thread Mike Gilbert
On Tue, Aug 30, 2022 at 4:16 PM Robbie Harwood wrote: > Why doesn't grub on the MBR get updated when you install a new grub > package? That seems like the real issue here - what am I missing? I think the grub project tries to maintain config file compatibility with older versions so that users

Re: [Regression] efi: Don't display a uefi-firmware entry if it's not supported

2022-08-30 Thread Robbie Harwood
Philip Müller writes: >> Hello Robbie, hello Daniel, >> >> with the commit 26031d3b101648352e4e427f04bf69d320088e77 >> 30_uefi-firmware will always call `fwsetup --is-supported' to check >> if the system supports EFI or not. However most installed grub >> versions on MBR don't support the