Re: [SECURITY PATCH 108/117] util/mkimage: Refactor section setup to use a helper

2021-03-23 Thread John Paul Adrian Glaubitz
Hi Daniel! On 3/23/21 8:35 PM, Daniel Kiper wrote: >> Any chance someone could have a look at this? As explained in the follow-up >> mails, >> the problem is that the pointer pointing to the modules location in the core >> image >> deviate from the actual modules location as the former was

Re: [SECURITY PATCH 108/117] util/mkimage: Refactor section setup to use a helper

2021-03-23 Thread Daniel Kiper
Hi Adrian, On Tue, Mar 23, 2021 at 08:16:43PM +0100, John Paul Adrian Glaubitz wrote: > Hello! > > On 3/18/21 9:38 AM, John Paul Adrian Glaubitz wrote: > > On 3/2/21 7:01 PM, Daniel Kiper wrote: > >> From: Peter Jones > >> > >> Add a init_pe_section() helper function to setup PE sections. This

Re: [SECURITY PATCH 108/117] util/mkimage: Refactor section setup to use a helper

2021-03-23 Thread John Paul Adrian Glaubitz
Hello! On 3/18/21 9:38 AM, John Paul Adrian Glaubitz wrote: > On 3/2/21 7:01 PM, Daniel Kiper wrote: >> From: Peter Jones >> >> Add a init_pe_section() helper function to setup PE sections. This makes >> the code simpler and easier to read. >> >> Signed-off-by: Peter Jones >> Signed-off-by:

Re: [SECURITY PATCH 108/117] util/mkimage: Refactor section setup to use a helper

2021-03-20 Thread John Paul Adrian Glaubitz
On 3/20/21 4:05 PM, John Paul Adrian Glaubitz wrote: > However, the modules are still located at the same address in memory which is > why > the module loader can no longer find them. And the new address where the loader is looking for the modules is located at 0x39000 but the modules are still

Re: [SECURITY PATCH 108/117] util/mkimage: Refactor section setup to use a helper

2021-03-20 Thread John Paul Adrian Glaubitz
Hello! On 3/18/21 9:38 AM, John Paul Adrian Glaubitz wrote: > This change broke GRUB on ia64 for me. It now fails to perform any basic > commands: > > Loading.: grub > Starting: grub

Re: [SECURITY PATCH 108/117] util/mkimage: Refactor section setup to use a helper

2021-03-18 Thread John Paul Adrian Glaubitz
Hi! On 3/2/21 7:01 PM, Daniel Kiper wrote: > From: Peter Jones > > Add a init_pe_section() helper function to setup PE sections. This makes > the code simpler and easier to read. > > Signed-off-by: Peter Jones > Signed-off-by: Javier Martinez Canillas > Reviewed-by: Daniel Kiper This

[SECURITY PATCH 108/117] util/mkimage: Refactor section setup to use a helper

2021-03-02 Thread Daniel Kiper
From: Peter Jones Add a init_pe_section() helper function to setup PE sections. This makes the code simpler and easier to read. Signed-off-by: Peter Jones Signed-off-by: Javier Martinez Canillas Reviewed-by: Daniel Kiper --- util/mkimage.c | 141