On Mon, Nov 2, 2009 at 7:17 PM, Robert Millan wrote:
>
> Please see the commit I did yesterday. Does this suffice?
>
Yes, it is sufficient.
--
bvk-chaitanya
___
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/grub
On Mon, Nov 02, 2009 at 06:21:52AM +0530, BVK wrote:
> On Mon, Nov 2, 2009 at 3:28 AM, Robert Millan wrote:
> >
> > But you also added a check for NULL dereference. Is that also required by
> > the standard?
> >
>
> Standard doesn't say anything about it, so I guess it means, it is
> left for im
Attached is the new patch without NULL dereference checks.
I looked at grub_strchr and grub_strrchr calls as much as I can, and
they don't seem to rely on NULL dereference behavior. But it was not
feasible to verify this for some cases, as we are using function
pointers (like, grub_disk_dev->open
On Mon, Nov 2, 2009 at 3:28 AM, Robert Millan wrote:
>
> But you also added a check for NULL dereference. Is that also required by
> the standard?
>
Standard doesn't say anything about it, so I guess it means, it is
left for implementations. Old grub_strchr implementation has this
check, so kep
On Mon, Nov 02, 2009 at 12:24:33AM +0530, BVK wrote:
> hi,
>
>
> As per http://www.opengroup.org/onlinepubs/009695399/functions/strchr.html
> strchr method should consider '\0' as part of the string, which means,
> strchr should return '\0' character position when it is passed as the
> character
hi,
As per http://www.opengroup.org/onlinepubs/009695399/functions/strchr.html
strchr method should consider '\0' as part of the string, which means,
strchr should return '\0' character position when it is passed as the
character to look for.
I believe, grub_strchr is intended to mimic standard
