Re: grub causing NVDIMMs to be treated as normal memory

2015-12-29 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 28.11.2015 07:41, Elliott, Robert (Persistent Memory) wrote: > If you can define a standard meaning for 16 and 20, that'd be more > useful than marking them as OEM defined. There will always be a mix > of software that interprets it as unusable vs. follows this new > advice. 16 would be "RAM

RE: grub causing NVDIMMs to be treated as normal memory

2015-12-08 Thread Elliott, Robert (Persistent Memory)
> -Original Message- > From: grub-devel-bounces+elliott=hp@gnu.org [mailto:grub-devel- > bounces+elliott=hp@gnu.org] On Behalf Of Andrei Borzenkov > Sent: Tuesday, December 08, 2015 11:16 AM > To: grub-devel@gnu.org > Subject: Re: grub causing NVDIMMs to be

RE: grub causing NVDIMMs to be treated as normal memory

2015-12-03 Thread Elliott, Robert (Persistent Memory)
ment of GNU GRUB <grub-devel@gnu.org> > > Subject: Re: grub causing NVDIMMs to be treated as normal memory > > > > What about this patch for the passing of pram? > ... > > --- a/include/grub/memory.h > > +++ b/include/grub/memory.h > > @@ -30,6 +30,7 @@ type

RE: grub causing NVDIMMs to be treated as normal memory

2015-11-30 Thread Elliott, Robert (Persistent Memory)
> grub-core/efiemu/mm.c: > * efiemu_alloc_requests reqorder[] - add GRUB_EFI_PERSISTENT_MEMORY > (although we don't want to encourage ever allocating these >ranges, UNUSABLE_MEMORY is already there) Reviewing that code, since this array has one entry per EFI memory type: static grub_size_t

Re: grub causing NVDIMMs to be treated as normal memory

2015-11-27 Thread Andrei Borzenkov
27.11.2015 16:55, Vladimir 'φ-coder/phcoder' Serbinenko пишет: > New version attached > For completeness, there is lsmmap, but it is cosmetic. What about multiboot(2)? It lists possible memory types. Do they constitute binding API? #define MULTIBOOT_MEMORY_AVAILABLE 1 #define

Re: grub causing NVDIMMs to be treated as normal memory

2015-11-27 Thread Vladimir 'φ-coder/phcoder' Serbinenko
What about this patch for the passing of pram? diff --git a/grub-core/mmap/efi/mmap.c b/grub-core/mmap/efi/mmap.c index 900a4d6..0c03c5d 100644 --- a/grub-core/mmap/efi/mmap.c +++ b/grub-core/mmap/efi/mmap.c @@ -118,6 +118,12 @@ grub_efi_mmap_iterate (grub_memory_hook_t hook, void *hook_data,

Re: grub causing NVDIMMs to be treated as normal memory

2015-11-27 Thread Andrei Borzenkov
On Fri, Nov 27, 2015 at 2:08 PM, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > What about this patch for the passing of pram? It is incomplete. You need to handle make_efi_memtype() as well as efiemu where I am not sure what is the right thing to do (and we probably have zero

Re: grub causing NVDIMMs to be treated as normal memory

2015-11-27 Thread Vladimir 'φ-coder/phcoder' Serbinenko
New version attached >> GRUB_MEMORY_COREBOOT_TABLES = 16, >> GRUB_MEMORY_CODE = 20, >> /* This one is special: it's used internally but is never reported > Note (b): The internal GRUB_MEMORY_CODE (20) value is > leaking through to the E820 table. > > That appears to

RE: grub causing NVDIMMs to be treated as normal memory

2015-11-27 Thread Elliott, Robert (Persistent Memory)
el@gnu.org> > Subject: Re: grub causing NVDIMMs to be treated as normal memory > > What about this patch for the passing of pram? ... > --- a/include/grub/memory.h > +++ b/include/grub/memory.h > @@ -30,6 +30,7 @@ typedef enum grub_memory_type > GRU

Re: grub causing NVDIMMs to be treated as normal memory

2015-11-26 Thread Andrei Borzenkov
26.11.2015 09:15, Elliott, Robert (Persistent Memory) пишет: ... > ... > mmap/efi/mmap.c:66: EFI memory region 0x88000-0xc8000: 14 > Unknown memory type 14, considering reserved > mmap/efi/mmap.c:66: EFI memory region 0x148000-0x1a8000: 14 > Unknown memory type 14, considering

RE: grub causing NVDIMMs to be treated as normal memory

2015-11-26 Thread Elliott, Robert (Persistent Memory)
com; linux-nvd...@lists.01.org > Subject: Re: grub causing NVDIMMs to be treated as normal memory > > 26.11.2015 09:15, Elliott, Robert (Persistent Memory) пишет: > ... > > > ... > > mmap/efi/mmap.c:66: EFI memory region 0x88000-0xc8000: 14 > > Unknown m

Re: grub causing NVDIMMs to be treated as normal memory

2015-11-26 Thread Andrei Borzenkov
>> development of GNU GRUB <grub-devel@gnu.org>; >> dan.j.willi...@intel.com; linux-nvd...@lists.01.org >> Subject: Re: grub causing NVDIMMs to be treated as normal memory >> >> 26.11.2015 09:15, Elliott, Robert (Persistent Memory) пишет: >> ... >&

RE: grub causing NVDIMMs to be treated as normal memory

2015-11-26 Thread Elliott, Robert (Persistent Memory)
com; linux-nvd...@lists.01.org > Subject: Re: grub causing NVDIMMs to be treated as normal memory > > 27.11.2015 02:24, Elliott, Robert (Persistent Memory) пишет: > > ... > > Note (a): The 088 and 148 ranges were merged into the > > 010 and 0c8 usable ranges, as

Re: grub causing NVDIMMs to be treated as normal memory

2015-11-25 Thread Seth Goldberg
It may operate the same, but there may be persistent data in there that the OS wants to preserve across reboots. —S On Nov 25, 2015, at 6:08 AM, Andrei Borzenkov wrote: > On Wed, Nov 25, 2015 at 2:52 AM, Elliott, Robert (Persistent Memory) > wrote: >>

Re: grub causing NVDIMMs to be treated as normal memory

2015-11-25 Thread Andrei Borzenkov
25.11.2015 02:52, Elliott, Robert (Persistent Memory) пишет: > We've noticed that some combinations of grub and old linux kernels > > end up interpreting the UEFI memory map EfiPersistentMemory type 14 > > (formerly a reserved value) as regular memory in the linux e820 > > table, causing silent

RE: grub causing NVDIMMs to be treated as normal memory

2015-11-25 Thread Elliott, Robert (Persistent Memory)
sts.01.org > Subject: Re: grub causing NVDIMMs to be treated as normal memory > > 25.11.2015 02:52, Elliott, Robert (Persistent Memory) пишет: > > We've noticed that some combinations of grub and old linux kernels > > > > end up interpreting the UEFI memory map EfiPers

Re: grub causing NVDIMMs to be treated as normal memory

2015-11-25 Thread Andrei Borzenkov
ment of GNU GRUB <grub-devel@gnu.org>; >> dan.j.willi...@intel.com; linux-nvd...@lists.01.org >> Subject: Re: grub causing NVDIMMs to be treated as normal memory >> >> 25.11.2015 02:52, Elliott, Robert (Persistent Memory) пишет: >>> We've noticed that some comb

RE: grub causing NVDIMMs to be treated as normal memory

2015-11-25 Thread Elliott, Robert (Persistent Memory)
> -Original Message- > From: Linux-nvdimm [mailto:linux-nvdimm-boun...@lists.01.org] On Behalf Of > Andrei Borzenkov > Sent: Wednesday, November 25, 2015 8:08 AM > To: The development of GNU GRUB <grub-devel@gnu.org> > Cc: linux-nvd...@lists.01.org > Subjec

Re: grub causing NVDIMMs to be treated as normal memory

2015-11-25 Thread Dan Williams
On Wed, Nov 25, 2015 at 6:08 AM, Andrei Borzenkov wrote: > On Wed, Nov 25, 2015 at 2:52 AM, Elliott, Robert (Persistent Memory) > wrote: >> We've noticed that some combinations of grub and old linux kernels >> >> end up interpreting the UEFI memory map

RE: grub causing NVDIMMs to be treated as normal memory

2015-11-25 Thread Elliott, Robert (Persistent Memory)
> -Original Message- > From: Andrei Borzenkov [mailto:arvidj...@gmail.com] ... > From the build directory > > pkgdatadir=$PWD ./grub-install --bootloader-id testgrub -d grub-core > > This should install grub in \EFI\testgrub on ESP and add EFI menu for > it. You can add --no-nvram to

Re: grub causing NVDIMMs to be treated as normal memory

2015-11-25 Thread Andrei Borzenkov
On Wed, Nov 25, 2015 at 2:52 AM, Elliott, Robert (Persistent Memory) wrote: > We've noticed that some combinations of grub and old linux kernels > > end up interpreting the UEFI memory map EfiPersistentMemory type 14 > > (formerly a reserved value) as regular memory in the linux