Re: [PATCH] Parse commandline in grub-xen

2015-05-12 Thread Olaf Hering
On Mon, May 11, Vladimir 'phcoder' Serbinenko wrote: On May 11, 2015 7:08 PM, Olaf Hering o...@aepfle.de wrote: And regarding $debug itself, with my change its set very early before any script runs. Perhaps that is useful to debug early issues. Even if it is, it shouldn't be a side effect

Re: [PATCH] Parse commandline in grub-xen

2015-05-12 Thread Vladimir 'phcoder' Serbinenko
On May 12, 2015 10:06 AM, Olaf Hering o...@aepfle.de wrote: On Mon, May 11, Vladimir 'phcoder' Serbinenko wrote: On May 11, 2015 7:08 PM, Olaf Hering o...@aepfle.de wrote: And regarding $debug itself, with my change its set very early before any script runs. Perhaps that is useful to

Re: [PATCH] Parse commandline in grub-xen

2015-05-12 Thread Vladimir 'phcoder' Serbinenko
On May 12, 2015 11:10 AM, Olaf Hering o...@aepfle.de wrote: On Tue, May 12, Vladimir 'phcoder' Serbinenko wrote: On May 12, 2015 10:06 AM, Olaf Hering o...@aepfle.de wrote: On Mon, May 11, Vladimir 'phcoder' Serbinenko wrote: On May 11, 2015 7:08 PM, Olaf Hering o...@aepfle.de

Re: [PATCH] Parse commandline in grub-xen

2015-05-12 Thread Olaf Hering
On Tue, May 12, Vladimir 'phcoder' Serbinenko wrote: On May 12, 2015 10:06 AM, Olaf Hering o...@aepfle.de wrote: On Mon, May 11, Vladimir 'phcoder' Serbinenko wrote: On May 11, 2015 7:08 PM, Olaf Hering o...@aepfle.de wrote: And regarding $debug itself, with my change its set very

Re: [PATCH] Parse commandline in grub-xen

2015-05-11 Thread Vladimir 'phcoder' Serbinenko
On May 11, 2015 12:41 PM, Olaf Hering o...@aepfle.de wrote: On Mon, May 11, Andrei Borzenkov wrote: On Mon, May 11, 2015 at 12:43 PM, Olaf Hering o...@aepfle.de wrote: Futhermore what freedom would you like to hand out to those who implement the scripts? In my testing some variables

Re: [PATCH] Parse commandline in grub-xen

2015-05-11 Thread Olaf Hering
On Mon, May 11, Andrei Borzenkov wrote: On Mon, May 11, 2015 at 12:43 PM, Olaf Hering o...@aepfle.de wrote: Futhermore what freedom would you like to hand out to those who implement the scripts? In my testing some variables such as root= and prefix= are overriden anyway. You do not know

Re: [PATCH] Parse commandline in grub-xen

2015-05-11 Thread Olaf Hering
On Mon, May 11, Vladimir 'phcoder' Serbinenko wrote: As said previously, allowing setting arbitrary variables from command line will not be an accepted behavior. Also the code should be generic enough to allow handling of other platforms if need be but surely without including any

Re: [PATCH] Parse commandline in grub-xen

2015-05-11 Thread Andrei Borzenkov
On Mon, May 11, 2015 at 12:43 PM, Olaf Hering o...@aepfle.de wrote: On Mon, May 11, Vladimir 'phcoder' Serbinenko wrote: As said previously, allowing setting arbitrary variables from command line will not be an accepted behavior. Also the code should be generic enough to allow handling of

Re: [PATCH] Parse commandline in grub-xen

2015-05-11 Thread Vladimir 'phcoder' Serbinenko
As said previously, allowing setting arbitrary variables from command line will not be an accepted behavior. Also the code should be generic enough to allow handling of other platforms if need be but surely without including any unnecessary code for platforms that don't need it. Until there is an

Re: [PATCH] Parse commandline in grub-xen

2015-05-11 Thread Olaf Hering
On Mon, May 11, Vladimir 'phcoder' Serbinenko wrote: Do you really own all those installs to be able to speak on behalf of all of them? Since there is zero upstream support for anything regarding grub xen distros are forced to provide their own grub-xen binary for dom0. This includes at least

Re: [PATCH] Parse commandline in grub-xen

2015-05-11 Thread Olaf Hering
On Mon, May 11, Andrei Borzenkov wrote: Either by allowing ${grub.arg.XXX} (not sure if current grammar accepts it) or by adding getarg command, something like getarg --name debug --set debug What would such format buy us? You do not control what arguments grub gets - end use (admin)

Re: [PATCH] Parse commandline in grub-xen

2015-05-11 Thread Vladimir 'phcoder' Serbinenko
On May 11, 2015 1:23 PM, Olaf Hering o...@aepfle.de wrote: On Mon, May 11, Vladimir 'phcoder' Serbinenko wrote: Do you really own all those installs to be able to speak on behalf of all of them? Since there is zero upstream support for anything regarding grub xen distros are forced to

Re: [PATCH] Parse commandline in grub-xen

2015-05-11 Thread Olaf Hering
On Mon, May 11, Vladimir 'phcoder' Serbinenko wrote: Well your argument doesn't say at all why no prefix is better than separating namespaces Who is supposed to parse the prefix? And at what point in time? Early, later, never? How do you envison a way to select a boot device, or set

Re: [PATCH] Parse commandline in grub-xen

2015-05-11 Thread Michael Chang
On Mon, May 11, 2015 at 01:01:43PM +0200, Olaf Hering wrote: On Mon, May 11, Vladimir 'phcoder' Serbinenko wrote: Do you really own all those installs to be able to speak on behalf of all of them? Since there is zero upstream support for anything regarding grub xen distros are forced to

Re: [PATCH] Parse commandline in grub-xen

2015-05-11 Thread Andrei Borzenkov
В Mon, 11 May 2015 13:51:48 +0200 Olaf Hering o...@aepfle.de пишет: On Mon, May 11, Vladimir 'phcoder' Serbinenko wrote: On May 11, 2015 1:23 PM, Olaf Hering o...@aepfle.de wrote: On Mon, May 11, Vladimir 'phcoder' Serbinenko wrote: Do you really own all those installs to be

Re: [PATCH] Parse commandline in grub-xen

2015-05-11 Thread Vladimir 'phcoder' Serbinenko
On May 11, 2015 2:16 PM, Olaf Hering o...@aepfle.de wrote: On Mon, May 11, Andrei Borzenkov wrote: Either by allowing ${grub.arg.XXX} (not sure if current grammar accepts it) or by adding getarg command, something like getarg --name debug --set debug What would such format buy us?

Re: [PATCH] Parse commandline in grub-xen

2015-05-11 Thread Vladimir 'phcoder' Serbinenko
On May 11, 2015 2:04 PM, Andrei Borzenkov arvidj...@gmail.com wrote: В Mon, 11 May 2015 13:51:48 +0200 Olaf Hering o...@aepfle.de пишет: On Mon, May 11, Vladimir 'phcoder' Serbinenko wrote: On May 11, 2015 1:23 PM, Olaf Hering o...@aepfle.de wrote: On Mon, May 11, Vladimir

Re: [PATCH] Parse commandline in grub-xen

2015-05-11 Thread Olaf Hering
On Mon, May 11, Vladimir 'phcoder' Serbinenko wrote: On May 11, 2015 1:23 PM, Olaf Hering o...@aepfle.de wrote: On Mon, May 11, Vladimir 'phcoder' Serbinenko wrote: Do you really own all those installs to be able to speak on behalf of all of them? Since there is zero upstream

Re: [PATCH] Parse commandline in grub-xen

2015-05-11 Thread Vladimir 'phcoder' Serbinenko
On May 11, 2015 1:52 PM, Olaf Hering o...@aepfle.de wrote: On Mon, May 11, Vladimir 'phcoder' Serbinenko wrote: On May 11, 2015 1:23 PM, Olaf Hering o...@aepfle.de wrote: On Mon, May 11, Vladimir 'phcoder' Serbinenko wrote: Do you really own all those installs to be able to

Re: [PATCH] Parse commandline in grub-xen

2015-05-11 Thread Olaf Hering
On Mon, May 11, Vladimir 'phcoder' Serbinenko wrote: On May 11, 2015 2:16 PM, Olaf Hering o...@aepfle.de wrote: The use of uninitialized vars has to be caught by the script author no? It never works this way So? How does it work then? Because thats what I will propose to my package

Re: [PATCH] Parse commandline in grub-xen

2015-05-11 Thread Vladimir 'phcoder' Serbinenko
On May 11, 2015 3:34 PM, Olaf Hering o...@aepfle.de wrote: On Mon, May 11, Vladimir 'phcoder' Serbinenko wrote: On May 11, 2015 2:16 PM, Olaf Hering o...@aepfle.de wrote: The use of uninitialized vars has to be caught by the script author no? It never works this way So? How does it

Re: [PATCH] Parse commandline in grub-xen

2015-05-11 Thread Andrei Borzenkov
В Mon, 11 May 2015 19:14:14 +0200 Vladimir 'phcoder' Serbinenko phco...@gmail.com пишет: On May 11, 2015 6:52 PM, Andrei Borzenkov arvidj...@gmail.com wrote: В Mon, 11 May 2015 14:55:34 +0200 Vladimir 'phcoder' Serbinenko phco...@gmail.com пишет: On May 11, 2015 2:04 PM, Andrei

Re: [PATCH] Parse commandline in grub-xen

2015-05-11 Thread Andrei Borzenkov
В Mon, 11 May 2015 14:15:54 +0200 Olaf Hering o...@aepfle.de пишет: On Mon, May 11, Andrei Borzenkov wrote: Either by allowing ${grub.arg.XXX} (not sure if current grammar accepts it) or by adding getarg command, something like getarg --name debug --set debug What would such format

Re: [PATCH] Parse commandline in grub-xen

2015-05-11 Thread Olaf Hering
On Mon, May 11, Andrei Borzenkov wrote: В Mon, 11 May 2015 14:15:54 +0200 Olaf Hering o...@aepfle.de пишет: On Mon, May 11, Andrei Borzenkov wrote: Either by allowing ${grub.arg.XXX} (not sure if current grammar accepts it) or by adding getarg command, something like getarg

Re: [PATCH] Parse commandline in grub-xen

2015-05-11 Thread Vladimir 'phcoder' Serbinenko
On May 11, 2015 8:46 PM, Andrei Borzenkov arvidj...@gmail.com wrote: В Mon, 11 May 2015 19:14:14 +0200 Vladimir 'phcoder' Serbinenko phco...@gmail.com пишет: On May 11, 2015 6:52 PM, Andrei Borzenkov arvidj...@gmail.com wrote: В Mon, 11 May 2015 14:55:34 +0200 Vladimir 'phcoder'

Re: [PATCH] Parse commandline in grub-xen

2015-05-11 Thread Andrei Borzenkov
В Mon, 11 May 2015 20:01:29 +0800 Michael Chang mch...@suse.com пишет: On Mon, May 11, 2015 at 01:01:43PM +0200, Olaf Hering wrote: On Mon, May 11, Vladimir 'phcoder' Serbinenko wrote: Do you really own all those installs to be able to speak on behalf of all of them? Since

Re: [PATCH] Parse commandline in grub-xen

2015-05-11 Thread Vladimir 'phcoder' Serbinenko
On May 11, 2015 7:08 PM, Olaf Hering o...@aepfle.de wrote: On Mon, May 11, Andrei Borzenkov wrote: В Mon, 11 May 2015 14:15:54 +0200 Olaf Hering o...@aepfle.de пишет: On Mon, May 11, Andrei Borzenkov wrote: Either by allowing ${grub.arg.XXX} (not sure if current grammar accepts

Re: [PATCH] Parse commandline in grub-xen

2015-05-11 Thread Andrei Borzenkov
В Mon, 11 May 2015 14:55:34 +0200 Vladimir 'phcoder' Serbinenko phco...@gmail.com пишет: On May 11, 2015 2:04 PM, Andrei Borzenkov arvidj...@gmail.com wrote: В Mon, 11 May 2015 13:51:48 +0200 Olaf Hering o...@aepfle.de пишет: On Mon, May 11, Vladimir 'phcoder' Serbinenko wrote: