Re: [PATCH v3] docs: Add debugging chapter to development documentation

2023-08-17 Thread Olaf Hering
Wed, 16 Aug 2023 12:53:48 -0500 Glenn Washburn : > I specifically wanted these two sections to be subsections of > x86_64-efi and not at the same level as i386-pc, hence why I have them > as subsections. I suspect that the issue could be fixed by adding a > @menu in the x86_64-efi section with

Re: [PATCH v3] docs: Add debugging chapter to development documentation

2023-08-16 Thread Glenn Washburn
On Wed, 16 Aug 2023 10:41:40 +0200 Olaf Hering wrote: > Wed, 16 Aug 2023 00:29:28 -0500 Glenn Washburn : > > > Anyway, since you're the first and *so far* only person seeing this, > > could you submit a patch that fixes this for you? It would be great to > > support older makeinfos (if that is

Re: [PATCH v3] docs: Add debugging chapter to development documentation

2023-08-16 Thread Olaf Hering
Wed, 16 Aug 2023 00:29:28 -0500 Glenn Washburn : > Anyway, since you're the first and *so far* only person seeing this, > could you submit a patch that fixes this for you? It would be great to > support older makeinfos (if that is indeed the issue) in the upcoming > release. The change below

Re: [PATCH v3] docs: Add debugging chapter to development documentation

2023-08-15 Thread Glenn Washburn
On Tue, 15 Aug 2023 22:37:08 +0200 Olaf Hering wrote: > Tue, 15 Aug 2023 12:31:29 -0500 Glenn Washburn : > > > I'm not seeing this issue when building on Debian 11. I'm successfully > > building the info, html, and pdf documentation from the texi files > > using debians texinfo package at

Re: [PATCH v3] docs: Add debugging chapter to development documentation

2023-08-15 Thread Olaf Hering
Tue, 15 Aug 2023 12:31:29 -0500 Glenn Washburn : > I'm not seeing this issue when building on Debian 11. I'm successfully > building the info, html, and pdf documentation from the texi files > using debians texinfo package at version 6.7.0.dfsg.2-6. Are you sure > you are building from clean

Re: [PATCH v3] docs: Add debugging chapter to development documentation

2023-08-15 Thread Glenn Washburn
On Tue, 15 Aug 2023 10:14:07 +0200 Olaf Hering wrote: > Thu, 15 Jun 2023 13:06:09 +0200 Daniel Kiper : > > > Right now patch is in the git repo. If you want to improve that part of > > doc please send a fix to grub-devel and CC interested folks. > > Yeah, that is very unfortunate, because it

Re: [PATCH v3] docs: Add debugging chapter to development documentation

2023-08-15 Thread Olaf Hering
Thu, 15 Jun 2023 13:06:09 +0200 Daniel Kiper : > Right now patch is in the git repo. If you want to improve that part of > doc please send a fix to grub-devel and CC interested folks. Yeah, that is very unfortunate, because it breaks the build:

Re: [PATCH v3] docs: Add debugging chapter to development documentation

2023-06-15 Thread Oskari Pirhonen
On Thu, Jun 15, 2023 at 13:06:09 +0200, Daniel Kiper wrote: > On Thu, Jun 15, 2023 at 01:21:57AM -0500, Oskari Pirhonen wrote: > > Oops, apologies for the late reply. Reading through it again, I found a > > few more small nits: > > Right now patch is in the git repo. If you want to improve that

Re: [PATCH v3] docs: Add debugging chapter to development documentation

2023-06-15 Thread Daniel Kiper
On Thu, Jun 15, 2023 at 01:21:57AM -0500, Oskari Pirhonen wrote: > Oops, apologies for the late reply. Reading through it again, I found a > few more small nits: Right now patch is in the git repo. If you want to improve that part of doc please send a fix to grub-devel and CC interested folks.

Re: [PATCH v3] docs: Add debugging chapter to development documentation

2023-06-15 Thread Oskari Pirhonen
Oops, apologies for the late reply. Reading through it again, I found a few more small nits: On Tue, Jun 06, 2023 at 00:48:39 -0500, Glenn Washburn wrote: > Debugging GRUB can be tricky and require arcane knowledge. This will > help those unfamiliar with the process to get started debugging GRUB

Re: [PATCH v3] docs: Add debugging chapter to development documentation

2023-06-12 Thread Daniel Kiper
On Tue, Jun 06, 2023 at 12:48:39AM -0500, Glenn Washburn wrote: > Debugging GRUB can be tricky and require arcane knowledge. This will > help those unfamiliar with the process to get started debugging GRUB > with less effort. > > Signed-off-by: Glenn Washburn Reviewed-by: Daniel Kiper Thank