Re: [RFC PATCH] i386: don't include lib/i386/reset.c in EFI builds

2018-07-25 Thread Daniel Kiper
On Fri, Jul 13, 2018 at 03:46:57PM +0100, Leif Lindholm wrote: > On Fri, Jul 13, 2018 at 03:59:38PM +0200, Daniel Kiper wrote: > > On Fri, Jul 13, 2018 at 01:53:52PM +0100, Leif Lindholm wrote: > > > On Fri, Jul 13, 2018 at 01:27:08PM +0200, Daniel Kiper wrote: > > > > > > > (i386_)ieee1275

Re: [RFC PATCH] i386: don't include lib/i386/reset.c in EFI builds

2018-07-13 Thread Leif Lindholm
On Fri, Jul 13, 2018 at 03:59:38PM +0200, Daniel Kiper wrote: > On Fri, Jul 13, 2018 at 01:53:52PM +0100, Leif Lindholm wrote: > > On Fri, Jul 13, 2018 at 01:27:08PM +0200, Daniel Kiper wrote: > > > > > > (i386_)ieee1275 implements its own grub_reboot(), so that should be > > > > > > fine. (This

Re: [RFC PATCH] i386: don't include lib/i386/reset.c in EFI builds

2018-07-13 Thread Daniel Kiper
On Fri, Jul 13, 2018 at 01:53:52PM +0100, Leif Lindholm wrote: > On Fri, Jul 13, 2018 at 01:27:08PM +0200, Daniel Kiper wrote: > > > > > (i386_)ieee1275 implements its own grub_reboot(), so that should be > > > > > fine. (This does mean that i386_ieee1275 may currently be unable to > > > > > load

Re: [RFC PATCH] i386: don't include lib/i386/reset.c in EFI builds

2018-07-13 Thread Leif Lindholm
On Fri, Jul 13, 2018 at 01:27:08PM +0200, Daniel Kiper wrote: > > > > (i386_)ieee1275 implements its own grub_reboot(), so that should be > > > > fine. (This does mean that i386_ieee1275 may currently be unable to > > > > load the reboot module on master.) > > > > > > Hmmm... So, it looks that

Re: [RFC PATCH] i386: don't include lib/i386/reset.c in EFI builds

2018-07-13 Thread Daniel Kiper
On Thu, Jul 12, 2018 at 12:52:49PM +0100, Leif Lindholm wrote: > On Thu, Jul 12, 2018 at 01:44:36PM +0200, Daniel Kiper wrote: > > On Wed, Jul 11, 2018 at 12:53:01PM +0100, Leif Lindholm wrote: > > > On Wed, Jul 11, 2018 at 01:03:12PM +0200, Daniel Kiper wrote: > > > > On Mon, Jul 09, 2018 at

Re: [RFC PATCH] i386: don't include lib/i386/reset.c in EFI builds

2018-07-12 Thread Leif Lindholm
On Thu, Jul 12, 2018 at 01:44:36PM +0200, Daniel Kiper wrote: > On Wed, Jul 11, 2018 at 12:53:01PM +0100, Leif Lindholm wrote: > > On Wed, Jul 11, 2018 at 01:03:12PM +0200, Daniel Kiper wrote: > > > On Mon, Jul 09, 2018 at 07:49:06PM +0100, Leif Lindholm wrote: > > > > Commit 0ba90a7f0178 ("efi:

Re: [RFC PATCH] i386: don't include lib/i386/reset.c in EFI builds

2018-07-12 Thread Daniel Kiper
On Wed, Jul 11, 2018 at 12:53:01PM +0100, Leif Lindholm wrote: > On Wed, Jul 11, 2018 at 01:03:12PM +0200, Daniel Kiper wrote: > > On Mon, Jul 09, 2018 at 07:49:06PM +0100, Leif Lindholm wrote: > > > Commit 0ba90a7f0178 ("efi: Move grub_reboot() into kernel") broke > > > the build on i386-efi -

Re: [RFC PATCH] i386: don't include lib/i386/reset.c in EFI builds

2018-07-11 Thread Leif Lindholm
On Wed, Jul 11, 2018 at 01:03:12PM +0200, Daniel Kiper wrote: > On Mon, Jul 09, 2018 at 07:49:06PM +0100, Leif Lindholm wrote: > > Commit 0ba90a7f0178 ("efi: Move grub_reboot() into kernel") broke > > the build on i386-efi - genmoddep.awk bails out with message > > grub_reboot in reboot is

Re: [RFC PATCH] i386: don't include lib/i386/reset.c in EFI builds

2018-07-11 Thread Daniel Kiper
On Mon, Jul 09, 2018 at 07:49:06PM +0100, Leif Lindholm wrote: > Commit 0ba90a7f0178 ("efi: Move grub_reboot() into kernel") broke > the build on i386-efi - genmoddep.awk bails out with message > grub_reboot in reboot is duplicated in kernel > This is because both lib/i386/reset.c and