On Tue, Oct 12, 2021 at 07:39:58PM -0500, Glenn Washburn wrote:
> When using the output of a subshell as input, its error code is ignored in
> the context of "set -e". Many test scripts use grub-shell in a subshell with
> output used as an argument to the test command to test
When using the output of a subshell as input, its error code is ignored in
the context of "set -e". Many test scripts use grub-shell in a subshell with
output used as an argument to the test command to test for expected output.
Refactor these tests so that the subshell output goes
On 08.12.2015 17:36, Andrei Borzenkov wrote:
> `test' in GRUB implicitly assumes `and' operation between consecutive
> terms and does not enforce proper syntax like UNIX (bash) `test' does. Both
>
> test x y z
> test x = y z = w
>
> result in error in Linux and are silently accepted by GRUB with
`test' in GRUB implicitly assumes `and' operation between consecutive
terms and does not enforce proper syntax like UNIX (bash) `test' does. Both
test x y z
test x = y z = w
result in error in Linux and are silently accepted by GRUB with
interpretation
test x -a y -a z
test ( x = y ) -a ( z = w
On Thu, Jan 29, 2015 at 7:19 AM, Andrei Borzenkov
wrote:
> В Thu, 29 Jan 2015 06:17:42 -0800
> Jonathan McCune пишет:
>
> > On Jan 29, 2015 1:19 AM, "Andrei Borzenkov" wrote:
> > >
> > > What sematic of file tests should be? I think they should just test
> > > file existence; this already happe
В Thu, 29 Jan 2015 06:17:42 -0800
Jonathan McCune пишет:
> On Jan 29, 2015 1:19 AM, "Andrei Borzenkov" wrote:
> >
> > What sematic of file tests should be? I think they should just test
> > file existence; this already happens for compressed files that checks
> > that on-disk file size, not unco
On Jan 29, 2015 1:19 AM, "Andrei Borzenkov" wrote:
>
> What sematic of file tests should be? I think they should just test
> file existence; this already happens for compressed files that checks
> that on-disk file size, not uncompressed. I think same should apply to
> signature checks.
>
Where t
What sematic of file tests should be? I think they should just test
file existence; this already happens for compressed files that checks
that on-disk file size, not uncompressed. I think same should apply to
signature checks.
May be file checks should simply disable all filters unconditionally
to
commited
On Thu, Apr 16, 2009 at 3:15 PM, phcoder wrote:
> BTW, I think you can simplify test_parse. For example, you write "if (*argn
>> + 2 < argc ...)" many times, but it should be possible to test this
>> condition only once per loop.
>>
> Optimised. Perhaps compiler optimised this anyway bu
BTW, I think you can simplify test_parse. For example, you write "if (*argn +
2 < argc ...)" many times, but it should be possible to test this condition
only once per loop.
Optimised. Perhaps compiler optimised this anyway but it made code more
readable
Regards,
Okuji
__
On Sunday 12 April 2009 00:11:45 phcoder wrote:
> Updated. Same changelog
>
> >> + {
> >> + update_val (grub_strcmp (args[*argn], args[*argn + 2]) == 0);
> >> + (*argn) += 3;
> >
> > I myself feel that these parentheses are redundant, but I don't know how
> > others think. For
Updated. Same changelog
+ {
+ update_val (grub_strcmp (args[*argn], args[*argn + 2]) == 0);
+ (*argn) += 3;
I myself feel that these parentheses are redundant, but I don't know how
others think. For C programmers, it is well known that * has a very high
priority.
These
On Saturday 11 April 2009 07:18:59 phcoder wrote:
> Rediffed. New changelog
This time, I comment on all style problems.
> diff --git a/commands/test.c b/commands/test.c
> index a9c8281..2d8dedd 100644
> --- a/commands/test.c
> +++ b/commands/test.c
> @@ -21,33 +21,385 @@
> #include
> #include
Rediffed. New changelog
2009-04-11 Vladimir Serbinenko
Test command
* commands/test.c: rewritten to use bash-like test
phcoder wrote:
Sorry forgot to attach the file
phcoder wrote:
Hello. Here is an implementation of bash-like "test" command. Many
file tests a
Sorry forgot to attach the file
phcoder wrote:
Hello. Here is an implementation of bash-like "test" command. Many file
tests are omitted because they are useless in grub (e.g. -c test). I
also added 3 extension: lexicographical comparing, prefixed -gt and -lt
(it skips common pref
Hello. Here is an implementation of bash-like "test" command. Many file
tests are omitted because they are useless in grub (e.g. -c test). I
also added 3 extension: lexicographical comparing, prefixed -gt and -lt
(it skips common prefix. Useful for comparing versions. e.g. [ vmlin
16 matches
Mail list logo
