Hello,
On Nov/29/2009, Carles Pina i Estany wrote:
+ grub_printf (_(Failed to boot default entries.));
+ grub_putchar ('\n');
This is the only string that I've spotted that it's String\n
other ones are:
\nString
String\n
Up to the discussion in the grub_printfnl I would change it to
Hi,
I've added some easy changes for normal/menu_entry.c
So better review this patch.
Thanks!
--
Carles Pina i Estany
http://pinux.info
2009-11-28 Carles Pina i Estany car...@pina.cat
* normal/menu_text.c (grub_color_menu_high): Gettexttize string.
(print_spaces):
Please remember about spaces in our coding style:
On Sat, Nov 28, 2009 at 12:21:28PM +, Carles Pina i Estany wrote:
+ next_new_line = (grub_uint32_t*)last_position;
^ ^
+ while (getstringwidth(current_position,next_new_line) line_len
Hello,
On Nov/28/2009, Robert Millan wrote:
Please remember about spaces in our coding style:
On Sat, Nov 28, 2009 at 12:21:28PM +, Carles Pina i Estany wrote:
+ next_new_line = (grub_uint32_t*)last_position;
^ ^
+ while
Carles Pina i Estany wrote:
Hello,
On Nov/28/2009, Robert Millan wrote:
Please remember about spaces in our coding style:
On Sat, Nov 28, 2009 at 12:21:28PM +, Carles Pina i Estany wrote:
+ next_new_line = (grub_uint32_t*)last_position;
Hi,
Find attached the patch and ChangeLog for normal_menu.c
Suggestions? What to change?
Notice that I used grub_printf to print the spaces/new lines of
formatting.
And print_message_indented receive a long string and prints it
splitting by the spaces and indented 6 spaces.
(15 and 6 in that
Hi,
On Nov/28/2009, Carles Pina i Estany wrote:
Find attached the patch and ChangeLog for normal_menu.c
new version with two improvements:
a) uses grubcharwidth to calculate the width of the string (for the
characters that doesn't have any width, etc.). This has to be consistent
with
Hi,
On Nov/28/2009, Carles Pina i Estany wrote:
Hi,
On Nov/28/2009, Carles Pina i Estany wrote:
Find attached the patch and ChangeLog for normal_menu.c
new version with two improvements:
really, I should not be sending mails on Friday too late. Now is
attached.
--
Carles Pina i
