Re: [grub-fs-tester.in] zisofs test looks unsuitable

2021-08-26 Thread Thomas Schmitt
Hi, Glenn Washburn wrote: > If I'm not mistaken, there is currently no test which actually > exercises that code, ie no test runs "grub-fs-tester ziso9660". I think > it could be a good idea to have one though. So we should get this to work. zisofs can be helpful to squeeze more operating system

Re: [PATCH] fs/xfs: Avoid unreadble filesystem if V4 superblock

2021-08-26 Thread Erwan Velu
I should have cc Carlos Maiolino who authored this patch. This is now done. Le mer. 25 août 2021 à 15:32, Erwan Velu a écrit : > Commit 8b1e5d1936fffc490510e85c95f93248453586c1 introduced the support > of bigtime by adding the some features in inodes V3. > > This change extended grub_xfs_inode

set digest off

2021-08-26 Thread Nikolai Kostrigin
set digest off ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] fs/xfs: Avoid unreadble filesystem if V4 superblock

2021-08-26 Thread Erwan Velu
> > [...] > Thanks for spotting this! > We got hit in production with it, that's why we investigate this issue. It's deployed on our infra & works fine on the affected servers but works fine too on the servers running V5 fs. I don't know what is the policy of this project, but a point release wou

Re: [PATCH 2/2] configure: Check -falign-jumps=1 -falign-functions=1 beside -falign-loops=1

2021-08-26 Thread Daniel Kiper
On Wed, Aug 25, 2021 at 09:34:41AM -0700, Fangrui Song wrote: > On 2021-08-25, Daniel Kiper wrote: > > On Mon, Aug 23, 2021 at 11:18:38PM -0700, Fangrui Song wrote: > > > Clang does not support -falign-jumps and only recently gained support > > > for -falign-loops. Test all the alignment options to

Re: [PATCH 2/2] autogen.sh: Detect python

2021-08-26 Thread Daniel Kiper
On Wed, Aug 18, 2021 at 09:19:23AM +0200, Petr Vorel wrote: > > On Mon, Aug 09, 2021 at 01:52:29PM +0200, Daniel Kiper wrote: > > > On Fri, Aug 06, 2021 at 08:45:08AM +0200, Petr Vorel wrote: > > > > It help to avoid error on distros which has only python3 binary: > > > > ./autogen.sh: line 20: pyt

Re: [PATCH 2/2] autogen.sh: Detect python

2021-08-26 Thread Daniel Kiper
On Wed, Aug 18, 2021 at 11:04:50AM -0500, Bruce Dubbs wrote: > On 8/18/21 1:19 AM, Petr Vorel wrote: > > > On Mon, Aug 09, 2021 at 01:52:29PM +0200, Daniel Kiper wrote: > > > > On Fri, Aug 06, 2021 at 08:45:08AM +0200, Petr Vorel wrote: > > > > > It help to avoid error on distros which has only pyt

Re: [PATCH 2/2] autogen.sh: Detect python

2021-08-26 Thread Daniel Kiper
On Wed, Aug 18, 2021 at 09:38:11AM +0200, Petr Vorel wrote: > > Hi Daniel, > > > sorry for longer time to reply (vacation). > > > > On Fri, Aug 06, 2021 at 08:45:08AM +0200, Petr Vorel wrote: > > > > It help to avoid error on distros which has only python3 binary: > > > > ./autogen.sh: line 20: pyt

Re: [PATCH] fs/xfs: Avoid unreadble filesystem if V4 superblock

2021-08-26 Thread Carlos Maiolino
On Thu, Aug 26, 2021 at 09:54:59AM +0200, Erwan Velu wrote: >I should have cc Carlos Maiolino who authored this patch. >This is now done. > >Le mer. 25 août 2021 à 15:32, Erwan Velu <[1]erwanalia...@gmail.com> a >écrit : > > Commit 8b1e5d1936fffc490510e85c95f93248453586c1 int

Re: [PATCH 1/1] autogen.sh: detect python3

2021-08-26 Thread Daniel Kiper
On Fri, Aug 13, 2021 at 08:46:24PM +0200, Heinrich Schuchardt wrote: > On some current distributions there is no /usr/bin/python. The Python > binary is /usr/bin/python3. If a command python3 is available, use it > instead. > > Signed-off-by: Heinrich Schuchardt I prefer solution proposed here [1

Re: [PATCH v3 0/6] Runtime allocation of memory regions

2021-08-26 Thread Daniel Kiper
Hey, Adding Daniel Axtens... On Sun, Aug 15, 2021 at 01:09:06PM +0200, Patrick Steinhardt wrote: > Hi, > > this is the third version of my patch set to implement runtime > allocation of additional memory regions. > > Changes compared to v2: > > - A new preparatory patch was added to remove un

[PATCH v3 1/2] configure: Remove obsoleted -malign-{jumps, loops, functions}

2021-08-26 Thread Fangrui Song via Grub-devel
GCC warns `cc1: warning: ‘-malign-loops’ is obsolete, use ‘-falign-loops’`. Clang silently ignores -malign-{jumps,loops,functions}. The preferred -falign-* forms have been supported since GCC 3.2, so just remove -malign-{jumps,loops,functions}. Acked-by: Paul Menzel Reviewed-by: Daniel Kiper Si

[PATCH v3 0/2] configure: Remove -malign-* and fix Clang 14 breakage

2021-08-26 Thread Fangrui Song via Grub-devel
Replaces https://lists.gnu.org/archive/html/grub-devel/2021-08/msg00094.html ("[PATCH 0/2] configure: Remove -malign-* and fix Clang 14 breakage") Changes from v2: Split -falign-jumps=1 -falign-loops=1 checks Change a tab to spaces Fangrui Song (2): configure: Remove obsoleted -malign-{jump

[PATCH v3 2/2] configure: Check -falign-jumps=1 beside -falign-loops=1

2021-08-26 Thread Fangrui Song via Grub-devel
Clang does not support -falign-jumps and only recently gained support for -falign-loops. -falign-jumps=1 should be tested beside -fliang-loops=1 to avoid passing unrecognized options to Clang: clang-14: error: optimization flag '-falign-jumps=1' is not supported [-Werror,-Wignored-optimizatio

Re: [PATCH v2 1/8] tests: Make sure LANG is set properly for iso9660_test

2021-08-26 Thread Glenn Washburn
On Thu, 26 Aug 2021 08:53:31 +0200 "Thomas Schmitt" wrote: > Hi, > > Glenn Washburn wrote: > > Despite having an alternative approach, do you have concerns or > > objections to my patch? > > Not specifically. I initially only wanted to mention that there is > a xorriso alternative to setting L

Re: [PATCH v3 1/2] configure: Remove obsoleted -malign-{jumps,loops,functions}

2021-08-26 Thread Daniel Kiper
On Thu, Aug 26, 2021 at 09:02:31AM -0700, Fangrui Song wrote: > GCC warns `cc1: warning: ‘-malign-loops’ is obsolete, use ‘-falign-loops’`. > Clang silently ignores -malign-{jumps,loops,functions}. > > The preferred -falign-* forms have been supported since GCC 3.2, so just > remove -malign-{jumps,

Re: [PATCH v2 1/8] tests: Make sure LANG is set properly for iso9660_test

2021-08-26 Thread Thomas Schmitt
Hi, now i know that i should have asked for the test-suite.log file. The problem turned out to be in Joliet, not in ISO 9660. Because Joliet gets its file names and other texts encoded as UCS-2 16-bit characters it is indeed inavoidable to define the meaning of the bytes in a Unix file name. The

Re: v7 for detached headers and key files

2021-08-26 Thread Daniel Kiper
Hey Denis, On Wed, Aug 18, 2021 at 12:30:26AM +0200, Denis 'GNUtoo' Carikli wrote: > Hi, > > Since the last time where I sent this patch serie (December 2020), GRUB > 2.06 is out and many of the security issues have now been fixed, so I > hope it's a good time to ping again for this patch now. > >

Re: [PATCH 00/12] Grub-shell improvements

2021-08-26 Thread Daniel Kiper
Hi Glenn, On Wed, Aug 25, 2021 at 06:06:30PM -0500, Glenn Washburn wrote: > Hi Daniel, > > What are the chances this patch series can be reviewed in the near > future? Some feedback would be greatly appreciated. I can see the following patches from you waiting in my review queue: - [CRYPTO-LUKS

Re: [grub-fs-tester.in] zisofs test looks unsuitable

2021-08-26 Thread Thomas Schmitt
Hi, i managed to get the ziso9660 test running with actual compression. ./grub-fs-tester ziso9660 now produces an ISO image but seems not to be happy with it. If i get it right then it sees the compressed size 1124519 of file "1.img" but expects its uncompressed size 5242879. Linux mount sees

Re: [PATCH v2 1/8] tests: Make sure LANG is set properly for iso9660_test

2021-08-26 Thread Glenn Washburn
On Thu, 26 Aug 2021 19:49:37 +0200 "Thomas Schmitt" wrote: > Hi, > > now i know that i should have asked for the test-suite.log file. > > The problem turned out to be in Joliet, not in ISO 9660. > Because Joliet gets its file names and other texts encoded as UCS-2 > 16-bit characters it is inde

Re: [PATCH v2 1/8] tests: Make sure LANG is set properly for iso9660_test

2021-08-26 Thread Thomas Schmitt
Hi, i wrote: > > xorriso ... -as mkisofs -input-charset UTF-8 -output-charset UTF-8 Glenn Washburn wrote: > Do there need to be any UTF-8 locales installed (or any locales for > that matter) for this to work? My guess is no. I expect the same. It's not easy to test, though. In theory it is es

Re: [grub-fs-tester.in] zisofs test looks unsuitable

2021-08-26 Thread Glenn Washburn
On Thu, 26 Aug 2021 22:07:29 +0200 "Thomas Schmitt" wrote: > Hi, > > i managed to get the ziso9660 test running with actual compression. > > ./grub-fs-tester ziso9660 > > now produces an ISO image but seems not to be happy with it. > > If i get it right then it sees the compressed size 1124

Re: [PATCH 00/12] Grub-shell improvements

2021-08-26 Thread Glenn Washburn
Hi Daniel, On Thu, 26 Aug 2021 20:00:32 +0200 Daniel Kiper wrote: > Hi Glenn, > > On Wed, Aug 25, 2021 at 06:06:30PM -0500, Glenn Washburn wrote: > > Hi Daniel, > > > > What are the chances this patch series can be reviewed in the near > > future? Some feedback would be greatly appreciated. >

Re: [grub-fs-tester.in] zisofs test looks unsuitable

2021-08-26 Thread Thomas Schmitt
Hi. Glenn Washburn wrote: > I think the changes to get the test > working are worthy of inclusion so that the tests are ready when this > feature gets implemented. Do you think my draft of a commit message is ok ? Probably i should mention that this test will fail until zisofs is implemented.

Re: [PATCH v2 1/8] tests: Make sure LANG is set properly for iso9660_test

2021-08-26 Thread Glenn Washburn
On Thu, 26 Aug 2021 23:28:04 +0200 "Thomas Schmitt" wrote: > > If yes, then I should probably remove this patch altogether and put > > this code elsewhere. > > I think it can be justified to hardcode UTF-8 in grub-fs-tester > regardless whether higher levels of the test empire or the user have >

Re: [grub-fs-tester.in] zisofs test looks unsuitable

2021-08-26 Thread Glenn Washburn
On Fri, 27 Aug 2021 00:14:20 +0200 "Thomas Schmitt" wrote: > Hi. > > Glenn Washburn wrote: > > I think the changes to get the test > > working are worthy of inclusion so that the tests are ready when > > this feature gets implemented. > > Do you think my draft of a commit message is ok ? Seems

Re: [PATCH v3 0/6] Runtime allocation of memory regions

2021-08-26 Thread Daniel Axtens
Daniel Kiper writes: > Hey, > > Adding Daniel Axtens... > > On Sun, Aug 15, 2021 at 01:09:06PM +0200, Patrick Steinhardt wrote: >> Hi, >> >> this is the third version of my patch set to implement runtime >> allocation of additional memory regions. >> >> Changes compared to v2: >> >> - A new p