Re: [PATCH v3] docs: Add debugging chapter to development documentation

2023-08-15 Thread Olaf Hering
Thu, 15 Jun 2023 13:06:09 +0200 Daniel Kiper : > Right now patch is in the git repo. If you want to improve that part of > doc please send a fix to grub-devel and CC interested folks. Yeah, that is very unfortunate, because it breaks the build:

Re: [PATCH v9 02/11] Unify GUID types

2023-08-15 Thread Ard Biesheuvel
On Tue, 15 Aug 2023 at 05:42, Vladimir 'phcoder' Serbinenko wrote: >> >> . >> >> Ard thinks that a 64 bit alignment for EFI GUIDs is a mistake - see [1] >> and [2]. Hence Linux uses `__aligned(__alignof__(u32))` for "efi_guid_t" >> since 2019. > > > My patch presents a reliability paradigm:

[PATCH] templates/linux_xen: Fix XSM entries generation

2023-08-15 Thread Anthony PERARD via Grub-devel
It turns out that setting $xen_version in linux_entry_xsm() override $xen_version in the loop over $xen_list. This means that only one entry per Xen version is going to enable XSM, but all further entries are going to have "(XSM enabled)" in their titles without enabling XSM. When a

Re: [PATCH v9 02/11] Unify GUID types

2023-08-15 Thread Laszlo Ersek
On 8/15/23 10:17, Ard Biesheuvel wrote: > On Tue, 15 Aug 2023 at 05:42, Vladimir 'phcoder' Serbinenko > wrote: >>> >>> . >>> >>> Ard thinks that a 64 bit alignment for EFI GUIDs is a mistake - see [1] >>> and [2]. Hence Linux uses `__aligned(__alignof__(u32))` for "efi_guid_t" >>> since 2019. >>

Re: [PATCH v9 02/11] Unify GUID types

2023-08-15 Thread Vladimir 'phcoder' Serbinenko
Le mar. 15 août 2023, 14:00, Laszlo Ersek a écrit : > On 8/15/23 10:17, Ard Biesheuvel wrote: > > On Tue, 15 Aug 2023 at 05:42, Vladimir 'phcoder' Serbinenko > > wrote: > >>> > >>> . > >>> > >>> Ard thinks that a 64 bit alignment for EFI GUIDs is a mistake - see [1] > >>> and [2]. Hence Linux

Re: [PATCH v3] docs: Add debugging chapter to development documentation

2023-08-15 Thread Glenn Washburn
On Tue, 15 Aug 2023 10:14:07 +0200 Olaf Hering wrote: > Thu, 15 Jun 2023 13:06:09 +0200 Daniel Kiper : > > > Right now patch is in the git repo. If you want to improve that part of > > doc please send a fix to grub-devel and CC interested folks. > > Yeah, that is very unfortunate, because it

Re: [PATCH v3] docs: Add debugging chapter to development documentation

2023-08-15 Thread Olaf Hering
Tue, 15 Aug 2023 12:31:29 -0500 Glenn Washburn : > I'm not seeing this issue when building on Debian 11. I'm successfully > building the info, html, and pdf documentation from the texi files > using debians texinfo package at version 6.7.0.dfsg.2-6. Are you sure > you are building from clean

Re: [PATCH v3] docs: Add debugging chapter to development documentation

2023-08-15 Thread Glenn Washburn
On Tue, 15 Aug 2023 22:37:08 +0200 Olaf Hering wrote: > Tue, 15 Aug 2023 12:31:29 -0500 Glenn Washburn : > > > I'm not seeing this issue when building on Debian 11. I'm successfully > > building the info, html, and pdf documentation from the texi files > > using debians texinfo package at