On 20.03.2013 08:41, Vladimir Testov wrote:
new option: start_angle_degrees
maybe like that? :)
Using a different option for the same thing just expressed in different
units isn't good or natural. It's more natural to use unit modifiers like
start_angle = 90° or start_angle = 90 deg
On Mon, Apr 01, 2013 at 06:45:16PM +0200, Francesco Lavra wrote:
On 03/17/2013 09:36 PM, Francesco Lavra wrote:
I'm working on the GRUB port to ARM using the EFI platform. When
generating a relocatable ARM image, some relocation entries use a
relocation code (0x33) which is not defined in
On 22.03.2013 16:58, Vladimir Testov wrote:
+word_width = label_string_width (buf, font, l_lastend, end);
+if (isvertical || (str_width + word_width l_width)) // can't add new
word
+ {
Please don't use // comments. This code completely forgets the cases
when even the first
On 26.03.2013 15:44, Radosław Szymczyszyn wrote:
+fail:
+ return grub_error (GRUB_ERR_BAD_PART_TABLE, disklabel64 not found);
+}
There is only one user for this label. Please put this part directly at
where it's used
signature.asc
Description: OpenPGP digital signature
On 30.03.2013 09:46, Andrey Borzenkov wrote:
В Tue, 26 Mar 2013 11:48:37 +0100
Vladimir 'φ-coder/phcoder' Serbinenko phco...@gmail.com пишет:
+@deffn Command background_color color
+Set background color for active terminal. For valid color specifications
see
+@pxref{Theme file format,
On 30.01.2013 21:36, David Michael wrote:
insmod cpuid
if [ $cpuid_model_name = QEMU Virtual CPU ...
This is not a proper way to detect qemu (see -cpu ?). You should
probably rather parse smbios tables
signature.asc
Description: OpenPGP digital signature
On Mon, Apr 01, 2013 at 04:29:02PM +0200, Francesco Lavra wrote:
On 04/01/2013 04:15 AM, Vladimir '??-coder/phcoder' Serbinenko wrote:
Which architecture is raspberry pie? I have one here and it would be
good if I could use it for testing.
It's ARMv6, so unfortunately it's not supported by
On Sat, Mar 30, 2013 at 04:15:54PM +0100, Francesco Lavra wrote:
On 03/24/2013 06:01 PM, Leif Lindholm wrote:
[...]
=== added file 'grub-core/kern/arm/cache.S'
--- grub-core/kern/arm/cache.S 1970-01-01 00:00:00 +
+++ grub-core/kern/arm/cache.S 2013-03-24 12:56:20 +
@@
On Mon, Apr 01, 2013 at 04:08:59AM +0200, Vladimir '??-coder/phcoder'
Serbinenko wrote:
On 24.03.2013 18:01, Leif Lindholm wrote:
About memory map:
It would make sense to put modules right before heap as module space is
reused later as heap if this is enabled.
So, move stack to after heap?
On Sat, Mar 30, 2013 at 05:20:54PM +0100, Francesco Lavra wrote:
Mostly cosmetic comments from my side here...
Typos will be fixed.
On 03/24/2013 06:01 PM, Leif Lindholm wrote:
[...]
=== added file 'grub-core/kern/uboot/init.c'
--- grub-core/kern/uboot/init.c 1970-01-01 00:00:00
On Mon, Apr 01, 2013 at 04:15:03AM +0200, Vladimir '??-coder/phcoder'
Serbinenko wrote:
+#define GRUB_KERNEL_MACHINE_STACK_SIZE 0x4
+#define GRUB_KERNEL_MACHINE_HEAP_SIZE (grub_size_t) (2 * 1024 * 1024)
Why so small heap?
I copied ieee1275 HEAP_MIN_SIZE to begin with, and it was
On Mon, Apr 01, 2013 at 06:18:17PM +0200, Francesco Lavra wrote:
On 03/24/2013 06:01 PM, Leif Lindholm wrote:
=== added directory 'grub-core/loader/arm'
=== added file 'grub-core/loader/arm/linux.c'
--- grub-core/loader/arm/linux.c1970-01-01 00:00:00 +
+++
On Mon, Apr 01, 2013 at 04:31:13AM +0200, Vladimir '??-coder/phcoder'
Serbinenko wrote:
+static grub_uint64_t
+grub_efi_get_time_ms(void)
+{
+ grub_efi_time_t now;
+ grub_uint64_t retval;
+ grub_efi_status_t status;
+
+ status = efi_call_2
Please email the following information [...]
Done.
+fail:
+ return grub_error (GRUB_ERR_BAD_PART_TABLE, disklabel64 not found);
+}
There is only one user for this label. Please put this part directly at
where it's used
Fixed.
part-dfly.3.patch
Description: Binary data
On Wed, Apr 03, 2013 at 04:24:51PM +, Leif Lindholm wrote:
Because I am an overtly paranoid person. :)
That's not paranoid. That's just inefficient. The length argument has
to be based on the target size, NOT the length of the source. If you want
to length of the source, that's what plain
On Mon, Apr 01, 2013 at 06:24:43PM +0200, Francesco Lavra wrote:
On 03/24/2013 06:01 PM, Leif Lindholm wrote:
=== added file 'grub-core/kern/arm/efi/misc.c'
--- grub-core/kern/arm/efi/misc.c 1970-01-01 00:00:00 +
+++ grub-core/kern/arm/efi/misc.c 2013-03-24 15:43:19 +
[...]
В Wed, 3 Apr 2013 11:53:06 -0400
Peter Jones pjo...@redhat.com пишет:
When we have 4kB sectors instead of 512b sectors, hd.partition_start and
grub_partition_get_start() won't match - the latter assumes 512-byte
sectors, and the former gives us the correct number based on the
physical
On 17.02.2013 16:15, Andrey Borzenkov wrote:
See screenshot for what I get using current trunk.
I do not pretend to fully understand all this code so review is
appreciated. So far it does fix both gfxterm and console cases for me.
I've fixed the same problem by much smaller logic change
On 31.01.2013 13:49, Andrey Borzenkov wrote:
В Fri, 11 Jan 2013 21:54:22 +0100
Vladimir 'φ-coder/phcoder' Serbinenko phco...@gmail.com пишет:
Hello, all. I've just committed import of libgcrypt and implementation
of related code to check signatures. Short usage:
verify_detached FILE
On 31.01.2013 23:20, Cyrille Lefevre wrote:
Hi,
I'm attempting to build grub2-rc1 -emu under cygwin w/o success.
I've made a fast and dirty patch about the missing stuff (emunet tap),
see attachment,
It breaks Linux part, you need #ifdef's
# but I don't known how to say to the build
On 03.04.2013 20:05, Lennart Sorensen wrote:
On Wed, Apr 03, 2013 at 04:24:51PM +, Leif Lindholm wrote:
Because I am an overtly paranoid person. :)
That's not paranoid. That's just inefficient. The length argument has
to be based on the target size, NOT the length of the source. If
On 03.04.2013 20:07, Leif Lindholm wrote:
I don't see grub-mkimage currently being fully cross-platform anyway,
so I would (as mentioned in previous email) prefer to postpone any
such adjustments until the basic support is in. I have the patches
for it, if not entirely up to date.
22 matches
Mail list logo
