Re: [PATCH 00/10] various cleanup

2018-02-23 Thread Daniel Kiper
On Thu, Feb 15, 2018 at 11:34:18AM +0100, Daniel Kiper wrote: > Sorry for delay. > > On Thu, Feb 01, 2018 at 06:18:48PM +, Leif Lindholm wrote: > > So, sorry I dropped the ball on this last year. > > > > This series contains what I would hope to be non-contentious > > cleanup in preparation

Re: [PATCH] libgcrypt: Import replacement CRC operations

2018-02-23 Thread Daniel Kiper
On Tue, Feb 20, 2018 at 06:20:17PM +0100, Daniel Kiper wrote: > On Sun, Feb 11, 2018 at 12:18:12AM +, Colin Watson wrote: > > The CRC implementation imported from libgcrypt 1.5.3 is arguably > > non-free, due to being encumbered by the restrictive Internet Society > > licence on RFCs (see e.g.

Re: [PATCH] ieee1275: add nvme support within ofpath

2018-02-23 Thread John Paul Adrian Glaubitz
On 02/23/2018 11:02 PM, Daniel Kiper wrote: > Applied! Woohooo \o/. Debian on sparc64 with a working GRUB is getting closer :-). > FYI, this is last time when I sent commit confirmation. > If I send one in the future then this will be rather > exception than rule. So, if you receive my

Re: [PATCH v2] chainloader: Fix wrong break condition (must be AND not, OR)

2018-02-23 Thread Daniel Kiper
On Tue, Feb 20, 2018 at 06:01:19PM +0100, Daniel Kiper wrote: > On Mon, Feb 19, 2018 at 03:26:35PM +0100, C. Masloch wrote: > > The definition of bpb's num_total_sectors_16 and num_total_sectors_32 > > is that either the 16-bit field is non-zero and is used (in which case > > eg mkfs.fat sets the

Re: [PATCH] x86-64: Treat R_X86_64_PLT32 as R_X86_64_PC32

2018-02-23 Thread Daniel Kiper
On Tue, Feb 20, 2018 at 06:16:03PM +0100, Daniel Kiper wrote: > On Sat, Feb 17, 2018 at 06:47:28AM -0800, H.J. Lu wrote: > > Starting from binutils commit bd7ab16b4537788ad53521c45469a1bdae84ad4a: > > > >

Re: [PATCH] ieee1275: add nvme support within ofpath

2018-02-23 Thread Daniel Kiper
On Tue, Feb 20, 2018 at 09:01:05PM +0100, Daniel Kiper wrote: > On Tue, Feb 20, 2018 at 09:57:14AM -0800, Eric Snowberg wrote: > > Add NVMe support within ofpath. > > > > The Open Firmware text representation for a NVMe device contains the > > Namespace ID. An invalid namespace ID is one whose

Re: [PATCH v3 5/7] mkimage: refactor a bunch of section data into a struct.

2018-02-23 Thread Peter Jones
On Fri, Feb 23, 2018 at 03:51:07PM +0100, Daniel Kiper wrote: > On Wed, Feb 21, 2018 at 03:20:27PM -0500, Peter Jones wrote: > > This basically moves a bunch of the section information we pass around a > > lot into a struct, and passes a pointer to a single one of those > > instead. > > > >

Re: [PATCH v3 7/7] .mod files: Strip annobin annotations and .eh_frame, and their relocations

2018-02-23 Thread Daniel Kiper
On Fri, Feb 23, 2018 at 03:54:49PM +0100, Daniel Kiper wrote: > On Wed, Feb 21, 2018 at 03:20:29PM -0500, Peter Jones wrote: > > This way debuginfo built from the .module will still include this > > information, but the final result won't have the data we don't actually > > need in the modules,

Re: [PATCH v3 7/7] .mod files: Strip annobin annotations and .eh_frame, and their relocations

2018-02-23 Thread Daniel Kiper
On Wed, Feb 21, 2018 at 03:20:29PM -0500, Peter Jones wrote: > This way debuginfo built from the .module will still include this > information, but the final result won't have the data we don't actually > need in the modules, either on-disk, loaded at runtime, or in prebuilt > images. > >

Re: [PATCH v3 6/7] mkimage: avoid copying relocations for sections that won't be copied.

2018-02-23 Thread Daniel Kiper
On Wed, Feb 21, 2018 at 03:20:28PM -0500, Peter Jones wrote: > Some versions of gcc include a plugin called "annobin", and in some > build systems this is enabled by default. This plugin creates special > ELF note sections to track which ABI-breaking features are used by a > binary, as well as a

Re: [PATCH v3 5/7] mkimage: refactor a bunch of section data into a struct.

2018-02-23 Thread Daniel Kiper
On Wed, Feb 21, 2018 at 03:20:27PM -0500, Peter Jones wrote: > This basically moves a bunch of the section information we pass around a > lot into a struct, and passes a pointer to a single one of those > instead. > > Because it's more convenient, it also puts the section_vaddresses > calculations

Re: [PATCH v3 4/7] mkimage: make locate_sections() set up vaddresses as well.

2018-02-23 Thread Daniel Kiper
On Wed, Feb 21, 2018 at 03:20:26PM -0500, Peter Jones wrote: > This puts both kinds of address initialization at the same place, and also > lets > us iterate through the section list one time fewer. > > Signed-off-by: Peter Jones Reviewed-by: Daniel Kiper

Re: [PATCH v3 3/7] mkimage: rename a couple of things to be less confusing later.

2018-02-23 Thread Daniel Kiper
On Wed, Feb 21, 2018 at 03:20:25PM -0500, Peter Jones wrote: > This renames some things: > > - the "strtab" and "strtab_section" in relocate_symbols are changed to > "symtab" > instead, so as to be less confusing when "strtab" is moved to a struct in a > later patch. > > - The places where we

Re: [PATCH v3 2/7] mkimage: make it easier to run syntax checkers on grub-mkimagexx.c

2018-02-23 Thread Daniel Kiper
On Wed, Feb 21, 2018 at 03:20:24PM -0500, Peter Jones wrote: > This makes it so you can treat grub-mkimagexx.c as a file you can build > directly, so syntax checkers like vim's "syntastic" plugin, which uses > "gcc -x c -fsyntax-only" to build it, will work. > > One still has to do whatever setup

Re: [PATCH v3 1/7] aout.h: Fix missing include.

2018-02-23 Thread Daniel Kiper
On Wed, Feb 21, 2018 at 03:20:23PM -0500, Peter Jones wrote: > grub_aout_load() has a grub_file_t parameter, and depending on what order > includes land in, it's sometimes not defined. This patch explicitly adds > file.h to aout.h so that it will always be defined. > > Signed-off-by: Peter Jones