[PATCH] diskboot: trivial correction on stale comments

2018-04-10 Thread Cao jin
diskboot.img now is loaded at 0x8000 and is jumped to with 0:0x8000. Signed-off-by: Cao jin --- grub-core/boot/i386/pc/diskboot.S | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/grub-core/boot/i386/pc/diskboot.S

Re: stale comment in diskboot.S ?

2018-04-10 Thread Cao jin
Hi Daniel, On 04/11/2018 04:25 AM, Daniel Kiper wrote: > On Wed, Mar 28, 2018 at 04:09:00PM +0800, Cao jin wrote: >> Hi, >> >> I was reading the code, and I want to confirm is following comment is stale? >> >> /* >> * _start is loaded at 0x2000 and is jumped to with >> * CS:IP

Re: [GRUB PARTUUID PATCH V9 0/5] Add PARTUUID detection support

2018-04-10 Thread Nick Vinson
On 04/10/2018 01:56 PM, Daniel Kiper wrote: > On Sat, Apr 07, 2018 at 04:28:09PM -0700, Nicholas Vinson wrote: >> Changes from Patch v8: >> - Renamed GRUB_ENABLE_LINUX_PARTUUID to GRUB_DISABLE_LINUX_PARTUUID >> - Updated the 10_linux logic so GRUB_ENABLE_LINUX_PARTUUID and >>

Re: [GRUB PARTUUID PATCH V9 4/5] Update grub script template files

2018-04-10 Thread Nick Vinson
On 04/10/2018 01:52 PM, Daniel Kiper wrote: > On Sat, Apr 07, 2018 at 04:28:13PM -0700, Nicholas Vinson wrote: >> Update grub-mkconfig.in and 10_linux.in to support grub-probe's new >> partuuid target. Update grub.texi documentation. The following table >> shows how GRUB_DISABLE_LINUX_UUID,

Re: Checksummed environments

2018-04-10 Thread Daniel Kiper
On Fri, Apr 06, 2018 at 03:08:23PM +0200, Kristian Amlie wrote: > On 06/04/18 14:35, Daniel Kiper wrote: > > On Fri, Apr 06, 2018 at 11:25:22AM +0200, Kristian Amlie wrote: > >> Hey, I work for Northern.tech, developing update software for embedded > >> Linux devices. > >> > >> I have a question

Re: [GRUB PARTUUID PATCH V9 0/5] Add PARTUUID detection support

2018-04-10 Thread Daniel Kiper
On Sat, Apr 07, 2018 at 04:28:09PM -0700, Nicholas Vinson wrote: > Changes from Patch v8: > - Renamed GRUB_ENABLE_LINUX_PARTUUID to GRUB_DISABLE_LINUX_PARTUUID > - Updated the 10_linux logic so GRUB_ENABLE_LINUX_PARTUUID and > GRUB_ENABLE_LINUX_UUID would behave more independently.

Re: [GRUB PARTUUID PATCH V9 4/5] Update grub script template files

2018-04-10 Thread Daniel Kiper
On Sat, Apr 07, 2018 at 04:28:13PM -0700, Nicholas Vinson wrote: > Update grub-mkconfig.in and 10_linux.in to support grub-probe's new > partuuid target. Update grub.texi documentation. The following table > shows how GRUB_DISABLE_LINUX_UUID, GRUB_DISABLE_LINUX_PARTUUID, and > initramfs

Re: stale comment in diskboot.S ?

2018-04-10 Thread Daniel Kiper
On Wed, Mar 28, 2018 at 04:09:00PM +0800, Cao jin wrote: > Hi, > > I was reading the code, and I want to confirm is following comment is stale? > > /* >* _start is loaded at 0x2000 and is jumped to with >* CS:IP 0:0x2000 in kernel. >*/ > > As I understand, it is