Re: [PATCH v3 2/2] fat: Support file modification times

2020-03-09 Thread David Michael
On Mon, Mar 9, 2020 at 7:33 AM Daniel Kiper wrote: > On Sat, Mar 07, 2020 at 12:59:52AM -0500, David Michael wrote: > > This allows comparing file ages on EFI system partitions. > > > > Signed-off-by: David Michael > > Reviewed-by: Daniel Kiper > > ...except... > > > --- > > > > Changes since

Re: [PATCH 1/2] build: Fix option to explicitly disable memory debugging

2020-03-09 Thread Daniel Kiper
On Mon, Mar 09, 2020 at 01:22:34PM +0100, Patrick Steinhardt wrote: > On Mon, Mar 09, 2020 at 12:18:41PM +0100, Paul Menzel wrote: > > Dear Patrick, > > > > On 2020-03-07 17:29, Patrick Steinhardt wrote: > > > The memory management system supports a debug mode that can be enabled > > > at build

Re: [PATCH 1/2] build: Fix option to explicitly disable memory debugging

2020-03-09 Thread Patrick Steinhardt
On Mon, Mar 09, 2020 at 12:18:41PM +0100, Paul Menzel wrote: > Dear Patrick, > > > On 2020-03-07 17:29, Patrick Steinhardt wrote: > > The memory management system supports a debug mode that can be enabled > > at build time by passing "--enable-mm-debug" to the configure script. > > Passing the

Re: [PATCH 2/2] gnulib: Fix build of base64 when compiling with memory debugging

2020-03-09 Thread Daniel Kiper
On Mon, Mar 09, 2020 at 01:01:51PM +0100, Patrick Steinhardt wrote: > On Mon, Mar 09, 2020 at 12:19:15PM +0100, Daniel Kiper wrote: > > On Sat, Mar 07, 2020 at 05:29:09PM +0100, Patrick Steinhardt wrote: > > > When building GRUB with memory management debugging enabled, then the > > > build fails

Re: [PATCH 2/2] gnulib: Fix build of base64 when compiling with memory debugging

2020-03-09 Thread Patrick Steinhardt
On Mon, Mar 09, 2020 at 12:19:15PM +0100, Daniel Kiper wrote: > On Sat, Mar 07, 2020 at 05:29:09PM +0100, Patrick Steinhardt wrote: > > When building GRUB with memory management debugging enabled, then the > > build fails because of `grub_debug_malloc()` and `grub_debug_free()` > > being undefined

Re: [PATCH v3 2/2] fat: Support file modification times

2020-03-09 Thread Daniel Kiper
On Sat, Mar 07, 2020 at 12:59:52AM -0500, David Michael wrote: > This allows comparing file ages on EFI system partitions. > > Signed-off-by: David Michael Reviewed-by: Daniel Kiper ...except... > --- > > Changes since v2: > * Added comments referencing the specs > * Set errno when the

Re: [PATCH v3 1/2] exfat: Save the matching directory entry struct when searching

2020-03-09 Thread Daniel Kiper
On Sat, Mar 07, 2020 at 12:59:31AM -0500, David Michael wrote: > This provides the node's attributes outside the iterator function > so the file modification time can be accessed and reported. > > Signed-off-by: David Michael Reviewed-by: Daniel Kiper Daniel

Re: [PATCH v2 08/12] kern: Make grub_error() more verbose

2020-03-09 Thread Daniel Kiper
On Fri, Mar 06, 2020 at 02:37:43PM +0100, Vladimir 'phcoder' Serbinenko wrote: > Le ven. 6 mars 2020 à 13:43, Daniel Kiper a écrit : > > > Re-adding grub-devel@gnu.org... > > > > On Fri, Mar 06, 2020 at 12:44:05PM +0100, Vladimir 'phcoder' Serbinenko > > wrote: > > > Le ven. 6 mars 2020 à 12:42,

Re: [PATCH 1/2] build: Fix option to explicitly disable memory debugging

2020-03-09 Thread Paul Menzel
Dear Patrick, On 2020-03-07 17:29, Patrick Steinhardt wrote: > The memory management system supports a debug mode that can be enabled > at build time by passing "--enable-mm-debug" to the configure script. > Passing the option will cause us define MM_DEBUG as expected, but in > fact the reverse

Re: [PATCH 2/2] gnulib: Fix build of base64 when compiling with memory debugging

2020-03-09 Thread Daniel Kiper
On Sat, Mar 07, 2020 at 05:29:09PM +0100, Patrick Steinhardt wrote: > When building GRUB with memory management debugging enabled, then the > build fails because of `grub_debug_malloc()` and `grub_debug_free()` > being undefined in the luks2 module. The cause is that we patch > "base64.h" to

Re: [PATCH 1/2] build: Fix option to explicitly disable memory debugging

2020-03-09 Thread Daniel Kiper
On Sat, Mar 07, 2020 at 05:29:08PM +0100, Patrick Steinhardt wrote: > The memory management system supports a debug mode that can be enabled > at build time by passing "--enable-mm-debug" to the configure script. > Passing the option will cause us define MM_DEBUG as expected, but in > fact the