Re: [PATCH] v6 for detached headers and key files

On Wed, 19 Aug 2020 17:09:08 +0200 Denis 'GNUtoo' Carikli wrote: > Hi, > > Here's a new version of this patchset. > > The only change with the v5 is that I fixed the issue that Glenn > Washburn found (in the 4/6 patch, one of the grub_file_seek return > code wasn't properly checked). Thanks

Re: GRUB build failure

On Wed, 19 Aug 2020 10:30:34 + Naveen Chaudhary wrote: > Hi, > > I figured out that I should add "--disable-werror" to the configure. > > After this I was able to build successfully. Hmm, interesting. I also compile on ubuntu (upgrade to 20.04) with no added CFLAGS and do not have this

[PATCH v6 1/6] cryptodisk: luks: unify grub_cryptodisk_dev function names

Signed-off-by: Denis 'GNUtoo' Carikli Reviewed-by: Patrick Steinhardt --- ChangeLog since v4: - Added Reviewed-by tag ChangeLog since v5: - No changes --- grub-core/disk/luks.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/grub-core/disk/luks.c b/grub-core/disk/luks.c

[PATCH v6 4/6] cryptodisk: add support for LUKS1 detached headers

From: John Lane cryptsetup supports having a detached header through the --header command line argument for both LUKS1 and LUKS2. This adds support for LUKS1 detached headers. Signed-off-by: John Lane gnu...@cyberdimension.org: rebase, small fixes, commit message Signed-off-by: Denis 'GNUtoo'

[PATCH] v6 for detached headers and key files

Hi, Here's a new version of this patchset. The only change with the v5 is that I fixed the issue that Glenn Washburn found (in the 4/6 patch, one of the grub_file_seek return code wasn't properly checked). Thanks for finding the issue. I also took some time to send it again because I tried to

[PATCH v6 5/6] cryptodisk: enable the backends to implement key files

From: John Lane Signed-off-by: John Lane gnu...@cyberdimension.org: rebase, patch split, small fixes, commit message Signed-off-by: Denis 'GNUtoo' Carikli Reviewed-by: Patrick Steinhardt --- Changelog since v3: --- - Fixed the size formating with PRIuGRUB_SIZE - Added

[PATCH v6 6/6] cryptodisk: Add support for LUKS1 key files

cryptsetup supports key files thourh the --key-file --header command line argument for both LUKS1 and LUKS2. This adds support for LUKS1 key files. Signed-off-by: John Lane gnu...@cyberdimension.org: rebase, fixes, commit message Signed-off-by: Denis 'GNUtoo' Carikli Reviewed-by: Patrick

[PATCH v6 2/6] cryptodisk: geli: unify grub_cryptodisk_dev function names

Signed-off-by: Denis 'GNUtoo' Carikli Reviewed-by: Patrick Steinhardt --- ChangeLog since v4: - Added Reviewed-by tag ChangeLog since v5: - No changes --- grub-core/disk/geli.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/grub-core/disk/geli.c

[PATCH v6 3/6] cryptodisk: enable the backends to implement detached headers

From: John Lane Signed-off-by: John Lane gnu...@cyberdimension.org: rebase, patch split, small fixes, commit message Signed-off-by: Denis 'GNUtoo' Carikli Reviewed-by: Patrick Steinhardt --- ChangeLog since v4: - Added Reviewed-by tag ChangeLog since v5: - No changes ---

Re: GRUB build failure

Hi, I figured out that I should add "--disable-werror" to the configure. After this I was able to build successfully. Thanks, Naveen From: Naveen Chaudhary Sent: Wednesday, August 19, 2020 3:54 PM To: bug-g...@gnu.org ; grub-devel@gnu.org Subject: GRUB build

GRUB build failure

Hi, Host : Ubuntu 18.04.3 LTS GCC : gcc (Ubuntu 7.3.0-16ubuntu3) 7.3.0 uname : Linux vm 5.0.0-27-generic #28~18.04.1-Ubuntu SMP Thu Aug 22 03:00:32 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux I have clone the GRUB2 from https://github.com/rhboot/grub2 today and the HEAD points to