Re: [PATCH v2 0/2] cryptodisk: Allows UUIDs to be compared in a dash-insensitive manner

2021-03-23 Thread Mihai Moldovan
* On 3/24/21 5:24 AM, Glenn Washburn wrote: > Aside from the fact that this doesn't handle negative values of n, this > would be fine. Neither do the original version or grub_strncasecmp()... and if you *can* get n to be negative, I'd be highly impressed! Jokes aside, it's unsigned, so there's

Re: [PATCH v2] i386-pc: build verifiers API as module

2021-03-23 Thread Michael Chang via Grub-devel
On Tue, Mar 23, 2021 at 05:33:12PM +0100, Daniel Kiper wrote: > On Mon, Mar 22, 2021 at 08:45:27PM +, Colin Watson wrote: [snip] > > rounds of security megapatches we've also seen that the amount of > > divergence between upstream and various distributions in > > security-critical code is in

Re: [PATCH v2 0/2] cryptodisk: Allows UUIDs to be compared in a dash-insensitive manner

2021-03-23 Thread Glenn Washburn
On Mon, 22 Mar 2021 23:53:16 +0100 Mihai Moldovan wrote: > * On 3/21/21 9:06 PM, Glenn Washburn wrote: > > I have another version of grub_uuidcasecmp which is more efficient > > by not copying the UUID bytes to another buffer to strip out the > > dashes. [...] > > At first, I didn't understand

Re: [PATCH 0/4] Various LUKS2 improvements

2021-03-23 Thread Glenn Washburn
On Tue, 23 Mar 2021 18:43:59 +0100 Daniel Kiper wrote: > On Fri, Mar 19, 2021 at 07:14:47PM -0500, Glenn Washburn wrote: > > Patch #1: Allows GRUB to be more resilient in the fact or > > unexpected json data, thus allowing access to LUKS2 volumes in > > cases where currently it would be

Re: [PATCH v2] i386-pc: build verifiers API as module

2021-03-23 Thread Michael Chang via Grub-devel
On Tue, Mar 23, 2021 at 05:48:01PM +0100, Daniel Kiper wrote: > On Tue, Mar 23, 2021 at 12:16:21PM +0800, Michael Chang via Grub-devel wrote: > > On Mon, Mar 22, 2021 at 04:20:00PM +0100, Daniel Kiper wrote: > > > On Thu, Mar 18, 2021 at 07:30:26PM +0800, Michael Chang via Grub-devel > > > wrote:

Re: [PATCH 0/5] serial: Add MMIO & SPCR support for AWS EC2 metal instances

2021-03-23 Thread Benjamin Herrenschmidt
On Tue, 2021-03-23 at 19:04 +0100, Daniel Kiper wrote: > Hi Benjamin, > > On Fri, Mar 19, 2021 at 09:07:23AM +1100, Benjamin Herrenschmidt wrote: > > (Apologies if that got sent twice, there was an issue with my setup > > yesterday causing it to be sent with the wrong From: line) > > > > This

Re: [SECURITY PATCH 108/117] util/mkimage: Refactor section setup to use a helper

2021-03-23 Thread John Paul Adrian Glaubitz
Hi Daniel! On 3/23/21 8:35 PM, Daniel Kiper wrote: >> Any chance someone could have a look at this? As explained in the follow-up >> mails, >> the problem is that the pointer pointing to the modules location in the core >> image >> deviate from the actual modules location as the former was

Re: [PATCH 0/4] Various LUKS2 improvements

2021-03-23 Thread Daniel Kiper
On Tue, Mar 23, 2021 at 06:43:59PM +0100, Daniel Kiper wrote: > On Fri, Mar 19, 2021 at 07:14:47PM -0500, Glenn Washburn wrote: > > Patch #1: Allows GRUB to be more resilient in the fact or unexpected json > > data, thus allowing access to LUKS2 volumes in cases where currently it > > would be

Re: [SECURITY PATCH 108/117] util/mkimage: Refactor section setup to use a helper

2021-03-23 Thread Daniel Kiper
Hi Adrian, On Tue, Mar 23, 2021 at 08:16:43PM +0100, John Paul Adrian Glaubitz wrote: > Hello! > > On 3/18/21 9:38 AM, John Paul Adrian Glaubitz wrote: > > On 3/2/21 7:01 PM, Daniel Kiper wrote: > >> From: Peter Jones > >> > >> Add a init_pe_section() helper function to setup PE sections. This

Re: [SECURITY PATCH 108/117] util/mkimage: Refactor section setup to use a helper

2021-03-23 Thread John Paul Adrian Glaubitz
Hello! On 3/18/21 9:38 AM, John Paul Adrian Glaubitz wrote: > On 3/2/21 7:01 PM, Daniel Kiper wrote: >> From: Peter Jones >> >> Add a init_pe_section() helper function to setup PE sections. This makes >> the code simpler and easier to read. >> >> Signed-off-by: Peter Jones >> Signed-off-by:

Re: [PATCH 0/2] Enable bigtime feature for xfs driver

2021-03-23 Thread Daniel Kiper
Hey Carlos, On Tue, Mar 23, 2021 at 02:29:57PM +0100, Carlos Maiolino wrote: > Hello. > First, my apologies if I messed up with code styling here somehow, it's the > first time I send a patch to grub. > > This series enable grub's xfs driver to recognize new xfs's feature bigtime, > which aims to

Re: [PATCH 0/5] serial: Add MMIO & SPCR support for AWS EC2 metal instances

2021-03-23 Thread Daniel Kiper
Hi Benjamin, On Fri, Mar 19, 2021 at 09:07:23AM +1100, Benjamin Herrenschmidt wrote: > (Apologies if that got sent twice, there was an issue with my setup > yesterday causing it to be sent with the wrong From: line) > > This series adds support for the serial console of AWS EC2 "metal" x86 >

Re: [PATCH] kern/dl: Disable grub_dl_unload_unneeded

2021-03-23 Thread Daniel Kiper
On Sat, Mar 20, 2021 at 01:22:44AM +, Colin Watson wrote: > grub_dl_unload_unneeded has been unused by default since de04eecfa9 put > its only call within an "#if 0", so there's no point in it sitting > around taking up space in the core image. Turn the "#if 0" into "#ifdef >

Re: [PATCH v2] i386-pc: build verifiers API as module

2021-03-23 Thread Lennart Sorensen
On Tue, Mar 23, 2021 at 05:33:12PM +0100, Daniel Kiper wrote: > How long are you going to support such systems? 1, 5 or 10 years? This > approach makes GRUB upstream as a hostage of small MBR gaps users. > Anyway, I think we have to make users aware that small MBR gaps are not > supported any

Re: [PATCH 0/4] Various LUKS2 improvements

2021-03-23 Thread Daniel Kiper
On Fri, Mar 19, 2021 at 07:14:47PM -0500, Glenn Washburn wrote: > Patch #1: Allows GRUB to be more resilient in the fact or unexpected json > data, thus allowing access to LUKS2 volumes in cases where currently it > would be inaccessible > Patch #2-3: Add some text to go along with the error

Re: [PATCH] usb: Use GRUB_USB_MAX_CONF macro instead of literal in hub for maximum configs

2021-03-23 Thread Daniel Kiper
On Thu, Mar 18, 2021 at 08:35:46PM -0500, Glenn Washburn wrote: > Signed-off-by: Glenn Washburn Reviewed-by: Daniel Kiper Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] buffer: Sync up out-of-range error message

2021-03-23 Thread Daniel Kiper
On Fri, Mar 19, 2021 at 11:54:38PM +, Colin Watson wrote: > The messages associated with other similar GRUB_ERR_OUT_OF_RANGE errors > were lacking the trailing full stop. Syncing up the strings saves a > small amount of precious core image space on i386-pc. > > DOWN:

Re: [PATCH v2] i386-pc: build verifiers API as module

2021-03-23 Thread Daniel Kiper
On Tue, Mar 23, 2021 at 01:27:15PM +, Colin Watson wrote: > On Tue, Mar 23, 2021 at 12:37:20PM +0100, Javier Martinez Canillas wrote: > > On 3/23/21 5:16 AM, Michael Chang wrote > > > Afterall, keeping existing running system to survive update (NOT new > > > install) is really an important

Re: [PATCH v2] i386-pc: build verifiers API as module

2021-03-23 Thread Daniel Kiper
On Tue, Mar 23, 2021 at 12:16:21PM +0800, Michael Chang via Grub-devel wrote: > On Mon, Mar 22, 2021 at 04:20:00PM +0100, Daniel Kiper wrote: > > On Thu, Mar 18, 2021 at 07:30:26PM +0800, Michael Chang via Grub-devel > > wrote: > > [snip] > > > NAK for this patch and others "fixing" small MBR

Re: [PATCH v2] i386-pc: build verifiers API as module

2021-03-23 Thread Daniel Kiper
On Mon, Mar 22, 2021 at 08:45:27PM +, Colin Watson wrote: > On Mon, Mar 22, 2021 at 03:19:06PM -0500, Glenn Washburn wrote: > > On Mon, 22 Mar 2021 16:16:26 + > > Colin Watson wrote: > > > On Mon, Mar 22, 2021 at 04:20:00PM +0100, Daniel Kiper wrote: > > > > NAK for this patch and others

Re: GRUB 2.06~rc1 released

2021-03-23 Thread Daniel Kiper
Hey, On Mon, Mar 22, 2021 at 04:31:19PM +0100, Miguel Ángel Arruga Vivas wrote: > Hi, > > Daniel Kiper writes: > > > Translators can use http://alpha.gnu.org/pub/gnu/grub/grub-2.06~rc1.pot for > > translation. > > The pot signature is available at > >

Re: [PATCH v2] i386-pc: build verifiers API as module

2021-03-23 Thread Javier Martinez Canillas
On 3/23/21 2:27 PM, Colin Watson wrote: > On Tue, Mar 23, 2021 at 12:37:20PM +0100, Javier Martinez Canillas wrote: [snip] >> >> For this particular case, it might be better for distros to just revert >> commit >> 9e95f45ceee ("verifiers: Move verifiers API to kernel image") instead of >>

[PATCH 0/2] Enable bigtime feature for xfs driver

2021-03-23 Thread Carlos Maiolino
Hello. First, my apologies if I messed up with code styling here somehow, it's the first time I send a patch to grub. This series enable grub's xfs driver to recognize new xfs's feature bigtime, which aims to fix the y2038 timestamps problems. The first patch in the series is the xfs driver

[PATCH 2/2] Use 64bit type for filesystem timestamp

2021-03-23 Thread Carlos Maiolino
Some filesystems nowadays uses 64bit timestamps for timestamps, so, update grub_dirhook_info struct to use an int64 type to store mtime. This also updates grub_unixtime2datetime() to receive a 64-bit timestamp argument and do 64bit-safe divisions. Both changes enables grub to support dates beyond

[PATCH 1/2] Add bigtime support for xfs driver

2021-03-23 Thread Carlos Maiolino
XFS filesystem now supports bigtime feature, to overcome y2038 problem. This patch makes grub able to support xfs filesystems with this feature enabled. xfs counter for bigtime enable timestamps starts on 0, which translates to INT32_MIN (Dec 31 20:45:52 UTC 1901) in the legacy timestamps. The

Re: [PATCH v2] i386-pc: build verifiers API as module

2021-03-23 Thread Colin Watson
On Tue, Mar 23, 2021 at 12:37:20PM +0100, Javier Martinez Canillas wrote: > On 3/23/21 5:16 AM, Michael Chang wrote > > Afterall, keeping existing running system to survive update (NOT new > > install) is really an important thing as many can't afford that to > > happen. If we can make it any

Re: [PATCH v2] i386-pc: build verifiers API as module

2021-03-23 Thread Javier Martinez Canillas
On 3/23/21 5:16 AM, Michael Chang wrote [snip] > > Afterall, keeping existing running system to survive update (NOT new > install) is really an important thing as many can't afford that to > happen. If we can make it any better to reduce the cost please consider > to do it. It doesn't conflict