Re: [PATCH 04/19] mm: assert that we preserve header vs region alignment

2021-10-20 Thread Daniel Kiper
On Tue, Oct 12, 2021 at 06:29:53PM +1100, Daniel Axtens wrote: > grub_mm_region_init() does: > > h = (grub_mm_header_t) (r + 1); > > where h is a grub_mm_header_t and r is a grub_mm_region_t. > > Cells are supposed to be GRUB_MM_ALIGN aligned, but while grub_mm_dump > ensures this vs the region

Re: [PATCH 02/19] grub-shell: pseries: don't pass fw_opt to qemu

2021-10-20 Thread Daniel Kiper
On Tue, Oct 12, 2021 at 01:57:43PM -0500, Glenn Washburn wrote: > On Tue, 12 Oct 2021 18:29:51 +1100 > Daniel Axtens wrote: > > > At some point this started to break the test - qemu just rejects the > > command line. Just don't pass it in, it's seabios specific. > > > > Signed-off-by: Daniel

Re: [PATCH 01/19] grub-shell: Boot PowerPC using PMU instead of CUDA for power management

2021-10-20 Thread Daniel Kiper
On Tue, Oct 12, 2021 at 12:11:30PM -0500, Glenn Washburn wrote: > On Tue, 12 Oct 2021 18:29:50 +1100 > Daniel Axtens wrote: > > > From: Glenn Washburn > > > > A recent refactoring of CUDA command code has exposed a bug in OpenBIOS[1] > > which was causing system powerdown and system reset to

[PATCH v2] Print module name on license check failure

2021-10-20 Thread Robbie Harwood
Before performing the license check, resolve the module name so that it can be printed if the license check fails. Prior to this change, grub would only indicate that the check had been failed, but not by what module. This made it difficult to track down either the problem module, or debug the

Re: [DEBUG 2/2] misc: Add debug log condition to log output

2021-10-20 Thread Daniel Kiper
On Tue, Oct 19, 2021 at 01:47:03AM -0500, Glenn Washburn wrote: > Adding the conditional to debug log messages allows the grub user to > construct the $debug variable without needing to consult the source to > find the conditional (especially useful for situations where the source > is not readily

Re: [PATCH] Print module name on license check failure

2021-10-20 Thread Daniel Kiper
On Thu, Oct 14, 2021 at 02:26:35PM -0400, Robbie Harwood wrote: > At the very least, this will make it easier to track down the problem > module - or, if something else has gone wrong, provide more information > for debugging. > > Signed-off-by: Robbie Harwood > --- > grub-core/kern/dl.c | 10

Re: [PATCH 2/2] Make a "gdb" dprintf that tells us load addresses.

2021-10-20 Thread Thomas Schmitt
Hi, Robbie Harwood wrote: > dl.c:694: > add-symbol-file ... > dl.c:694: > add-symbol-file ... > dl.c:694: > add-symbol-file ... > > You can't easily copy-paste that into gdb. It needs to be processed to > remove the file:line stuff. How about hiding the "dl.c" lines