Two small suggestions inlined in the quoted part.
Regards,
ecm
On at 2020-03-05 15:38 +0100, Daniel Kiper wrote:
> On Thu, Mar 05, 2020 at 06:40:01PM +0800, Michael Chang wrote:
>> Further to the discussion about disabling btrfs zstd support for
>> i386-pc[1], this paragraph in manual about mbr
tor16.S?id=495781f5ed1b48bf27f16c53940d6700c181c74c#n97
[4]: https://ulukai.org/ecm/lDebug-5479a7988d21-nohelp.zip
Signed-off-by: C. Masloch
---
grub-core/lib/i386/relocator16.S | 26 +++---
1 file changed, 19 insertions(+), 7 deletions(-)
diff --git a/grub-core/lib/i386/relocator1
Hello,
Was this overlooked?
I think I should check whether dev->disk->data actually is a (struct
grub_biosdisk_data *) but I don't know how!
Regards,
ecm
On at 2018-02-01 15:51 +01:00, C. Masloch wrote:
>
> These fields must reflect the ROM-BIOS's geometry for CHS-bas
On at 2018-02-23 23:05 +01:00, Daniel Kiper wrote:
> Applied!
>
> FYI, this is last time when I sent commit confirmation.
> If I send one in the future then this will be rather
> exception than rule. So, if you receive my reviewed-by
> and patch is not committed in a week or two then it means
>
s the sector count if
> BPB_TotSec16 is 0 (count is greater than or equal to 0x1).
(This specifies that an unused BPB_TotSec32 field is set to zero.)
Tested with lDebug booted in qemu via grub2's
FreeDOS direct loading support, refer to
https://bitbucket.org/ecm/ldosboot + https://bitb
eros.)
>>
>>>> Tested with lDebug booted in qemu via grub2's
>>>> FreeDOS direct loading support, refer to
>>>> https://bitbucket.org/ecm/ldosboot + https://bitbucket.org/ecm/ldebug
>>>
>>> Could you put your SOB here?
>>
>> Li
support, refer to
https://bitbucket.org/ecm/ldosboot + https://bitbucket.org/ecm/ldebug
(For this test, lDebug's iniload.asm must be assembled with
-D_QUERY_GEOMETRY=0 to leave the BPB values provided by grub.)
Signed-off-by: C. Masloch <pus...@38.de>
---
grub-core/loader/i386/pc/chainloader.
On at 2018-01-29 18:09 +01:00, Daniel Kiper wrote:
> On Sun, Jan 21, 2018 at 04:02:10PM +0100, C. Masloch wrote:
>> The definition of bpb's num_total_sectors_16 and num_total_sectors_32
>> is that either the 16-bit field is non-zero and is used (in which case
>> eg mkfs.fat
The definition of bpb's num_total_sectors_16 and num_total_sectors_32
is that either the 16-bit field is non-zero and is used (in which case
eg mkfs.fat sets the 32-bit field to zero), or it is zero and the
32-bit field is used. Therefore, a BPB is invalid only if *both*
fields are zero; having
On 2012-09-09 21:49 +0200, Vladimir 'φ-coder/phcoder' Serbinenko wrote:
+ {
+grub_relocator_chunk_t ch;
+err = grub_relocator_alloc_chunk_addr (rel, ch,
GRUB_FREEDOS_BPB_ADDR,
+ GRUB_DISK_SECTOR_SIZE);
I don't understand this. Shouldn't it
Thanks for the help. The attached patch includes spaces around all
operators, doesn't include the void cast, and doesn't mention (E)DR-DOS
any longer. I recently learned that the dl register requirement is present
in prior releases of the FreeDOS kernel too, still called DOS-C. These
Hello,
A bit about me first; feel free to skip this paragraph. I know 86 assembly
language well and have been involved in FreeDOS kernel development. On the
freedos-user list I read that GRUB 2.00 added FreeDOS direct loading
support. I have reviewed GRUB's implementation of the FreeDOS
12 matches
Mail list logo
