Re: Checksummed environments

On Fri, Apr 06, 2018 at 11:25:22AM +0200, Kristian Amlie wrote: > Hey, I work for Northern.tech, developing update software for embedded > Linux devices. > > I have a question about GRUB's environment block: This block is not I am not sure what exactly you mean by "GRUB's environment block". Could

Re: Add TPM measured boot support

Hi Matthew, On Sat, Apr 07, 2018 at 01:36:28AM +0100, Matthew Garrett wrote: > On Tue, Jan 23, 2018 at 12:45:14PM +0100, Daniel Kiper wrote: > > > Sadly yes. Sorry about that. However, this is still on my radar. I hope that > > I come back to work on this in a few weeks. >

Re: stale comment in diskboot.S ?

On Wed, Mar 28, 2018 at 04:09:00PM +0800, Cao jin wrote: > Hi, > > I was reading the code, and I want to confirm is following comment is stale? > > /* >* _start is loaded at 0x2000 and is jumped to with >* CS:IP 0:0x2000 in kernel. >*/ > > As I understand, it is loaded

Re: [GRUB PARTUUID PATCH V9 4/5] Update grub script template files

On Sat, Apr 07, 2018 at 04:28:13PM -0700, Nicholas Vinson wrote: > Update grub-mkconfig.in and 10_linux.in to support grub-probe's new > partuuid target. Update grub.texi documentation. The following table > shows how GRUB_DISABLE_LINUX_UUID, GRUB_DISABLE_LINUX_PARTUUID, and > initramfs detection

Re: [GRUB PARTUUID PATCH V9 0/5] Add PARTUUID detection support

On Sat, Apr 07, 2018 at 04:28:09PM -0700, Nicholas Vinson wrote: > Changes from Patch v8: > - Renamed GRUB_ENABLE_LINUX_PARTUUID to GRUB_DISABLE_LINUX_PARTUUID > - Updated the 10_linux logic so GRUB_ENABLE_LINUX_PARTUUID and > GRUB_ENABLE_LINUX_UUID would behave more independently.

Re: Checksummed environments

On Fri, Apr 06, 2018 at 03:08:23PM +0200, Kristian Amlie wrote: > On 06/04/18 14:35, Daniel Kiper wrote: > > On Fri, Apr 06, 2018 at 11:25:22AM +0200, Kristian Amlie wrote: > >> Hey, I work for Northern.tech, developing update software for embedded > >> Linux devices.

Re: [PATCH] diskboot: trivial correction on stale comments

On Wed, Apr 11, 2018 at 11:23:10AM +0800, Cao jin wrote: > diskboot.img now is loaded at 0x8000 and is jumped to with 0:0x8000. > > Signed-off-by: Cao jin Reviewed-by: Daniel Kiper Thanks a lot! I will apply this patch together with other patches in a week or so

Re: [GRUB PARTUUID PATCH V9 4/5] Update grub script template files

On Tue, Apr 10, 2018 at 08:00:04PM -0700, Nick Vinson wrote: > On 04/10/2018 01:52 PM, Daniel Kiper wrote: > > On Sat, Apr 07, 2018 at 04:28:13PM -0700, Nicholas Vinson wrote: > >> Update grub-mkconfig.in and 10_linux.in to support grub-probe's new > >> pa

Re: [PATCH] ieee1275: obdisk driver

On Thu, Apr 05, 2018 at 10:53:55AM -0700, Eric Snowberg wrote: > Add a new disk driver called obdisk for IEEE1275 platforms. Currently > the only platform using this disk driver is SPARC, however other IEEE1275 > platforms could start using it if they so choose. While the functionality > within t

Re: Checksummed environments

On Tue, Apr 10, 2018 at 11:09:33PM +0200, Daniel Kiper wrote: > On Fri, Apr 06, 2018 at 03:08:23PM +0200, Kristian Amlie wrote: > > On 06/04/18 14:35, Daniel Kiper wrote: > > > On Fri, Apr 06, 2018 at 11:25:22AM +0200, Kristian Amlie wrote: > > >> Hey, I work for No

Re: Checksummed environments

On Thu, Apr 12, 2018 at 10:35:06AM +0200, Kristian Amlie wrote: > On 12/04/18 10:33, Daniel Kiper wrote: > > On Tue, Apr 10, 2018 at 11:09:33PM +0200, Daniel Kiper wrote: > >> On Fri, Apr 06, 2018 at 03:08:23PM +0200, Kristian Amlie wrote: > >>> On 06/04/18 14:35, Dan

Re: [GRUB PARTUUID PATCH V9 4/5] Update grub script template files

On Wed, Apr 11, 2018 at 07:45:01AM -0700, Nick Vinson wrote: > On 04/11/2018 01:31 AM, Daniel Kiper wrote: > > On Tue, Apr 10, 2018 at 08:00:04PM -0700, Nick Vinson wrote: > >> On 04/10/2018 01:52 PM, Daniel Kiper wrote: > >>> On Sat, Apr 07, 2018 at 04:28:13P

Re: [GRUB PARTUUID PATCH V10 4/4] Update grub script template files

On Mon, Apr 16, 2018 at 10:36:26PM -0700, Nicholas Vinson wrote: > Update grub-mkconfig.in and 10_linux.in to support grub-probe's new > partuuid target. Update grub.texi documentation. The following table > shows how GRUB_DISABLE_LINUX_UUID, GRUB_DISABLE_LINUX_PARTUUID, and > initramfs detection

Re: [PATCH] pass kernel command line as verbatim

On Wed, Apr 11, 2018 at 05:17:03PM +0800, Michael Chang wrote: > And this bug report seems relevant .. > > https://savannah.gnu.org/bugs/?49937 > > On Wed, Apr 11, 2018 at 04:58:54PM +0800, Michael Chang wrote: > > The command line has been processed by grub shell, then the result is > > expected

Re: [PATCH] bufio: fix the next_buf calculation

CC-ing Vladimir. On Mon, Apr 16, 2018 at 06:05:04PM +0800, Michael Chang wrote: > The next_buf is the offset to the next cached block rounded to the size of > bufio->block_size. However the calculation needs the block_size to be in power > of 2 is not always valid. As an example, files with smalle

Re: [GRUB PARTUUID PATCH V10 4/4] Update grub script template files

On Tue, Apr 17, 2018 at 08:20:45AM -0700, Nick Vinson wrote: > On 04/17/2018 06:36 AM, Daniel Kiper wrote: > > On Mon, Apr 16, 2018 at 10:36:26PM -0700, Nicholas Vinson wrote: > >> Update grub-mkconfig.in and 10_linux.in to support grub-probe's new > >> pa

Re: [PATCH v3] grub-install: locale depends on nls

On Fri, Apr 13, 2018 at 11:36:49PM +0200, Olaf Hering wrote: > With --disable-nls no locales exist. > > Avoid runtime error by moving code that copies locales into its own > function. Return early in case nls was disabled. That way the compiler > will throw away unreachable code, no need to put pre

Re: [PATCH RFC] Proposition of a --auto-nvram option for grub-install

On Thu, Apr 12, 2018 at 07:09:58PM +0200, Lukasz Zemczak wrote: > Hello everyone, > > I'm writing to this list since I would like to get some feedback on an > additional option to the grub-install tool we would find very > convenient to have. The diff is attached to the e-mail (also available > as

Re: Multiboot ELF segment handling patch

Hi Alexander, On Sat, Apr 14, 2018 at 12:07:29AM +0200, Alexander Boettcher wrote: > Hello, > > On 06.04.2018 14:28, Daniel Kiper wrote: > > On Thu, Mar 29, 2018 at 11:20:37AM +0200, Alexander Boettcher wrote: > > > >> Can you please have a look and check

Re: [PATCH] bufio: fix the next_buf calculation

On Wed, Apr 18, 2018 at 03:28:20PM +0800, Michael Chang wrote: > On Tue, Apr 17, 2018 at 07:11:34PM +0200, Daniel Kiper wrote: > > CC-ing Vladimir. > > > > On Mon, Apr 16, 2018 at 06:05:04PM +0800, Michael Chang wrote: > > > The next_buf is the offset to the next ca

Re: [RFC] Add support for BTRFS raid5/6 to GRUB

On Tue, Apr 17, 2018 at 09:57:40PM +0200, Goffredo Baroncelli wrote: > Hi All, > > Below you can find a patch to add support for accessing files from > grub in a RAID5/6 btrfs filesystem. This is a RFC because it is > missing the support for recovery (i.e. if some devices are missed). In > the next

Re: [PATCH RFC] Proposition of a --auto-nvram option for grub-install

Hey Lukasz, On Thu, Apr 19, 2018 at 11:29:28AM +0200, Lukasz Zemczak wrote: > Hey Daniel! > > Thank you for your feedback! I can drop the warning message, sure, I > added it only for verbosity anyway so there's no real reason for > keeping it around. Thanks! > As for your second comment: general

Re: [PATCH] bufio: round up block size to power of 2

On Fri, Apr 20, 2018 at 03:21:30PM +0800, Michael Chang wrote: > Rounding up the bufio->block_size to meet power of 2 to facilitate next_buf > calcuation in grub_bufio_read. > > Signed-off-by: Michael Chang > --- > grub-core/io/bufio.c | 8 > 1 file changed, 8 insertions(+) > > diff --gi

Re: [PATCH v2] bufio: round up block size to power of 2

On Tue, Apr 24, 2018 at 02:13:04PM +0800, Michael Chang wrote: > Rounding up the bufio->block_size to meet power of 2 to facilitate next_buf > calcuation in grub_bufio_read. > > Signed-off-by: Michael Chang > > v2: Next time please put "---" before "v2:" just after SOB. This way git am will not p

Re: [PATCH] pass kernel command line as verbatim

On Wed, Apr 18, 2018 at 03:07:15PM +0800, Michael Chang wrote: > On Tue, Apr 17, 2018 at 06:37:06PM +0200, Daniel Kiper wrote: > > On Wed, Apr 11, 2018 at 05:17:03PM +0800, Michael Chang wrote: > > > And this bug report seems relevant .. > > > > > >

Re: [PATCH v2] Makefile.am: Add `all_video` to `default_payload.elf`

On Mon, Apr 23, 2018 at 09:45:02PM +0200, Paul Menzel wrote: > Dear GRUB folks, > > > Am Mittwoch, den 21.03.2018, 09:28 +0100 schrieb Paul Menzel: > > From a199bc1f64e33aa942b23fe6d16670cc6002bb6c Mon Sep 17 00:00:00 2001 > > From: Paul Menzel > > Date: Sun, 16 Apr 2017 21:02:58 +0200 > > Subject

Re: Multiboot ELF segment handling patch

On Mon, Apr 23, 2018 at 08:26:34PM +0200, Alexander Boettcher wrote: > Hello, > > On 17.04.2018 21:40, Daniel Kiper wrote > >> The overriden memory may contain device memory (vga text mode e.g.), which > >> leads to strange boot behaviour. > > > > Have

Re: What is this grub_disk_read doing in the i386 linux loader?

On Thu, Apr 19, 2018 at 03:22:55PM -0700, Andrew Jeddeloh wrote: > While solving a bug in the coreos fork of grub I came across this disk > read in the i386 linux loader [1]. It looks like its reading whatever > is after the boot param header in the kernel file (defined by the > linux x86 boot prot

Re: What is this grub_disk_read doing in the i386 linux loader?

On Tue, Apr 24, 2018 at 04:08:57PM -0700, Andrew Jeddeloh wrote: > Thanks for the reply. > > I'm not sure I follow. Looking over the 32 bit boot spec, it looks > like the process is: > > 1) zero out linux_params > - grub does this > 2) copy the linux boot params (from 0x1f1) into linux params > -

Re: What is this grub_disk_read doing in the i386 linux loader?

On Wed, Apr 25, 2018 at 12:45:15PM -0700, Andrew Jeddeloh wrote: > > As Michael said, "0x0202 + byte value at offset 0x0201" is your friend. > > I think Michael's message got lost; I think he replied to just you? I > didn't receive it and I don't see it in the archives. > > > AIUI it is. Please loo

Re: grub-mkconfig does not fsync() or sync() - can result in boot failure

On Tue, Apr 24, 2018 at 08:48:05PM -0600, Chris Murphy wrote: > Hi, > > I've done a 'UB's docs then it would be perfect. -ff -o stracegrub.out > grub-mkconfig' and there is no > fsync() or sync() at all, so this does not seem crash safe for either > non-journaled or journaled file systems. > > The

Re: [PATCH] pass kernel command line as verbatim

On Thu, Apr 26, 2018 at 04:42:30PM +0800, Michael Chang wrote: > On Tue, Apr 24, 2018 at 12:03:21PM +0200, Daniel Kiper wrote: > > On Wed, Apr 18, 2018 at 03:07:15PM +0800, Michael Chang wrote: > > > On Tue, Apr 17, 2018 at 06:37:06PM +0200, Daniel Kiper wrote: > > > &

Re: [PATCH 1/7] Add support for reading a filesystem with a raid5 or raid6 profile.

On Tue, Apr 24, 2018 at 09:13:10PM +0200, Goffredo Baroncelli wrote: > Signed-off-by: Goffredo Baroncelli > --- > grub-core/fs/btrfs.c | 32 > 1 file changed, 32 insertions(+) > > diff --git a/grub-core/fs/btrfs.c b/grub-core/fs/btrfs.c > index be195448d..b0032ea4

Re: [PATCH 2/7] Add helper to check the btrfs header.

On Tue, Apr 24, 2018 at 09:13:11PM +0200, Goffredo Baroncelli wrote: > This helper was used in few places to help the debugging. As conservative > approach, in case of error it is only logged. Could you explain in the commit message why we are so conservative here? > Signed-off-by: Goffredo Baron

Re: [PATCH 3/7] Move from the find_device the error logging logic to the callee.

On Tue, Apr 24, 2018 at 09:13:12PM +0200, Goffredo Baroncelli wrote: > Signed-off-by: Goffredo Baroncelli > --- > grub-core/fs/btrfs.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/grub-core/fs/btrfs.c b/grub-core/fs/btrfs.c > index 01a1fc7a1..745bb854e 100644 > -

Re: [PATCH 4/7] Avoiding scanning for an already not found device.

On Tue, Apr 24, 2018 at 09:13:13PM +0200, Goffredo Baroncelli wrote: > If a device is missing, create the entry in data->devices_attached[] array. What kind of entry? Invalid one? Please clarify this. > This avoid un-necessary devices rescan. > > Signed-off-by: Goffredo Baroncelli Otherwise LGT

Re: [PATCH 5/7] Refactor the code of read from disk

On Tue, Apr 24, 2018 at 09:13:14PM +0200, Goffredo Baroncelli wrote: > This is a preparatory patch, to help the adding of the raid5/6 recovery code OK, but please tell us why this patch is needed? > Signed-off-by: Goffredo Baroncelli > --- > grub-core/fs/btrfs.c | 111 --

Re: [PATCH 6/7] Add support for recovery for a raid5 btrfs profiles.

On Tue, Apr 24, 2018 at 09:13:15PM +0200, Goffredo Baroncelli wrote: > Signed-off-by: Goffredo Baroncelli > --- > grub-core/fs/btrfs.c | 206 +-- > 1 file changed, 199 insertions(+), 7 deletions(-) > > diff --git a/grub-core/fs/btrfs.c b/grub-core/fs/btrfs.

Re: [PATCH V2] Add support for BTRFS raid5/6 to GRUB

On Tue, Apr 24, 2018 at 09:13:09PM +0200, Goffredo Baroncelli wrote: > > Hi All, > > the aim of this patches set is to provide support for a BTRFS raid5/6 > filesystem in GRUB. > > The first patch, implements the basic support for raid5/6. I.e this works when > all the disks > are present. > > Th

Re: [PATCH 7/7] Add raid6 recovery.

On Tue, Apr 24, 2018 at 09:13:16PM +0200, Goffredo Baroncelli wrote: > The code origins from "raid6_recovery.c". The code was changed because the > original one assumed that both the disk address and size are multiple of > GRUB_DISK_SECTOR_SIZE. This is not true for grub btrfs driver. > > The code

Re: [PATCH V2] Add support for BTRFS raid5/6 to GRUB

On Wed, May 09, 2018 at 09:36:55PM +0200, Goffredo Baroncelli wrote: > On 05/09/2018 07:00 PM, Daniel Kiper wrote: > > On Tue, Apr 24, 2018 at 09:13:09PM +0200, Goffredo Baroncelli wrote: > >> > >> Hi All, > >> > >> the aim of this patches

Re: [PATCH] loader/i386/linux: calculate the size of the setup header

On Wed, May 09, 2018 at 10:46:47AM -0700, Andrew Jeddeloh wrote: > This patch is prompted from a question I asked a while ago about why > the disk read is necessary. See the thread here [1]. > > This changes the disk read to use the length of the setup header as > calculated by the x86 32 bit linux

Re: [PATCH] Enable /dev/mapper/dm-[0-9]-* scanning

On Thu, May 10, 2018 at 04:32:46PM +0300, Oleg Solovyov wrote: > This code was modified because the original code skips any device with > basename starts with /dm-[0-9]/ > e.g. if the root device path is //dev/mapper/dm-0-luks/ it won't be > detected by grub-probe and "root=" parameter in grub.cfg

Re: Multiboot ELF segment handling patch

On Thu, Apr 26, 2018 at 11:55:22PM +0200, Alexander Boettcher wrote: > On 24.04.2018 12:42, Daniel Kiper wrote: > > On Mon, Apr 23, 2018 at 08:26:34PM +0200, Alexander Boettcher wrote: > >> On 17.04.2018 21:40, Daniel Kiper wrote > >>>> The overriden memory may con

Re: [PATCH] Enable /dev/mapper/dm-[0-9]-* scanning

#x27;t skip /dev/mapper/dm-* devices > > This patch ensures that grub-probe will find the root device placed in > /dev/mapper/dm-[0-9]+-.* > e.g. device named /dev/mapper/dm-0-luks will be found and grub.cfg will > be updated properly, enabling the system to boot. > > Signed-off-by:

Re: [PATCH 1/8] Add support for reading a filesystem with a raid5 or raid6 profile.

On Fri, May 11, 2018 at 09:24:39PM +0200, Goffredo Baroncelli wrote: > Signed-off-by: Goffredo Baroncelli > --- > grub-core/fs/btrfs.c | 61 > 1 file changed, 61 insertions(+) > > diff --git a/grub-core/fs/btrfs.c b/grub-core/fs/btrfs.c > index be19544

Re: [PATCH 2/8] Add helper to check the btrfs header.

On Fri, May 11, 2018 at 09:24:40PM +0200, Goffredo Baroncelli wrote: > This helper was used in few places to help the debugging. As conservative s/was/will be/? > approach, in case of error it is only logged. This because I was unaware s/This because I was unaware/This is because I am not sure/

Re: [PATCH 3/8] Move the error logging logic from find_device() to the callee.

On Fri, May 11, 2018 at 09:24:41PM +0200, Goffredo Baroncelli wrote: > This is a preparatory patch. The callee knows better if this > error is fatal, or if it exists another available disk. WRT the subject: s/Move the error logging logic from find_device() to the callee./ Move the error logg

Re: [PATCH 5/8] Refactor the code that read from disk

It looks that patch 4 is missing in this series. On Fri, May 11, 2018 at 09:24:43PM +0200, Goffredo Baroncelli wrote: > This is a preparatory patch, to help the adding of the raid5/6 recovery code. > In case of availability of all disks, this code is good for all the RAID > profiles. However in ca

Re: [PATCH 6/8] Add support for recovery for a raid5 btrfs profiles.

On Fri, May 11, 2018 at 09:24:44PM +0200, Goffredo Baroncelli wrote: > Signed-off-by: Goffredo Baroncelli > --- > grub-core/fs/btrfs.c | 178 +-- > 1 file changed, 173 insertions(+), 5 deletions(-) > > diff --git a/grub-core/fs/btrfs.c b/grub-core/fs/btrfs.

Re: [PATCH 5/8] Refactor the code that read from disk

On Mon, May 14, 2018 at 08:26:40PM +0200, Daniel Kiper wrote: > It looks that patch 4 is missing in this series. > > On Fri, May 11, 2018 at 09:24:43PM +0200, Goffredo Baroncelli wrote: > > This is a preparatory patch, to help the adding of the raid5/6 recovery > >

Re: [PATCH 7/8] Make more generic the code for raid6 rebuilding

On Fri, May 11, 2018 at 09:24:45PM +0200, Goffredo Baroncelli wrote: > The original grub code which handles the recovery of a raid6 disks array > assumes that all the read are multiple of 1 << GRUB_DISK_SECTOR_BITS and s/the read/reads/ > it also assumes that all the I/O is done via the struct >

Re: [PATCH 8/8] Add raid6 recovery for a btrfs filesystem.

On Fri, May 11, 2018 at 09:24:46PM +0200, Goffredo Baroncelli wrote: > Add the raid6 recovery, in order to use a raid6 filesystem even if some > disks (up to two) are missing. > This code use the old md raid6 code already present in grub. Please fix the commit message formating. > Signed-off-by:

Re: [PATCH 7/8] Make more generic the code for raid6 rebuilding

On Mon, May 14, 2018 at 08:57:10PM +0200, Daniel Kiper wrote: > On Fri, May 11, 2018 at 09:24:45PM +0200, Goffredo Baroncelli wrote: > > The original grub code which handles the recovery of a raid6 disks array > > assumes that all the read are multiple of 1 << GRUB_DISK_SECT

Re: [PATCH 7/8] Make more generic the code for raid6 rebuilding

On Mon, May 14, 2018 at 10:52:11PM +0200, Goffredo Baroncelli wrote: > On 05/14/2018 08:57 PM, Daniel Kiper wrote: > > On Fri, May 11, 2018 at 09:24:45PM +0200, Goffredo Baroncelli wrote: > [...] > > > >> + char *buf, grub_uint64

Re: xfsprogs 4.16.0 format change, GRUB error unknown filesystem

Hi, On Mon, May 14, 2018 at 01:12:27PM -0600, Chris Murphy wrote: > Hi, > > xfsprogs 4.16.0 defaults to enabling "sparse inode" which is not > compatible with GRUB. > > Downstream bug in Fedora, grub-probe fails so grub-install can't work; > and on systems with an already properly installed core.i

Re: [PATCH] mbi: use per segment a separate relocator chunk

On Mon, May 14, 2018 at 09:02:00PM +0200, Alexander Boettcher wrote: > >From 8a0296d040a42950cd64e733f7997203975bc184 Mon Sep 17 00:00:00 2001 > From: Alexander Boettcher > Date: Fri, 13 Apr 2018 23:37:01 +0200 > Subject: [PATCH] mbi: use per segment a separate relocator chunk > > if elf is non re

Re: FTDI serial console support?

On Fri, May 11, 2018 at 03:55:36PM +0200, Petter Gustad wrote: > > Is there a way to specify a FTDI based serial console using > GRUB_TERMINAL, GRUB_SERIAL_COMMAND, or some other variable? If yes, > what is the syntax? > > BTW my serial port adapter matches the vendor id and device id given > in gr

Re: [GRUB PATCH] xfs: accept filesystem with sparse inodes

On Tue, May 15, 2018 at 02:55:55PM -0500, Eric Sandeen wrote: > The sparse inode metadata format became a mkfs.xfs default in > xfsprogs-4.16.0, and such filesystems are now rejected by grub as > containing an incompatible feature. > > In essence, this feature allows xfs to allocate inodes into fra

Re: FTDI serial console support?

On Wed, May 16, 2018 at 06:21:17AM +0200, Petter Gustad wrote: > From: Daniel Kiper > Subject: Re: FTDI serial console support? > Date: Tue, 15 May 2018 22:00:06 +0200 > > > On Fri, May 11, 2018 at 03:55:36PM +0200, Petter Gustad wrote: > >> > >> Is there

Re: [PATCH] mbi: use per segment a separate relocator chunk

On Tue, May 15, 2018 at 09:18:18PM +0200, Alexander Boettcher wrote: > On 15.05.2018 21:10, Alexander Boettcher wrote: > >>I assume that a given ELF PHDR address/size does not cover VGA memory or > >>anything like that, > > > >No. > > > >>so, I am not sure what exactly overwrites this region. > >>g

Re: [PATCH] loader/i386/linux: calculate the size of the setup header

Re-added grub-devel. Next time please do not drop GRUB ML from the addresses. On Thu, May 17, 2018 at 03:40:32PM -0700, Andrew Jeddeloh wrote: > Sorry about the long delay, I agree with all the sugguestions, except > shouldn't No problem. > if (len > &linux_params.e820_map - &linux_params) > >

Re: FTDI serial console support?

On Fri, May 18, 2018 at 01:01:41PM +0200, Petter Gustad wrote: > From: Daniel Kiper > Subject: Re: FTDI serial console support? > Date: Wed, 16 May 2018 11:32:19 +0200 > > > On Wed, May 16, 2018 at 06:21:17AM +0200, Petter Gustad wrote: > >> From: Daniel Kiper &g

Re: [PATCH] Enable /dev/mapper/dm-[0-9]-* scanning

On Tue, May 29, 2018 at 04:55:10PM +0300, Oleg Solovyov wrote: > 29.05.2018 16:50, Vladimir 'phcoder' Serbinenko ??: > > > > > > On Tue, 29 May 2018, 13:58 Oleg Solovyov, > > wrote: > > > > Anybody? > > > > Why do you need this? Normally the same devices shoul

Re: [PATCH 1/9] btrfs: add support for reading a filesystem with a RAID 5 or RAID 6 profile.

On Wed, May 16, 2018 at 08:48:11PM +0200, Goffredo Baroncelli wrote: > Signed-off-by: Goffredo Baroncelli > --- > grub-core/fs/btrfs.c | 68 > 1 file changed, 68 insertions(+) > > diff --git a/grub-core/fs/btrfs.c b/grub-core/fs/btrfs.c > index be19544

Re: [PATCH 2/9] btrfs: add helper to check the btrfs header.

On Wed, May 16, 2018 at 08:48:12PM +0200, Goffredo Baroncelli wrote: > This helper will be used in few places to help the debugging. As s/in few/in a few/ > conservative approach, in case of error it is only logged. This s/This/This is/ Otherwise LGTM. Daniel _

Re: [PATCH 3/9] btrfs: move the error logging from find_device() to its callee.

On Wed, May 16, 2018 at 08:48:13PM +0200, Goffredo Baroncelli wrote: > This is a preparatory patch. The callee knows better if this s/callee/caller/ > error is fatal or not, i.e. another available disk. s/i.e. another available disk./e.g. another disk is available or not./ And I think that you

Re: [PATCH 4/9] btrfs: avoiding a rescan for a device which was already not founded.

WRT the subject: s/btrfs: avoiding a rescan for a device which was already not founded./ btrfs: Avoid a rescan for a device which was already not found/ On Wed, May 16, 2018 at 08:48:14PM +0200, Goffredo Baroncelli wrote: > If a device is not found, record this failure storing NULL in s/failure

Re: [PATCH 5/9] btrfs: move logging code in grub_btrfs_read_logical()

On Wed, May 16, 2018 at 08:48:15PM +0200, Goffredo Baroncelli wrote: > A portion of the logging code is moved outside a for(;;). The part that is s/outside a for/outside of for/ > left inside is the one which depends by the for(;;) index. s/depends by the for/depends on the for/ By the way, the

Re: [PATCH 6/9] btrfs: refactor the code that read from disk

On Wed, May 16, 2018 at 08:48:16PM +0200, Goffredo Baroncelli wrote: > This is a preparatory patch, to help the adding of the RAID 5/6 recovery Please move "This is a preparatory patch" sentence below... > code. In case of availability of all disks, this code is good for all the > RAID profiles.

Re: [PATCH 7/9] btrfs: add support for recovery for a RAID 5 btrfs profiles.

On Wed, May 16, 2018 at 08:48:17PM +0200, Goffredo Baroncelli wrote: > Signed-off-by: Goffredo Baroncelli > --- > grub-core/fs/btrfs.c | 174 ++- > 1 file changed, 170 insertions(+), 4 deletions(-) > > diff --git a/grub-core/fs/btrfs.c b/grub-core/fs/btrfs.

Re: [PATCH 8/9] btrfs: make more generic the code for RAID 6 rebuilding

On Wed, May 16, 2018 at 08:48:18PM +0200, Goffredo Baroncelli wrote: > The original code which handles the recovery of a RAID 6 disks array > assumes that all reads are multiple of 1 << GRUB_DISK_SECTOR_BITS and it > assumes that all the I/O is done via the struct grub_diskfilter_segment. > This is

Re: [PATCH 9/9] btrfs: add RAID 6 recovery for a btrfs filesystem.

On Wed, May 16, 2018 at 08:48:19PM +0200, Goffredo Baroncelli wrote: > Add the RAID 6 recovery, in order to use a RAID 6 filesystem even if some > disks (up to two) are missing. This code use the old md RAID 6 code already s/the old md/the md/ > present in grub. > > Signed-off-by: Goffredo Baronc

Re: online doc currency?

On Mon, May 21, 2018 at 01:26:25AM -0400, Felix Miata wrote: > https://www.gnu.org/software/grub/manual/grub/html_node/Command_002dline-and-menu-entry-commands.html > shows only a small fraction of what I see at a grub> prompt, where there are > 19 > items starting with the string "net_" alone. Is

Re: FTDI serial console support?

On Sat, May 26, 2018 at 07:21:24AM +0200, Petter Gustad wrote: > From: Andrew Worsley > Subject: Re: FTDI serial console support? > Date: Sat, 19 May 2018 23:12:42 +1000 > > > On 19 May 2018 at 00:32, Petter Gustad wrote: > >> From: Daniel Kiper > >> Subj

Re: [PATCH] loader/i386/linux: calculate the size of the setup header

On Fri, May 25, 2018 at 12:02:03PM -0700, Andrew Jeddeloh wrote: > Oops, my bad, didn't mean to drop the ML. No problem. Sometimes it happens. > So you're saying the setup header could expand to include some of pad7 > in the future, but we error if it goes beyond that (into the e820 Yep! > map)

Re: [PATCH] multiboot2: clarify usage of the address tag

On Tue, Jun 05, 2018 at 11:55:36AM +0200, Roger Pau Monne wrote: > Add a note to spell out that if the address tag is not present the > file should be loaded using the elf header. > > Signed-off-by: Roger Pau Monné > --- > Cc: Daniel Kiper > Cc: xen-de...@lists.xenpro

Re: [PATCH] multiboot2: clarify usage of the address tag

On Thu, Jun 07, 2018 at 04:46:37PM +0200, Roger Pau Monné wrote: > On Wed, Jun 06, 2018 at 07:28:20PM +0200, Daniel Kiper wrote: > > On Tue, Jun 05, 2018 at 11:55:36AM +0200, Roger Pau Monne wrote: > > > Add a note to spell out that if the address tag is not present the > >

Re: [PATCH v2] multiboot2: clarify usage of the address tag

On Thu, Jun 07, 2018 at 05:59:06PM +0200, Roger Pau Monne wrote: > Add a note to spell out that if the address tag is not present the > file should be loaded using the elf header. > > Signed-off-by: Roger Pau Monné > --- > Cc: Daniel Kiper > Cc: xen-de...@lists.xenprojec

Re: [PATCH v2] multiboot2: clarify usage of the address tag

On Fri, Jun 08, 2018 at 12:08:22PM +0200, Roger Pau Monné wrote: > On Fri, Jun 08, 2018 at 11:35:52AM +0200, Daniel Kiper wrote: > > On Thu, Jun 07, 2018 at 05:59:06PM +0200, Roger Pau Monne wrote: > > > Add a note to spell out that if the address tag is not present the > >

Re: [PATCH v2] multiboot2: clarify usage of the address tag

On Mon, Jun 11, 2018 at 11:30:16AM +0200, Roger Pau Monné wrote: [...] > I think the following is clear enough: > > "Note: This information does not need to be provided if the kernel image is in > @sc{elf} format, but it must be provided if the image is in a.out format or in > some other format.

Re: [PATCH v3] multiboot2: clarify usage of the address tag

On Mon, Jun 11, 2018 at 01:49:02PM +0200, Roger Pau Monne wrote: > Add a note to spell out that if the address tag is not present the > file should be loaded using the elf header. > > Signed-off-by: Roger Pau Monné Reviewed-by: Daniel Kiper If there are no objections I will app

Re: [PATCH v2] mbi: use per segment a separate relocator chunk

On Tue, Jun 05, 2018 at 10:14:49PM +0200, Alexander Boettcher wrote: > Instead of setting up a all comprising relocator chunk for all segments, > use per segment a separate relocator chunk. > > If the ELF is non-relocatable, a single relocator chunk will comprise memory > (between the segments) whi

Re: [PATCH v3] mbi: use per segment a separate relocator chunk

On Tue, Jun 12, 2018 at 08:19:35PM +0200, Alexander Boettcher wrote: > Instead of setting up a all comprising relocator chunk for all segments, > use per segment a separate relocator chunk. > > If the ELF is non-relocatable, a single relocator chunk will comprise memory s/If/Currently, if/ > (bet

Re: [PATCH 1/9] btrfs: Add support for reading a filesystem with a RAID 5 or RAID 6 profile.

On Sun, Jun 03, 2018 at 08:53:40PM +0200, Goffredo Baroncelli wrote: > Signed-off-by: Goffredo Baroncelli > --- > grub-core/fs/btrfs.c | 70 > 1 file changed, 70 insertions(+) > > diff --git a/grub-core/fs/btrfs.c b/grub-core/fs/btrfs.c > index be19544

Re: [PATCH 2/9] btrfs: Add helper to check the btrfs header.

On Sun, Jun 03, 2018 at 08:53:41PM +0200, Goffredo Baroncelli wrote: > This helper will be used in a few places to help the debugging. As > conservative approach, in case of error it is only logged. This is s/, in case of error it/ the error/ > because I am not sure if this can change something i

Re: [PATCH 3/9] btrfs: Move the error logging from find_device() to its caller.

On Sun, Jun 03, 2018 at 08:53:42PM +0200, Goffredo Baroncelli wrote: > This is a preparatory patch. The caller knows better if this > error is fatal or not, i.e. another disk is available or not. Please make first sentence last one in separate line. The same applies to other patches. Otherwise LG

Re: Fwd: [PATCH 4/9] btrfs: Avoid a rescan for a device which was already not found.

On Mon, Jun 04, 2018 at 09:26:06PM +0200, Goffredo Baroncelli wrote: > Resend this patch because I am not sure that all received it. It looks that #4 is a bit unfortunate for you and/or patch series... :-))) > BR > G.Baroncelli > > > Forwarded Message > Subject: [PATCH 4/9] btrf

Re: [PATCH 5/9] btrfs: Move logging code in grub_btrfs_read_logical()

On Sun, Jun 03, 2018 at 08:53:44PM +0200, Goffredo Baroncelli wrote: > A portion of the logging code is moved outside of internal for(;;). The part > that is left inside is the one which depends by the internal for(;;) index. s/depends by/depends on/ > This is a preparatory patch: in the next one

Re: [PATCH 6/9] btrfs: Refactor the code that read from disk

On Sun, Jun 03, 2018 at 08:53:45PM +0200, Goffredo Baroncelli wrote: > Move the code in charge to read the data from disk in a separate s/in a/into a/ > function. This helps to separate the error handling logic (which depend by s/depend by/depends on/ Please fix this here and in other patches to

Re: [PATCH 7/9] btrfs: Add support for recovery for a RAID 5 btrfs profiles.

On Sun, Jun 03, 2018 at 08:53:46PM +0200, Goffredo Baroncelli wrote: > Add support for recovery fo a RAID 5 btrfs profile. In addition s/fo /for / > it is added some code as preparatory work for RAID 6 recovery code. > > Signed-off-by: Goffredo Baroncelli > --- > grub-core/fs/btrfs.c | 180

Re: [PATCH 9/9] btrfs: Add RAID 6 recovery for a btrfs filesystem.

On Sun, Jun 03, 2018 at 08:53:48PM +0200, Goffredo Baroncelli wrote: > Add the RAID 6 recovery, in order to use a RAID 6 filesystem even if some > disks (up to two) are missing. This code use the md RAID 6 code already > present in grub. > > Signed-off-by: Goffredo Baroncelli > --- > grub-core/fs

Re: [PATCH V5] Add support for BTRFS raid5/6 to GRUB

Hi Goffredo, On Sun, Jun 03, 2018 at 08:53:39PM +0200, Goffredo Baroncelli wrote: > > Hi All, > > the aim of this patches set is to provide support for a BTRFS raid5/6 > filesystem in GRUB. > > The first patch, implements the basic support for raid5/6. I.e this works when > all the disks are prese

Re: [PATCH 0/2] efi/fdt: set #address-cells/#size-cells on empty tree

On Mon, Jun 11, 2018 at 05:24:57PM +0100, Leif Lindholm wrote: > Set #address-cells and #size-cells properties (to 2) for ARM*/UEFI > systems when creating an empty DT at boot time. This resolves an issue > seen in the wild with kexec on certain 64-bit ARM systems. > > First part is moving out the

Re: [PATCH 0/2] efi/fdt: set #address-cells/#size-cells on empty tree

On Thu, Jun 14, 2018 at 04:37:34PM +0100, Leif Lindholm wrote: > On Thu, Jun 14, 2018 at 03:38:13PM +0200, Daniel Kiper wrote: > > On Mon, Jun 11, 2018 at 05:24:57PM +0100, Leif Lindholm wrote: > > > Set #address-cells and #size-cells properties (to 2) for ARM*/UEFI > > &g

Re: [PATCH v2] ieee1275: obdisk driver

On Wed, May 30, 2018 at 04:55:22PM -0700, Eric Snowberg wrote: > Add a new disk driver called obdisk for IEEE1275 platforms. Currently > the only platform using this disk driver is SPARC, however other IEEE1275 > platforms could start using it if they so choose. While the functionality > within t

Re: Grub2 EFI: compatibility with wimboot

Hi, On Tue, Jun 05, 2018 at 08:25:53PM +0200, jame88f...@gmx.de wrote: > Hello, > > I wanted to ask if it would be possible to make the compatibility with > wimboot in Grub2 EFI? currently only legacy works. > > http://ipxe.org/wimboot > > that would be really nice. We are happy to help but first

Re: [PATCH v2] ieee1275: obdisk driver

On Fri, Jun 15, 2018 at 02:05:32PM +0200, John Paul Adrian Glaubitz wrote: > On 06/15/2018 02:02 PM, Daniel Kiper wrote: > >> +static int disks_enumerated = 0; > >> +static struct disk_dev *disk_devs = NULL; > >> +static struct parent_dev *parent_devs = NULL; > &g

Re: [PATCH 1/1] grub-fs-tester: fix losetup race

On Fri, Jun 15, 2018 at 06:34:04PM +0100, Will Thompson wrote: > If something else on the system is using loopback devices, then the > device that's free at the call to `losetup -f` may not be free in the > following call to try to use it. Instead, find and use the first free > loopback device in a

Re: [PATCH v4] mbi: use per segment a separate relocator chunk

On Thu, Jun 14, 2018 at 08:29:14PM +0200, Alexander Boettcher wrote: > Instead of setting up a all comprising relocator chunk for all segments, > use per segment a separate relocator chunk. > > Currently, if the ELF is non-relocatable, a single relocator chunk will > comprise memory (between the se

  1   2   3   4   5   6   7   8   9   10   >