[PATCH v5 10/13] error: Use format code PRIxGRUB_UINT64_T for 64-bit arg in grub_error

lue regardless. Signed-off-by: Glenn Washburn --- grub-core/efiemu/i386/loadcore64.c | 3 ++- grub-core/kern/arm64/dl.c | 3 ++- grub-core/kern/ia64/dl.c | 3 ++- grub-core/kern/riscv/dl.c | 5 +++-- grub-core/kern/sparc64/dl.c| 3 ++- grub-core/kern/x86_64/d

[PATCH] style: Format string macro should have a space between quotes

Signed-off-by: Glenn Washburn --- grub-core/disk/luks2.c | 38 +++--- grub-core/fs/xfs.c | 4 ++-- 2 files changed, 21 insertions(+), 21 deletions(-) diff --git a/grub-core/disk/luks2.c b/grub-core/disk/luks2.c index 7460d7b58..125e8609a 100644 --- a/grub

[PATCH v5 12/13] error: Use format code llu for 64-bit uint bp->blk_prop in grub_error

For some reason PRIuGRUB_UINT64_T is not expanding to llu, but to lu, which causes the format string check to fail. Use literal and force cast until this is debugged. Signed-off-by: Glenn Washburn --- grub-core/fs/zfs/zfs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH v5 11/13] error: Use format code PRIuGRUB_UINT64_T for 64-bit typed fileblock in grub_error

Signed-off-by: Glenn Washburn --- grub-core/fs/hfsplus.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/grub-core/fs/hfsplus.c b/grub-core/fs/hfsplus.c index 9c4e4c88c..b538f52e0 100644 --- a/grub-core/fs/hfsplus.c +++ b/grub-core/fs/hfsplus.c @@ -188,7 +188,8

Re: Threading of patch series (was: [PATCH v6 00/14] error: Do compile-time format string checking on grub>)

Hi Paul, On Sat, 6 Mar 2021 07:59:18 +0100 Paul Menzel wrote: > Dear Glenn, > > > Am 06.03.21 um 00:15 schrieb Glenn Washburn: > > On Fri, 5 Mar 2021 17:27:01 +0100 Daniel Kiper wrote: > > […] > > >> By the way, my I ask you once again to send each patch

Re: [PATCH] disk/pata: Prepend log message with PATA

usb mass storage disk and ATAPI(?) cdrom configured in qemu. So in addition to this patch, it would be nice to not have the pata module print that message when no devices are found. Perhaps a grub_dprintf would be better. Glenn Reviewed-by: Glenn Washburn > Signed-off-by: Paul Menzel > ---

Re: [PATCH v6 00/14] error: Do compile-time format string checking on grub>

On Fri, 5 Mar 2021 17:27:01 +0100 Daniel Kiper wrote: > On Thu, Mar 04, 2021 at 06:22:31PM -0600, Glenn Washburn wrote: > > Daniel, you mentioned wanting a separate patch series which is the > > real fix for patch #12. I've added it to this patch series, since > > they go

Re: [PATCH v2 0/7] Add xHCI USB support

> > On Fri, Feb 19, 2021 at 7:11 PM Glenn Washburn > wrote: > > > > Hi Patrick, > > > > Thanks for the contribution. I think this would be a great addition > > to GRUB. However, there are a few issues I see at the moment. > > > > On Mon, 7 D

Re: multiboot2 and module2 boot issues via GRUB2

On Thu, 1 Apr 2021 20:43:46 +0100 Andrew Cooper via Grub-devel wrote: > On 01/04/2021 09:44, Roger Pau Monné wrote: > > On Thu, Apr 01, 2021 at 09:31:07AM +0200, Jan Beulich wrote: > >> On 01.04.2021 03:06, Roman Shaposhnik wrote: > >>> And the obvious next question: is my EVE usecase esoteric

Re: RFC: Grub project management

On Thu, 11 Feb 2021 23:50:38 -0500 Eli Schwartz wrote: > On 2/11/21 10:53 PM, Glenn Washburn wrote: > > For patches that people don't want to disappear on the list, I > > think a merge request can help mitigate that. Also since the merge > > request is effectively a whole

Re: RFC: Grub project management

On Fri, 12 Feb 2021 17:35:05 -0500 Eli Schwartz wrote: > On 2/12/21 4:58 PM, Glenn Washburn wrote: > > And you're right the merge request part is not ideal. There > > is redundancy, but I don't think its that big of a deal. There does > > come more confusion when determin

Re: RFC: Grub project management

On Fri, 12 Feb 2021 17:16:39 -0500 Konrad Rzeszutek Wilk wrote: > On Thu, Feb 11, 2021 at 09:53:37PM -0600, Glenn Washburn wrote: > > I believe I speak for more than just myself when I say that the > > current development process leaves much to be desired. GRUB has > > bee

[CI 09/17] grub-shell: Put all generated files into working dir and use better file names

into a randomly named directory, so as not to collide with other grub-shell invocations. And now that the generated files can be put in a location where they will not get stepped on, and they can be named sensible names. Signed-off-by: Glenn Washburn --- tests/util/grub-shell.in | 22

[CI 07/17] grub-shell: Only show grub-mkrescue output if it returns an error

needs the iso image created by grub-mkresue to boot the qemu instance, a failure here should be considered fatal. Signed-off-by: Glenn Washburn --- tests/util/grub-shell.in | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/tests/util/grub-shell.in b/tests/util

[CI 05/17] grub-shell: Allow specifying non-default trim line contents

This will be useful for tests that have unwanted output from setup. This is not documented because its only intended to be internal at the moment. Also, --no-trim is allowed to explicitly turn off trim. Signed-off-by: Glenn Washburn --- tests/util/grub-shell.in | 14 +- 1 file

[CI 02/17] tests: Fix partmap_test for arm*-efi, disk numbering has changed

Perhaps using a newer UEFI firmware is the reason for the created test disk showing up as hd2 instead of hd3. Signed-off-by: Glenn Washburn --- tests/partmap_test.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/partmap_test.in b/tests/partmap_test.in index 6ef518b0a

[CI 16/17] ci: Add .gitlab-ci.yml for continuous integration with Gitlab CI

Signed-off-by: Glenn Washburn --- .ci/build.sh| 66 +++ .ci/functions.gitlab.sh | 30 + .ci/functions.sh| 30 + .ci/make-images.sh | 71 +++ .ci/process-tests.sh| 108 .ci/test.sh | 106 .gitlab-ci.yml | 1184

[CI 17/17] keep: remove a lot of cruft that we probably want to reuse at some point

Signed-off-by: Glenn Washburn --- .ci/build.sh | 10 - .ci/process-tests.sh | 11 - .ci/test.sh | 8 - .gitlab-ci.yml | 552 --- 4 files changed, 581 deletions(-) diff --git a/.ci/build.sh b/.ci/build.sh index 14dd7f7c5

[CI 14/17] grub-shell: Use malta qemu-mips machine type instead off non-existant indy

Signed-off-by: Glenn Washburn --- tests/util/grub-shell.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/util/grub-shell.in b/tests/util/grub-shell.in index 211bfdb95..332fae704 100644 --- a/tests/util/grub-shell.in +++ b/tests/util/grub-shell.in @@ -119,7 +119,7

[CI 15/17] grub-shell: Update qemu UEFI firmware names to be more generic

-off-by: Glenn Washburn --- tests/util/grub-shell.in | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/util/grub-shell.in b/tests/util/grub-shell.in index 332fae704..33d39d4dd 100644 --- a/tests/util/grub-shell.in +++ b/tests/util/grub-shell.in @@ -74,7 +74,7

[CI 12/17] tests: Allow turning on shell tracing from environment variables

This allows turning on shell tracing when its not practical or not possible to use commandline arguments. Turn on tracing when the envvar is an integer greater than 1, since these can log a lot of messages. Signed-off-by: Glenn Washburn --- tests/util/grub-fs-tester.in | 2 ++ tests/util/grub

[PATCH v4 01/13] misc: Format string for grub_error should be a literal

Signed-off-by: Glenn Washburn --- grub-core/loader/efi/chainloader.c | 2 +- grub-core/net/tftp.c | 2 +- grub-core/script/lexer.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/grub-core/loader/efi/chainloader.c b/grub-core/loader/efi

[PATCH v4 02/13] error: grub_error missing format string argument

Its obvious from the error message that the variable named "type" was accidentally omitted. Signed-off-by: Glenn Washburn --- grub-core/parttool/msdospart.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/grub-core/parttool/msdospart.c b/grub-core/parttool/m

[PATCH v4 03/13] error: grub_error format string add missing format code

Signed-off-by: Glenn Washburn --- grub-core/video/bochs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/grub-core/video/bochs.c b/grub-core/video/bochs.c index 7a249eb21..30ea1bd82 100644 --- a/grub-core/video/bochs.c +++ b/grub-core/video/bochs.c @@ -249,11 +249,11

[PATCH v4 09/13] error: Use format code PRIxGRUB_UINT64_T for 64-bit uint argument in grub_error

Signed-off-by: Glenn Washburn --- grub-core/disk/ata.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/grub-core/disk/ata.c b/grub-core/disk/ata.c index 685f33a19..c8f350ed3 100644 --- a/grub-core/disk/ata.c +++ b/grub-core/disk/ata.c @@ -219,7 +219,7

[PATCH v4 10/13] error: Use format code PRIxGRUB_UINT64_T for 64-bit arg in grub_error

lue regardless. Signed-off-by: Glenn Washburn --- grub-core/efiemu/i386/loadcore64.c | 3 ++- grub-core/kern/arm64/dl.c | 3 ++- grub-core/kern/ia64/dl.c | 3 ++- grub-core/kern/riscv/dl.c | 5 +++-- grub-core/kern/sparc64/dl.c| 3 ++- grub-core/kern/x86_64/d

[CI 10/17] grub-shell: Add grub output logfile with grub-shell --debug

This allows seeing full qemu output of grub-shell, which can be invaluable when debugging failing tests. Signed-off-by: Glenn Washburn --- tests/util/grub-shell.in | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/tests/util/grub-shell.in b/tests/util/grub-shell.in

[CI 03/17] tests: When checking squashfs fstime, use superblock last modified time

takes more than 3 seconds to generate the image, as is the case on a low power machine. Instead use squashfs tools to get the filesystem timestamp directly. Signed-off-by: Glenn Washburn --- tests/util/grub-fs-tester.in | 6 ++ 1 file changed, 6 insertions(+) diff --git a/tests/util/grub-fs

[CI 13/17] grub-shell: Add --verbose to mkrescue when $debug is greater than 2

Signed-off-by: Glenn Washburn --- tests/util/grub-shell.in | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/util/grub-shell.in b/tests/util/grub-shell.in index 3b6bce4c2..211bfdb95 100644 --- a/tests/util/grub-shell.in +++ b/tests/util/grub-shell.in @@ -404,7 +404,9

[CI 11/17] grub-shell: Set exit status to qemu exit status

This allows us to test if unexpected output in test scripts is because of a bug in grub, because there was an error in qemu, or qemu was killed due to a timeout. Signed-off-by: Glenn Washburn --- tests/util/grub-shell.in | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff

[CI 08/17] grub-shell: Allow setting default timeout via GRUB_SHELL_DEFAULT_TIMEOUT envvar

Signed-off-by: Glenn Washburn --- tests/util/grub-shell.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/util/grub-shell.in b/tests/util/grub-shell.in index 9d8c417da..e80471126 100644 --- a/tests/util/grub-shell.in +++ b/tests/util/grub-shell.in @@ -211,7 +211,7

[PATCH v4 07/13] efi: Format string error in grub_error

The second format string argument, GRUB_EFI_MAX_USABLE_ADDRESS, is a macro to a number literal. However depending on what the target architecture, the type can be 32 or 64 bits. Cast to a 64-bit integer. Also, change the format string literals %llx to use PRIxGRUB_UINT64_T. Signed-off-by: Glenn

[PATCH v4 04/13] dmraid_nvidia: Format string error in grub_error

The grub_error has a format string expecting two arguments, but only one provided. According to the comments in the struct grub_nv_super definition, the version field looks like a version number where major.minor is encoded as each a byte in the two-byte short. Signed-off-by: Glenn Washburn

[PATCH v4 00/13] error: Do compile-time format string checking on grub_error

PRIuGRUB_UINT64_T was not expanding to llu, and yet the compiler was saying the argument was a long long unsigned. The tests results can be found here: https://gitlab.com/gwashburn/grub/-/pipelines/255133408 Glenn Glenn Washburn (13): misc: Format string for grub_error should be a literal error

[PATCH v4 06/13] pgp: Format code for grub_error is incorrect

The format code is for a 32-bit int, but the argument, keyid, is declared as a 64 bit int. The comment above says keyid is 32-bit. I'm not sure if the comment or declaration is wrong, so force the display of a 64-bit int for now. Signed-off-by: Glenn Washburn --- grub-core/commands/pgp.c | 2

[PATCH v4 11/13] error: Use format code PRIuGRUB_UINT64_T for 64-bit typed fileblock in grub_error

Signed-off-by: Glenn Washburn --- grub-core/fs/hfsplus.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/grub-core/fs/hfsplus.c b/grub-core/fs/hfsplus.c index 9c4e4c88c..b538f52e0 100644 --- a/grub-core/fs/hfsplus.c +++ b/grub-core/fs/hfsplus.c @@ -188,7 +188,8

[PATCH v4 12/13] error: Use format code llu for 64-bit uint bp->blk_prop in grub_error

For some reason PRIuGRUB_UINT64_T is not expanding to llu, but to lu, which causes the format string check to fail. Use literal and force cast until this is debugged. Signed-off-by: Glenn Washburn --- grub-core/fs/zfs/zfs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH v4 13/13] error: Do compile-time format string checking on grub_error

This should help prevent format string errorsand thus improve the quality of error reporting. Signed-off-by: Glenn Washburn --- include/grub/err.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/grub/err.h b/include/grub/err.h index 24ba9f5f5..b08d5d0de 100644

[PATCH v4 05/13] grub_error: Use format code PRIuGRUB_SIZE for variables of type grub_size_t

Signed-off-by: Glenn Washburn --- grub-core/disk/cryptodisk.c| 12 grub-core/kern/efi/efi.c | 2 +- grub-core/loader/efi/chainloader.c | 2 +- grub-core/loader/i386/bsd.c| 3 ++- 4 files changed, 12 insertions(+), 7 deletions(-) diff --git a/grub-core

[PATCH v4 08/13] error: Use %p format code for pointer types

Signed-off-by: Glenn Washburn --- grub-core/loader/i386/pc/linux.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/grub-core/loader/i386/pc/linux.c b/grub-core/loader/i386/pc/linux.c index 814988ab9..0bc5d6807 100644 --- a/grub-core/loader/i386/pc/linux.c +++ b/grub-core

[CI 01/17] tests: Make sure LANG is set properly for iso9660_test

like a UTF-8 locale, print a warning so the user will have a clue as to why the iso9660_test might be failing. Signed-off-by: Glenn Washburn --- tests/iso9660_test.in | 6 ++ 1 file changed, 6 insertions(+) diff --git a/tests/iso9660_test.in b/tests/iso9660_test.in index 571b938d7

[CI 00/17] Gitlab CI and test framework improvements

/258485608 Glenn Glenn Washburn (17): tests: Make sure LANG is set properly for iso9660_test tests: Fix partmap_test for arm*-efi, disk numbering has changed tests: When checking squashfs fstime, use superblock last modified time tests: Fail immediately when grub-shell fails and do

[CI 04/17] tests: Fail immediately when grub-shell fails and do not occlude the error code

' is not set and there are subsequent successful commands. When the test script fails because of a failure in grub-shell, then test script should exit with the failed exit code of grub-shell. Signed-off-by: Glenn Washburn --- tests/ahci_test.in | 6 +- tests/cdboot_test.in | 3

[CI 06/17] grub-shell: Trim line should always be matched from the beginning of the line

When turning on shell tracing the trim line will be output before we actually want to start the trim. However, in this case the trim line never starts from the beginning of the line. So start trimming from the correct line by matching from the beginning of the line. Signed-off-by: Glenn Washburn

Re: RFC: Grub project management

On Sun, 14 Feb 2021 13:58:40 +1100 Daniel Axtens wrote: > > Reading more about patchwork, it seems to have its own set of > > issues, partly revolving around using a mailing list of development > > as we do. see: https://lwn.net/Articles/773456/ > > I'm a patchwork maintainer, happy to discuss

Re: [PATCH v2 0/7] Add xHCI USB support

Hi Patrick, Thanks for the contribution. I think this would be a great addition to GRUB. However, there are a few issues I see at the moment. On Mon, 7 Dec 2020 08:41:20 +0100 Patrick Rudolph wrote: > Add basic support for xHCI USB controllers and non root xHCI hubs. > The motivation is to

RFC: Grub project management

Hi fellow GRUB developers, I want to start by recognizing that most people who are involved with the project maintenance are doing so on a voluntary basis (or at least that's my assumption) and people have busy lives. Its a mostly thankless job, so thank you guys for all the time spent keeping

Re: [PATCH 00/12] Grub-shell improvements

Hi Daniel, On Thu, 26 Aug 2021 20:00:32 +0200 Daniel Kiper wrote: > Hi Glenn, > > On Wed, Aug 25, 2021 at 06:06:30PM -0500, Glenn Washburn wrote: > > Hi Daniel, > > > > What are the chances this patch series can be reviewed in the near > > future? Some feed

Re: [grub-fs-tester.in] zisofs test looks unsuitable

On Fri, 27 Aug 2021 00:14:20 +0200 "Thomas Schmitt" wrote: > Hi. > > Glenn Washburn wrote: > > I think the changes to get the test > > working are worthy of inclusion so that the tests are ready when > > this feature gets implemented. > > Do y

Re: [grub-fs-tester.in] zisofs test looks unsuitable

On Thu, 26 Aug 2021 22:07:29 +0200 "Thomas Schmitt" wrote: > Hi, > > i managed to get the ziso9660 test running with actual compression. > > ./grub-fs-tester ziso9660 > > now produces an ISO image but seems not to be happy with it. > > If i get it right then it sees the compressed size

Re: [PATCH v2 1/8] tests: Make sure LANG is set properly for iso9660_test

On Thu, 26 Aug 2021 19:49:37 +0200 "Thomas Schmitt" wrote: > Hi, > > now i know that i should have asked for the test-suite.log file. > > The problem turned out to be in Joliet, not in ISO 9660. > Because Joliet gets its file names and other texts encoded as UCS-2 > 16-bit characters it is

Re: [PATCH v2 1/8] tests: Make sure LANG is set properly for iso9660_test

On Thu, 26 Aug 2021 23:28:04 +0200 "Thomas Schmitt" wrote: > > If yes, then I should probably remove this patch altogether and put > > this code elsewhere. > > I think it can be justified to hardcode UTF-8 in grub-fs-tester > regardless whether higher levels of the test empire or the user have

Re: [PATCH v2 1/8] tests: Make sure LANG is set properly for iso9660_test

On Fri, 27 Aug 2021 21:13:17 +0200 "Thomas Schmitt" wrote: > Hi, > > it turns out that it might be contraproductive to set > LANG=en_US.UTF-8. > > If the LANG locale is not listed by > locale -a > then nl_langinfo(3) returns "ANSI_X3.4-1968". > I stumbled over this when testing

Re: [PATCH 00/12] Grub-shell improvements

Hi Daniel, What are the chances this patch series can be reviewed in the near future? Some feedback would be greatly appreciated. Glenn On Wed, 31 Mar 2021 20:57:39 -0500 Glenn Washburn wrote: > I've extracted this patch series from the GitLab CI patch series, > which some

[PATCH v2 1/8] tests: Make sure LANG is set properly for iso9660_test

like a UTF-8 locale, print a warning so the user will have a clue as to why the iso9660_test might be failing. Signed-off-by: Glenn Washburn --- tests/iso9660_test.in | 6 ++ 1 file changed, 6 insertions(+) diff --git a/tests/iso9660_test.in b/tests/iso9660_test.in index 571b938d7

[PATCH v2 3/8] tests: When checking squashfs fstime, use superblock last modified time

takes more than 3 seconds to generate the image, as is the case on a virtual machine. Instead use squashfs tools to get the filesystem timestamp directly. Signed-off-by: Glenn Washburn --- tests/util/grub-fs-tester.in | 6 ++ 1 file changed, 6 insertions(+) diff --git a/tests/util/grub-fs

[PATCH v2 2/8] tests: Fix partmap_test for arm*-efi, disk numbering has changed

Perhaps using a newer UEFI firmware is the reason for the created test disk showing up as hd2 instead of hd3. Signed-off-by: Glenn Washburn --- tests/partmap_test.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/partmap_test.in b/tests/partmap_test.in index 6ef518b0a

[PATCH v2 7/8] tests: Exit with skipped exit code when test not performed

These tests were not performed and therefore did not pass, nor fail. This fixes misleading test exit code where, for instance, the pseries_test will pass on i386-pc, which is not a pseries architecture. Signed-off-by: Glenn Washburn --- tests/ahci_test.in | 8 tests

[PATCH v2 0/8] Various fixes/improvements for tests

Glenn Washburn (8): tests: Make sure LANG is set properly for iso9660_test tests: Fix partmap_test for arm*-efi, disk numbering has changed tests: When checking squashfs fstime, use superblock last modified time tests: Fail immediately when grub-shell fails and do not occlude

[PATCH v2 5/8] tests: Make setup errors in grub-fs-tester hard errors

being run and those that are really failing. Signed-off-by: Glenn Washburn --- tests/util/grub-fs-tester.in | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/tests/util/grub-fs-tester.in b/tests/util/grub-fs-tester.in index 4213b7bfc..eacb1e0a7 100644 --- a/tests

[PATCH v2 6/8] tests: A failure of mktemp should cause the test script to exit with code 99

A test exiting with code 99 means that there was an error in the test itself and not a failure in the thing being tested (also known as a hard error). Signed-off-by: Glenn Washburn --- tests/ahci_test.in| 4 ++-- tests/ehci_test.in| 4 ++-- tests/gettext_strings_test.in

[PATCH v2 4/8] tests: Fail immediately when grub-shell fails and do not occlude the error code

' is not set and there are subsequent successful commands. When the test script fails because of a failure in grub-shell, then test script should exit with the failed exit code of grub-shell. Signed-off-by: Glenn Washburn --- tests/ahci_test.in | 6 +- tests/cdboot_test.in | 3

[PATCH v2 8/8] tests: Use @BUILD_SHEBANG@ autoconf var instead of literal shell

This bring this test in line with the rest of the test scripts. Signed-off-by: Glenn Washburn --- tests/f2fs_test.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/f2fs_test.in b/tests/f2fs_test.in index 1ea77c826..8c415db61 100644 --- a/tests/f2fs_test.in +++ b/tests

[PATCH 1/3] cryptodisk: Add infrastructure to pass data from cryptomount to cryptodisk modules

As an example, passing a password as a cryptomount argument is implemented. However, the backends are not implemented, so testing this will return a not implemented error. Signed-off-by: Glenn Washburn --- grub-core/disk/cryptodisk.c | 31 ++- grub-core/disk/geli.c

[PATCH 0/3] Refactor/improve cryptomount data passing to crypto modules

for an improved patch series providing detached header and keyfile support (I already have the series updated and ready to send once this is accepted). I also believe tha this will somewhat simplify the patch series by James Bottomley in passing secrets to the crypto backends. Glenn Glenn Washburn (3

[PATCH 3/3] cryptodisk: Move global variables into grub_cryptomount_args struct

Signed-off-by: Glenn Washburn --- grub-core/disk/cryptodisk.c | 26 +- include/grub/cryptodisk.h | 3 +++ 2 files changed, 12 insertions(+), 17 deletions(-) diff --git a/grub-core/disk/cryptodisk.c b/grub-core/disk/cryptodisk.c index b6cf1835d..00a671a59 100644

[PATCH 2/3] cryptodisk: Refactor password input out of crypto dev modules into cryptodisk

The crypto device modules should only be setting up the crypto devices and not getting user input. This has the added benefit of simplifying the code such that three essentially duplicate pieces of code are merged into one. Signed-off-by: Glenn Washburn --- grub-core/disk/cryptodisk.c | 52

Re: [PATCH v2 1/8] tests: Make sure LANG is set properly for iso9660_test

Hi Thomas, On Wed, 25 Aug 2021 11:34:47 +0200 "Thomas Schmitt" wrote: > Hi, > > Glenn Washburn wrote: > > LANG must be set to something that supports international > > characters, otherwise xorriso will refuse to include the file with > > name having inter

Re: [grub-fs-tester.in] zisofs test looks unsuitable

On Wed, 25 Aug 2021 12:29:48 +0200 "Thomas Schmitt" wrote: > Hi, > > the xorriso run for testing zisofs in > > tests/util/grub-fs-tester.in > > looks not like it would cause any zisofs compression in the ISO. > > Line 1024: > > xorriso -compliance rec_mtime -set_filter_r --zisofs --

Re: Where is the testing? (was: Re: [PATCH] fs/xfs: Avoid unreadble filesystem if V4 superblock)

On Wed, 8 Sep 2021 18:03:50 +0200 Daniel Kiper wrote: > On Wed, Sep 08, 2021 at 01:22:20AM +0000, Glenn Washburn wrote: > > It looks like the xfs_test test succeeds with tag grub-2.06-rc1a, > > fails with tag grub-2.06, and succeeds with current master. Yes, as > > ex

Re: [SECURITY PATCH 05/28] malloc: Use overflow checking primitives where we do complex allocations

On Wed, 29 Jul 2020 19:00:18 +0200 Daniel Kiper wrote: > From: Peter Jones > > This attempts to fix the places where we do the following where > arithmetic_expr may include unvalidated data: > > X = grub_malloc(arithmetic_expr); > > It accomplishes this by doing the arithmetic ahead of

[PATCH] udf: Fix regression which is preventing symlink access

he maximum growth in bytes when converting from 2-byte unicode code-points to UTF-8 (from 2 bytes to 3). Signed-off-by: Glenn Washburn --- grub-core/fs/udf.c | 17 - 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/grub-core/fs/udf.c b/grub-core/fs/udf.c index

Re: [PATCH] udf: Fix regression which is preventing symlink access

On Tue, 14 Sep 2021 16:27:55 +0200 Daniel Kiper wrote: > On Fri, Sep 10, 2021 at 04:03:23PM +0000, Glenn Washburn wrote: > > This code was broken by commit 3f05d693 ("malloc: Use overflow > > checking primitives where we do complex allocations"), which added > >

Re: [PATCH] udf: Fix regression which is preventing symlink access

On Wed, 15 Sep 2021 16:52:28 +0200 Daniel Kiper wrote: > On Tue, Sep 14, 2021 at 06:19:03PM +0000, Glenn Washburn wrote: > > On Tue, 14 Sep 2021 16:27:55 +0200 > > Daniel Kiper wrote: > > > > > On Fri, Sep 10, 2021 at 04:03:23PM +, Glenn Washburn wrote

Where is the testing? (was: Re: [PATCH] fs/xfs: Avoid unreadble filesystem if V4 superblock)

On Thu, 2 Sep 2021 10:56:49 +0200 Carlos Maiolino wrote: > On Wed, Sep 01, 2021 at 02:40:57PM +0200, Daniel Kiper wrote: > > CC-ing Javier... > > > > On Mon, Aug 30, 2021 at 01:48:50PM +0200, Carlos Maiolino wrote: > > > Hi. > > > On Mon, Aug 30, 2021 at 11:18:31AM +0200, Erwan Velu wrote: > >

Re: [PATCH] tests: Let xorriso fixely assume UTF-8 as local character set

On Wed, 1 Sep 2021 15:11:38 +0200 Daniel Kiper wrote: > On Fri, Aug 27, 2021 at 11:05:06PM +0200, Thomas Schmitt wrote: > > iso9660_test fails if the effective locale is not UTF-8. This > > happens because xorriso needs to convert file names and FSLABEL to > > UCS-2 when preparing a Joliet tree.

Re: [PATCH 3/3] cryptodisk: Move global variables into grub_cryptomount_args struct

On Mon, 30 Aug 2021 20:02:26 +0200 Patrick Steinhardt wrote: > On Thu, Aug 26, 2021 at 12:08:52AM -0500, Glenn Washburn wrote: > > Signed-off-by: Glenn Washburn > > --- > > grub-core/disk/cryptodisk.c | 26 +- > > include/grub/cryptodis

Re: [PATCH 1/3] cryptodisk: Add infrastructure to pass data from cryptomount to cryptodisk modules

On Mon, 30 Aug 2021 19:55:59 +0200 Patrick Steinhardt wrote: > On Thu, Aug 26, 2021 at 12:08:50AM -0500, Glenn Washburn wrote: > > As an example, passing a password as a cryptomount argument is > > implemented. However, the backends are not implemented, so testing >

[PATCH 02/10] tests: mkreiserfs only supports 4096 block size

Signed-off-by: Glenn Washburn --- tests/util/grub-fs-tester.in | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tests/util/grub-fs-tester.in b/tests/util/grub-fs-tester.in index 9f6f26f26..ab58a96c8 100644 --- a/tests/util/grub-fs-tester.in +++ b/tests/util/grub-fs

[PATCH 00/10] More test fixes/improvements

very recently a fairly old version of dosfstools has been used which didn't do invalid character checking. Glenn Glenn Washburn (10): tests: Rename variable filtime -> filetime as its meant to be tests: mkreiserfs only supports 4096 block size tests: Disable reiserfs tests for old for

[PATCH 07/10] tests: Skip hfs test only when mac_roman module is not loaded and not loadable

Allow the hfs tests to not be skipped if the mac_roman modules is loaded in the kernel, but not accessible to modprobe. Signed-off-by: Glenn Washburn --- tests/hfs_test.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/hfs_test.in b/tests/hfs_test.in index d7ec56bef

[PATCH 10/10] tests: Do not delete filesystem images on error

The filesystem images created for the filesystem test can be useful when debugging why a filesystem test failed. So keep them around and let the user clean them up. Signed-off-by: Glenn Washburn --- tests/util/grub-fs-tester.in | 3 --- 1 file changed, 3 deletions(-) diff --git a/tests/util

[PATCH 04/10] tests: mkfs.btrfs now supports only 4k sector sizes and above

Signed-off-by: Glenn Washburn --- tests/util/grub-fs-tester.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/util/grub-fs-tester.in b/tests/util/grub-fs-tester.in index ab58a96c8..f4d9f161b 100644 --- a/tests/util/grub-fs-tester.in +++ b/tests/util/grub-fs-tester.in

[PATCH 09/10] tests: Output list of devices when partmap fails

Signed-off-by: Glenn Washburn --- tests/partmap_test.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/partmap_test.in b/tests/partmap_test.in index faace51ec..3d9871a2f 100644 --- a/tests/partmap_test.in +++ b/tests/partmap_test.in @@ -43,7 +43,7 @@ check_output

[PATCH 05/10] tests: Only test minix3 volumes of 1k block size

because they were being skipped due to not finding a mkfs.minix with the -B option. Signed-off-by: Glenn Washburn --- tests/minixfs_test.in| 5 - tests/util/grub-fs-tester.in | 4 ++-- 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/tests/minixfs_test.in b/tests

[PATCH 08/10] grub-shell: Boot PowerPC using PMU instead of CUDA for power management

://gitlab.com/qemu-project/qemu/-/issues/624 Signed-off-by: Glenn Washburn --- tests/util/grub-shell.in | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/util/grub-shell.in b/tests/util/grub-shell.in index 93e9f5148..5354d8678 100644 --- a/tests/util/grub-shell.in +++ b/tests/util/grub-shell.in

Re: [PATCH v2 7/8] tests: Exit with skipped exit code when test not performed

On Wed, 25 Aug 2021 02:04:01 -0500 Glenn Washburn wrote: > These tests were not performed and therefore did not pass, nor fail. > This fixes misleading test exit code where, for instance, the > pseries_test will pass on i386-pc, which is not a pseries > architecture. > > Si

[PATCH 03/10] tests: Disable reiserfs tests for old format because newer kernels do not support them

Signed-off-by: Glenn Washburn --- tests/reiserfs_test.in | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/reiserfs_test.in b/tests/reiserfs_test.in index b5fed7635..ff703b203 100644 --- a/tests/reiserfs_test.in +++ b/tests/reiserfs_test.in @@ -16,5 +16,7 @@ if ! which

[PATCH 01/10] tests: Rename variable filtime -> filetime as its meant to be

Signed-off-by: Glenn Washburn --- tests/util/grub-fs-tester.in | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/util/grub-fs-tester.in b/tests/util/grub-fs-tester.in index 7c22cf882..9f6f26f26 100644 --- a/tests/util/grub-fs-tester.in +++ b/tests/util/grub-fs

[PATCH 06/10] tests: Change FAT volume label to be with in the valid character range

to test odd volume labels. Signed-off-by: Glenn Washburn --- tests/util/grub-fs-tester.in | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tests/util/grub-fs-tester.in b/tests/util/grub-fs-tester.in index 96b204590..537cdd48b 100644 --- a/tests/util/grub-fs-tester.in +++ b

[PATCH] docs: Improve search documentation, by adding short options and section on hints

Signed-off-by: Glenn Washburn --- docs/grub.texi | 17 + 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/docs/grub.texi b/docs/grub.texi index 0be500387..8baf99ad1 100644 --- a/docs/grub.texi +++ b/docs/grub.texi @@ -4999,16 +4999,25 @@ Search devices by file

[PATCH v2] udf: Fix regression which is preventing symlink access

allocated but will not be used for UTF-8 characters, so the NULL byte is accounted for. Signed-off-by: Glenn Washburn --- grub-core/fs/udf.c | 17 - 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/grub-core/fs/udf.c b/grub-core/fs/udf.c index 2ac5c1d00..4ff970

Re: IS: Glenn's patches status WAS: Re: [PATCH 00/12] Grub-shell improvements

On Tue, 14 Sep 2021 13:04:31 +0200 Daniel Kiper wrote: > On Mon, Aug 30, 2021 at 05:23:44PM +0200, Daniel Kiper wrote: > > CC-ing Denis and Patrick... > > > > On Thu, Aug 26, 2021 at 05:08:21PM -0500, Glenn Washburn wrote: > > > Hi Daniel, > > > &

Re: [PATCH 3/3] cryptodisk: Move global variables into grub_cryptomount_args struct

On Sun, 12 Sep 2021 13:17:29 +0200 Patrick Steinhardt wrote: > On Tue, Sep 07, 2021 at 02:34:30AM +0000, Glenn Washburn wrote: > > On Mon, 30 Aug 2021 20:02:26 +0200 > > Patrick Steinhardt wrote: > > > > > On Thu, Aug 26, 2021 at 12:08:52AM -0500, Glenn Wash

[PATCH v4 2/9] tests: When checking squashfs fstime, use superblock last modified time

takes more than 3 seconds to generate the image, as is the case on a virtual machine. Instead use squashfs tools to get the filesystem timestamp directly. Signed-off-by: Glenn Washburn --- tests/util/grub-fs-tester.in | 6 ++ 1 file changed, 6 insertions(+) diff --git a/tests/util/grub-fs

[PATCH v4 7/9] tests: A failure of mktemp should cause the test script to exit with code 99

A test exiting with code 99 means that there was an error in the test itself and not a failure in the thing being tested (also known as a hard error). Signed-off-by: Glenn Washburn --- tests/ahci_test.in| 4 ++-- tests/ehci_test.in| 4 ++-- tests/gettext_strings_test.in

[PATCH v4 3/9] tests: Add set -e to missing tests

This helps to ensure that error codes do not get ignored. Signed-off-by: Glenn Washburn --- tests/grub_cmd_test.in| 1 + tests/grub_script_blockarg.in | 1 + tests/test_sha512sum.in | 1 + 3 files changed, 3 insertions(+) diff --git a/tests/grub_cmd_test.in b/tests

Re: [PATCH v3 2/4] tests: Do not occlude subshell error codes

On Tue, 12 Oct 2021 21:40:45 +0200 Daniel Kiper wrote: > On Mon, Oct 11, 2021 at 01:06:17PM -0500, Glenn Washburn wrote: > > On Mon, 11 Oct 2021 16:20:46 +0200 > > Daniel Kiper wrote: > > > > > On Thu, Oct 07, 2021 at 03:33:25PM -0500, Glenn Washburn wrote: &g

[PATCH v4 1/9] tests: Fix partmap_test for arm*-efi, disk numbering has changed

Perhaps using a newer UEFI firmware is the reason for the created test disk showing up as hd2 instead of hd3. Signed-off-by: Glenn Washburn --- tests/partmap_test.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/partmap_test.in b/tests/partmap_test.in index 6ef518b0a

[PATCH v4 0/9] Various fixes/improvements for tests

Updates since v3: * Dropped iso9660_test LANG patch * Merged v3 in v2 * Rewrote commit message for #4 to hopefully be clearer * Replace `...` with $(...) These are mostly test improvement and fixes that stand on their own. Glenn Glenn Washburn (9): tests: Fix partmap_test for arm*-efi, disk

<    1   2   3   4   5   6   7   8   9   10   >