-existant machine type. And while this was discussed here on the list as a
possible solution, I couldn't get the mips tests working, so I'm not sure it's
the right fix.
Glenn
Glenn Washburn (12):
grub-shell: Allow specifying non-default trim line contents
grub-shell: Trim line should always
needs the iso image created by grub-mkresue to boot the qemu instance, a
failure here should be considered fatal.
Signed-off-by: Glenn Washburn
---
tests/util/grub-shell.in | 17 +++--
1 file changed, 15 insertions(+), 2 deletions(-)
diff --git a/tests/util/grub-shell.in b/tests/util
When turning on shell tracing the trim line will be output before we
actually want to start the trim. However, in this case the trim line never
starts from the beginning of the line. So start trimming from the correct
line by matching from the beginning of the line.
Signed-off-by: Glenn Washburn
This allows seeing full qemu output of grub-shell, which can be invaluable
when debugging failing tests.
Signed-off-by: Glenn Washburn
---
tests/util/grub-shell.in | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/tests/util/grub-shell.in b/tests/util/grub-shell.in
This allows turning on shell tracing when its not practical or not possible
to use commandline arguments. Turn on tracing when the envvar is an integer
greater than 1, since these can log a lot of messages.
Signed-off-by: Glenn Washburn
---
tests/util/grub-fs-tester.in | 2 ++
tests/util/grub
Signed-off-by: Glenn Washburn
---
tests/util/grub-shell.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/util/grub-shell.in b/tests/util/grub-shell.in
index 9d8c417da..e80471126 100644
--- a/tests/util/grub-shell.in
+++ b/tests/util/grub-shell.in
@@ -211,7 +211,7
On Wed, 10 Nov 2021 14:47:07 +0100
Daniel Kiper wrote:
> CC-ing Glenn...
>
> On Tue, Oct 12, 2021 at 06:30:06PM +1100, Daniel Axtens wrote:
> > This is handy for debugging - I'm including it in case anyone else hacking
> > on this area finds it helpful.
> >
> > Signed-off-by: Daniel Axtens
> >
Signed-off-by: Glenn Washburn
---
scripts/ci/functions.sh | 899 +++-
1 file changed, 898 insertions(+), 1 deletion(-)
diff --git a/scripts/ci/functions.sh b/scripts/ci/functions.sh
index 2f4cecaa1..f94f90dc1 100644
--- a/scripts/ci/functions.sh
+++ b/scripts
Signed-off-by: Glenn Washburn
---
scripts/ci/functions.local.sh | 37 +
scripts/local-tester.sh | 39 +++
2 files changed, 76 insertions(+)
create mode 100644 scripts/ci/functions.local.sh
create mode 100755 scripts/local
d building/testing locally.
I'm not particularly in love with the name "local-tester.sh", so suggestions on
alternative names are welcome. The same goes for the output, which I think
could look better.
Glenn
Glenn Washburn (3):
scripts: Add general scripts to aid automated te
Signed-off-by: Glenn Washburn
---
scripts/ci/build.sh | 67
scripts/ci/functions.sh | 33 ++
scripts/ci/make-images.sh | 86 ++
scripts/ci/process-tests.sh | 111 +
scripts/ci/test.sh
On Fri, 22 Oct 2021 18:44:15 +0200
Daniel Kiper wrote:
> On Thu, Oct 21, 2021 at 12:49:19PM -0500, Glenn Washburn wrote:
> > The gnulib sources are large but more importantly have lots of changes. So
> > initial checkout of the repository can take a long time when network or
&g
These patches are pretty self explanatory. The first patch was requested by
Daniel and Daniel suggested the link to the INSTALL file from the git web
repo.
Glenn
Glenn Washburn (4):
docs: Add sentence on where Debian packages can be searched for online
docs: Update development docs
Use the Git Book as a reference for documentation on Git as no other link
was provided. Other links were broken because they used @url instead of
@uref and needed a comma separator between link and link text.
Signed-off-by: Glenn Washburn
---
docs/grub-dev.texi | 10 +-
1 file changed
Signed-off-by: Glenn Washburn
---
INSTALL | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/INSTALL b/INSTALL
index 38d8d5a4d..8a2b617f3 100644
--- a/INSTALL
+++ b/INSTALL
@@ -5,7 +5,8 @@ This is the GRUB. Welcome.
This file contains instructions for compiling
Add a section with minimal description on setting up and running the test
suite with a link to the INSTALL documentation which is a little more
detailed in terms of package requirements.
Signed-off-by: Glenn Washburn
---
docs/grub-dev.texi | 12
1 file changed, 12 insertions
Signed-off-by: Glenn Washburn
---
INSTALL | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/INSTALL b/INSTALL
index 8a2b617f3..a64f63723 100644
--- a/INSTALL
+++ b/INSTALL
@@ -90,6 +90,10 @@ Note that `make check' will run and many tests may complete
successfully
On Wed, 17 Nov 2021 18:29:36 +0100
Daniel Kiper wrote:
> On Tue, Oct 12, 2021 at 06:26:26PM -0500, Glenn Washburn wrote:
> > As an example, passing a password as a cryptomount argument is implemented.
>
> I am not very happy with that. Splitting this into separate patch or
>
On Wed, 17 Nov 2021 20:10:21 +0100
Daniel Kiper wrote:
> On Tue, Oct 12, 2021 at 06:26:27PM -0500, Glenn Washburn wrote:
> > The crypto device modules should only be setting up the crypto devices and
> > not getting user input. This has the added benefit of simpl
On Thu, 18 Nov 2021 15:06:56 +0100
Daniel Kiper wrote:
> On Tue, Oct 12, 2021 at 06:26:28PM -0500, Glenn Washburn wrote:
> > Signed-off-by: Glenn Washburn
> > ---
> > grub-core/disk/cryptodisk.c | 26 +-
> > grub-core/disk/geli.c | 9 ++
On Sun, 14 Nov 2021 10:56:15 +0100
Patrick Steinhardt wrote:
> On Tue, Oct 12, 2021 at 06:26:28PM -0500, Glenn Washburn wrote:
> > Signed-off-by: Glenn Washburn
> > ---
> > grub-core/disk/cryptodisk.c | 26 +-
> > grub-core/disk/geli.c
ted,
as desired.
Signed-off-by: Glenn Washburn
---
grub-core/disk/cryptodisk.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/grub-core/disk/cryptodisk.c b/grub-core/disk/cryptodisk.c
index 99265097a..2381c3330 100644
--- a/grub-core/disk/cryptodisk.c
+++ b/grub-core/d
This displays an error notifying the user that they'll want to load a
backend module to make cryptomount useful.
Signed-off-by: Glenn Washburn
---
grub-core/disk/cryptodisk.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/grub-core/disk/cryptodisk.c b/grub-core/disk/cryptodisk.c
index
-off-by: Glenn Washburn
---
grub-core/disk/cryptodisk.c | 31 +--
grub-core/disk/geli.c | 6 +-
grub-core/disk/luks.c | 7 ++-
grub-core/disk/luks2.c | 7 ++-
include/grub/cryptodisk.h | 9 -
5 files changed, 46 insertions
usable.
Signed-off-by: Glenn Washburn
---
docs/grub.texi | 9 --
grub-core/disk/cryptodisk.c | 56 +
grub-core/disk/geli.c | 26 -
grub-core/disk/luks.c | 27 +++---
grub-core/disk/luks2.c | 26
Note that cargs.search_uuid does not need to be initialized in various parts
of the cryptomount argument parsing, just once when cargs is declared with a
struct initializer. The previous code used a global variable which would
retain the value across cryptomount invocations.
Signed-off-by: Glenn
When a cryptmount is specified with a UUID, but no cryptodisk backends find
a disk with that UUID, return a more detailed message giving telling the
user that they might not have a needed cryptobackend module loaded.
Signed-off-by: Glenn Washburn
---
grub-core/disk/cryptodisk.c | 2 +-
1 file
Update such that "cryptomount -u UUID" will not print two error messages
when an invalid passphrase is given and the most relevant error message
will be displayed.
Signed-off-by: Glenn Washburn
---
grub-core/disk/cryptodisk.c | 21 +
1 file changed, 17 insert
Signed-off-by: Glenn Washburn
---
grub-core/disk/luks2.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/grub-core/disk/luks2.c b/grub-core/disk/luks2.c
index 371a53b83..fea196dd4 100644
--- a/grub-core/disk/luks2.c
+++ b/grub-core/disk/luks2.c
@@ -370,7 +370,10
le support (I already have
the series updated and ready to send once this is accepted). I also believe
tha this will somewhat simplify the patch series by James Bottomley in
passing secrets to the crypto backends.
Glenn
Glenn Washburn (9):
luks2: Add debug message to align with luks and ge
ng. The mount should silently
succeed in this case, which is what happens with this patch.
Signed-off-by: Glenn Washburn
---
grub-core/disk/cryptodisk.c | 56 +++--
1 file changed, 35 insertions(+), 21 deletions(-)
diff --git a/grub-core/disk/cryptodisk.c b/grub-co
On Tue, 7 Dec 2021 22:01:14 +0100
Michael Schierl wrote:
> Hello Glenn,
>
>
> Am 07.12.2021 um 10:17 schrieb Glenn Washburn:
>
> >> maybe move the conditional before the assignment of ret?
> >
> > I'm understanding you to be suggesting to mov
On Tue, 7 Dec 2021 23:07:32 +0100
Michael Schierl wrote:
>
> Hello Glenn,
>
>
> Am 07.12.2021 um 22:59 schrieb Glenn Washburn:
> > Yes, but I didn't want to assume that "all" is the first item in the
> > list.
>
> More important, "all" doe
On Thu, 9 Dec 2021 18:38:51 +0100
Josselin Poiret via Grub-devel wrote:
> Hello,
>
> These two draft patches make devmapper set up LUKS2 cryptomount
> properties when pulling, as well as report LUKS2 cryptomounts as
> having GRUB_DEV_ABSTRACTION_LUKS. This makes grub-probe and
> grub-install
The iso9660 tests test creating isos with different combinations of joliet,
rockridge, and iso9660 conformance level. Refactor xorriso argument
generation for more readability and extensibility.
Signed-off-by: Glenn Washburn
---
tests/util/grub-fs-tester.in | 43
Signed-off-by: Glenn Washburn
---
I've been wondering why my build has been strangely failing for the last
couple months and finally found the culprit. Quite an annoyance. I guess no
one else actually uses BUILD_LDFLAGS.
Glenn
---
configure.ac | 2 +-
1 file changed, 1 insertion(+), 1 deletion
On Wed, 8 Dec 2021 17:41:32 +0100
Daniel Kiper wrote:
> On Sat, Dec 04, 2021 at 01:15:46AM -0600, Glenn Washburn wrote:
> > Update such that "cryptomount -u UUID" will not print two error messages
> > when an invalid passphrase is given and the most relevant error mess
On Wed, 8 Dec 2021 17:37:19 +0100
Daniel Kiper wrote:
> On Sat, Dec 04, 2021 at 01:15:45AM -0600, Glenn Washburn wrote:
> > The global "have_it" was never used by the crypto-backends, but was used to
> > determine if a crypto-backend successfully mounted a cryptod
On Wed, 08 Dec 2021 09:11:07 +0100
"Thomas Schmitt" wrote:
> Hi,
>
> i think this change is beneficial for the maintainability of the test.
>
> But this sequence looks a bit confusing, albeit it is ok on the second
> glimpse:
>
> + XORRISO_ARGS="-as mkisofs
The iso9660 tests test creating isos with different combinations of joliet,
rockridge, and iso9660 conformance level. Refactor xorriso argument
generation for more readability and extensibility.
Signed-off-by: Glenn Washburn
---
Updates since v1:
* Reorder such that command line arguments
uot; to the
$debug variable will disable that conditional. To illustrate, the command
"set debug=all,-btrfs,-scripting,btrfs" will enable btrfs.
Also, add documentation explaining this new behavior.
Signed-off-by: Glenn Washburn
---
Changes since v2:
* Fix issue where a facility at the start of the
On Thu, 18 Nov 2021 15:25:44 +0100
Daniel Kiper wrote:
> On Tue, Oct 12, 2021 at 06:26:29PM -0500, Glenn Washburn wrote:
> > The member found_uuid was never used by the crypto-backends, but was used to
>
> Ha! Could you make this patch second in this patch series? Then we could
&
Hi Michael,
Thanks for taking a look at this.
On Mon, 6 Dec 2021 22:01:22 +0100
Michael Schierl wrote:
>
> Hello Glenn,
>
> Comments below, note that I did not test the patch so maybe I am missing
> something.
>
> Am 06.12.2021 um 18:03 schrieb Glenn Washburn:
>
receeded by a string of 2 tabs followed by 2 spaces.
Glenn
>
> El jue, 13 ene 2022 a las 5:08, Glenn Washburn
> () escribió:
> >
> > On Wed, 12 Jan 2022 23:54:58 +0100
> > Javier Moragon wrote:
> >
> > > According to https://www.ietf.org/rfc/rfc2616.txt 4.2,
On Fri, 14 Jan 2022 00:05:59 +0100
Jamo wrote:
> From: Javier Moragon
>
> I applied the last suggestion in this patch and I've finally realized
> how to use git send-email.
>
> I'm sorry for the unnecesary mails and I hope for next contributions
> I won't make the same mistakes, Thank you!
because the test is potentially compiled differently for each target.
Signed-off-by: Glenn Washburn
---
Makefile.am | 9 +++
Makefile.util.def| 164 +--
conf/Makefile.common | 4 ++
gentpl.py| 6 +-
4 files changed, 97
-native tests (skipping the native tests) by partitioning the set
of tests into native and non-native based on whether QEMU is used by the test.
The first patch is not necessary, but makes things look cleaner.
Phcoder, could you confirm that the logic above is sound?
Glenn
Glenn Washburn (2
at this point.
Glenn
Glenn Washburn (2):
util/resolve.c: Do not read past the end of the array in read_dep_list
util/resolve.c: Bail with error if moddep lst file line is too long
util/resolve.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
--
2.27.0
ectly fine,
the problem is in GRUB's parser. Check if we've hit a line longer than the
size of the buffer, and if so send a more correct and reasonable error.
Signed-off-by: Glenn Washburn
---
util/resolve.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/util/resolve.c b/util/resol
. Make
sure that 'p' is inside 'buf' before dereferencing it.
Signed-off-by: Glenn Washburn
---
util/resolve.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/util/resolve.c b/util/resolve.c
index 3e887d2ff..5e9afa10c 100644
--- a/util/resolve.c
+++ b/util/resolve.c
@@ -102,7
error
and where the test suite succeeds. So I believe these patches are allowing
a usable build. Under normal conditions, these changes should be superflous
and thus not affect the build process.
Glenn
Glenn Washburn (2):
gentpl.py: Fix issue where sometimes marker files have CPP defines
Makefile
modules are selected.
Signed-off-by: Glenn Washburn
---
gentpl.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gentpl.py b/gentpl.py
index 28ec24209..9f51e4fb6 100644
--- a/gentpl.py
+++ b/gentpl.py
@@ -700,7 +700,7 @@ def module(defn, platform):
output(""&qu
I believe the patches are fairly self explantatory.
Glenn
Glenn Washburn (5):
tests: Do not remove image file on error in pata_test
tests: Skip pata_test on i386-efi
tests: Remove $((BASE#NUM)) bashism in grub-fs-tester
tests: Ensure that mountpoints are unmounted before exiting
tests
In comparison to other i386 targets, on i386-efi the Q35 QEMU machine type
is used to do the testing to be able to make use of the EFI firmware in
QEMU. On the Q35 machine type there is no way to use ATA to communicate with
an IDE, only AHCI.
Signed-off-by: Glenn Washburn
---
tests/pata_test.in
on exit or process interruption that will umount all mounts that haven't
already been unmounted.
Signed-off-by: Glenn Washburn
---
tests/util/grub-fs-tester.in | 30 +++---
1 file changed, 27 insertions(+), 3 deletions(-)
diff --git a/tests/util/grub-fs-tester.in b/tests/util
Signed-off-by: Glenn Washburn
---
conf/Makefile.common | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/conf/Makefile.common b/conf/Makefile.common
index 2a1a886f6..f0bb6e160 100644
--- a/conf/Makefile.common
+++ b/conf/Makefile.common
@@ -102,24 +102,24
fini (void);
| ^~~
...
When generating libgrub_a_init.lst only lines starting with "@MARKER@" are
desired.
Signed-off-by: Glenn Washburn
---
Makefile.am | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Makefile.am b/Makefile.am
index 10faf670b..81a196cdc 100644
---
This bashism allows converting NUM in base BASE to decimal. Its not needed
because the only place its used is to convert from hexidecimal and this can
also be done with the more portable $((0xHEXNUM)) syntax.
Signed-off-by: Glenn Washburn
---
tests/util/grub-fs-tester.in | 10 +-
1 file
The image file can be useful in debugging an issue when the test fails.
Signed-off-by: Glenn Washburn
---
tests/pata_test.in | 1 -
1 file changed, 1 deletion(-)
diff --git a/tests/pata_test.in b/tests/pata_test.in
index 4fee0b0fb..27dccec19 100644
--- a/tests/pata_test.in
+++ b/tests
code
to delete all loopback devices setup during the test run will never be able
to finish because the loopback device can not be deleted while in use.
Signed-off-by: Glenn Washburn
---
tests/util/grub-fs-tester.in | 23 ---
1 file changed, 20 insertions(+), 3 deletions(-)
diff
On Wed, 12 Jan 2022 23:54:58 +0100
Javier Moragon wrote:
> According to https://www.ietf.org/rfc/rfc2616.txt 4.2, header names
> shall be case insensitive and we are now forced to read headers like
> `Content-Length` capitalized.
>
> The problem with that is when a HTTP server responds with a
>
On Mon, 7 Feb 2022 10:29:44 -0500
James Bottomley wrote:
> This module is designed to provide an efisecret provider which
> interrogates the EFI configuration table to find the location of the
> confidential computing secret and tries to register the secret with
> the cryptodisk.
>
> The
On Mon, 7 Feb 2022 10:29:43 -0500
James Bottomley wrote:
> Make use of the new OS provided secrets API so that if the new '-s'
> option is passed in we try to extract the secret from the API rather
> than prompting for it.
>
> The primary consumer of this is AMD SEV, which has been programmed
startup code depending on if the target uses static or
dynamic loading. This is complicated by the fact that a subshell is used to
check the autoconf variable and shells return 0 for success, but 0 is false
in conditionals in GDB. So an inversion of the status code is needed.
Signed-off-by: Glenn
up to the user to determine how to get the test and data
addresses.
Signed-off-by: Glenn Washburn
---
grub-core/gdb_grub.in | 54 +++
1 file changed, 54 insertions(+)
diff --git a/grub-core/gdb_grub.in b/grub-core/gdb_grub.in
index dd1e86bf2..f3c6faf94
is a custom command defined in the gdb_grub GDB script. So GDB
should be started with the script as an argument to the -x option or
sourced into an active GDB session before running the outputted command.
Co-developed-by: Peter Jones
Signed-off-by: Glenn Washburn
---
config.h.in
This prevents load_all_modules from failing when called before any modules
have been loaded. Failures in GDB user-defined functions cause any function
which called them to also fail.
Signed-off-by: Glenn Washburn
---
grub-core/gdb_grub.in | 4 +++-
1 file changed, 3 insertions(+), 1 deletion
h.
Glenn
[1] https://lists.gnu.org/archive/html/grub-devel/2021-11/msg8.html
[2] https://lists.gnu.org/archive/html/grub-devel/2011-11/msg00069.html
Glenn Washburn (8):
gdb: Move runtime module loading into runtime_load_module
gdb: If no modules have been loaded, do not try to load module symbol
Signed-off-by: Glenn Washburn
---
grub-core/gdb_grub.in | 20 +---
1 file changed, 13 insertions(+), 7 deletions(-)
diff --git a/grub-core/gdb_grub.in b/grub-core/gdb_grub.in
index e322d3dc1..b0e8d1ed1 100644
--- a/grub-core/gdb_grub.in
+++ b/grub-core/gdb_grub.in
@@ -70,16
causing gmodule.pl to write a bad .loadsym.gdb that GDB chokes on.
Signed-off-by: Glenn Washburn
---
grub-core/gmodule.pl.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/grub-core/gmodule.pl.in b/grub-core/gmodule.pl.in
index 78aa1e64e..c74eedf4a 100644
--- a/grub-core
GDB logging is redirected to write .segments.tmp, which means that GDB will
wrap lines longer than what it thinks is the screen width (typically 80
characters). When wrapping does occur it causes gmodule.pl to misbehave. So
disable line wrapping.
Signed-off-by: Glenn Washburn
---
grub-core
, grub_dl_add()
will have finished setting up it stack frame. But at this point we will be
in grub_dl_get()'s stack frame. So go one frame up, which will be
grub_dl_add(), to get mod's value.
Signed-off-by: Glenn Washburn
---
grub-core/gdb_grub.in | 11 ++-
1 file changed, 10 insertions(+), 1
this feature in
a very long time (and is not currently using it).
Glenn
Glenn Washburn (3):
configure: Properly handle MM_DEBUG
mm: Export grub_mm_dump and grub_mm_dump_free
mm: Temporarily disable grub_mm_debug while calling grub_vprintf in
grub_printf
config.h.in | 4
To prevent infinite recursion when grub_mm_debug is on, disable it when
calling grub_vprintf. One such call loop is:
grub_vprintf -> parse_printf_args -> parse_printf_arg_fmt
-> grub_debug_calloc -> grub_printf -> grub_vprintf
Signed-off-by: Glenn Washburn
---
grub-core/k
On Fri, 4 Mar 2022 18:01:10 -0600
Glenn Washburn wrote:
> On Wed, 2 Mar 2022 14:08:23 -0500
> Robbie Harwood wrote:
>
> > Changes this version:
> >
> > - Reorder last two commits so that warning fixes come after the change that
> > introduces them.
>
On Thu, 03 Mar 2022 13:47:29 -0500
Robbie Harwood wrote:
> Glenn Washburn writes:
>
> > Robbie Harwood wrote:
> >
> >> If you have a patch that makes this work, I don't have a problem with
> >> it. However, I was unable to make that work in practice.
&g
On Wed, 2 Mar 2022 14:08:23 -0500
Robbie Harwood wrote:
> Changes this version:
>
> - Reorder last two commits so that warning fixes come after the change that
> introduces them.
> - Fix comment formatting to comply with grub2 style.
Either I missed it before or something changed. But I'm
fixed for the %m format code in commit 2e246b6f.
Signed-off-by: Glenn Washburn
---
po/arabic.sed | 3 ++-
po/cyrillic.sed | 3 ++-
po/greek.sed| 3 ++-
po/hebrew.sed | 3 ++-
4 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/po/arabic.sed b/po/arabic.sed
index 21dc8b6db2
On Fri, 11 Mar 2022 00:35:57 +0100
Daniel Kiper wrote:
> Latest GCC may complain in that way:
>
> commands/i386/pc/sendkey.c: In function ‘grub_sendkey_postboot’:
> commands/i386/pc/sendkey.c:223:21: error: writing 1 byte into a region of
> size 0 [-Werror=stringop-overflow=]
> 223 |
will fail on an unknown format code. This is essentially the same
issue fixed for the %m format code in commit 2e246b6f (po: Fix replacement
of %m in sed programs).
Also reorder transliteration lines to be more lexographically ordered.
Signed-off-by: Glenn Washburn
---
po/arabic.sed | 3 ++-
po
On Wed, 9 Mar 2022 17:10:01 +0100
Daniel Kiper wrote:
> On Mon, Mar 07, 2022 at 12:15:36PM -0600, Glenn Washburn wrote:
> > Commit 45bffae13 uses the %zu format specifier which has not been used in
>
> If you mention a commit please use the following format:
> commit 45bff
On Wed, 9 Mar 2022 16:42:43 +0100
Daniel Kiper wrote:
> On Mon, Mar 07, 2022 at 02:15:49AM -0600, Glenn Washburn wrote:
> > On Fri, 4 Mar 2022 18:01:10 -0600
> > Glenn Washburn wrote:
> >
> > > On Wed, 2 Mar 2022 14:08:23 -0500
> > > Robbie Harwood wr
On Wed, 9 Mar 2022 16:49:57 +0100
Daniel Kiper wrote:
> On Wed, Mar 02, 2022 at 06:25:12PM -0600, Glenn Washburn wrote:
> > Add linker flags when linking kernel.exec to have malloc and free point to
> > grub_malloc and grub_free respectively. Some gdb functionality depends on
&
Signed-off-by: Glenn Washburn
---
grub-core/net/net.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/grub-core/net/net.c b/grub-core/net/net.c
index 4d3eb5c1a5..563dea9ec8 100644
--- a/grub-core/net/net.c
+++ b/grub-core/net/net.c
@@ -1948,5 +1948,5 @@ GRUB_MOD_FINI(net
milliseconds call and then I had to step out back into GRUB which could be
a hundred or more instructions. This reduces the probability that interrupting
GRUB lands in the firmware when GRUB is blocked waiting on a keypress.
Glenn
Glenn Washburn (3):
net: Unset grub_net_poll_cards_idle when net
In grub_net_poll_cards_idle_real, only call grub_net_tcp_retransmit if there
are network cards found. If there are no network card found, there can be no
tcp sockets to transmit on.
Signed-off-by: Glenn Washburn
---
grub-core/net/net.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion
If there are no TCP sockets, this call to grub_get_time_ms is unneeded. This
prevents a call into the firmware on some platforms.
Signed-off-by: Glenn Washburn
---
grub-core/net/tcp.c | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/grub-core/net/tcp.c b/grub-core
On Tue, 22 Feb 2022 19:03:39 +0100
Daniel Kiper wrote:
> On Tue, Feb 15, 2022 at 12:36:42PM -0600, Glenn Washburn wrote:
> > These functions may be useful within modules as well. Export them so that
> > modules can use them.
>
> Though there are no users for these func
Signed-off-by: Glenn Washburn
---
tests/util/grub-fs-tester.in | 246 +--
1 file changed, 123 insertions(+), 123 deletions(-)
diff --git a/tests/util/grub-fs-tester.in b/tests/util/grub-fs-tester.in
index a1f3f299b4..65633c7f81 100644
--- a/tests/util/grub-fs
On Tue, 22 Feb 2022 14:49:39 +0100
Daniel Kiper wrote:
> On Tue, Feb 15, 2022 at 12:44:44PM -0600, Glenn Washburn wrote:
> > Signed-off-by: Glenn Washburn
> > ---
> > Daniel,
> >
> > I think I recall you saying you accumulate whitespace fixes. So her
Finally getting back to this...
On Thu, 17 Feb 2022 17:18:47 -0500
James Bottomley wrote:
> On Mon, 2022-02-14 at 16:18 -0600, Glenn Washburn wrote:
> > On Mon, 7 Feb 2022 10:29:43 -0500
> > James Bottomley wrote:
> >
> > > Make use of the new OS provided secr
On Mon, 28 Feb 2022 21:48:35 +0100
Elyes Haouas wrote:
> The value stored to 'ptrdest' is never read
>
> Signed-off-by: Elyes Haouas
> ---
> grub-core/loader/i386/multiboot_mbi.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/grub-core/loader/i386/multiboot_mbi.c
>
These functions may be useful within modules as well. Export them so that
modules can use them.
Signed-off-by: Glenn Washburn
---
include/grub/mm.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/grub/mm.h b/include/grub/mm.h
index 9c38dd3ca5..44fde7cb90 100644
Signed-off-by: Glenn Washburn
---
Daniel,
I think I recall you saying you accumulate whitespace fixes. So here's a
patch to add to those, if so. Otherwise, the commit message could probably
be a little better,so feel free to modify as desired.
Glenn
---
tests/util/grub-fs-tester.in | 246
On Tue, 15 Feb 2022 14:07:15 +0100
Renaud Métrich wrote:
> Please ignore, deprecated by "efi: new 'connectefi' command" (v3).
I'm not sure what was eactly wrong with v3 (haven't looked at the
difference). However, v3 was done better in some regards. On this list
it is customary to have
be enabled.
Signed-off-by: Glenn Washburn
---
config.h.in | 4
configure.ac | 6 --
2 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/config.h.in b/config.h.in
index 9e8f9911b1..c1323a88e3 100644
--- a/config.h.in
+++ b/config.h.in
@@ -9,6 +9,10 @@
#define GCRYPT_NO_DEPRECATED 1
On Thu, 17 Feb 2022 21:48:58 +0800
Qiumiao Zhang via Grub-devel wrote:
> During UEFI PXE boot in IPv6 network, if the DHCP server adopts stateful
> automatic
> configuration, when the client receives the ICMP6_ROUTER_ADVERTISE message
> multicast
> from the server, it will cause the problem of
On Wed, 2 Mar 2022 18:00:11 +0100
Daniel Kiper wrote:
> On Thu, Feb 24, 2022 at 01:37:19PM -0500, Robbie Harwood wrote:
> > Originally added in db7337a3d353a817ffe9eb4a3702120527100be9, this
> > patched out all relevant invocations of abort() in gnulib. While it was
> > not documented why at
On Thu, 03 Mar 2022 11:58:11 -0500
Robbie Harwood wrote:
> Glenn Washburn writes:
>
> > On Wed, 2 Mar 2022 14:08:27 -0500
> > Robbie Harwood wrote:
> >
> >> Originally added in db7337a3d353a817ffe9eb4a3702120527100be9, this
> >> patched out all
On Wed, 2 Mar 2022 14:08:27 -0500
Robbie Harwood wrote:
> Originally added in db7337a3d353a817ffe9eb4a3702120527100be9, this
> patched out all relevant invocations of abort() in gnulib. While it was
> not documented why at the time, testing suggests that there's no abort()
> implementation
601 - 700 of 1383 matches
Mail list logo
