[PATCH 1/2] multiboot: Allow running autogen.sh

Current gnulib's gnulib-tool only runs if configure.ac contains AC_PREREQ(2.63). As Autoconf 2.63 has been released in 2008-09, this should not affect too many systems in 2020. Signed-off-by: Hans Ulrich Niedermann --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH 2/2] multiboot: Use .gitignore files

Add /.gitignore file and remove the /.bzrignore file. The /doc/.gitignore file is generated by gnulib-tool so we keep that file in addition to the top-level /.gitignore file which covers everything else in subdirectories as well. Signed-off-by: Hans Ulrich Niedermann --- .bzrignore | 30

[PATCH v2 2/3] multiboot2: Use .gitignore files

Add /.gitignore file and remove the /.bzrignore file. The /doc/.gitignore file is generated by gnulib-tool so we keep that file in addition to the top-level /.gitignore file which covers everything else in subdirectories as well. Signed-off-by: Hans Ulrich Niedermann --- .bzrignore | 30

[PATCH 2/3] multiboot2: Use .gitignore files

Add /.gitignore file and remove the /.bzrignore file. The /doc/.gitignore file is generated by gnulib-tool so we keep that file in addition to the top-level /.gitignore file which covers everything else in subdirectories as well. Signed-off-by: Hans Ulrich Niedermann --- .bzrignore | 30

[PATCH 3/3] multiboot2: Make example kernel build at least for i386

Document both boot_i386.S and boot_mips.S, and build at least boot_i386.S. Building a mips kernel if a mips compiler is actually available still needs some work. Signed-off-by: Hans Ulrich Niedermann --- .gitignore | 2 ++ configure.ac| 29

[PATCH] docs: Fix numerous minor mistakes in grub.info

. Signed-off-by: Hans Ulrich Niedermann --- docs/grub.texi | 66 +- 1 file changed, 33 insertions(+), 33 deletions(-) diff --git a/docs/grub.texi b/docs/grub.texi index 8e6f9acec..409619fb2 100644 --- a/docs/grub.texi +++ b/docs/grub.texi

[PATCH 0/1] docs: Fix numerous minor mistakes in grub.info

This patch does not change the intended meaning of the text and only touches about the first 1300 of about 7000 lines in docs/grub.texi. If there is interest in picking up this patch, I intend to read through the rest of grub.texi as well to find more of these easy fixes while adding remarks for

[PATCH 1/3] multiboot2: Allow running autogen.sh

Current gnulib's gnulib-tool only runs if configure.ac contains AC_PREREQ(2.63). As Autoconf 2.63 has been released in 2008-09, this should not affect too many systems in 2020. Signed-off-by: Hans Ulrich Niedermann --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [PATCH 0/1] docs: Fix numerous minor mistakes in grub.info

On Thu, 16 Apr 2020 16:27:02 +0200 Daniel Kiper wrote: > On Thu, Apr 16, 2020 at 03:03:43PM +0200, Hans Ulrich Niedermann > wrote: > > This patch does not change the intended meaning of the text > > and only touches about the first 1300 of about 7000 lines >

119 grub commands not documented in grub.texi

Hi, I have noticed that there are two commands documented in grub.texi which appear not to occur anywhere within the grub source code: 'pxe_unload' and 'uppermem'. @node pxe_unload @subsection pxe_unload @deffn Command pxe_unload Unload the PXE environment (@pxref{Network}).

[PATCH 3/3 v3] docs: Remove docs for non-existing uppermem command

the paragraph describing how GRUB's uppermem command was supposed to complement the Linux kernel's mem= parameter. Signed-off-by: Hans Ulrich Niedermann --- docs/grub.texi | 13 - 1 file changed, 13 deletions(-) diff --git a/docs/grub.texi b/docs/grub.texi index 0f7886bb6..d51ad0e25 100644

[PATCH 1/3 v3] docs: Add grub command documentation checks

(tested with Python 2.7 and Python 3.7) The docs/check-commands.py script runs fast enough to not perceivably slow down a "make" on the grub source tree. The script basically reads and more or less greps through docs/grub.texi and all *.c source files, and that happens very quickly. Sign

[PATCH 2/3 v3] docs: Remove docs for non-existing pxe_unload command

Remove the documentation of the pxe_unload command from the docs/grub.texi file. The pxe_unload command is not implemented in the grub source at this time at all. It appears to have been removed in commit 71a78acb0648d3d73c95ab0f021f907499aacc0 (from 2011-07-05). Signed-off-by: Hans Ulrich

[PATCH 0/3 v3] docs: Document list of undocumented commands

comments to the check-commands.py script * Use more descriptive variable names in check-commands.py * If a command is mentioned somewhere in grub.texi, we now add a remark about that to the autogenerated "this command is undocumented" documentation stub. Hans Ulrich Nie

How to submit patches and patchsets via grub-devel

Hello, as I am continuing to flood this mailing list with patches, I am realizing that I am missing some general rules for how things work on grub-devel. Sorry for the inconvenience caused by that. Anyway, here are a few questions I am beginning realize I should know the answers to before

Re: [PATCH v2] tests: Don't run f2fs test on systems with PAGE_SIZE more than 4096 bytes

On Wed, 29 Apr 2020 17:06:36 +0300 Anatoly Pugachev wrote: > Don't run f2fs test on systems with PAGE_SIZE > 4096 bytes, since > f2fs is not supported on these systems and trying to mount a f2fs > filesystem would fail. "Skip the f2fs test on ..." might be better wording, both in this paragraph

[PATCH 4/5 v2] gitignore: Add leading slashes where appropriate

everywhere, so those definitively need no leading slash. For some patterns like "contrib" or "ascii.bitmaps", it is unclear where in the source tree they should match. Those patterns are kept as they are, matching the patterns in the whole tree of subdirectories. Signed-off-by:

[PATCH 5/5 v2] gitignore: Add a few forgotten file patterns

Add a few patterns to .gitignore to cover files which are generated by building grub ("make", "make check", "make dist") but which have been forgotten to add to .gitignore in the past. Signed-off-by: Hans Ulrich Niedermann --- .gitignore | 32 ++

[PATCH 2/5 v2] gitignore: Group patterns with and without slash

-by: Hans Ulrich Niedermann --- .gitignore | 81 -- 1 file changed, 42 insertions(+), 39 deletions(-) diff --git a/.gitignore b/.gitignore index 8908a2131..01c1ec538 100644 --- a/.gitignore +++ b/.gitignore @@ -1,3 +1,4 @@ +# Ignore patterns

[PATCH 3/5 v2] gitignore: Sort both pattern groups alphabetically

Alphabetically sort the two groups of gitignore patterns: * The group of patterns without slashes, matching anywhere in the directory subtree. * The group of patterns with slashes, matching relative to the .gitignore file's directory Signed-off-by: Hans Ulrich Niedermann

[PATCH 1/5 v2] gitignore: Consistent leading slash is easier to read

As all gitignore patterns containing a left or middle slash match only relative to the .gitignore file's directory, we write them all in the same manner with a leading slash. This makes the file significantly easier to read. Signed-off-by: Hans Ulrich Niedermann --- .gitignore | 88

[PATCH 0/5 v2] gitignore: Clean up most of the gitignore mess

ntion the two pattern groups in the same order as they appear inside the .gitignore file. None of that is a catastrophe which cannot be fixed later, but as there have not been an pushes of v1 yet, you might as well push v2. Hans Ulrich Niedermann (5): gitignore: Consistent leading slash is ea

Re: [PATCH v2] tests: Don't run f2fs test on systems with PAGE_SIZE more than 4096 bytes

On Wed, 29 Apr 2020 19:25:57 +0200 Hans Ulrich Niedermann wrote: > On Wed, 29 Apr 2020 17:06:36 +0300 > Anatoly Pugachev wrote: > > > Don't run f2fs test on systems with PAGE_SIZE > 4096 bytes, since > > f2fs is not supported on these systems and trying to mount a f

Re: [PATCH] gitignore: Add a few forgotten files

On Wed, 22 Apr 2020 21:54:14 +0200 John Paul Adrian Glaubitz wrote: > On 4/22/20 9:44 PM, Hans Ulrich Niedermann wrote: > > Signed-off-by: Hans Ulrich Niedermann > > --- > > .gitignore | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --

[PATCH 3/5] gitignore: Consistent leading slash is easier to read

As all gitignore patterns containing a left or middle slash match only relative to the .gitignore file's directory, we write them all in the same manner with a leading slash. This makes the file significantly easier to read. Signed-off-by: Hans Ulrich Niedermann --- .gitignore | 88

[PATCH 2/5] gitignore: Sort both pattern groups alphabetically

Alphabetically sort the two groups of gitignore patterns: * The group of patterns with slashes, matching relative to the .gitignore file's directory * The group of patterns without slashes, matching anywhere in the directory subtree. Signed-off-by: Hans Ulrich Niedermann

[PATCH 1/5] gitignore: Group patterns with and without slash

-by: Hans Ulrich Niedermann --- .gitignore | 81 -- 1 file changed, 42 insertions(+), 39 deletions(-) diff --git a/.gitignore b/.gitignore index 819cd185d..87280ba24 100644 --- a/.gitignore +++ b/.gitignore @@ -1,3 +1,4 @@ +# Ignore patterns

[PATCH 0/5] gitignore: Clean up most of the gitignore mess

. Some of the remaining no-slash patterns (i.e. those matching anywhere in the directory tree) might work with a leading slash, but I could not research all of them (especially for old code and optionally built files), so I have left those for now. Hans Ulrich Niedermann (5): gitignore: Group

[PATCH 5/5] gitignore: Add a few forgotten file patterns

Add a few patterns to .gitignore to cover files which are generated by building grub ("make", "make check", "make dist") but which have been forgotten in the past. Signed-off-by: Hans Ulrich Niedermann --- .gitignore | 33 + 1 file c

[PATCH 4/5] gitignore: Add leading slashes where appropriate

or ascii.bitmaps, it is unclear where in the source tree they should match. Those patterns are kept as they are, matching the patterns in the whole tree of subdirectories. Signed-off-by: Hans Ulrich Niedermann --- .gitignore | 234 ++--- 1 file changed, 117

[PATCH 1/3 v2] docs: Add grub command documentation checks

ten to run on Python 2 and 3 (tested with Python 2.7 and Python 3.7) The time docs/check-commands.py needs to read and basically grep through docs/grub.texi and all *.c source files is quick enough to not significantly slow down a "make" on the grub source tree. Signed-off-by: Hans Ul

Re: 119 grub commands not documented in grub.texi

On Wed, 22 Apr 2020 12:10:31 +0200 Daniel Kiper wrote: > On Sat, Apr 18, 2020 at 12:53:12PM +0200, Hans Ulrich Niedermann > wrote: > > I have noticed that there are two commands documented in grub.texi > > which appear not to occur anywhere within the grub source cod

[PATCH 2/3] docs: Remove docs for non-existing pxe_unload command

Remove the documentation for the pxe_unload command from the docs/grub.texi file. The pxe_unload command is not implemented in the grub source at all and appears to have been removed in commit 71a78acb0648d3d73c95ab0f021f907499aacc0 (from 2011-07-05). Signed-off-by: Hans Ulrich Niedermann

[PATCH 1/3] docs: Add grub command documentation checks

ten to run on Python 2 and 3 (tested with Python 2.7 and Python 3.7) The time docs/check-commands.py needs to read and basically grep through docs/grub.texi and all *.c source files is quick enough to not significantly slow down a "make" on the grub source tree. Signed-off-by: Hans Ul

[PATCH] gitignore: Add a few forgotten files

Add a few forgotten files to .gitignore which are generated when building grub: /30_uefi-firmware /ChangeLog /docs/*.info-* Signed-off-by: Hans Ulrich Niedermann --- .gitignore | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.gitignore b/.gitignore index 819cd185d..149b3713a

Re: [PATCH 1/3 v3] docs: Add grub command documentation checks

On Fri, 24 Apr 2020 15:50:54 +0200 Hans Ulrich Niedermann wrote: > This adds the docs/check-commands.py script which checks whether > grub commands implemented in the git source tree are documented > in docs/grub.texi and vice versa. > > During a standard "make" com

[PATCH v4 2/3] docs: Remove docs for non-existing pxe_unload command

Remove the documentation of the pxe_unload command from the docs/grub.texi file. The pxe_unload command is not implemented in the grub source at this time at all. It appears to have been removed in commit 71a78acb0648d3d73c95ab0f021f907499aacc0 (from 2011-07-05). Signed-off-by: Hans Ulrich

[PATCH v4 1/3] docs: Add grub command documentation checks

reps through docs/grub.texi and all *.c source files, and that happens very quickly. Signed-off-by: Hans Ulrich Niedermann create mode 100644 docs/check-commands.py diff --git a/.gitignore b/.gitignore index aa180fa89..b7a853b90 100644 --- a/.gitignore +++ b/.gitignore @@ -96,6 +96,7 @@ wid

[PATCH v4 0/3] docs: Document list of undocumented commands

pattern for the file it generates. Hans Ulrich Niedermann (3): docs: Add grub command documentation checks docs: Remove docs for non-existing pxe_unload command docs: Remove docs for non-existing uppermem command .gitignore | 1 + docs/Makefile.am | 18 +++- docs/check

[PATCH v4 3/3] docs: Remove docs for non-existing uppermem command

the paragraph describing how GRUB's uppermem command was supposed to complement the Linux kernel's mem= parameter. Signed-off-by: Hans Ulrich Niedermann diff --git a/docs/grub.texi b/docs/grub.texi index 0f7886bb6..d51ad0e25 100644 --- a/docs/grub.texi +++ b/docs/grub.texi @@ -1114,12 +1114,6

Re: [MULTIBOOT2 SPEC PATCH v3 2/4] multiboot2: Use .gitignore files

On Wed, 13 May 2020 18:21:11 +0200 Daniel Kiper wrote: > On Fri, May 08, 2020 at 06:50:47AM +0200, Hans Ulrich Niedermann > wrote: [... lots of gitignore stuff again ... ] > > +/doc/mdate-sh > > +/doc/texinfo.tex > > +/install-sh > > +/INSTALL > > +/missing

Re: [MULTIBOOT2 SPEC PATCH v3 2/4] multiboot2: Use .gitignore files

On Wed, 13 May 2020 18:21:11 +0200 Daniel Kiper wrote: > On Fri, May 08, 2020 at 06:50:47AM +0200, Hans Ulrich Niedermann > wrote: > > Add .gitignore file and remove the obsolete .bzrignore file. > > > > The doc/.gitignore file is generated by gnulib-tool so we keep &

Re: [MULTIBOOT2 SPEC PATCH v4 23/27] multiboot2: Generate per object file listings

ould either comment out those parameter additions, or guard them with a check for adhlns support and an AM_CONDITIONAL in configure.ac. Am 15. Mai 2020 05:43:46 MESZ schrieb Hans Ulrich Niedermann : >Generate one listing file *.lst per object file *.o. > >This allows easy examination

Re: [MULTIBOOT2 SPEC PATCH v3 2/4] multiboot2: Use .gitignore files

On Wed, 13 May 2020 23:11:03 +0200 Hans Ulrich Niedermann wrote: > On Wed, 13 May 2020 18:21:11 +0200 > Daniel Kiper wrote: > > > On Fri, May 08, 2020 at 06:50:47AM +0200, Hans Ulrich Niedermann > > wrote: > > > Add .gitignore file and remove the obsolete .bzrig

Re: [MULTIBOOT2 SPEC PATCH v3 3/4] multiboot2: Make example kernel build at least for i386

On Wed, 13 May 2020 18:24:28 +0200 Daniel Kiper wrote: > On Fri, May 08, 2020 at 06:50:48AM +0200, Hans Ulrich Niedermann > wrote: > > The example kernel has assembly language boot code for both > > i386 and mips, but the mips assembly code used to be built > > unconditio

[PATCH] docs: Fix build dependency for grub-dev.info

The grub-dev.info target depends on fdl.texi just like grub.info does, so grub-dev.info also requires the definition of that dependency in grub_dev_TEXINFOS just as grub_TEXINFOS provides for grub.info. Signed-off-by: Hans Ulrich Niedermann diff --git a/docs/Makefile.am b/docs/Makefile.am index

[MULTIBOOT2 SPEC PATCH v4 02/27] multiboot2: Use .gitignore files

there. All other ignore patterns should be in the top-level .gitignore file. Signed-off-by: Hans Ulrich Niedermann delete mode 100644 .bzrignore create mode 100644 .gitignore create mode 100644 doc/.gitignore diff --git a/.bzrignore b/.bzrignore deleted file mode 100644 index fda459816

[MULTIBOOT2 SPEC PATCH v4 05/27] multiboot2: Remove CCAS workarounds for pre-2005 Automake

n which we already require. Signed-off-by: Hans Ulrich Niedermann diff --git a/configure.ac b/configure.ac index 5b5c84d1e..37b220d0c 100644 --- a/configure.ac +++ b/configure.ac @@ -16,7 +16,7 @@ AC_PREREQ([2.63]) AC_INIT([Multiboot], [2.0], [bug-g...@gnu.org]) AC_CONFIG_SRCDIR([doc/mult

[MULTIBOOT2 SPEC PATCH v4 03/27] multiboot2: Use m4 quoting and AS_HELP_STRING

Use proper m4 quoting throughout configure.ac and use AS_HELP_STRING for the --enable-example-kernel argument. Signed-off-by: Hans Ulrich Niedermann diff --git a/configure.ac b/configure.ac index 8f21b1852..5bfc0ee5b 100644 --- a/configure.ac +++ b/configure.ac @@ -12,7 +12,7 @@ dnl

[MULTIBOOT2 SPEC PATCH v4 08/27] multiboot2: Automake cleans built programs automatically

The "CLEANFILES = $(noinst_PROGRAMS)" definition is from 2001-01, and Automake has learned to clean up generated files automatically since, so we can remove this. Signed-off-by: Hans Ulrich Niedermann diff --git a/doc/Makefile.am b/doc/Makefile.am index a65b452cf..dc7816d9f 100644

[MULTIBOOT2 SPEC PATCH v4 07/27] multiboot2: Automake generates dependencies automatically

is useless anyway. Signed-off-by: Hans Ulrich Niedermann diff --git a/doc/Makefile.am b/doc/Makefile.am index 2a5afd95d..a65b452cf 100644 --- a/doc/Makefile.am +++ b/doc/Makefile.am @@ -13,8 +13,6 @@ kernel_SOURCES = $(EXAMPLES) kernel_CFLAGS = -fno-builtin -nostdinc -O -g -Wall \ -imacros

[MULTIBOOT2 SPEC PATCH v4 04/27] multiboot2: Remove obsolete compat code for ancient Autoconf

The remark about "older versions of Autoconf" was added in 2001. We already AC_PREREQ(2.63) which is from 2008, so we need not worry about pre-2008 versions of Autoconf, much less about pre-2001 versions. Signed-off-by: Hans Ulrich Niedermann diff --git a/configure.ac b/configur

[MULTIBOOT2 SPEC PATCH v4 00/27] multiboot2: Clean up the example kernel

: * improved .gitignore * fix the case logic for the ix86 matching pattern ([[]]) * fix mb2 header tag alignment * fix alignment on mips Hans Ulrich Niedermann (27): multiboot2: Allow autogen.sh to run with current gnulib multiboot2: Use .gitignore files multiboot2: Use m4 quoting and A

[MULTIBOOT2 SPEC PATCH v4 16/27] multiboot2: Change "Multiboot" in comments to "Multiboot2"

d no comments at all. Signed-off-by: Hans Ulrich Niedermann diff --git a/doc/boot_i386.S b/doc/boot_i386.S index c6e7f1382..20a600a6e 100644 --- a/doc/boot_i386.S +++ b/doc/boot_i386.S @@ -38,7 +38,7 @@ _start: /* Align 64 bits boundary. */ .balign 8 -

[MULTIBOOT2 SPEC PATCH v4 12/27] multiboot2: Add boot_mips.S example code to docs

Ulrich Niedermann diff --git a/doc/Makefile.am b/doc/Makefile.am index e88f4d271..08fdbf342 100644 --- a/doc/Makefile.am +++ b/doc/Makefile.am @@ -1,6 +1,6 @@ info_TEXINFOS = multiboot.texi arch_sources = boot_i386.S boot_mips.S -multiboot_TEXINFOS = boot_i386.S.texi kernel.c.texi multiboot2.h.texi

[MULTIBOOT2 SPEC PATCH v4 14/27] multiboot2: Fix example kernel header tag alignment

e a listing file which shows the offsets of the labels in the boot_*.S files to verify the alignment issues. Note also that you cannot detect the wrong header tag alignment using the "grub-file --is-x86-multiboot2" utility. It only considers the Multiboot2 header magic fields while comple

[MULTIBOOT2 SPEC PATCH v4 17/27] multiboot2: Clean up stack (cdecl calling conventions)

Clean up the stack after calling C functions according to the i386 cdecl calling conventions. Signed-off-by: Hans Ulrich Niedermann diff --git a/doc/boot_i386.S b/doc/boot_i386.S index 20a600a6e..14dc14660 100644 --- a/doc/boot_i386.S +++ b/doc/boot_i386.S @@ -101,10 +101,12 @@ multiboot_entry

[MULTIBOOT2 SPEC PATCH v4 15/27] multiboot2: Remove unreferenced AOUT_KLUDGE

specification's example kernel. Signed-off-by: Hans Ulrich Niedermann diff --git a/doc/boot_i386.S b/doc/boot_i386.S index 0e8118b2a..c6e7f1382 100644 --- a/doc/boot_i386.S +++ b/doc/boot_i386.S @@ -28,13 +28,6 @@ /* The size of our stack (16KB). */ #define STACK_SIZE 0x4000

[MULTIBOOT2 SPEC PATCH v4 09/27] multiboot2: Use the constants by their proper names

In the i386 boot.S file, use the constants with the names multiboot2.h actually defines them as, and which boot_mips.S has been using already. Signed-off-by: Hans Ulrich Niedermann diff --git a/doc/boot.S b/doc/boot.S index 8f6f66fcc..9ab016612 100644 --- a/doc/boot.S +++ b/doc/boot.S @@ -50,11

[MULTIBOOT2 SPEC PATCH v4 11/27] multiboot2: Add boot_i386.S to shipped files

Ship the boot_i386.S file in the dist tarball as well, not just the boot_mips.S file. Signed-off-by: Hans Ulrich Niedermann diff --git a/doc/Makefile.am b/doc/Makefile.am index d9efe8116..e88f4d271 100644 --- a/doc/Makefile.am +++ b/doc/Makefile.am @@ -1,5 +1,5 @@ info_TEXINFOS

[MULTIBOOT2 SPEC PATCH v4 27/27] multiboot2: Add labels around the termination tag

For code consistency and more clarity as to what these .short and .long values actually are, use the same system for labeling the terminator header tag as for labeling all other header tags. This improves the readability of the code, without changing the actual output. Signed-off-by: Hans Ulrich

[MULTIBOOT2 SPEC PATCH v4 20/27] multiboot2: mips build wants __start symbol

nicely. Signed-off-by: Hans Ulrich Niedermann diff --git a/doc/boot_mips.S b/doc/boot_mips.S index b59e3fd6a..a6881528f 100644 --- a/doc/boot_mips.S +++ b/doc/boot_mips.S @@ -31,9 +31,10 @@ .set noreorder .set nomacro - .globl start, _start + .globl start, _start

[MULTIBOOT2 SPEC PATCH v4 18/27] multiboot2: Use predefined #ifdef __ASSEMBLER__

GCC already predefines __ASSEMBLER__ for .S files (assembly with C preprocessor), so we can just use that instead of defining our own ASM_FILE macro. Signed-off-by: Hans Ulrich Niedermann diff --git a/doc/boot_i386.S b/doc/boot_i386.S index 14dc14660..2aa2a92b6 100644 --- a/doc/boot_i386.S

[MULTIBOOT2 SPEC PATCH v4 13/27] multiboot2: Build arch specific boot code

(or x86_64 which is switched into 32bit mode) or mips, the example kernel build will be skipped. The mips definitions for kernel_ccasflags and kernel_cflags are completely untested. Signed-off-by: Hans Ulrich Niedermann diff --git a/.gitignore b/.gitignore index 631ff668d..e27a3e0e2 100644

[MULTIBOOT2 SPEC PATCH v4 24/27] multiboot2: Generate a kernel.map map file

Generate a kernel.map map file for the example kernel. This helps with examining the generated machine code, making the example kernel more educational. Signed-off-by: Hans Ulrich Niedermann diff --git a/.gitignore b/.gitignore index 7a035c267..889e17f69 100644 --- a/.gitignore +++ b

[MULTIBOOT2 SPEC PATCH v4 06/27] multiboot2: Remove unnecessary definition of CC

Remove the unnecessary separate definition of CC by AC_CHECK_TOOL. AC_CHECK_TOOL(CC, gcc) might have been necessary back in 1999 when this line has been written, but AC_PROG_CC has since taken over defining CC so we do not need AC_CHECK_TOOL for this any more. Signed-off-by: Hans Ulrich

[MULTIBOOT2 SPEC PATCH v4 22/27] multiboot2: Always define the kernel_* vars

are *not* built when running "make all". We still only build "if BUILD_EXAMPLE_KERNEL", which is when noinst_PROGRAMS is set. Signed-off-by: Hans Ulrich Niedermann diff --git a/doc/Makefile.am b/doc/Makefile.am index b19fc24bf..cb290a0cb 100644 --- a/doc/Makefile.am +++ b/doc/Makefi

[MULTIBOOT2 SPEC PATCH v4 23/27] multiboot2: Generate per object file listings

Generate one listing file *.lst per object file *.o. This allows easy examination of the generated machine code, making the example kernel more educational. Signed-off-by: Hans Ulrich Niedermann diff --git a/.gitignore b/.gitignore index e27a3e0e2..7a035c267 100644 --- a/.gitignore +++ b

[MULTIBOOT2 SPEC PATCH v4 19/27] multiboot2: Set -nostdlib before AC_PROG_CC for x-compile

example kernel ./configure --host=mips64-linux-gnu --enable-example-kernel It remains to be verified how this works on other systems, namely native mips systems, and non-x86 systems like arm. Signed-off-by: Hans Ulrich Niedermann diff --git a/configure.ac b/configure.ac index 830b1f57e

[MULTIBOOT2 SPEC PATCH v4 01/27] multiboot2: Allow autogen.sh to run with current gnulib

. Signed-off-by: Hans Ulrich Niedermann Reviewed-by: Daniel Kiper diff --git a/configure.ac b/configure.ac index 585b37a36..8f21b1852 100644 --- a/configure.ac +++ b/configure.ac @@ -12,7 +12,7 @@ dnl "AS IS" CONDITION. THE FREE SOFTWARE FOUNDATION DISCLAIMS ANY dnl LIABILITY OF ANY KI

[MULTIBOOT2 SPEC PATCH v4 25/27] multiboot2: Generate gcc temp files (*.i and *.s)

Generate gcc temporary files for each object file, showing the intermediate steps after the C preprocessor and immediately before assembly. This helps with examining how the example kernel code is generated, making the example kernel more educational. Signed-off-by: Hans Ulrich Niedermann diff

[MULTIBOOT2 SPEC PATCH v4 26/27] multiboot2: Generate symbol lists and disassembly file

educational. Signed-off-by: Hans Ulrich Niedermann diff --git a/.gitignore b/.gitignore index f6a1b7736..ba08c2911 100644 --- a/.gitignore +++ b/.gitignore @@ -39,7 +39,10 @@ Makefile /doc/*.c.texi /doc/*.h.texi /doc/kernel +/doc/kernel.lss /doc/kernel.map +/doc/kernel.sym +/doc/kernel.vsym

[MULTIBOOT2 SPEC PATCH v4 21/27] multiboot2: "make distcheck" with example kernel enabled

Even if no one ever does a tarball release of the Multiboot2 spec, "make distcheck" is a good way of checking the build system's integrity. Signed-off-by: Hans Ulrich Niedermann diff --git a/Makefile.am b/Makefile.am index 70eec9cd0..38e797aa7 100644 --- a/Makefile.am +++ b/Makefile.

[PATCH v3 2/6] gitignore: Group patterns with and without slash

-by: Hans Ulrich Niedermann Reviewed-by: Daniel Kiper --- .gitignore | 81 -- 1 file changed, 42 insertions(+), 39 deletions(-) diff --git a/.gitignore b/.gitignore index 8908a2131..01c1ec538 100644 --- a/.gitignore +++ b/.gitignore @@ -1,3 +1,4

[PATCH v3 0/6] gitignore: Clean up most of the gitignore mess

Ulrich Niedermann (6): gitignore: Consistent leading slash is easier to read gitignore: Group patterns with and without slash gitignore: Sort both pattern groups alphabetically gitignore: Add trailing slashes for directories gitignore: Add leading slashes where appropriate gitignore

[PATCH v3 1/6] gitignore: Consistent leading slash is easier to read

As all gitignore patterns containing a left or middle slash match only relative to the .gitignore file's directory, we write them all in the same manner with a leading slash. This makes the file significantly easier to read. Signed-off-by: Hans Ulrich Niedermann Reviewed-by: Daniel Kiper

[PATCH v3 6/6] gitignore: Add a few forgotten file patterns

Add a few patterns to .gitignore to cover files which are generated by building grub ("make", "make check", "make dist") but which have been forgotten to add to .gitignore in the past. Signed-off-by: Hans Ulrich Niedermann Reviewed-by: Dani

[PATCH v3 5/6] gitignore: Add leading slashes where appropriate

r some patterns like "ascii.bitmaps", it is unclear where in the source tree they should match. Those patterns are kept as they are, matching the patterns in the whole tree of subdirectories. Signed-off-by: Hans Ulrich Niedermann Reviewed-by: Danie

[PATCH v3 4/6] gitignore: Add trailing slashes for directories

Add trailing slashes for all patterns matching directories. Note that we do *not* add trailing slashes for *symlinks* to directories. Signed-off-by: Hans Ulrich Niedermann Reviewed-by: Daniel Kiper --- .gitignore | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git

[PATCH v3 3/6] gitignore: Sort both pattern groups alphabetically

Alphabetically sort the two groups of gitignore patterns: * The group of patterns without slashes, matching anywhere in the directory subtree. * The group of patterns with slashes, matching relative to the .gitignore file's directory Signed-off-by: Hans Ulrich Niedermann Reviewed

[PATCH v4 4/6] gitignore: Add trailing slashes for directories

Add trailing slashes for all patterns matching directories. Note that we do *not* add trailing slashes for *symlinks* to directories. Signed-off-by: Hans Ulrich Niedermann Reviewed-by: Daniel Kiper diff --git a/.gitignore b/.gitignore index 7e1d32df4..07561f027 100644 --- a/.gitignore +++ b

[PATCH v4 3/6] gitignore: Sort both pattern groups alphabetically

Alphabetically sort the two groups of gitignore patterns: * The group of patterns without slashes, matching anywhere in the directory subtree. * The group of patterns with slashes, matching relative to the .gitignore file's directory Signed-off-by: Hans Ulrich Niedermann Reviewed

[PATCH v4 1/6] gitignore: Consistent leading slash is easier to read

As all gitignore patterns containing a left or middle slash match only relative to the .gitignore file's directory, we write them all in the same manner with a leading slash. This makes the file significantly easier to read. Signed-off-by: Hans Ulrich Niedermann Reviewed-by: Daniel Kiper diff

[PATCH v4 2/6] gitignore: Group patterns with and without slash

-by: Hans Ulrich Niedermann Reviewed-by: Daniel Kiper diff --git a/.gitignore b/.gitignore index 8908a2131..01c1ec538 100644 --- a/.gitignore +++ b/.gitignore @@ -1,3 +1,4 @@ +# Ignore patterns in this directory and all subdirectories *~ 00_header 10_* @@ -30,9 +31,6 @@ config.sub configure

[PATCH v4 0/6] gitignore: Clean up most of the gitignore mess

a wrong sorting order for the ".deps*/" patterns. Hans Ulrich Niedermann (6): gitignore: Consistent leading slash is easier to read gitignore: Group patterns with and without slash gitignore: Sort both pattern groups alphabetically gitignore: Add trailing slashes for directories giti

[PATCH v4 5/6] gitignore: Add leading slashes where appropriate

r some patterns like "ascii.bitmaps", it is unclear where in the source tree they should match. Those patterns are kept as they are, matching the patterns in the whole tree of subdirectories. Signed-off-by: Hans Ulrich Niedermann Reviewed-by: Daniel Kiper diff --git a/.gitignore b/.gitign

[PATCH v4 6/6] gitignore: Add a few forgotten file patterns

Add a few patterns to .gitignore to cover files which are generated by building grub ("make", "make check", "make dist") but which have been forgotten to add to .gitignore in the past. Signed-off-by: Hans Ulrich Niedermann Reviewed-by: Daniel Kiper diff --git a

[MULTIBOOT2 SPEC PATCH v3 3/4] multiboot2: Make example kernel build at least for i386

Building the example kernel for mips still needs some work, as I have not managed to build for mips yet with either my mips64-linux-gnu cross-compilation toolchain on Fedora 32 or on my Debian 10.3 MIPS install running in qemu-system-mips. Signed-off-by: Hans Ulrich Niedermann rename doc/{boot.S

[MULTIBOOT2 SPEC PATCH v3 1/4] multiboot2: Allow autogen.sh to run with current gnulib

. Signed-off-by: Hans Ulrich Niedermann diff --git a/configure.ac b/configure.ac index 585b37a36..8f21b1852 100644 --- a/configure.ac +++ b/configure.ac @@ -12,7 +12,7 @@ dnl "AS IS" CONDITION. THE FREE SOFTWARE FOUNDATION DISCLAIMS ANY dnl LIABILITY OF ANY KIND FOR ANY DAMAGES

[MULTIBOOT2 SPEC PATCH v3 2/4] multiboot2: Use .gitignore files

Add .gitignore file and remove the obsolete .bzrignore file. The doc/.gitignore file is generated by gnulib-tool so we keep that file in addition to the top-level .gitignore file which covers everything else in the subdirectory tree. Signed-off-by: Hans Ulrich Niedermann delete mode 100644

[MULTIBOOT2 SPEC PATCH v3 4/4] multiboot2: fix example kernel header tag alignment

ets of the labels in the boot_*.S files to verify the alignment issues. Note also that the "grub-file --is-x86-multiboot2" utility does not recognize the wrong alignment of the Multiboot2 header tags, as it only considers the beginning of the Multiboot2 header and completely ignores the M

[MULTIBOOT2 SPEC PATCH v3 0/4] multiboot2: Clean up the example kernel

reasonable. Hans Ulrich Niedermann (4): multiboot2: Allow autogen.sh to run with current gnulib multiboot2: Use .gitignore files multiboot2: Make example kernel build at least for i386 multiboot2: fix example kernel header tag alignment .bzrignore | 30

Re: Multiboot2 on aarch64: Alignment of ELF Headers

On Fri, 22 May 2020 17:23:35 +0100 Chris Plant via Grub-devel wrote: > I'm continuing to work on Multiboot2 support on aarch64, and I'm > looking at the alignment of the ELF headers which are passed through > MB2. At the risk of me sounding stupid... Having read the MB2 specs quite thoroughly

Re: Multiboot2 on aarch64: Alignment of ELF Headers

On Sat, 23 May 2020 12:21:27 +0100 Chris Plant via Grub-devel wrote: > On Sat, 2020-05-23 at 12:43 +0200, Hans Ulrich Niedermann wrote: > > On Fri, 22 May 2020 17:23:35 +0100 > > Chris Plant via Grub-devel wrote: > > > > > I'm continuing to work on Multiboo

Multiboot2 Header Tags: Unclear definition of type

Quoting the Multiboot2 specification: > 3.1.3 General tag structure > --- > > Tags constitutes a buffer of structures following each other padded > when necessary in order for each tag to start at 8-bytes aligned > address. Tags are terminated by a tag of type '0' and

Multiboot 2 Header Tags: How many and in what sequence?

The Multiboot2 specification specifies a number of header tags which an OS image can define and which the bootloader needs to parse. However, the spec does not mention in which order an OS image should contain MB2 header tags: * Ascending numerical order of the 'type' value? (This could only

MB2 spec: Endianness weirdness in definition of terms

The MB2 spec "definition of terms used through the specification" defines terms like "must", "should", but also "u8", "u16", "u32", and "u64": > "u8" > The type of unsigned 8-bit data. > > "u16" > The type of unsigned 16-bit data. Because the target architecture > is little-endian,

Re: Multiboot 2 Header Alignment: implementation contradicts specification

On Sat, 23 May 2020 21:24:32 +0200 Jacob Paul via Grub-devel wrote: > On 2020-05-23 20:33, Hans Ulrich Niedermann wrote: > > The comment is valid for MB1, but not for MB2. Both regarding the > > alignment and regarding the size. And regarding the size, this > > actually

Re: Multiboot 2 Header Alignment: implementation contradicts specification

On Sat, 23 May 2020 18:50:09 +0200 Jacob Paul via Grub-devel wrote: > The Multiboot2 specification specifies that the Multiboot2 header > should be 8-byte (64-bit) aligned: > >An OS image must contain an additional header called Multiboot2 > >header, besides the headers of the format used by

[PATCH] doc: Reference configure.ac instead of configure.in

Change the textual reference in the INSTALL file to configure.in to refer to configure.ac instead. The grub configure.in has been renamed to configure.ac in 2003. Signed-off-by: Hans Ulrich Niedermann diff --git a/INSTALL b/INSTALL index e490d22d3..7eb0bd1cc 100644 --- a/INSTALL +++ b/INSTALL

  1   2   >