[PATCH] remove dependency on /boot/config-* in grub.d/20_linux_xen

2013-07-15 Thread Konrad Rzeszutek Wilk
as pretty much any upstream kernel is being built by default from distros to boot with Xen. If it does not, Xen will print a message telling the user that Linux does not have the required components. This patch removes said check. Signed-off-by: Konrad Rzeszutek Wilk konrad.w...@oracle.com

Re: Request for IRC chat about patches, which aren't accepted.

2013-07-23 Thread Konrad Rzeszutek Wilk
On Tue, Jul 23, 2013 at 07:57:43PM +0400, Vladimir Testov wrote: Hello! I would like to meet in IRC to go through some my patches which aren't accepted yet. - terminal window moving options - pixmap styled box fix and - gui_list-related patches (there are two or three more following)

Re: [PATCH] remove dependency on /boot/config-* in grub.d/20_linux_xen

2013-07-29 Thread Konrad Rzeszutek Wilk
On Fri, Jul 26, 2013 at 09:02:40PM +0200, Vladimir 'φ-coder/phcoder' Serbinenko wrote: On 26.07.2013 20:50, konrad wilk wrote: On 7/25/2013 5:24 PM, Vladimir 'φ-coder/phcoder' Serbinenko wrote: On 15.07.2013 20:00, Konrad Rzeszutek Wilk wrote: Hey, There is a discussion on the linux

Re: Gparted implanted on grub.cfg [grub2 version] does not want to boot

2013-09-04 Thread Konrad Rzeszutek Wilk
On Tue, Sep 03, 2013 at 01:53:33PM +, Stojsavljevic, Zoran wrote: Hello, I have VM based on Fedora 18. Since this machine is upgradable, and everything works there just fine, I started doing there lot of work, so I overloaded the HDD. My /home partition appeared to be small for all

Re: EFI and multiboot2 devlopment work for Xen

2013-10-21 Thread Konrad Rzeszutek Wilk
On Mon, Oct 21, 2013 at 02:36:38PM +0100, Jan Beulich wrote: On 21.10.13 at 14:57, Daniel Kiper daniel.ki...@oracle.com wrote: (Looking at the Cc list it's quite interesting that you copied a whole lot of people, but not me as the maintainer of the EFI bits in Xen.) I see this: From:

Re: EFI and multiboot2 devlopment work for Xen

2013-10-22 Thread Konrad Rzeszutek Wilk
On Tue, Oct 22, 2013 at 02:53:05PM +0100, Ian Campbell wrote: On Tue, 2013-10-22 at 09:42 -0400, Konrad Rzeszutek Wilk wrote: Looking at the Fedora GRUB2 source, the 'struct linux_kernel_header' is defined in the linux/Documentation/x86/boot.txt and hpa is pretty strict about making

Re: EFI and multiboot2 devlopment work for Xen

2013-10-22 Thread Konrad Rzeszutek Wilk
On Tue, Oct 22, 2013 at 10:59:33AM +0100, Jan Beulich wrote: On 22.10.13 at 11:45, Ian Campbell ian.campb...@citrix.com wrote: On Tue, 2013-10-22 at 10:31 +0100, Jan Beulich wrote: On 22.10.13 at 11:26, Ian Campbell ian.campb...@citrix.com wrote: AIUI efilinux is somewhat badly named and

Re: EFI and multiboot2 devlopment work for Xen

2013-10-22 Thread Konrad Rzeszutek Wilk
On Tue, Oct 22, 2013 at 09:42:52AM -0400, Konrad Rzeszutek Wilk wrote: On Tue, Oct 22, 2013 at 10:59:33AM +0100, Jan Beulich wrote: On 22.10.13 at 11:45, Ian Campbell ian.campb...@citrix.com wrote: On Tue, 2013-10-22 at 10:31 +0100, Jan Beulich wrote: On 22.10.13 at 11:26, Ian Campbell

Re: EFI and multiboot2 devlopment work for Xen

2013-10-22 Thread Konrad Rzeszutek Wilk
On Tue, Oct 22, 2013 at 03:24:28PM +0100, Ian Campbell wrote: On Tue, 2013-10-22 at 10:09 -0400, Konrad Rzeszutek Wilk wrote: So it can be booted the same way as xen.efi. But my understanding is that folks prefer a bootloader instead of loading the bzImage in an NVRAM of a platform

Re: EFI and multiboot2 devlopment work for Xen

2013-10-22 Thread Konrad Rzeszutek Wilk
On Tue, Oct 22, 2013 at 02:18:52PM +, Woodhouse, David wrote: I wonder why Linux can't make the EFI calls to fetch them itself? It can. It does. It prefers to. This is what the EFI boot stub is all about. But grub2 is crack-inspired and likes to do all kinds of crap that it

Re: EFI and multiboot2 devlopment work for Xen

2013-10-22 Thread Konrad Rzeszutek Wilk
On Tue, Oct 22, 2013 at 04:21:47PM +0100, Ian Campbell wrote: On Tue, 2013-10-22 at 10:57 -0400, Konrad Rzeszutek Wilk wrote: That 'that' is a standard PE/COFF image? Could you please point me to the code that does that in GRUB2? As I said earlier in the thread, it's a patch which

Re: [Xen-devel] EFI and multiboot2 devlopment work for Xen

2013-10-22 Thread Konrad Rzeszutek Wilk
On Tue, Oct 22, 2013 at 04:22:38PM +0100, Ian Campbell wrote: On Tue, 2013-10-22 at 15:24 +0100, Ian Campbell wrote: On Tue, 2013-10-22 at 10:09 -0400, Konrad Rzeszutek Wilk wrote: So it can be booted the same way as xen.efi. But my understanding is that folks prefer a bootloader

Re: EFI and multiboot2 devlopment work for Xen

2013-10-22 Thread Konrad Rzeszutek Wilk
On Tue, Oct 22, 2013 at 05:39:24PM +0200, Vladimir 'φ-coder/phcoder' Serbinenko wrote: On 22.10.2013 16:51, Konrad Rzeszutek Wilk wrote: If you use 'linux' module, it will call ExitBootService. If you use 'multiboot' module, it will call ExitBootService too. So if you don't want

Re: EFI and multiboot2 devlopment work for Xen

2013-10-22 Thread Konrad Rzeszutek Wilk
On Tue, Oct 22, 2013 at 03:25:39PM +, Woodhouse, David wrote: On Tue, 2013-10-22 at 10:43 -0400, Konrad Rzeszutek Wilk wrote: And looking at bit deeper in the x86/linux boot spec: EFI HANDOVER PROTOCOL

Re: EFI and multiboot2 devlopment work for Xen

2013-10-22 Thread Konrad Rzeszutek Wilk
Are you (going to be) in Edinburgh? Matthew was just explaining a bunch of this stuff to me, it might be useful for you to get it from the horses mouth instead of laundered through my brain (which is a bit addled afterwards ;-)). Sadly no. However, if it is possible/needed I could

Re: [Xen-devel] EFI and multiboot2 devlopment work for Xen

2013-10-23 Thread Konrad Rzeszutek Wilk
On Wed, Oct 23, 2013 at 09:32:30AM +0100, Ian Campbell wrote: On Tue, 2013-10-22 at 12:26 -0400, Konrad Rzeszutek Wilk wrote: It can (at least in Linux). There are two entry points in the Linux kernel and - one when it is launched from 'linuxefi' (See efi_stub_entry in arch/x86/boot

Re: EFI and multiboot2 devlopment work for Xen

2013-10-28 Thread Konrad Rzeszutek Wilk
On Tue, Oct 22, 2013 at 10:54:44AM +0200, Vladimir 'φ-coder/phcoder' Serbinenko wrote: On 21.10.2013 23:16, Vladimir 'φ-coder/phcoder' Serbinenko wrote: Mail is big, I think I got your essential points but I didn't read it whole. On 21.10.2013 14:57, Daniel Kiper wrote: Hi, During work

Re: [Xen-devel] GRUB2 XEN PV port is able to boot linux

2013-11-06 Thread Konrad Rzeszutek Wilk
On Tue, Nov 05, 2013 at 04:40:29AM +0100, Vladimir '??-coder/phcoder' Serbinenko wrote: On 05.11.2013 04:39, Vladimir '??-coder/phcoder' Serbinenko wrote: For now it's 64-bit only but it works. I've also tested with netbsd and GNU mach. All of them work as well as when launched directly from

Re: [PATCH] remove dependency on /boot/config-* in grub.d/20_linux_xen

2013-11-11 Thread Konrad Rzeszutek Wilk
On Sun, Nov 10, 2013 at 09:40:29PM +0100, Vladimir 'φ-coder/phcoder' Serbinenko wrote: On 15.07.2013 20:00, Konrad Rzeszutek Wilk wrote: Hey, There is a discussion on the linux-kernel mailing list in which the Linus states that if you depend on any config file, you're broken

Re: [PATCH] remove dependency on /boot/config-* in grub.d/20_linux_xen

2013-11-13 Thread Konrad Rzeszutek Wilk
On Sun, Nov 10, 2013 at 09:40:29PM +0100, Vladimir 'φ-coder/phcoder' Serbinenko wrote: On 15.07.2013 20:00, Konrad Rzeszutek Wilk wrote: Hey, There is a discussion on the linux-kernel mailing list in which the Linus states that if you depend on any config file, you're broken

Re: Is: grub2-mkconfig detecting ELF files the multiboot2 header and using proper module. Was:Re: [PATCH 0/5] multiboot2: Enable EFI boot services usage in loaded images

2015-05-11 Thread Konrad Rzeszutek Wilk
and using some of that logic to inspect the Xen to find the MB2 header? See grub-file tool. Possibly it's still only in next branch I see it. Thank you. I also see 'faf4a65e1e1ce1d822d251c1e4b53d96ec7faec5' Revert grub-file usage in grub-mkconfig. but not much of an explanation?

Is: grub2-mkconfig detecting ELF files the multiboot2 header and using proper module. Was:Re: [PATCH 0/5] multiboot2: Enable EFI boot services usage in loaded images

2015-05-11 Thread Konrad Rzeszutek Wilk
On Mon, Feb 09, 2015 at 06:55:05PM +0100, Daniel Kiper wrote: Hi all, On Fri, Jan 30, 2015 at 06:59:23PM +0100, Daniel Kiper wrote: Hi, This patch series enable EFI boot services usage in loaded images by multiboot2 protocol. Guys, do you have any comments on this patch series?

Re: GRUB release schedule?

2015-08-21 Thread Konrad Rzeszutek Wilk
On Fri, Aug 21, 2015 at 10:18:08AM -0700, Josef Bacik wrote: On 08/21/2015 10:11 AM, Konrad Rzeszutek Wilk wrote: On Fri, Aug 21, 2015 at 09:56:59AM -0700, Josef Bacik wrote: On 07/20/2015 11:22 AM, Peter Jones wrote: Hi everyone, Is there a plan for when upcoming GNU GRUB releases

Re: GRUB release schedule?

2015-08-21 Thread Konrad Rzeszutek Wilk
On Fri, Aug 21, 2015 at 09:56:59AM -0700, Josef Bacik wrote: On 07/20/2015 11:22 AM, Peter Jones wrote: Hi everyone, Is there a plan for when upcoming GNU GRUB releases will happen? As far as I can tell, the last official release on ftp://ftp.gnu.org/gnu/grub/ was 2.00 on 28-Jun-2012, and

Re: GRUB release schedule?

2015-08-21 Thread Konrad Rzeszutek Wilk
On Fri, Aug 21, 2015 at 09:24:33PM +0300, Andrei Borzenkov wrote: 21.08.2015 20:11, Konrad Rzeszutek Wilk пишет: On Fri, Aug 21, 2015 at 09:56:59AM -0700, Josef Bacik wrote: On 07/20/2015 11:22 AM, Peter Jones wrote: Hi everyone, Is there a plan for when upcoming GNU GRUB releases will happen

Re: GRUB release schedule?

2015-08-24 Thread Konrad Rzeszutek Wilk
On Sat, Aug 22, 2015 at 08:16:26AM +0300, Andrei Borzenkov wrote: 21.08.2015 21:41, Konrad Rzeszutek Wilk пишет: Lets start with a list of priorities: - What are the most important platforms after x86? I suppose distribution-wise they are ARM and PPC. This means 5 different GRUB builds

Re: [Xen-devel] [PATCH v2 21/23] x86/boot: implement early command line parser in C

2015-08-11 Thread Konrad Rzeszutek Wilk
+static void vga_parse(const char *cmdline, early_boot_opts_t *ebo) +{ +const char *c; +int tmp; +size_t la; +static const char empty_chars_comma[] __text = \n\r\t,; +static const char x[] __text = x; +static const char vga[] __text = vga=; +static const char

Re: [Xen-devel] [PATCH v2 22/23] x86: make Xen early boot code relocatable

2015-08-11 Thread Konrad Rzeszutek Wilk
On Mon, Jul 20, 2015 at 04:29:17PM +0200, Daniel Kiper wrote: Every multiboot protocol (regardless of version) compatible image must specify its load address (in ELF or multiboot header). Multiboot protocol compatible loader have to load image at specified address. However, there is no

Re: [PATCH v2 20/23] x86: add multiboot2 protocol support for EFI platforms

2015-08-11 Thread Konrad Rzeszutek Wilk
+run_bs: +push%rax +push%rdi + +/* Initialize BSS (no nasty surprises!). */ +lea __bss_start(%rip),%rdi +lea __bss_end(%rip),%rcx +sub %rdi,%rcx +shr $3,%rcx +xor %eax,%eax +rep stosq

Re: [PATCH v2 1/6] gitignore: Ignore *.orig, *.rej and *.swp files

2015-08-11 Thread Konrad Rzeszutek Wilk
On Mon, Jul 20, 2015 at 04:35:49PM +0200, Daniel Kiper wrote: Signed-off-by: Daniel Kiper daniel.ki...@oracle.com Reviewed-by: Konrad Rzeszutek Wilk konrad.w...@oracle.com but really - this is quite easy to review :-) --- .gitignore |3 +++ 1 file changed, 3 insertions(+) diff --git

Re: [PATCH v2 23/23] x86: add multiboot2 protocol support for relocatable images

2015-08-11 Thread Konrad Rzeszutek Wilk
-by: Konrad Rzeszutek Wilk konrad.w...@oracle.com ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH v2 5/6] multiboot2: Add support for relocatable images

2015-08-11 Thread Konrad Rzeszutek Wilk
On Mon, Jul 20, 2015 at 04:35:53PM +0200, Daniel Kiper wrote: This parts needs a bit of details I think. As in why can't the ELF note that is present in the binary be satisfied. Or under what conditions would the existing code not work? Signed-off-by: Daniel Kiper daniel.ki...@oracle.com ---

Re: [PATCH v2 4/6] multiboot2: Add tags used to pass ImageHandle to loaded image

2015-08-11 Thread Konrad Rzeszutek Wilk
On Mon, Jul 20, 2015 at 04:35:52PM +0200, Daniel Kiper wrote: Add tags used to pass ImageHandle to loaded image. It is used s/loaded image/loaded image if requested./ by at least ExitBootServices() function. Signed-off-by: Daniel Kiper daniel.ki...@oracle.com ---

Re: [PATCH v2 6/6] multiboot2: Do not pass memory maps to image if EFI boot services are enabled

2015-08-11 Thread Konrad Rzeszutek Wilk
(grub_efi_finish_boot_services): Try terminating EFI services several times due to quirks in some implementations. Otherwise: Reviewed-by: Konrad Rzeszutek Wilk konrad.w...@oracle.com Signed-off-by: Daniel Kiper daniel.ki...@oracle.com --- grub-core/loader/multiboot_mbi2.c

Re: [PATCH v2 3/6] i386/relocator: Add grub_relocator64_efi relocator

2015-08-11 Thread Konrad Rzeszutek Wilk
On Mon, Jul 20, 2015 at 04:35:51PM +0200, Daniel Kiper wrote: Add grub_relocator64_efi relocator. It will be used on EFI 64-bit platforms when multiboot2 compatible image requests MULTIBOOT_TAG_TYPE_EFI_BS. Relocator will set lower parts of %rax and %rbx accordingly to multiboot2 specification.

Re: [PATCH v2 23/23] x86: add multiboot2 protocol support for relocatable images

2015-08-14 Thread Konrad Rzeszutek Wilk
On Fri, Aug 14, 2015 at 01:57:01PM +0200, Daniel Kiper wrote: On Tue, Aug 11, 2015 at 12:56:58PM -0400, Konrad Rzeszutek Wilk wrote: On Mon, Jul 20, 2015 at 04:29:18PM +0200, Daniel Kiper wrote: Add multiboot2 protocol support for relocatable images. Only GRUB2 with relevant patches

Re: [Xen-devel] [PATCH v2 07/23] x86/boot/reloc: Rename some variables and rearrange code a bit

2015-08-10 Thread Konrad Rzeszutek Wilk
and ... it more readable. Additionally, this way multiboot (v1) protocol implementation and future multiboot2 protocol implementation will use the same variable naming convention. Signed-off-by: Daniel Kiper daniel.ki...@oracle.com Reviewed-by: Konrad Rzeszutek Wilk konrad.w...@oracle.com --- v2

Re: [Xen-devel] [PATCH v2 06/23] x86/boot: use %ecx instead of %eax

2015-08-10 Thread Konrad Rzeszutek Wilk
-by: Daniel Kiper daniel.ki...@oracle.com Reviewed-by: Andrew Cooper andrew.coop...@citrix.com Reviewed-by: Konrad Rzeszutek Wilk konrad.w...@oracle.com --- xen/arch/x86/boot/head.S | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/xen/arch/x86/boot

Re: [Xen-devel] [PATCH v2 08/23] x86: add multiboot2 protocol support

2015-08-10 Thread Konrad Rzeszutek Wilk
+#define MULTIBOOT2_FRAMEBUFFER_TYPE_RGB 1 +#define MULTIBOOT2_FRAMEBUFFER_TYPE_EGA_TEXT 2 And these. Otherwise, Reviewed-by: Konrad Rzeszutek Wilk konrad.w...@oracle.com + +#ifndef __ASSEMBLY__ +typedef struct { +u32 total_size; +u32 reserved; +} multiboot2_fixed_t

Re: [Xen-devel] [PATCH v2 18/23] efi: split out efi_exit_boot()

2015-08-10 Thread Konrad Rzeszutek Wilk
On Mon, Jul 20, 2015 at 04:29:13PM +0200, Daniel Kiper wrote: ..which gets memory map and calls ExitBootServices(). We want to re-use this code to support multiboot2 protocol on EFI platforms. Signed-off-by: Daniel Kiper daniel.ki...@oracle.com Reviewed-by: Konrad Rzeszutek Wilk konrad.w

Re: [PATCH v2 01/23] x86/boot: remove unneeded instruction

2015-08-10 Thread Konrad Rzeszutek Wilk
On Mon, Jul 27, 2015 at 09:46:08PM +0200, Daniel Kiper wrote: On Fri, Jul 24, 2015 at 12:22:57PM -0400, Konrad Rzeszutek Wilk wrote: On Mon, Jul 20, 2015 at 04:28:56PM +0200, Daniel Kiper wrote: Signed-off-by: Daniel Kiper daniel.ki...@oracle.com Don't you use it in: /* Switch

Re: [Xen-devel] [PATCH v2 04/23] x86/boot: call reloc() using cdecl calling convention

2015-08-10 Thread Konrad Rzeszutek Wilk
On Mon, Jul 20, 2015 at 04:28:59PM +0200, Daniel Kiper wrote: Suggested-by: Jan Beulich jbeul...@suse.com Signed-off-by: Daniel Kiper daniel.ki...@oracle.com Reviewed-by: Konrad Rzeszutek Wilk konrad.w...@oracle.com --- xen/arch/x86/boot/head.S |4 +++- xen/arch/x86/boot/reloc.c

Re: [Xen-devel] [PATCH v2 11/23] efi: split out efi_init()

2015-08-10 Thread Konrad Rzeszutek Wilk
On Mon, Jul 20, 2015 at 04:29:06PM +0200, Daniel Kiper wrote: ..which initializes basic EFI variables. We want to re-use this code to support multiboot2 protocol on EFI platforms. Signed-off-by: Daniel Kiper daniel.ki...@oracle.com Reviewed-by: Konrad Rzeszutek Wilk konrad.w...@oracle.com

Re: [Xen-devel] [PATCH v2 12/23] efi: split out efi_console_set_mode()

2015-08-10 Thread Konrad Rzeszutek Wilk
On Mon, Jul 20, 2015 at 04:29:07PM +0200, Daniel Kiper wrote: ..which sets console mode. We want to re-use this code to support multiboot2 protocol on EFI platforms. Signed-off-by: Daniel Kiper daniel.ki...@oracle.com Reviewed-by: Konrad Rzeszutek Wilk konrad.w...@oracle.com --- v2

Re: [Xen-devel] [PATCH v2 15/23] efi: split out efi_tables()

2015-08-10 Thread Konrad Rzeszutek Wilk
On Mon, Jul 20, 2015 at 04:29:10PM +0200, Daniel Kiper wrote: ..which collects system tables data. We want to re-use this code to support multiboot2 protocol on EFI platforms. Signed-off-by: Daniel Kiper daniel.ki...@oracle.com Reviewed-by: Konrad Rzeszutek Wilk konrad.w...@oracle.com

Re: [Xen-devel] [PATCH v2 09/23] efi: create efi_enabled()

2015-08-10 Thread Konrad Rzeszutek Wilk
Beulich jbeul...@suse.com Signed-off-by: Daniel Kiper daniel.ki...@oracle.com Reviewed-by: Konrad Rzeszutek Wilk konrad.w...@oracle.com --- xen/arch/x86/dmi_scan.c|4 ++-- xen/arch/x86/domain_page.c |2 +- xen/arch/x86/efi/stub.c| 11 --- xen/arch/x86/mpparse.c

Re: [Xen-devel] [PATCH v2 13/23] efi: split out efi_get_gop()

2015-08-10 Thread Konrad Rzeszutek Wilk
On Mon, Jul 20, 2015 at 04:29:08PM +0200, Daniel Kiper wrote: ..which gets pointer to GOP device. We want to re-use this code to support multiboot2 protocol on EFI platforms. Signed-off-by: Daniel Kiper daniel.ki...@oracle.com Reviewed-by: Konrad Rzeszutek Wilk konrad.w...@oracle.com

Re: [Xen-devel] [PATCH v2 16/23] efi: split out efi_variables()

2015-08-10 Thread Konrad Rzeszutek Wilk
On Mon, Jul 20, 2015 at 04:29:11PM +0200, Daniel Kiper wrote: ..which collects variable store parameters. We want to re-use this code to support multiboot2 protocol on EFI platforms. Signed-off-by: Daniel Kiper daniel.ki...@oracle.com Reviewed-by: Konrad Rzeszutek Wilk konrad.w...@oracle.com

Re: [Xen-devel] [PATCH v2 20/23] x86: add multiboot2 protocol support for EFI platforms

2015-08-10 Thread Konrad Rzeszutek Wilk
from non-EFI code. */ struct efi { With the changes above: Reviewed-by: Konrad Rzeszutek Wilk konrad.w...@oracle.com -- 1.7.10.4 ___ Xen-devel mailing list xen-de...@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v2 10/23] efi: build xen.gz with EFI code

2015-08-10 Thread Konrad Rzeszutek Wilk
, so Half-Reviewed-by: Konrad Rzeszutek Wilk konrad.w...@oracle.com diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c index 342414f..cef2eb6 100644 --- a/xen/arch/x86/mm.c +++ b/xen/arch/x86/mm.c @@ -344,7 +344,8 @@ void __init arch_init_memory(void) subarch_init_memory

Re: [Xen-devel] [PATCH v2 14/23] efi: split out efi_find_gop_mode()

2015-08-10 Thread Konrad Rzeszutek Wilk
On Mon, Jul 20, 2015 at 04:29:09PM +0200, Daniel Kiper wrote: ..which finds suitable GOP mode. We want to re-use this code to support multiboot2 protocol on EFI platforms. Signed-off-by: Daniel Kiper daniel.ki...@oracle.com Reviewed-by: Konrad Rzeszutek Wilk konrad.w...@oracle.com --- v2

Re: [Xen-devel] [PATCH v2 17/23] efi: split out efi_set_gop_mode()

2015-08-10 Thread Konrad Rzeszutek Wilk
On Mon, Jul 20, 2015 at 04:29:12PM +0200, Daniel Kiper wrote: ..which sets chosen GOP mode. We want to re-use this code to support multiboot2 protocol on EFI platforms. Signed-off-by: Daniel Kiper daniel.ki...@oracle.com Reviewed-by: Konrad Rzeszutek Wilk konrad.w...@oracle.com --- v2

Re: [Xen-devel] [PATCH v2 19/23] x86/efi: create new early memory allocator

2015-08-10 Thread Konrad Rzeszutek Wilk
implements #2 solution./ Signed-off-by: Daniel Kiper daniel.ki...@oracle.com Reviewed-by: Konrad Rzeszutek Wilk konrad.w...@oracle.com with the adjustments mentioned. --- xen/arch/x86/efi/efi-boot.h | 38 ++ xen/arch/x86/setup.c|3 +-- 2 files

Re: [Xen-devel] [PATCH v2 21/23] x86/boot: implement early command line parser in C

2015-08-10 Thread Konrad Rzeszutek Wilk
was done. Also at the assembler code and with that Reviewed-by: Konrad Rzeszutek Wilk konrad.w...@oracle.com .. snip.. diff --git a/xen/arch/x86/boot/cmdline.c b/xen/arch/x86/boot/cmdline.c new file mode 100644 index 000..5ea50a4 --- /dev/null +++ b/xen/arch/x86/boot/cmdline.c @@ -0,0 +1,396

Re: [PATCH v2 01/23] x86/boot: remove unneeded instruction

2015-07-24 Thread Konrad Rzeszutek Wilk
On Mon, Jul 20, 2015 at 04:28:56PM +0200, Daniel Kiper wrote: Signed-off-by: Daniel Kiper daniel.ki...@oracle.com Don't you use it in: /* Switch to low-memory stack. */ 193 mov sym_phys(trampoline_phys),%edi

Re: [Xen-devel] [PATCH v2 2/3] util/grub.d/20_linux_xen.in: Add arm64 support

2015-07-14 Thread Konrad Rzeszutek Wilk
On Tue, Jul 14, 2015 at 10:41:28AM +0100, Ian Campbell wrote: On Tue, 2015-07-14 at 06:53 +0300, Andrei Borzenkov wrote: +if [ x$machine != xaarch64 ]; then + multiboot_cmd=multiboot + module_cmd=module And we should use the grub-file --is-multiboot2 to figure out if the Xen binary can

Re: [PATCH grub-core/kern/xen/init.c] pvgrub2 xen cmdline xenstore var to grubenv

2015-10-24 Thread Konrad Rzeszutek Wilk
On Fri, Oct 23, 2015 at 05:11:33PM -0700, Mark Pryor wrote: > When entering the grub2 shell during a pvgrub2 boot, there is no info about > the current > domU in the grubenv (set). Starting with a patch submitted by Olaf Herring I > exported Which patch? Is there a name for it so it can be part

Re: GNU GRUB maintenance

2015-10-08 Thread Konrad Rzeszutek Wilk
On Wed, Oct 07, 2015 at 05:36:49PM -0400, SevenBits wrote: > On Wednesday, October 7, 2015, Vladimir 'φ-coder/phcoder' Serbinenko < > phco...@gmail.com> wrote: > > > Hello, all. I'm sorry for not being available to do enough maintenance > > for GRUB in last time but I was overbooked. Yet there is

Re: GNU GRUB maintenance

2015-10-08 Thread Konrad Rzeszutek Wilk
On Thu, Oct 08, 2015 at 01:24:50PM +0700, Fajar A. Nugraha wrote: > On Thu, Oct 8, 2015 at 6:02 AM, Vladimir 'φ-coder/phcoder' Serbinenko > wrote: > > On 07.10.2015 23:36, SevenBits wrote: > > >> What other systems would be ok? It > >> obviously has to be a free

Re: GNU GRUB maintenance

2015-10-09 Thread Konrad Rzeszutek Wilk
On October 9, 2015 8:14:39 AM EDT, "Vladimir 'φ-coder/phcoder' Serbinenko" <phco...@gmail.com> wrote: >On 08.10.2015 21:34, Konrad Rzeszutek Wilk wrote: >> On October 8, 2015 10:52:25 AM EDT, Andrei Borzenkov ><arvidj...@gmail.com> wrote: >>> On Thu,

Re: GNU GRUB maintenance

2015-10-09 Thread Konrad Rzeszutek Wilk
On Fri, Oct 09, 2015 at 08:30:01PM -0400, Konrad Rzeszutek Wilk wrote: > On October 9, 2015 8:14:39 AM EDT, "Vladimir 'φ-coder/phcoder' Serbinenko" > <phco...@gmail.com> wrote: > >On 08.10.2015 21:34, Konrad Rzeszutek Wilk wrote: > >> On October 8, 2

Re: GNU GRUB maintenance

2015-10-08 Thread Konrad Rzeszutek Wilk
On October 8, 2015 10:52:25 AM EDT, Andrei Borzenkov wrote: >On Thu, Oct 8, 2015 at 12:14 AM, Vladimir 'φ-coder/phcoder' Serbinenko > wrote: >> Hello, all. I'm sorry for not being available to do enough >maintenance >> for GRUB in last time but I was

Re: [Xen-devel] [PATCH v2 22/23] x86: make Xen early boot code relocatable

2015-08-28 Thread Konrad Rzeszutek Wilk
On Fri, Aug 28, 2015 at 02:22:46AM -0600, Jan Beulich wrote: On 27.08.15 at 19:56, 426...@gmail.com wrote: If you advocate direct booting ( no boot loader) on production machines I wont argue much, as long as there is good recovery tools to deal with failed boots (grub does this very

Re: Development practices?

2015-09-08 Thread Konrad Rzeszutek Wilk
On Thu, Sep 03, 2015 at 03:34:29PM -0400, Konrad Rzeszutek Wilk wrote: > Hey, Expanding the circle, including folks on the To list. Colin had answered some so snipping thouse out. > > I've noticed a couple of things that the community seems > to be doing different than other

Re: Development practices?

2015-09-11 Thread Konrad Rzeszutek Wilk
On Fri, Sep 11, 2015 at 05:34:45PM +0300, Andrei Borzenkov wrote: > 09.09.2015 20:47, Felix Zielcke пишет: > >Am Dienstag, den 08.09.2015, 13:57 -0400 schrieb Konrad Rzeszutek Wilk: > >>On Thu, Sep 03, 2015 at 03:34:29PM -0400, Konrad Rzeszutek Wilk > >>wrote: > &

Re: Development practices?

2015-09-11 Thread Konrad Rzeszutek Wilk
. snip.. > > From what I have gathered so far the not enough reviewers > >is tied in folks being overworked - so there simply was no > >point of posting on the mailing list as nobody had the time > >to review it or test it properly? > > > >>> > >>>Hi Konrad, > >>> > >>>back in

Re: Development practices?

2015-09-22 Thread Konrad Rzeszutek Wilk
On Fri, Sep 11, 2015 at 11:34:53AM -0400, Konrad Rzeszutek Wilk wrote: > .. snip.. > > >>>>> From what I have gathered so far the not enough reviewers > > >>>>>is tied in folks being overworked - so there simply was no > > >>>&

Re: Development practices?

2015-09-24 Thread Konrad Rzeszutek Wilk
On September 24, 2015 3:09:20 PM EDT, Andrei Borzenkov <arvidj...@gmail.com> wrote: > > >Отправлено с iPhone > >> 22 сент. 2015 г., в 20:28, Konrad Rzeszutek Wilk ><konrad.w...@oracle.com> написал(а): >> >>> On Fri, Sep 11, 2015 at 11:34:53AM

Re: FOSDEM

2016-01-31 Thread Konrad Rzeszutek Wilk
On January 31, 2016 4:12:15 AM EST, Vladimir 'phcoder' Serbinenko wrote: >If anybody would like to connect or discuss patches, design and so on, >feel >free to drop by at coreboot booth at FOSDEM. Non-coreboot GRUB topics >are >welcome as well Thank you. Could you in the

Re: 2.02~beta3 release

2016-02-29 Thread Konrad Rzeszutek Wilk
On Sun, Feb 28, 2016 at 03:21:44PM +0100, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > Hello, all. I've just released 2.02~beta3. The goal of this release is > to chase bugs so that we can move to 2.02 release. So from now on if you > think that your patch should be included in 2.02 rather than

Re: [GRUB2 PATCH v4 2/4] multiboot2: Add tags used to pass ImageHandle to loaded image

2016-03-15 Thread Konrad Rzeszutek Wilk
On Tue, Mar 15, 2016 at 04:25:59PM +0100, Daniel Kiper wrote: > Add tags used to pass ImageHandle to loaded image if requested. > It is used by at least ExitBootServices() function. > > Signed-off-by: Daniel Kiper <daniel.ki...@oracle.com> Reviewed-by: Konrad Rzeszu

Re: [GRUB2 PATCH v4 3/4 - FOR REVIEW ONLY] multiboot2: Do not pass memory maps to image if EFI boot services are enabled

2016-03-15 Thread Konrad Rzeszutek Wilk
dicating 'STALE-CHECK-EFI'.. > > Signed-off-by: Daniel Kiper <daniel.ki...@oracle.com> > Reviewed-by: Konrad Rzeszutek Wilk <konrad.w...@oracle.com> > --- > v3 - suggestions/fixes: >- improve commit message > (suggested by Konrad Rzeszutek Wilk and Vla

Re: Bugs and tasks for 2.02[~rc1]

2016-04-12 Thread Konrad Rzeszutek Wilk
On Mon, Mar 28, 2016 at 10:59:03AM -0400, Konrad Rzeszutek Wilk wrote: > ..snip.. > > What about > > > > - disk IO buffer alignment for small read (I personally prefer the first > > version of Leif's patch that exposes alignment in core, it also allows >

Re: [GRUB2 PATCH v4 3/4 - FOR REVIEW ONLY] multiboot2: Do not pass memory maps to image if EFI boot services are enabled

2016-03-19 Thread Konrad Rzeszutek Wilk
te: > > > > > > On Tue, Mar 15, 2016 at 07:46:46PM -0400, Konrad Rzeszutek Wilk wrote: > > >> On Tue, Mar 15, 2016 at 04:26:00PM +0100, Daniel Kiper wrote: > > >>> Do not pass memory maps to image if it asked for EFI boot services. > > >> >

Re: [GRUB2 PATCH v5 1/4] i386/relocator: Add grub_relocator64_efi relocator

2016-03-25 Thread Konrad Rzeszutek Wilk
boot services without any issues. > > Signed-off-by: Daniel Kiper <daniel.ki...@oracle.com> Reviewed-by: Konrad Rzeszutek Wilk <konrad.w...@oracle.com> .. with one modification: .. snip.. > diff --git a/grub-core/lib/x86_64/efi/relocator.c > b/grub-core/lib/x86_64/e

Re: [GRUB2 PATCH v5 4/4] multiboot2: Add support for relocatable images

2016-03-25 Thread Konrad Rzeszutek Wilk
gt; This patch does not provide functionality which could do relocations using > ELF relocation data. However, I was asked by Konrad Rzeszutek Wilk and > Vladimir > 'phcoder' Serbinenko to investigate that thing. It looks that relevant > machinery > could be added to existing cod

Re: [PATCH v4 0/4] arm64,xen: add xen_boot support into grup-mkconfig

2016-05-13 Thread Konrad Rzeszutek Wilk
On Tue, May 10, 2016 at 10:03:22PM +0800, fu@linaro.org wrote: > From: Fu Wei > > This patchset add xen_boot support into grup-mkconfig for > generating xen boot entrances automatically > All of them look good to me. Thanks! > Also update the docs/grub.texi for new

Re: [PATCH] Add fwconfig command

2017-01-24 Thread Konrad Rzeszutek Wilk
On Tue, Jan 24, 2017 at 04:36:03PM +, Colin Watson wrote: > On Tue, Jan 24, 2017 at 09:52:35AM -0500, Konrad Rzeszutek Wilk wrote: > > On Mon, Jan 23, 2017 at 03:43:32PM -0800, Matthew Garrett wrote: > > > + * GRUB is free software: you can redistribute it and/or modify &

Re: [PATCH] Add fwconfig command

2017-01-24 Thread Konrad Rzeszutek Wilk
On Mon, Jan 23, 2017 at 03:43:32PM -0800, Matthew Garrett wrote: > Add a command to read values from the qemu fwcfg store. This allows data > to be passed from the qemu command line to grub. > > Example use: > > echo '(hd0,1)' >rootdev > qemu -fw_cfg opt/rootdev,file=rootdev > > fwconfig

Re: New maintainers

2016-08-16 Thread Konrad Rzeszutek Wilk
On Tue, Aug 16, 2016 at 03:32:12PM +, Vladimir 'phcoder' Serbinenko wrote: > Hello, all. I’m delighted to announce that Daniel Kiper, Alexander > Burmashev and Alexei Borzenkov have accepted to become co-maintainers of > GNU GRUB. > This is great news. In last 2 years my availability was

Re: Patch: Improve HTTP time by sending Connection:close

2016-11-17 Thread Konrad Rzeszutek Wilk
On Thu, Nov 17, 2016 at 07:32:16PM +0100, Daniel Kiper wrote: > On Tue, Nov 15, 2016 at 01:43:16PM -0800, Walter Huf wrote: > > GRUB has a bug where it waits a minimum of 400ms for every file it fetches > > over HTTP, unless the server serves it with Transfer-Encoding:chunked or > > the file just

Re: [MULTIBOOT2 DOC PATCH v3 00/13] multiboot2: Update documentation

2016-12-07 Thread Konrad Rzeszutek Wilk
On Wed, Dec 07, 2016 at 12:26:19PM +0100, Daniel Kiper wrote: > On Tue, Dec 06, 2016 at 10:45:54PM -0500, Konrad Rzeszutek Wilk wrote: > > On December 6, 2016 5:52:48 PM EST, Daniel Kiper <daniel.ki...@oracle.com> > > wrote: > > >Hi, > > > > >

Re: [MULTIBOOT2 DOC PATCH v3 07/13] multiboot2: Add description of support for EFI boot services

2016-12-07 Thread Konrad Rzeszutek Wilk
.snip.. > --- a/doc/multiboot.texi > +++ b/doc/multiboot.texi > @@ -528,6 +528,66 @@ The physical address to which the boot loader should > jump in order to > start running the operating system. > @end table > > +@subsection EFI i386 entry address tag of Multiboot2 header > + > +@example >

Re: [PATCH] multiboot2: Fix alignment of header tags

2017-03-10 Thread Konrad Rzeszutek Wilk
On Fri, Mar 10, 2017 at 05:13:58PM +0100, Daniel Kiper wrote: > Header tags have to be 8-bytes aligned. So, fix it. > Additionally, mention header closing tag in the spec. > > Signed-off-by: Daniel Kiper <daniel.ki...@oracle.com> Reviewed-by: Konrad Rzeszutek Wilk <k

Re: [PATCH v2 14/14] efi: change heap allocation type to GRUB_EFI_LOADER_CODE

2017-08-07 Thread Konrad Rzeszutek Wilk
On Mon, Aug 07, 2017 at 02:11:16PM +, Vladimir 'phcoder' Serbinenko wrote: > LGTM Is LGTM equivalant to Acked-by? > > Le Thu, Aug 3, 2017 à 12:09 PM, Leif Lindholm a > écrit : > > > With upcoming changes to EDK2, allocations of type EFI_LOADER_DATA may > > not

Re: ZFS boot environment patch

2017-09-15 Thread Konrad Rzeszutek Wilk
On Fri, Sep 15, 2017 at 12:57:39AM +0100, Colin Watson wrote: > On Thu, Sep 14, 2017 at 09:22:01PM +0200, Paul Lagerweij wrote: > > On Wed, 13 Sep 2017 at 09:17:42PM +0100, Colin Watson wrote: > > > > On Wed, Sep 13, 2017 at 11:02:48AM -0400, Konrad Rzeszutek Wilk wrote: >

Re: ZFS boot environment patch

2017-09-13 Thread Konrad Rzeszutek Wilk
On Fri, Sep 01, 2017 at 01:31:28PM +0200, Paul Lagerweij wrote: > Hello, > > I've created a patch for util/grub.d/10_linux.in for dynamic ZFS boot > environment entries. I've only tested the patch in Ubuntu 16.04.2 with GRUB > 2.02~beta2, ZFS on Linux 0.6.5.6, Linux 4.4.0-83 and 4.4.0-81, but the

Re: GRUB documentation updated

2017-09-14 Thread Konrad Rzeszutek Wilk
On Thu, Sep 07, 2017 at 09:12:33PM +0200, Daniel Kiper wrote: > Hey, > > Some people asked me about Multiboot2 Specification and other GRUB doc stuff. > So, I have put latest things at > https://www.gnu.org/software/grub/grub-documentation.html Yeey! Thank you for doing that! > > I hope that

[PATCH v2 2/2] Use grub-file to figure out whether multiboot2 should be used for Xen.gz

2017-08-29 Thread Konrad Rzeszutek Wilk
The multiboot2 is much more preferable than multiboot. Especiall if booting under EFI where multiboot does not have the functionality to pass ImageHandler. Signed-off-by: Konrad Rzeszutek Wilk <konrad.w...@oracle.com> --- v2: Rebase on top of d33045ce7ffcb7c1e4a60c14d5ca64b36e3c5abe v

[PATCH v2 1/2] Fix util/grub.d/20_linux_xen.in: Add xen_boot command support for aarch64

2017-08-29 Thread Konrad Rzeszutek Wilk
not work if xen.gz is installed. CC: Fu Wei <fu@linaro.org> Signed-off-by: Konrad Rzeszutek Wilk <konrad.w...@oracle.com> --- v1: Initial patch v2: Add the failing output. --- util/grub.d/20_linux_xen.in | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a

[PATCH v2] Fix ARM multiboot2 breaking Fedora.

2017-08-29 Thread Konrad Rzeszutek Wilk
allows us to multiboot2 instead of multiboot if the binary supports it. util/grub.d/20_linux_xen.in | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) Konrad Rzeszutek Wilk (2): Fix util/grub.d/20_linux_xen.in: Add xen_boot command support for aarch64 Use grub-file

Commits in origin/master that haven't been posted on grub-devel?

2017-09-07 Thread Konrad Rzeszutek Wilk
Hey, As I was checking on 'origin/master' hoping to see two of my patches checked in I noticed these: commit 78d2b81bd1af0a3a84d0c23c9ff4af3caa2df23b (origin/master, origin/HEAD) Author: Vladimir Serbinenko Date: Thu Sep 7 13:55:22 2017 +0200 Fix compilation for

[PATCH 1/2] Fix util/grub.d/20_linux_xen.in: Add xen_boot command support for aarch64

2017-08-28 Thread Konrad Rzeszutek Wilk
. That fixes the issue. RH-BZ 1486002: grub2-mkconfig does not work if xen.gz is installed. CC: Fu Wei <fu@linaro.org> Signed-off-by: Konrad Rzeszutek Wilk <konrad.w...@oracle.com> --- util/grub.d/20_linux_xen.in | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff

[PATCH 2/2] Use grub-file to figure out whether multiboot2 should be used for Xen.gz

2017-08-28 Thread Konrad Rzeszutek Wilk
The multiboot2 is much more preferable than multiboot. Especiall if booting under EFI where multiboot does not have the functionality to pass ImageHandler. Signed-off-by: Konrad Rzeszutek Wilk <konrad.w...@oracle.com> --- v2: Rebase on top of d33045ce7ffcb7c1e4a60c14d5ca64b36e3c5abe ---

[PATCH] Fix ARM multiboot2 breaking Fedora.

2017-08-28 Thread Konrad Rzeszutek Wilk
| 13 - 1 file changed, 8 insertions(+), 5 deletions(-) Konrad Rzeszutek Wilk (2): Fix util/grub.d/20_linux_xen.in: Add xen_boot command support for aarch64 Use grub-file to figure out whether multiboot2 should be used for Xen.gz

Re: [PATCH 1/2] Fix util/grub.d/20_linux_xen.in: Add xen_boot command support for aarch64

2017-08-28 Thread Konrad Rzeszutek Wilk
On Mon, Aug 28, 2017 at 02:40:14PM -0400, Konrad Rzeszutek Wilk wrote: > Commit d33045ce7ffcb7c1e4a60c14d5ca64b36e3c5abe introduced > the support for this, but it does not work under x86 (as it stops > 20_linux_xen from running). > > The 20_linux_xen is run under a shell and any ex

Re: [PATCH 1/2] Fix util/grub.d/20_linux_xen.in: Add xen_boot command support for aarch64

2017-08-29 Thread Konrad Rzeszutek Wilk
On Tue, Aug 29, 2017 at 03:12:59PM +0800, Fu Wei Fu wrote: > Hi Konrad, > > Thanks for your feedback. Thank you for speedy response! > > On 29 August 2017 at 02:40, Konrad Rzeszutek Wilk > <konrad.w...@oracle.com> wrote: > > Commit d33045ce7ffcb7c1e4a60

Re: [Xen-devel] Xen PVH support in grub2

2017-11-08 Thread Konrad Rzeszutek Wilk
On Tue, Nov 07, 2017 at 11:10:29AM -0500, Boris Ostrovsky wrote: > On 11/07/2017 02:42 AM, Juergen Gross wrote: > > On 06/11/17 17:42, Boris Ostrovsky wrote: > >> On 11/06/2017 10:05 AM, Juergen Gross wrote: > >>> On 06/11/17 15:51, Boris Ostrovsky wrote: > On 11/06/2017 02:16 AM, Juergen

Re: Multiboot ELF segment handling patch

2018-04-17 Thread Konrad Rzeszutek Wilk
On April 17, 2018 3:40:11 PM EDT, Daniel Kiper wrote: >Hi Alexander, > >On Sat, Apr 14, 2018 at 12:07:29AM +0200, Alexander Boettcher wrote: >> Hello, >> >> On 06.04.2018 14:28, Daniel Kiper wrote: >> > On Thu, Mar 29, 2018 at 11:20:37AM +0200, Alexander Boettcher >wrote: >>

Re: [PATCH v3 5/8] verifiers: Rename verify module to pgp module

2018-10-09 Thread Konrad Rzeszutek Wilk
> > I did "git mv" but "git format-patch" produced this. I am not sure that > "git format-patch" is sufficiently smart to produce shorter stuff. Look at the -M param for git format-patch. ___ Grub-devel mailing list Grub-devel@gnu.org

  1   2   >