How do I find out what module is needed for a command?

2013-04-05 Thread Paul Menzel
Dear GRUB developers, is there a program/script, which module I need to load to get a certain command? Using my distribution `/boot/grub/grub.cfg` $ more /boot/grub/grub.cfg […] if [ -s $prefix/grubenv ]; then load_env fi set default=1Debian

SATA disk on cntroller in AHCI mode not found: `disk/ahci.c:225: couldn't start CR`

2013-04-05 Thread Paul Menzel
Dear GRUB developers, as reported to the coreboot mailing list already [1][2], using GRUB (4778) as a payload [3] on the AMD SB800 based ASRock E350M1 [4], the SATA disk attached to the SATA controller is not found when the controller is in AHCI mode. Using IDE mode works. grub set

Re: [PATCH] reimplement grub-reboot to nor depend on GRUB_DEFAULT=saved

2013-04-07 Thread Paul Menzel
Am Sonntag, den 07.04.2013, 14:34 +0400 schrieb Andrey Borzenkov: В Sat, 06 Apr 2013 21:52:15 +0200 Vladimir 'φ-coder/phcoder' Serbinenko phco...@gmail.com пишет: On 30.01.2013 10:08, Andrey Borzenkov wrote: + savenev next_entry + savenev next_entry Have you actually tested

Re: SATA disk on cntroller in AHCI mode not found: Hang at `AHCI status 1 0 150`

2013-04-19 Thread Paul Menzel
Dear GRUB folks, Am Donnerstag, den 18.04.2013, 13:11 +0200 schrieb Paul Menzel: here is an update on the issue I only reported to #grub on irc.freenode.net. Am Freitag, den 05.04.2013, 12:54 +0200 schrieb Paul Menzel: as reported to the coreboot mailing list already [1][2], using

[RFC][PATCH] documentation update

2013-04-23 Thread Paul Menzel
Dear Vladimir, you can use the [RFC] tag (*r*equest *f*or *c*omments) to mark draf patches. Also inline patches (not sure how to do this with Bazaar) would it make easier for me to comment them. Am Dienstag, den 23.04.2013, 14:14 +0400 schrieb Vladimir Testov: diff -Naur

GRUB as coreboot payload with *working* AHCI mode support

2013-04-28 Thread Paul Menzel
Dear GRUB folks, just for your information, I successfully tested revision 4911 containing the AHCI support, Vladimir committed yesterday. Big thanks to Vladimir! Here is the serial log from running coreboot with the GRUB payload on the ASRock E350M1. […] 01.069: Adding CBMEM

Re: GRUB as coreboot payload with *working* AHCI mode support

2013-04-28 Thread Paul Menzel
Am Sonntag, den 28.04.2013, 13:25 +0200 schrieb Vladimir 'φ-coder/phcoder' Serbinenko: On 28.04.2013 11:02, Paul Menzel wrote: […] 02.316: 1b[H1b[J1b[1;1Hdisk/ahci.c:211: dev: 0:11.0 Here the debug messages start as there is `set debug=ahci` in `grub.cfg` in the memdisk

[MERGE] AHCI: Put terms of `grub_ahci_hba_port_command` members in comments

2013-04-28 Thread Paul Menzel
'ChangeLog' --- ChangeLog 2013-04-27 21:06:52 + +++ ChangeLog 2013-04-28 12:12:49 + @@ -1,3 +1,7 @@ +2013-04-28 Paul Menzel paulepan...@users.sourceforge.net + + * AHCI: Put terms of `grub_ahci_hba_port_command` members in comments + 2013-04-27 Paulo Flabiano Smorigo pfsmor...@br.ibm.com

Re: halt: reboot instead of power-off on ASRock E350M1 with coreboot

2013-06-06 Thread Paul Menzel
Dear GRUB developers, Am Sonntag, den 02.06.2013, 11:14 +0200 schrieb Paul Menzel: on the ASRock E350M1 with coreboot, running the GRUB 2 payload and loading the module `halt` and executing `halt`, the system reboots instead of halting. The GRUB 2 revision includes the latest DSDT parser

Re: [BUG][PATCH] configure.ac: Respect the configured freetype-config

2013-06-09 Thread Paul Menzel
Am Samstag, den 08.06.2013, 08:00 +0400 schrieb Andrey Borzenkov: В Fri, 7 Jun 2013 14:35:10 -0400 David Michael fedora@gmail.com пишет: On Fri, Jun 7, 2013 at 2:20 PM, Andrey Borzenkov arvidj...@gmail.com wrote: But FREETYPE cannot be anything than freetype-config, can it? Do you

[RFC] Moving from Bazaar (bzr) to git

2013-06-22 Thread Paul Menzel
Dear GRUB folks, this is *not* the start of a flame war about what VCS is the best. Hopefully everyone will agree, that git is the most popular one in the FOSS world (Linux, freedesktop.org, GNOME, KDE, …) and a lot of people are now familiar with the basic git commands. So using Bazaar is one

Passing two arguments to `terminal_*` both fail to load if the first one fails

2014-02-12 Thread Paul Menzel
Dear GRUB folks, using coreboot with GRUB 2 as payload built with `make default_payload` and putting `grub.cfg` into CBFS containg the lines below […] serial --unit=0 --speed=115200 terminal_input console serial terminal_output console serial […] I do

Building GRUB fails with `In function `do_setkey' undefined reference to `fips_mode'`

2014-12-26 Thread Paul Menzel
Dear GRUB folks, with latest master $ git describe grub-2.02-beta2-137-gbac5d1a building GRUB as a coreboot payload fails on Debian Sid/unstable. $ make clean $ ./configure --with-platform=coreboot $ make […] mv -f

Re: Building GRUB fails with `In function `do_setkey' undefined reference to `fips_mode'`

2014-12-29 Thread Paul Menzel
Am Freitag, den 26.12.2014, 20:59 +0300 schrieb Andrei Borzenkov: В Fri, 26 Dec 2014 11:23:24 +0100 Paul Menzel пишет: with latest master $ git describe grub-2.02-beta2-137-gbac5d1a building GRUB as a coreboot payload fails on Debian Sid/unstable

[PATCH] docs/grub.texi: Fix spelling of cbfstool

2015-04-11 Thread Paul Menzel
Date: Sat, 11 Apr 2015 21:40:50 +0200 --- docs/grub.texi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/grub.texi b/docs/grub.texi index 46b9e7f..4af22af 100644 --- a/docs/grub.texi +++ b/docs/grub.texi @@ -5848,7 +5848,7 @@ Following variables must be defined:

make check: Tests for platform coreboot using temporary files fail

2015-04-11 Thread Paul Menzel
Dear GRUB developers, using Debian Sid/unstable, building GRUB from commit f11db3c (core: avoid NULL derefrence in grub_divmod64s) and running `make check`, all the tests using temporary files fail. $ ./autogen.sh $ ./configure --with-platform=coreboot --enable-boot-time

cb_timestamps.c: Add new time stamp descriptions

2015-05-15 Thread Paul Menzel
Date: Fri, 15 May 2015 17:35:00 +0200 Add the descriptions of the “core”, that means no vendorcode or payload, coreboot time stamps added up to coreboot commit a7d92441 (timestamps: You can never have enough of them!) [1]. Running `cbtime` in the GRUB command line interface now shows

[PATCH v2] cb_timestamps.c: Add new time stamp descriptions

2015-05-15 Thread Paul Menzel
Date: Fri, 15 May 2015 17:35:00 +0200 Add the descriptions of the “core”, that means no vendorcode or payload, coreboot time stamps added up to coreboot commit a7d92441 (timestamps: You can never have enough of them!) [1]. Running `coreboot_boottime` in the GRUB command line interface now shows

Read and publish firmware time stamps and boot time (was: [systemd-devel] bootloader time on a non-EFI bootloader)

2015-04-06 Thread Paul Menzel
[CC’ing coreboot, GRUB, SeaBIOS, Syslinux project and Linux kernel] Am Montag, den 16.03.2015, 11:38 +0100 schrieb Kay Sievers: On Mon, Mar 16, 2015 at 11:29 AM, Umut Tezduyar Lindskog wrote: I would like to pass the time it was spent in bootloader to systemd. Is there a kernel command line

[PATCH v2] disk/ahci.c: Use defines `GRUB_AHCI_HBA_PORT_CMD_SPIN_UP` and `GRUB_AHCI_HBA_PORT_CMD_POWER_ON`

2015-06-07 Thread Paul Menzel
Date: Thu, 28 May 2015 19:14:19 +0200 Instead of hard coding `2` and `4` use the macros defined already at the top of the file. As a consequence, wrap the now too long line. --- v2: Merge both patches. grub-core/disk/ahci.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

[PATCH 2/2] disk/ahci.c: Wrap too long line

2015-05-28 Thread Paul Menzel
Date: Thu, 28 May 2015 19:50:51 +0200 Using the macros the line is too long, so wrap it. --- grub-core/disk/ahci.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/grub-core/disk/ahci.c b/grub-core/disk/ahci.c index 0825998..fa7aa88 100644 --- a/grub-core/disk/ahci.c +++

[PATCH 1/2] disk/ahci.c: Use defines `GRUB_AHCI_HBA_PORT_CMD_SPIN_UP` and `GRUB_AHCI_HBA_PORT_CMD_POWER_ON`

2015-05-28 Thread Paul Menzel
Date: Thu, 28 May 2015 19:14:19 +0200 Instead of hard coding `2` and `4` use the macros defined already at the top of the file. --- grub-core/disk/ahci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/grub-core/disk/ahci.c b/grub-core/disk/ahci.c index 7f75724..0825998

[PATCH v2] disk/ahci.c: Add port number to port debug messages

2015-05-28 Thread Paul Menzel
Date: Wed, 27 May 2015 22:48:57 +0200 Currently, some messages cannot be mapped to the port they belong to as the port number is missing from the output. So add `port: n` to the debug messages. --- grub-core/disk/ahci.c | 22 +++--- 1 file changed, 11 insertions(+), 11

[PATCH] disk/ahci: Use defines `GRUB_ATA_STATUS_BUSY` and `GRUB_ATA_STATUS_DRQ`

2015-05-24 Thread Paul Menzel
Date: Sun, 24 May 2015 11:11:25 +0200 Instead of hard coding `0x88` use the macros defined in `disk/ata.h`. --- grub-core/disk/ahci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/grub-core/disk/ahci.c b/grub-core/disk/ahci.c index d6bdbdd..7f75724 100644 ---

Re: disk/ahci: Unaligned pointer with old commit as coreboot payload

2015-05-24 Thread Paul Menzel
Dear Andrei, Am Sonntag, den 24.05.2015, 13:15 +0300 schrieb Andrei Borzenkov: В Sun, 24 May 2015 09:03:40 +0200 Paul Menzel пишет: further trying to bisect the AHCI regression on, that the GRUB payload does not detect the AHCI drive [1], I tried to build GRUB from commits changing `grub

Re: disk/ahci: Unaligned pointer with old commit as coreboot payload

2015-05-24 Thread Paul Menzel
Dear Andrei, Am Sonntag, den 24.05.2015, 21:23 +0300 schrieb Andrei Borzenkov: В Sun, 24 May 2015 14:30:28 +0200 Paul Menzel пишет: Am Sonntag, den 24.05.2015, 13:15 +0300 schrieb Andrei Borzenkov: В Sun, 24 May 2015 09:03:40 +0200 Paul Menzel пишет: further trying to bisect

[PATCH] Correct spelling of *scheduled*

2015-05-25 Thread Paul Menzel
Date: Sun, 24 May 2015 23:27:46 +0200 Run the command below $ git grep -l schedulded | xargs sed -i 's/schedulded/scheduled/g' and revert the change in `ChangeLog-2015`. --- gentpl.py | 2 +- grub-core/disk/ahci.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)

AHCI: SATA drive not detected by GRUB payload for coreboot

2015-05-25 Thread Paul Menzel
Dear GRUB folks, as already mentioned, currently using coreboot with the GRUB payload on the ASRock E350M1, the HDD connected over Serial ATA (SATA) at port 2, or any other port, is not detected. Using an SSD instead it’s also *not* detected. This issue is present since at least last year and

disk/ahci: Unaligned pointer with old commit as coreboot payload

2015-05-24 Thread Paul Menzel
Dear GRUB folks, further trying to bisect the AHCI regression on, that the GRUB payload does not detect the AHCI drive [1], I tried to build GRUB from commits changing `grub-core/disk/ahci.c`, I built commit dc2a6c8b (Improve AHCI detection and command issuing.), but it it fails to boot with

Keyboard not working with QEMU and coreboot and GRUB payload

2015-08-18 Thread Paul Menzel
Dear GRUB folks, just a note that using QEMU with coreboot and GRUB payload, I am unable to enter anything. Using libpayload based payloads, the keyboard works, so I think it’s GRUB related. Thanks, Paul $ qemu-system-i386 -M q35 -bios 20150808--coreboot-qemu-q35-with-grub.rom -serial

Fails to build with GCC from Debian Sid/unstable: `/usr/bin/ld: -r and -pie may not be used together`

2016-11-26 Thread Paul Menzel
Dear GRUB folks, Using Debian Sid/unstable with GCC 6.2, which has PIE enabled by default *in Debian* since some time [1], building GRUB for the platform *coreboot* fails. ``` $ gcc --version gcc (Debian 6.2.1-5) 6.2.1 20161124 […] $ ld --version GNU ld (GNU Binutils for Debian)

Re: xHCI driver

2016-11-26 Thread Paul Menzel
Dear Bjørn, Am Freitag, den 25.11.2016, 13:43 +0100 schrieb Bjørn Forsman: > My name is Bjørn Forsman, first time poster. I've been tasked to make > an xHCI driver for GRUB at my $dayjob. The end goal is to have smart > card (CCID) reader functionality. We already have a working CCID > driver

Re: Fails to build with GCC from Debian Sid/unstable: `/usr/bin/ld: -r and -pie may not be used together`

2016-12-13 Thread Paul Menzel
Dear Andrei, I am sorry for the late reply. Am Samstag, den 26.11.2016, 20:07 +0300 schrieb Andrei Borzenkov: > 26.11.2016 19:48, Paul Menzel пишет: > > Using Debian Sid/unstable with GCC 6.2, which has PIE enabled by > > default *in Debian* since some time [1], building GRUB f

Re: [solved] Build error with clang 4.0

2017-01-06 Thread Paul Menzel
Dear Andrei, Am Freitag, den 30.12.2016, 18:44 +0300 schrieb Andrei Borzenkov: > 27.12.2016 18:10, Paul Menzel пишет: > > Using Clang 4.0 the build fails with the error below. > > > > ``` > > $ sudo apt install clang-4.0 # Debian Sid/unstable > > $ clang-4.0

[PATCH] INSTALL: Remove spaces from blank line

2016-12-27 Thread Paul Menzel
Date: Tue, 27 Dec 2016 16:15:34 +0100 ---  INSTALL | 2 +-  1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/INSTALL b/INSTALL index e5b081105..0c8ef51ec 100644 --- a/INSTALL +++ b/INSTALL @@ -101,7 +101,7 @@ The simplest way to compile this package is:      2. Skip this and following

Build error with clang 4.0

2016-12-27 Thread Paul Menzel
Dear GRUB folks, Using Clang 4.0 the build fails with the error below. ``` $ sudo apt install clang-4.0 # Debian Sid/unstable $ clang-4.0 --version clang version 4.0.0-svn286225-1 (trunk) Target: i686-pc-linux-gnu Thread model: posix InstalledDir: /usr/bin $ git log --oneline -1 ce95549cc efi:

[PATCH] Makefile.am: Add `all_video` to `default_payload.elf`

2017-04-16 Thread Paul Menzel
Date: Sun, 16 Apr 2017 21:02:58 +0200 The module `all_video` is used in `util/grub.d/00_header.in`, and included for grub-pc by default. To make it easier to load such a GRUB configuration from disk for a GRUB coreboot payload, add this module also to `default_payload.elf` by default. That

`all_video.mod` missing loading `grub.cfg` generated by grub-pc in GRUB payload (coreboot)

2017-04-15 Thread Paul Menzel
Dear GRUB folks, When using GRUB as a coreboot payload, that means passing `--with- platform=coreboot` to configure, and configuring it to load the GRUB configuration file from disk, `/boot/grub/grub.cfg` in Debian 8.7 (Jessie/stable) and 9 (Stretch/testing), generated by GRUB shipped by the

`halt` doesn’t work on Lenovo T60 with coreboot and GRUB payload

2017-04-15 Thread Paul Menzel
Dear GRUB folks, On a Lenovo T60 with coreboot and the GRUB payload, version 2.02-rc1, entering `halt` in the GRUB command line, nothing happens. The cursor goes one line below, and everything stays that way. After that, the system can only be powered off by pressing the power button for ten

How to deal with `multiboot` and compressed files

2017-04-15 Thread Paul Menzel
Dear GRUB folks, The payloads for coreboot are normally LZMA compressed, as there is only little room on a flash ROM chip. Vladimir adapted SeaBIOS so it’s Multiboot compatible, so that SeaBIOS and the VGA Option can be easily loaded from the hard disk, and not the flash ROM chip. Trying to

Re: `all_video.mod` missing loading `grub.cfg` generated by grub-pc in GRUB payload (coreboot)

2017-04-16 Thread Paul Menzel
Dear Andrei, Am Samstag, den 15.04.2017, 14:22 +0300 schrieb Andrei Borzenkov: > 15.04.2017 13:25, Paul Menzel пишет: > > When using GRUB as a coreboot payload, that means passing `--with- > > platform=coreboot` to configure, and configuring it to load the GRUB > > configu

Re: `halt` doesn’t work on Lenovo T60 with coreboot and GRUB payload

2017-04-16 Thread Paul Menzel
Dear Andrei, Thank you for your reply. Am Samstag, den 15.04.2017, 19:52 +0300 schrieb Andrei Borzenkov: > 15.04.2017 19:32, Paul Menzel пишет: > > On a Lenovo T60 with coreboot and the GRUB payload, version 2.02-rc1, > > entering `halt` in the GRUB command line, nothing happ

Re: [coreboot] RFC: Changing CBMEM console to run as a persistent ring-buffer

2017-04-22 Thread Paul Menzel
[For the GRUB folks, this is about coreboot commit d67c6876 (Turn CBMEM console into a ring buffer that can persist across reboots) [1]. Julius’ message can be find in the coreboot list archive [2].] Dear Julius, Am Montag, den 10.04.2017, 15:50 -0700 schrieb Julius Werner: […] > The change

Build failure on ppc64le

2017-07-01 Thread Paul Menzel
Dear GRUB folks, Building GRUB at commit 7346682 (Allow GRUB to mount ext2/3/4 filesystems that have the encryption feature.) for the platform `powerpc-ieee1275` with Ubuntu 16.04.02 LTS (Xenial Xerus) on such a machine (ppc64le), fails with the error below. ``` $ ./autogen.sh $ ./configure $

How to build GRUB for `arm_coreboot`?

2017-05-09 Thread Paul Menzel
Dear GRUB folks, After the GRUB 2.02 release, φ-coder’s work to get GRUB working on ARM is now in the master branch. I like to try GRUB with the coreboot “board” *emulation/qemu-armv7 (QEMU ARMv7)*, and did the following under Debian Sid/unstable ``` $ git log --oneline -1 d11ced1e1

Problems with loadfont and loading

2017-09-11 Thread Paul Menzel
Dear GRUB folks, Using coreboot with the GRUB payload, the font file is not found. I build GRUB as a coreboot payload, but only tell the configuration file in the memdisk to load the configuration file from the hard disk. (root is the partition mounted to `/boot`.) configfile

Re: [PATCH] tsc: Change default tsc calibration method to EFI on EFI systems

2017-09-12 Thread Paul Menzel
Dear David, Am Mittwoch, den 06.09.2017, 13:20 -0700 schrieb David E. Box: > On efi systems, make efi based tsc calibration the default, followed by > the pmtimer before using the pit. This prevents Grub boot failure on > newer x86 systems that power gate the pit. Could you please be specific,

Re: Making TODO first

2018-05-27 Thread Paul Menzel
Dear Inzo, Am Dienstag, den 15.05.2018, 05:10 +0600 schrieb Inzo Abe: > I am trying to improve grub. > Could you pls help me. Thank you for your offer. I guess the best thing to get started is to review patches and to look at the bug tracker [1]. Otherwise, just pick an item that interests

Any plans for GRUB 2.03 release?

2018-08-01 Thread Paul Menzel
Dear GRUB developers, A lot of changes have been made since the GRUB 2.02 release, and distribution start to cherry-pick them. In my opinion, it’d be helpful if a new release was made. Do you have already plans? Kind regards, Paul signature.asc Description: This is a digitally signed

[PATCH v3] Makefile.am: Add `all_video` to `default_payload.elf`

2018-08-09 Thread Paul Menzel
Date: Sun, 16 Apr 2017 21:02:58 +0200 The module `all_video` is used in `util/grub.d/00_header.in`, and included for grub-pc by default. To make it easier to load such a GRUB configuration from disk with a GRUB built as a coreboot payload, add this module also to `default_payload.elf` by

Re: Questions about grub_video_set_mode()

2018-08-09 Thread Paul Menzel
Dear Dexuan, Am Mittwoch, den 08.08.2018, 00:23 + schrieb Dexuan Cui: > I'm debugging a strange grub2 issue in a Linux Virtual Machine > running on Hyper-V. […] > 4. What's the best way to debug grub_video_set_mode()? > grub_dprintf() can't output anything in this function. Why?

[PATCH] ahci: Increase time-out from 10 s to 32 s

2018-08-09 Thread Paul Menzel
e reading failed. Signed-off-by: Paul Menzel --- grub-core/disk/ahci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/grub-core/disk/ahci.c b/grub-core/disk/ahci.c index f2f606423..0e6d56c24 100644 --- a/grub-core/disk/ahci.c +++ b/grub-core/disk/ahci.c @@ -576

Re: [PATCH resend] ofnet: Initialize structs in bootpath parser

2018-08-24 Thread Paul Menzel
On 08/23/18 14:12, Julian Andres Klode wrote: > Code later on checks if variables inside the struct are > 0 to see if they have been set, like if there were addresses > in the bootpath. > > The variables were not initialized however, so the check > might suceed with uninitialized data, and a

Re: How can I debug the grub2.02?

2018-08-22 Thread Paul Menzel
Dear Sherry, On 08/22/18 12:20, Sherry Zhang wrote: > I run into a error while I am testing. I have found that it is > normal berfore BIOS using the INT19 . But when the linux OS System is > booting , I can see the error log. So I doubt the error happens when > the grub is running. If I want

[PATCH v2] grub-install: Mention *efibootmgr* in `no-nvram` description

2018-09-06 Thread Paul Menzel
`, add the word to the description of the switch *no-nvram*, which skips the efibootmgr execution. Signed-off-by: Paul Menzel --- v2: Add Signed-off-by line util/grub-install.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/grub-install.c b/util/grub-install.c index

[PATCH] grub-install: Mention *efibootmgr* in no-nvram description

2018-09-06 Thread Paul Menzel
Date: Thu, 6 Sep 2018 15:15:45 +0200 If executing `efibootmgr` fails, for example, because the system is booted in legacy mode, but with a mounted EFI System Partition, the error message mentions *efibootmgr*. To make it easier for users to work around that problem by skipping running

Re: [PATCH] ahci: Improve error handling

2018-03-08 Thread Paul Menzel
Dear Stefan, Am Montag, den 29.01.2018, 13:16 +0100 schrieb Daniel Kiper: > On Tue, Jan 23, 2018 at 01:00:56PM +0100, Daniel Kiper wrote: > > On Fri, Jan 19, 2018 at 02:13:29PM +0100, Stefan Fritsch wrote: > > > From: Stefan Fritsch > > > > > > Check the error bits in the

Re: [PATCH v2] Makefile.am: Add `all_video` to `default_payload.elf`

2018-04-23 Thread Paul Menzel
Dear GRUB folks, Am Mittwoch, den 21.03.2018, 09:28 +0100 schrieb Paul Menzel: > From a199bc1f64e33aa942b23fe6d16670cc6002bb6c Mon Sep 17 00:00:00 2001 > From: Paul Menzel <paulepan...@users.sourceforge.net> > Date: Sun, 16 Apr 2017 21:02:58 +0200 > Subject: [PATCH] Makefile.

Re: [PATCH] Fix packed-not-aligned error on GCC 8

2018-03-31 Thread Paul Menzel
m> > > > Tested-by: Michael Chang <mch...@suse.com> > > > > Otherwise, Reviewed-by: Daniel Kiper <daniel.ki...@oracle.com> > > > > If there are no objections I will apply this in a week or so. > > Thank you very much. :) Tested-by: Paul Menzel <paulepan...@users.sourceforge.net> Thanks, Paul signature.asc Description: This is a digitally signed message part ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] F2FS support

2018-03-31 Thread Paul Menzel
Dear Pete, Am Donnerstag, den 29.03.2018, 17:08 +0100 schrieb Pete Batard: > Thanks for reviewing the patch. > Here's a v2 that takes your comments into account. Could you please make the commit message title a statement by adding a verb? > Add F2FS support Could you additionally add an

Re: [PATCH 1/7] Cryptomount support LUKS detached header

2018-03-21 Thread Paul Menzel
Dear John, Am Mittwoch, den 14.03.2018, 19:00 + schrieb John Lane: > On 14/03/18 13:05, Daniel Kiper wrote: > > On Wed, Mar 14, 2018 at 09:44:58AM +, John Lane wrote: > > > From: John Lane > > > > I have just skimmed through the series. First of all, most if not > >

./include/grub/gpt_partition.h:79:1: error: alignment 1 of ‘struct grub_gpt_partentry’ is less than 8 [-Werror=packed-not-aligned]

2018-03-21 Thread Paul Menzel
Dear GRUB folks, Building GRUB’s master branch with GCC 8 shows the error below. ``` $ gcc-8 --version | head -1 gcc-8 (Debian 8-20180320-1) 8.0.1 20180320 (experimental) [trunk revision 258670] $ git log --oneline -1 e2faabacf ieee1275: split up grub_machine_get_bootlocation $ ./autogen.sh $

[PATCH v2] Makefile.am: Add `all_video` to `default_payload.elf`

2018-03-21 Thread Paul Menzel
From a199bc1f64e33aa942b23fe6d16670cc6002bb6c Mon Sep 17 00:00:00 2001 From: Paul Menzel <paulepan...@users.sourceforge.net> Date: Sun, 16 Apr 2017 21:02:58 +0200 Subject: [PATCH] Makefile.am: Add `all_video` to default_payload.elf The module `all_video` is used in `util/grub.d/00_hea

[PATCH] unix/platform: Initialize variable to fix grub-install on UEFI system

2018-10-23 Thread Paul Menzel
. Installation finished. No error reported. [1]: https://github.com/rhboot/efibootmgr/issues/100 Signed-off-by: Paul Menzel --- grub-core/osdep/unix/platform.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/grub-core/osdep/unix/platform.c b/grub-core/osdep/unix/platform.c index

Re: [PATCH v3 0/2] btrfs: Add zstd support to grub btrfs

2018-10-10 Thread Paul Menzel
Dear Nick, Thank you very much for your patches. Am 10.10.2018 um 01:21 schrieb Nick Terrell: This patch set imports the upstream zstd library, adds zstd support to the btrfs module, and adds a test case. I've also tested the patch set by storing my boot partition in btrfs with and without

Re: [PATCH v3] Makefile.am: Add `all_video` to `default_payload.elf`

2018-10-01 Thread Paul Menzel
Dear Daniel, On 09/27/18 18:52, Daniel Kiper wrote: > On Wed, Sep 19, 2018 at 06:12:18PM +0200, Daniel Kiper wrote: >> On Thu, Sep 06, 2018 at 03:21:24PM +0200, Daniel Kiper wrote: >>> On Thu, Sep 06, 2018 at 03:07:57PM +0200, Vladimir 'phcoder' Serbinenko >>> wrote: Unfortunately this

Re: [PATCH v3 0/2] btrfs: Add zstd support to grub btrfs

2018-10-11 Thread Paul Menzel
Dear Nick, Am 10.10.2018 um 22:28 schrieb Nick Terrell: On Oct 10, 2018, at 12:34 AM, Paul Menzel wrote: Sorry for being ignorant, but you explain, why the library needs to be imported and it is not enough to use that library as an external dependency? Importing the library means, it has

Re: [PATCH v2] grub-install: Mention *efibootmgr* in `no-nvram` description

2018-09-19 Thread Paul Menzel
Dear Daniel, On 09/19/18 16:08, Daniel Kiper wrote: > On Thu, Sep 06, 2018 at 08:37:50PM +0300, Vladimir 'phcoder' Serbinenko wrote: >> On Thu, 6 Sep 2018, 17:03 Paul Menzel, wrote: >> >>> Date: Thu, 6 Sep 2018 15:15:45 +0200 >>> >>> If executin

Menu time-out missing when GRUB is loaded quickly and `at_keyboard`

2019-01-14 Thread Paul Menzel
Dear GRUB folks, When the module `at_keyboard` is directly into the GRUB image (`--modules`), and GRUB is loaded really quickly, then the timer, which, after counting down to 0 (`GRUB_TIMEOUT`), starts the selected entry, is not shown. I noticed this issue on the ASRock E350M1 with

Re: Detect combined bzImage and UEFI binary

2019-04-02 Thread Paul Menzel
Dear jame88fane, On 03/30/19 17:45, jame88f...@gmx.de wrote: […] > I have here a combined bzImage and UEFI binary and wanted to start it with > the linux/linuxefi command, but unfortunately GRUB2 does not recognize the > integrated UEFI binary and tries to start the bzImage. > > Could someone

[PATCH v2] Makefile: Allow to set file systems modules for default_payload.elf

2019-03-07 Thread Paul Menzel
y joey 832976 Mar 7 12:13 default_payload.elf So, the resulting payload size is around 370 kB smaller. (Adding it to the CBFS, it will be compressed, so the effective size difference will be smaller.) Signed-off-by: Paul Menzel --- Makefile.am | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

Re: [PATCH v2] Makefile: Allow to set file systems modules for default_payload.elf

2019-03-07 Thread Paul Menzel
Dear Daniel, On 07.03.19 20:37, Daniel Kiper wrote: On Thu, Mar 07, 2019 at 12:16:06PM +0100, Paul Menzel wrote: Date: Wed Mar 6 08:14:28 2019 +0100 By default all file system modules are added to the GRUB coreboot payload `default_payload.elf`. This makes the image quite big, especially

Re: [PATCH 1/1] Add new module msr

2019-02-18 Thread Paul Menzel
Dear Jesus, Thank you very much for your contribution. On 02/16/19 18:29, JesusDF wrote: > Add a new grub module called msr that registers two commands (rdmsr and wrmsr) > to be able to read and write to the model-specific registers. It is i386 > specific, as the cpuid module. The name of the

Re: [PATCH] Add knobs to allow non-initrd boot config

2019-02-18 Thread Paul Menzel
Dear Daniel, On 18.02.19 13:58, Daniel Kiper wrote: On Fri, Feb 15, 2019 at 07:44:55AM -0800, Nick Vinson wrote: Let me start of by saying that I am a contributor and do not have any authority to approve or deny patches to GRUB. That said I do have a few comments below that I would like

Re: [PATCH] Add travis-ci config file

2019-02-13 Thread Paul Menzel
Dear Alexander, On 02/12/19 18:00, Alexander Graf wrote: > There is a really convenient service for open source project from Travis > CI: They allow for free CI testing using their infrastructure. > > Grub has had issues with broken builds for various targets for a long time > already. The main

[PATCH] Add knobs to allow non-initrd boot config

2019-02-15 Thread Paul Menzel
https://code.launchpad.net/ubuntu/+source/grub2 2. Fix typo s/Then/When/] Signed-off-by: Paul Menzel --- docs/grub.texi | 13 + util/grub-mkconfig.in | 4 +++- util/grub.d/10_linux.in | 11 +-- 3 files changed, 25 insertions(+), 3 deletions(-) diff --git a/docs

[PATCH] normal/menu: Do not treat error values as key presses

2019-02-05 Thread Paul Menzel
Currently, the time-out is cancelled/cleared. With the commit, it is not. With a small GRUB payload, this the problem is also reproducible on the ASRock E350M1. Link: http://lists.gnu.org/archive/html/grub-devel/2019-01/msg00037.html Signed-off-by: Paul Menzel --- grub-core/normal/menu.c | 3 ++- 1

clang 7.0.1 build fails with `error: argument unused during compilation: '-Qn'`

2019-02-05 Thread Paul Menzel
Dear GRUB folks, Building GRUB from the master branch fails with clang 7.0.1 fails with the error below. The error is not shown with clang 6.0.1. ``` $ ./autogen.sh $ ./configure CC=clang $ make -j`nproc` […] clang -DHAVE_CONFIG_H -I. -I.. -Wall -W -DGRUB_MACHINE_PCBIOS=1

Re: [PATCH v3] probe: Support probing for GPT partition UUID with -q

2019-05-13 Thread Paul Menzel
Dear Jacob, On 10.05.19 14:05, Jacob Kroon wrote: Linux supports root=PARTUUID= boot argument, so add support for probing it. Compared to the fs UUID, the partition UUID does not change when reformatting a partition. How did you choose the switch name `-q`? Are other tools using this

Re: [PATCH v7] probe: Support probing for partition UUID with --part-uuid

2019-05-20 Thread Paul Menzel
Dear Daniel, On 20.05.19 13:39, Daniel Kiper wrote: CC-ing Paul. On Wed, May 15, 2019 at 09:04:43PM +0200, Jacob Kroon wrote: Linux supports root=PARTUUID= boot argument, so add support for probing it. Compared to the fs UUID, the partition UUID does not change when reformatting a partition.

Re: Patch that fixes an 'at_keyboard' module issue (unreliable key presses)

2019-08-27 Thread Paul Menzel
Dear Michael, On 8/24/19 9:09 PM, Michael Bideau wrote: > This patch fixes an issue that prevented the 'at_keyboard' module to > work (for me). > > The cause is a bad/wrong return value in the function > 'grub_at_keyboard_getkey()' in file > 'grub-core/term/at_keyboard.c' at line 234. > > >

Re: Error in docs

2019-09-03 Thread Paul Menzel
Dear Clayton, On 2019-08-30 23:03, Clayton Voges wrote: > I found a type error in grub's manual/document on section 16.3.19. What > action should I take to fix this? Please check out the source code, make the change, create the commit, and send that to this mailing list. Kind regards, Paul

Re: Patch that fixes an 'at_keyboard' module issue (unreliable key presses)

2019-09-03 Thread Paul Menzel
Dear Michael, I am sorry for the late reply. On 2019-08-29 00:24, Michael Bideau wrote: > Le mardi 27 août 2019 à 11:57 +0200, Paul Menzel a écrit : >> On 8/24/19 9:09 PM, Michael Bideau wrote: >> >>> This patch fixes an issue that prevented the 'at_keyboard' mo

error: the initrd is too big

2019-11-15 Thread Paul Menzel
Dear GRUB folks, I built Linux 5.4-rc7 with an initrd and additional options like KASAN selected. When starting the 9.8 MB LZ4 compressed initrd on a Dell Latitude E7250 with 16 GB RAM GRUB shows: error: the initrd is too big UEFI is used and GRUB 2.04 from Debian Sid/unstable. Any idea,

Re: [PATCH] btrfs: disable zstd support for i386-pc

2019-11-05 Thread Paul Menzel
Dear Michael, Thank you for your patch. On 2019-11-05 10:19, Michael Chang wrote: > The zstd support in btrfs has dependenciy to zstd module and core.img dependency > grows its size significantly to 75KB on my system. The resulted image > cannot be installed into btrfs bootloader area in the

Re: Disable CLI in submenu but allow users to access it

2019-12-03 Thread Paul Menzel
Dear Vladimir, On 2019-11-29 16:34, Vladimir 'phcoder' Serbinenko wrote: > On Fri, 29 Nov 2019, 15:17 Paul Menzel, wrote: >> Is it possible to allow unprivileged users to access a submenu but >> not enter the command-line interface? >> >> Reading the documentation [

[PATCH] docs: Export `superusers` to apply to submenus

2019-12-10 Thread Paul Menzel
Date: Tue, 10 Dec 2019 12:52:22 +0100 Subject: [PATCH] docs: Export `superusers` to apply to submenus Signed-off-by: Paul Menzel --- docs/grub.texi | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/docs/grub.texi b/docs/grub.texi index c25ab7a5f..615c32d99 100644

Disable CLI in submenu but allow users to access it

2019-11-29 Thread Paul Menzel
Dear GRUB folks, Is it possible to allow unprivileged users to access a submenu but not enter the command-line interface? Reading the documentation [1] it’s not clear to me how to do that, and my tests to do that also failed. The warning in [2] also hints that it’s not possible. > Warning —

Re: [PATCH 2/2] build: Disable PIE in TARGET_CCASFLAGS if needed

2020-02-25 Thread Paul Menzel
Dear Matt, Thank you for upstreaming the patches. On 2020-02-20 07:51, Matt Turner wrote: > From: Mike Gilbert > > PIE should be disabled in assembly sources as well, or else grub will > fail to boot. Could you please extend this with the list, on what architectures it fails to boot? It

Re: Anyone tried hooking up Link Time Optimization (LTO)

2020-02-24 Thread Paul Menzel
Dear GRUB folks, Am 24.02.20 um 12:57 schrieb Paul Menzel: Dear GRUB folks, Jacob integrated support for LTO (Link Time Optimization) to coreboot [1], libpayload [2], and the payload *coreinfo* [3] resulting in a noticeable reduction in the size. So maybe GRUB would benefit too. Has anyone

Anyone tried hooking up Link Time Optimization (LTO)

2020-02-24 Thread Paul Menzel
Dear GRUB folks, Jacob integrated support for LTO (Link Time Optimization) to coreboot [1], libpayload [2], and the payload *coreinfo* [3] resulting in a noticeable reduction in the size. So maybe GRUB would benefit too. Has anyone looked into this already? Kind regards, Paul [1]:

Re: master fails to create moddep.lst, related to luks2 changes

2020-03-03 Thread Paul Menzel
Dear Olaf, On 2020-03-03 09:48, Olaf Hering wrote: > After upgrade from > 4e75b2ae313b13b5bfb54cc5e5c53368d6eb2a08..d5a32255de0e073881980fca0262000c865b30dd > I get this compile error: > > env CFLAGS=-Wall CXXFLAGS=-Wall FFLAGS=-Wall ../grub2-src/configure > --target=i386-suse-linux

Re: [PATCH 1/2] build: Fix option to explicitly disable memory debugging

2020-03-09 Thread Paul Menzel
[AC_DEFINE([MM_DEBUG], [1], > - [Define to 1 if you enable memory manager > debugging.])]) > + [include memory manager debugging])) > +if test x$enable_mm_debug = xyes; then > +AC_DEFINE([MM_DEBUG], [1], > +[Define to 1 if you enable memory

Re: [PATCHv2] multiboot2: enable quirk-modules-after-kernel

2020-04-06 Thread Paul Menzel
ub_multiboot2_highest_load; #endif /* ! GRUB_MULTIBOOT_HEADER */ Does this need to be documented somewhere? (Multiboot 2 does not seem to be separately documented in `docs/grub.texi`, so maybe not. It’d be great if you added a separate second patch on top, adding a Multiboot 2 example with

[PATCH v2] docs/grub: Fix typo in *preferred*

2020-04-08 Thread Paul Menzel
Signed-off-by: Paul Menzel --- Add Signed-off-by line. docs/grub.texi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/grub.texi b/docs/grub.texi index 8e6f9acec..ba1169487 100644 --- a/docs/grub.texi +++ b/docs/grub.texi @@ -4729,7 +4729,7 @@ be reloaded after using

[PATCH] docs/grub: Fix typo in *preferred*

2020-04-08 Thread Paul Menzel
--- docs/grub.texi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/grub.texi b/docs/grub.texi index 8e6f9acec..ba1169487 100644 --- a/docs/grub.texi +++ b/docs/grub.texi @@ -4729,7 +4729,7 @@ be reloaded after using this command (@pxref{module}). Some kernels have known

Re: [PATCH] multiboot2: enable quirk-modules-after-kernel

2020-04-02 Thread Paul Menzel
Dear Zide, Thank you very much for your patch. Am 26.03.20 um 23:46 schrieb Zide Chen: In multiboot2, currently there is no way to control where to load the modules. In case of user wants to reserve low address for specific usage, this quirk is useful. It’d be great if you elaborated, where

Re: Patch to add newer i386 modinfo types

2020-04-05 Thread Paul Menzel
Dear Eric, Am 05.04.20 um 03:54 schrieb Eric McCorkle: Here's a first attempt at a patch that adds the code necessary to pass the EFI framebuffer info into the FreeBSD kernel. I have tested this successfully on real hardware. Nice. Great work. What hardware (also firmware version) did you

Re: disk/mdraid1x_linux.c:181:15: warning: array subscript ...

2020-03-25 Thread Paul Menzel
Dear PGNet Dev, Am 25.03.20 um 16:35 schrieb PGNet Dev: […] with your patches, no immediate mdraid1x or zfs build errors one does surface, now, for ntfscomp ... […] Thanks, but please follow the mailing list netiquette, and start a new discussion thread with a descriptive subject line.

Re: disk/mdraid1x_linux.c:181:15: warning: array subscript ...

2020-03-25 Thread Paul Menzel
Dear PGNet Dev, Am 25.03.20 um 16:54 schrieb PGNet Dev: On 3/25/20 8:52 AM, Paul Menzel wrote: Thanks, but please follow the mailing list netiquette I was responding to a question asked by a developer in THIS thread Yes, the question was, if the reported(?) build issues were fixed

  1   2   >