Re: [PATCH] fix grub-probe fail on by-(id|uuid|path) device names

2012-04-23 Thread Michael Chang
I'm cherry picking your patch into our package and will let you know once I found any problem. Btw, When I'm working on this, I'm not sure the *is_part = 1 should also be set somewhere after devmapper_out: ? Please correct me if I'm wrong. devmapper_out: if (! mapper_name node) {

Re: [PATCH] fix grub-probe fail on by-(id|uuid|path) device names

2012-04-23 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 23.04.2012 09:29, Michael Chang wrote: I'm cherry picking your patch into our package and will let you know once I found any problem. Btw, When I'm working on this, I'm not sure the *is_part = 1 should also be set somewhere after devmapper_out: ? Please correct me if I'm wrong. No it

[PATCH] fix grub-probe fail on by-(id|uuid|path) device names

2012-04-20 Thread Michael Chang
This patch fixes grub-probe fails on probing devices under /dev/disk/by-id and other similar mount-by alias names. The method used to determine the whole disk is by it's name without numeric character end, but this may be wrong for the by-(id|uuid|path) names as they are not necessary ended

Re: [PATCH] fix grub-probe fail on by-(id|uuid|path) device names

2012-04-20 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 20.04.2012 13:40, Michael Chang wrote: This patch fixes grub-probe fails on probing devices under /dev/disk/by-id and other similar mount-by alias names. The method used to determine the whole disk is by it's name without numeric character end, but this may be wrong for the

Re: [PATCH] fix grub-probe fail on by-(id|uuid|path) device names

2012-04-20 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 20.04.2012 13:40, Michael Chang wrote: This patch fixes grub-probe fails on probing devices under /dev/disk/by-id and other similar mount-by alias names. The method used to determine the whole disk is by it's name without numeric character end, but this may be wrong for the