Re: [PATCH v4 2/7] cryptodisk: Refactor to discard have_it global

2021-12-09 Thread Daniel Kiper
On Wed, Dec 08, 2021 at 12:18:13PM -0600, Glenn Washburn wrote: > On Wed, 8 Dec 2021 17:37:19 +0100 > Daniel Kiper wrote: > > > On Sat, Dec 04, 2021 at 01:15:45AM -0600, Glenn Washburn wrote: > > > The global "have_it" was never used by the crypto-backends, but was used > > > to > > > determine

Re: [PATCH v4 2/7] cryptodisk: Refactor to discard have_it global

2021-12-08 Thread Glenn Washburn
On Wed, 8 Dec 2021 17:37:19 +0100 Daniel Kiper wrote: > On Sat, Dec 04, 2021 at 01:15:45AM -0600, Glenn Washburn wrote: > > The global "have_it" was never used by the crypto-backends, but was used to > > determine if a crypto-backend successfully mounted a cryptodisk with a given > > uuid. This

Re: [PATCH v4 2/7] cryptodisk: Refactor to discard have_it global

2021-12-08 Thread Daniel Kiper
On Sat, Dec 04, 2021 at 01:15:45AM -0600, Glenn Washburn wrote: > The global "have_it" was never used by the crypto-backends, but was used to > determine if a crypto-backend successfully mounted a cryptodisk with a given > uuid. This is not needed however, because grub_device_iterate() will return

[PATCH v4 2/7] cryptodisk: Refactor to discard have_it global

2021-12-03 Thread Glenn Washburn
The global "have_it" was never used by the crypto-backends, but was used to determine if a crypto-backend successfully mounted a cryptodisk with a given uuid. This is not needed however, because grub_device_iterate() will return 1 if and only if grub_cryptodisk_scan_device() returns 1. And