Re: [PATCH 18/18] x86: add multiboot2 protocol support for EFI platforms

2015-03-27 Thread Daniel Kiper
On Fri, Mar 27, 2015 at 03:06:43PM +, Jan Beulich wrote: > >>> On 27.03.15 at 15:57, wrote: > > On Fri, Mar 27, 2015 at 02:34:19PM +, Jan Beulich wrote: > >> >>> On 27.03.15 at 15:26, wrote: > >> > On Fri, Mar 27, 2015 at 01:36:32PM +, Jan Beulich wrote: > >> >> >>> On 27.03.15 at 14:

Re: [PATCH 18/18] x86: add multiboot2 protocol support for EFI platforms

2015-03-27 Thread Jan Beulich
>>> On 27.03.15 at 15:57, wrote: > On Fri, Mar 27, 2015 at 02:34:19PM +, Jan Beulich wrote: >> >>> On 27.03.15 at 15:26, wrote: >> > On Fri, Mar 27, 2015 at 01:36:32PM +, Jan Beulich wrote: >> >> >>> On 27.03.15 at 14:06, wrote: >> >> > On Tue, Mar 17, 2015 at 10:32:01AM +, Jan Beuli

Re: [PATCH 18/18] x86: add multiboot2 protocol support for EFI platforms

2015-03-27 Thread Daniel Kiper
On Fri, Mar 27, 2015 at 02:34:19PM +, Jan Beulich wrote: > >>> On 27.03.15 at 15:26, wrote: > > On Fri, Mar 27, 2015 at 01:36:32PM +, Jan Beulich wrote: > >> >>> On 27.03.15 at 14:06, wrote: > >> > On Tue, Mar 17, 2015 at 10:32:01AM +, Jan Beulich wrote: > >> >> >>> On 30.01.15 at 18:

Re: [PATCH 18/18] x86: add multiboot2 protocol support for EFI platforms

2015-03-27 Thread Jan Beulich
>>> On 27.03.15 at 15:26, wrote: > On Fri, Mar 27, 2015 at 01:36:32PM +, Jan Beulich wrote: >> >>> On 27.03.15 at 14:06, wrote: >> > On Tue, Mar 17, 2015 at 10:32:01AM +, Jan Beulich wrote: >> >> >>> On 30.01.15 at 18:54, wrote: >> >> > +/* Skip Multiboot2 information fixed part

Re: [PATCH 18/18] x86: add multiboot2 protocol support for EFI platforms

2015-03-27 Thread Daniel Kiper
On Fri, Mar 27, 2015 at 01:36:32PM +, Jan Beulich wrote: > >>> On 27.03.15 at 14:06, wrote: > > On Tue, Mar 17, 2015 at 10:32:01AM +, Jan Beulich wrote: > >> >>> On 30.01.15 at 18:54, wrote: > >> > +/* Skip Multiboot2 information fixed part */ > >> > +lea MB2_fixed_siz

Re: [PATCH 18/18] x86: add multiboot2 protocol support for EFI platforms

2015-03-27 Thread Jan Beulich
>>> On 27.03.15 at 14:06, wrote: > On Tue, Mar 17, 2015 at 10:32:01AM +, Jan Beulich wrote: >> >>> On 30.01.15 at 18:54, wrote: >> > +/* Skip Multiboot2 information fixed part */ >> > +lea MB2_fixed_sizeof(%ebx),%ecx >> >> Let's please not add more assumptions than necessa

Re: [PATCH 18/18] x86: add multiboot2 protocol support for EFI platforms

2015-03-27 Thread Daniel Kiper
On Tue, Mar 17, 2015 at 10:32:01AM +, Jan Beulich wrote: > >>> On 30.01.15 at 18:54, wrote: > > @@ -94,6 +111,17 @@ ENTRY(start) > > gdt_boot_descr: > > .word 6*8-1 > > .long sym_phys(trampoline_gdt) > > +.long 0 /* Needed for 64-bit lgdt */ > > + > > +cs32_swi

Re: [PATCH 18/18] x86: add multiboot2 protocol support for EFI platforms

2015-03-17 Thread Daniel Kiper
On Tue, Mar 17, 2015 at 10:32:01AM +, Jan Beulich wrote: > >>> On 30.01.15 at 18:54, wrote: > > @@ -94,6 +111,17 @@ ENTRY(start) > > gdt_boot_descr: > > .word 6*8-1 > > .long sym_phys(trampoline_gdt) > > +.long 0 /* Needed for 64-bit lgdt */ > > + > > +cs32_swi

Re: [PATCH 18/18] x86: add multiboot2 protocol support for EFI platforms

2015-03-17 Thread Jan Beulich
>>> On 30.01.15 at 18:54, wrote: > @@ -94,6 +111,17 @@ ENTRY(start) > gdt_boot_descr: > .word 6*8-1 > .long sym_phys(trampoline_gdt) > +.long 0 /* Needed for 64-bit lgdt */ > + > +cs32_switch_addr: > +.long sym_phys(cs32_switch) > +.long BOOT_CS

Re: [PATCH 18/18] x86: add multiboot2 protocol support for EFI platforms

2015-02-15 Thread Daniel Kiper
On Sat, Feb 14, 2015 at 08:23:45PM +0300, Andrei Borzenkov wrote: > В Wed, 11 Feb 2015 08:20:04 + > "Jan Beulich" пишет: > > > >>> On 10.02.15 at 22:27, wrote: > > > After some testing we have found at least one machine on which this thing > > > does not work. It is Dell PowerEdge R820 with l

Re: [PATCH 18/18] x86: add multiboot2 protocol support for EFI platforms

2015-02-14 Thread Andrei Borzenkov
В Wed, 11 Feb 2015 08:20:04 + "Jan Beulich" пишет: > >>> On 10.02.15 at 22:27, wrote: > > After some testing we have found at least one machine on which this thing > > does not work. It is Dell PowerEdge R820 with latest firmware. Machine > > crashes/stops because early 32-bit code is not re

Re: [PATCH 18/18] x86: add multiboot2 protocol support for EFI platforms

2015-02-11 Thread Jan Beulich
>>> On 10.02.15 at 22:27, wrote: > After some testing we have found at least one machine on which this thing > does not work. It is Dell PowerEdge R820 with latest firmware. Machine > crashes/stops because early 32-bit code is not relocatable and must live > under 0x10 address. (side note: I a

Re: [PATCH 18/18] x86: add multiboot2 protocol support for EFI platforms

2015-02-10 Thread Andrew Cooper
On 10/02/2015 21:27, Daniel Kiper wrote: > On Fri, Jan 30, 2015 at 06:54:22PM +0100, Daniel Kiper wrote: >> Signed-off-by: Daniel Kiper >> --- >> xen/arch/x86/boot/head.S | 174 >> +++-- >> xen/arch/x86/efi/efi-boot.h | 29 +++ >> xen/arch/x8

Re: [PATCH 18/18] x86: add multiboot2 protocol support for EFI platforms

2015-02-10 Thread Daniel Kiper
On Fri, Jan 30, 2015 at 06:54:22PM +0100, Daniel Kiper wrote: > Signed-off-by: Daniel Kiper > --- > xen/arch/x86/boot/head.S | 174 > +++-- > xen/arch/x86/efi/efi-boot.h | 29 +++ > xen/arch/x86/setup.c | 23 ++--- > xen/arch/x

Re: [PATCH 18/18] x86: add multiboot2 protocol support for EFI platforms

2015-01-30 Thread Andrew Cooper
On 30/01/2015 23:43, Daniel Kiper wrote: > On Fri, Jan 30, 2015 at 07:06:53PM +, Andrew Cooper wrote: >> On 30/01/15 17:54, Daniel Kiper wrote: >>> + >>> +efi_multiboot2_proto: >>> +/* Skip Multiboot2 information fixed part */ >>> +lea MB2_fixed_sizeof(%ebx),%ecx >>> + >>> +

Re: [PATCH 18/18] x86: add multiboot2 protocol support for EFI platforms

2015-01-30 Thread Daniel Kiper
On Fri, Jan 30, 2015 at 07:06:53PM +, Andrew Cooper wrote: > On 30/01/15 17:54, Daniel Kiper wrote: > > Signed-off-by: Daniel Kiper > > --- > > xen/arch/x86/boot/head.S | 174 > > +++-- > > xen/arch/x86/efi/efi-boot.h | 29 +++ > > xen/ar

Re: [PATCH 18/18] x86: add multiboot2 protocol support for EFI platforms

2015-01-30 Thread Andrew Cooper
On 30/01/15 17:54, Daniel Kiper wrote: > Signed-off-by: Daniel Kiper > --- > xen/arch/x86/boot/head.S | 174 > +++-- > xen/arch/x86/efi/efi-boot.h | 29 +++ > xen/arch/x86/setup.c | 23 ++--- > xen/arch/x86/x86_64/asm-offsets.c

[PATCH 18/18] x86: add multiboot2 protocol support for EFI platforms

2015-01-30 Thread Daniel Kiper
Signed-off-by: Daniel Kiper --- xen/arch/x86/boot/head.S | 174 +++-- xen/arch/x86/efi/efi-boot.h | 29 +++ xen/arch/x86/setup.c | 23 ++--- xen/arch/x86/x86_64/asm-offsets.c |2 + xen/common/efi/boot.c | 11 ++