From: Darren Kenny <darren.ke...@oracle.com> It is always possible that grub_zalloc() could fail, so we should check for a NULL return. Otherwise we run the risk of dereferencing a NULL pointer.
Fixes: CID 296221 Signed-off-by: Darren Kenny <darren.ke...@oracle.com> Reviewed-by: Daniel Kiper <daniel.ki...@oracle.com> --- grub-core/net/net.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/grub-core/net/net.c b/grub-core/net/net.c index 04ad10682..4d3eb5c1a 100644 --- a/grub-core/net/net.c +++ b/grub-core/net/net.c @@ -86,8 +86,13 @@ grub_net_link_layer_add_address (struct grub_net_card *card, /* Add sender to cache table. */ if (card->link_layer_table == NULL) - card->link_layer_table = grub_zalloc (LINK_LAYER_CACHE_SIZE - * sizeof (card->link_layer_table[0])); + { + card->link_layer_table = grub_zalloc (LINK_LAYER_CACHE_SIZE + * sizeof (card->link_layer_table[0])); + if (card->link_layer_table == NULL) + return; + } + entry = &(card->link_layer_table[card->new_ll_entry]); entry->avail = 1; grub_memcpy (&entry->ll_address, ll, sizeof (entry->ll_address)); -- 2.11.0 _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel