Re: Proposed PATCH to allow control of the kernel ordering in grub.cfg

2018-12-31 Thread Mihai Moldovan
* On 12/27/18 3:23 PM, Jeff Norden wrote: > Nothing is ever as simple as it seems, is it? Never is. > 1) Deleting the tr after the grep actually seems to break the patch. My > apologies for not testing this more carefully in advance. It looks like > the second tr masks grep's exit status,

Re: Proposed PATCH to allow control of the kernel ordering in grub.cfg

2018-12-27 Thread Jeff Norden
Well, DRAT! Nothing is ever as simple as it seems, is it? 1) Deleting the tr after the grep actually seems to break the patch. My apologies for not testing this more carefully in advance. It looks like the second tr masks grep's exit status, which is important b/c the script runs with 'set -e'

Re: Proposed PATCH to allow control of the kernel ordering in grub.cfg

2018-12-20 Thread Mihai Moldovan
* On 12/20/18 12:53 PM, Daniel Kiper wrote: >> diff --git a/util/grub.d/10_linux.in b/util/grub.d/10_linux.in >> index 4532266be..f2dea11e9 100644 >> --- a/util/grub.d/10_linux.in >> +++ b/util/grub.d/10_linux.in >> @@ -193,7 +193,14 @@ submenu_indentation="" >> >> is_top_level=true >> while [

Re: Proposed PATCH to allow control of the kernel ordering in grub.cfg

2018-12-20 Thread Jeff Norden
Hi Daniel, Thanks for the quick reply! I've made the suggested changes and attached a "git format-patch" patch below. Hopefully this is what you need. I'm not much of a git-expert. Thanks again. Have a great Holiday Season! -Jeff On Thu, 20 Dec 2018, Daniel Kiper wrote: > This looks like

Re: Proposed PATCH to allow control of the kernel ordering in grub.cfg

2018-12-20 Thread Daniel Kiper
Hi Jeff, On Wed, Dec 19, 2018 at 12:50:21AM -0600, Jeff Norden wrote: > Greetings. > > The small patch below adds a new variable (for use by 10_linux) that > allows you to tweak the ordering of kernels in grub.cfg > > When the 10_linux script finds more than one installed kernel, it orders > them

Proposed PATCH to allow control of the kernel ordering in grub.cfg

2018-12-19 Thread Jeff Norden
Greetings. The small patch below adds a new variable (for use by 10_linux) that allows you to tweak the ordering of kernels in grub.cfg When the 10_linux script finds more than one installed kernel, it orders them by version number. If you have several kernels, the one with the highest version