Re: [PATCH] mkimage: fix build regression in grub_mkimage_load_image

2018-03-07 Thread Daniel Kiper
On Tue, Mar 06, 2018 at 05:22:00PM -0500, Peter Jones wrote: > On Tue, Mar 06, 2018 at 01:38:58PM -0800, Eric Snowberg wrote: > > The grub_mkimage_load_image function (commit 7542af6, mkimage: refactor a > > bunch > > of section data into a struct.) introduces a build regression on SPARC: > > > >

Re: [PATCH v2] grub-install: locale depends on nls

2018-03-07 Thread Daniel Kiper
On Tue, Mar 06, 2018 at 09:05:26AM +0100, Olaf Hering wrote: > With --disable-nls no locales exist. > > Avoid runtime error by moving code that copies locales into its own > function. Return early in case nls was disabled. That way the compiler > will throw away unreachable code, no need to put pre

Re: Support for detached LUKS header

2018-03-07 Thread Daniel Kiper
On Tue, Mar 06, 2018 at 11:30:14AM +0100, Yannik Sembritzki wrote: > Hello, > > unfortunately, the patches for cryptomount > > ?? 0001-Cryptomount-support-LUKS-detached-header.patch > ?? 0002-Cryptomount-support-key-files.patch > ?? 0003-Cryptomount-luks-allow-multiple-passphrase-attemp

[PATCH] ieee1275: split up grub_machine_get_bootlocation

2018-03-07 Thread Eric Snowberg
Split up some of the functionality in grub_machine_get_bootlocation into grub_ieee1275_get_boot_dev. This will allow for code reuse in a follow on patch. Signed-off-by: Eric Snowberg --- grub-core/kern/ieee1275/init.c | 24 grub-core/kern/ieee1275/openfw.c | 27 ++

Re: [PATCH v2] grub-install: locale depends on nls

2018-03-07 Thread Olaf Hering
Am Wed, 7 Mar 2018 22:30:53 +0100 schrieb Daniel Kiper : > Sorry, I do not like it. Please use "__attribute__ ((unused))" for the > function > arguments and put #if/#endif around its whole body. It is not just this function body, many more parts will be unneeded. Really polluted the entire file