Re: disk/mdraid1x_linux.c:181:15: warning: array subscript ...

2020-03-25 Thread Michael Chang
On Tue, Mar 24, 2020 at 06:54:43PM +0100, Thomas Schmitt wrote: > Hi, > > i wrote: > > >(char *) &sb.dev_roles - (char *) sb > > >+ grub_le_to_cpu32 (sb.dev_number) * sizeof(grub_uint16_t) > > PGNet Dev wrote: > > grub-core/disk/mdraid1x_linux.c:183:6: error: canno

Re: disk/mdraid1x_linux.c:181:15: warning: array subscript ...

2020-03-25 Thread Thomas Schmitt
Hi, Michael Chang wrote in patch 2/2: > ../../grub-core/fs/zfs/zfs.c:2263:44: error: array subscript '' is > outside the bounds of an interior zero-length array 'grub_uint16_t[0]' {aka > 'short unsigned int[0]'} [-Werror=zero-length-bounds] > [...] > The l_hash[0] is apparnetly an interior member

Re: disk/mdraid1x_linux.c:181:15: warning: array subscript ...

2020-03-25 Thread PGNet Dev
On 3/25/20 12:27 AM, Michael Chang wrote: > It would be great if you can help to test patch to solve the build > problem for gcc-10 in your system or not. with your patches, no immediate mdraid1x or zfs build errors one does surface, now, for ntfscomp ... gcc --version gcc (SUSE Linux) 10

Re: disk/mdraid1x_linux.c:181:15: warning: array subscript ...

2020-03-25 Thread Paul Menzel
Dear PGNet Dev, Am 25.03.20 um 16:35 schrieb PGNet Dev: […] with your patches, no immediate mdraid1x or zfs build errors one does surface, now, for ntfscomp ... […] Thanks, but please follow the mailing list netiquette, and start a new discussion thread with a descriptive subject line.

Re: disk/mdraid1x_linux.c:181:15: warning: array subscript ...

2020-03-25 Thread PGNet Dev
On 3/25/20 8:52 AM, Paul Menzel wrote: > Thanks, but please follow the mailing list netiquette I was responding to a question asked by a developer in THIS thread ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-

Re: disk/mdraid1x_linux.c:181:15: warning: array subscript ...

2020-03-25 Thread Paul Menzel
Dear PGNet Dev, Am 25.03.20 um 16:54 schrieb PGNet Dev: On 3/25/20 8:52 AM, Paul Menzel wrote: Thanks, but please follow the mailing list netiquette I was responding to a question asked by a developer in THIS thread Yes, the question was, if the reported(?) build issues were fixed, and yo

Re: [PATCH 0/7] ZFS/other CoW FS save_env support

2020-03-25 Thread Daniel Kiper
Hi Paul, On Wed, Mar 11, 2020 at 10:37:08AM -0700, Paul Dagnelie wrote: > Hey all, I previously discussed my concept for this patch in my email > https://lists.gnu.org/archive/html/grub-devel/2020-01/msg4.html . > I'm pleased to announce that I've gotten it into a working state and > it is rea

Re: [PATCH v3 0/5] Support Argon2 KDF in LUKS2

2020-03-25 Thread Daniel Kiper
Hi Patrick, On Tue, Mar 10, 2020 at 07:58:27PM +0100, Patrick Steinhardt wrote: > Hi, > > this is the third version of my patchset to support the Argon2 KDF in > LUKS2. The following things have changed in comparison to v2: > > - Improved the GRUB_UINT_C macros to not use `elif 1` and fixed >

Re: [PATCH] Fix GRUB i386-pc build with Ubuntu gcc

2020-03-25 Thread Daniel Kiper
On Tue, Mar 24, 2020 at 01:29:12PM +, Simon Hardy wrote: > With recent versions of gcc on Ubuntu a very large lzma_decompress.img file is > output. (e.g. 134479600 bytes instead of 2864.) This causes grub-mkimage to > fail with: "error: Decompressor is too big." > > This seems to be caused by a

Re: [PATCH] efi/tpm: Fix memory leak in grub_tpm1/2_log_event()

2020-03-25 Thread Daniel Kiper
On Mon, Mar 23, 2020 at 07:22:43PM +0100, Javier Martinez Canillas wrote: > Hello Tianjia, > > On 3/23/20 12:52 PM, Tianjia Zhang wrote: > > The memory requested for the event is not released here, > > causing memory leaks. This patch fixes this problem. > > > > Signed-off-by: Jia Zhang > > Signed

Re: [PATCH] grub.d: Use linuxefi and initrdefi commands if platform is efi

2020-03-25 Thread Daniel Kiper
On Mon, Mar 23, 2020 at 07:53:15PM +0800, Tianjia Zhang wrote: > When the platform is EFI platform, use 'linuxefi' and 'initrdefi' > commands instead of 'linux' and 'initrd'. > > Signed-off-by: Jia Zhang > Signed-off-by: Tianjia Zhang Sorry, NAK! We do not want more "linuxefi" kinda commands in

Re: disk/mdraid1x_linux.c:181:15: warning: array subscript ...

2020-03-25 Thread Daniel Kiper
On Wed, Mar 25, 2020 at 03:27:28PM +0800, Michael Chang wrote: > On Tue, Mar 24, 2020 at 06:54:43PM +0100, Thomas Schmitt wrote: > > Hi, > > > > i wrote: > > > >(char *) &sb.dev_roles - (char *) sb > > > >+ grub_le_to_cpu32 (sb.dev_number) * > > > > sizeof(grub_uint

Re: [PATCH v1] http: return error on unhandled HTTP error responses

2020-03-25 Thread Daniel Kiper
On Tue, Mar 17, 2020 at 07:56:14PM +0100, Olaf Hering wrote: > A http transfer will hang if an unhandled error is returned. > The error branch returns the value zero, which is not expected by the caller. > > Signed-off-by: Olaf Hering > --- > grub-core/net/http.c | 2 +- > 1 file changed, 1 inser

Re: [PATCH 0/7] ZFS/other CoW FS save_env support

2020-03-25 Thread Paul Dagnelie
Not a problem, I suspected as much. We don't have any strong need to get this work integrated ASAP, since we are going to have to build a custom version of GRUB for internal use until this makes its way into a release that lands in an Ubuntu LTS. We just want to make sure that we get some good revi

Re: [PATCH v1] http: return error on unhandled HTTP error responses

2020-03-25 Thread Olaf Hering
Am Wed, 25 Mar 2020 19:55:47 +0100 schrieb Daniel Kiper : > Should not we do the same for 404, file not found, a few lines above? Maybe. For some reason a 404 returns quickly, while a 400 will request the file 4 times. With this patch there is still some delay, but the request is sent just once

Re: [PATCH] grub.d: Use linuxefi and initrdefi commands if platform is efi

2020-03-25 Thread Tianjia Zhang
I got it, Thanks for review. Tianjia On 2020/3/26 1:38, Daniel Kiper wrote: On Mon, Mar 23, 2020 at 07:53:15PM +0800, Tianjia Zhang wrote: When the platform is EFI platform, use 'linuxefi' and 'initrdefi' commands instead of 'linux' and 'initrd'. Signed-off-by: Jia Zhang Signed-off-by: Tianj

Re: disk/mdraid1x_linux.c:181:15: warning: array subscript ...

2020-03-25 Thread Michael Chang
On Wed, Mar 25, 2020 at 12:13:49PM +0100, Thomas Schmitt wrote: > Hi, > > Michael Chang wrote in patch 2/2: > > ../../grub-core/fs/zfs/zfs.c:2263:44: error: array subscript '' is > > outside the bounds of an interior zero-length array 'grub_uint16_t[0]' {aka > > 'short unsigned int[0]'} [-Werror=z

Re: disk/mdraid1x_linux.c:181:15: warning: array subscript ...

2020-03-25 Thread Michael Chang
On Wed, Mar 25, 2020 at 08:35:58AM -0700, PGNet Dev wrote: > On 3/25/20 12:27 AM, Michael Chang wrote: > > It would be great if you can help to test patch to solve the build > > problem for gcc-10 in your system or not. > > with your patches, no immediate mdraid1x or zfs build errors Thanks a lot

fs/ntfscomp.c:82:11: error: ‘flg’ may be used uninitialized in this function [-Werror=maybe-uninitialized]

2020-03-25 Thread PGNet Dev
building cd grub git log | head -n5 commit 552c9fd08122a3036c724ce96dfe68aa2f75705f Author: Patrick Steinhardt Date: Sat Mar 7 17:29:09 2020 +0100 gnulib: Fix build of base64 when compiling with memory debuggi

Re: disk/mdraid1x_linux.c:181:15: warning: array subscript ...

2020-03-25 Thread PGNet Dev
On 3/25/20 8:29 PM, Michael Chang wrote: >> with your patches, no immediate mdraid1x or zfs build errors > > Thanks a lot for your test and validation. > >> one does surface, now, for ntfscomp ... > > I am also using openSUSE, somehow I didn't have the ntfscomp build error > on my gcc-10 build t

Re: disk/mdraid1x_linux.c:181:15: warning: array subscript ...

2020-03-25 Thread Michael Chang
On Wed, Mar 25, 2020 at 07:35:27PM +0100, Daniel Kiper wrote: > On Wed, Mar 25, 2020 at 03:27:28PM +0800, Michael Chang wrote: > > On Tue, Mar 24, 2020 at 06:54:43PM +0100, Thomas Schmitt wrote: [snip] > > >From 8666468ac1a35f0678672de5c89a3f062d1aeb39 Mon Sep 17 00:00:00 2001 > > From: Michael C

Re: disk/mdraid1x_linux.c:181:15: warning: array subscript ...

2020-03-25 Thread Michael Chang
On Thu, Mar 26, 2020 at 12:13:11PM +0800, Michael Chang wrote: > On Wed, Mar 25, 2020 at 07:35:27PM +0100, Daniel Kiper wrote: > > On Wed, Mar 25, 2020 at 03:27:28PM +0800, Michael Chang wrote: > > > On Tue, Mar 24, 2020 at 06:54:43PM +0100, Thomas Schmitt wrote: > > [snip] > > > > >From 8666468a

[PATCH 1/2] mdraid1x_linux: Fix gcc10 error -Werror=array-bounds

2020-03-25 Thread Michael Chang
We bumped into the build error while testing gcc-10 pre-release. ../../grub-core/disk/mdraid1x_linux.c: In function 'grub_mdraid_detect': ../../grub-core/disk/mdraid1x_linux.c:181:15: error: array subscript is outside array bounds of 'grub_uint16_t[0]' {aka 'short unsigned int[0]'} [-Werror=arr

[PATCH 2/2] zfs: Fix gcc10 error -Werror=zero-length-bounds

2020-03-25 Thread Michael Chang
We bumped into the build error while testing gcc-10 pre-release. In file included from ../../include/grub/file.h:22, from ../../grub-core/fs/zfs/zfs.c:34: ../../grub-core/fs/zfs/zfs.c: In function 'zap_leaf_lookup': ../../grub-core/fs/zfs/zfs.c:2263:44: error: array subscript '' is