Re: [PATCH v2] tftp: roll-over block counter to prevent data packets timeouts

2020-09-10 Thread Daniel Kiper
On Thu, Sep 10, 2020 at 05:17:57PM +0200, Javier Martinez Canillas wrote: > Commit 781b3e5efc3 (tftp: Do not use priority queue) caused a regression > when fetching files over TFTP whose size is bigger than 65535 * block size. > > grub> linux /images/pxeboot/vmlinuz > grub> echo $? > 0 >

Re: [PATCH] tftp: roll-over block counter to prevent data packets timeouts

2020-09-10 Thread Javier Martinez Canillas
On 9/10/20 12:00 AM, Alexey Makhalov wrote: [snip] > Fixes: 781b3e5efc3 ("tftp: Do not use priority queue") Please drop this line. >>> >>> Same question here. I think is important information, specially for >>> downstream since they could allow people to decide whether they

[PATCH] shim_lock: Disable GRUB_VERIFY_FLAGS_DEFER_AUTH if secure boot off

2020-09-10 Thread Michael Chang
The GRUB_VERIFY_FLAGS_DEFER_AUTH is enabled regardless secure boot status that will cause error [1] on loading external grub modules if secure boot turned off in which shim protocol itself did not verify images so should not request verification for external modules either. This patch fixed the

[PATCH v2] tftp: roll-over block counter to prevent data packets timeouts

2020-09-10 Thread Javier Martinez Canillas
Commit 781b3e5efc3 (tftp: Do not use priority queue) caused a regression when fetching files over TFTP whose size is bigger than 65535 * block size. grub> linux /images/pxeboot/vmlinuz grub> echo $? 0 grub> initrd /images/pxeboot/initrd.img error: timeout reading

Re: [PATCH] tftp: roll-over block counter to prevent data packets timeouts

2020-09-10 Thread Daniel Kiper
On Thu, Sep 10, 2020 at 12:07:42PM +0200, Javier Martinez Canillas wrote: > On 9/10/20 12:00 AM, Alexey Makhalov wrote: > > [snip] > > > Fixes: 781b3e5efc3 ("tftp: Do not use priority queue") > > Please drop this line. > > >>> > >>> Same question here. I think is important