Re: [PATCH] tests: Refactor building xorriso command for iso9660 tests

2021-12-08 Thread Thomas Schmitt
Hi, i think this change is beneficial for the maintainability of the test. But this sequence looks a bit confusing, albeit it is ok on the second glimpse: + XORRISO_ARGS="-as mkisofs $XORRISOFS_CHARSET -graft-points" + + if [ -z "${fs##*rockridge*}" ]; then +

Re: [PATCH v4 3/7] cryptodisk: Improve error messaging in cryptomount invocations

2021-12-08 Thread Glenn Washburn
On Wed, 8 Dec 2021 17:41:32 +0100 Daniel Kiper wrote: > On Sat, Dec 04, 2021 at 01:15:46AM -0600, Glenn Washburn wrote: > > Update such that "cryptomount -u UUID" will not print two error messages > > when an invalid passphrase is given and the most relevant error message > > will be displayed.

Re: [PATCH] Add Fedora location of DejaVu SANS font

2021-12-08 Thread Robbie Harwood
Nicholas Vinson writes: > On 12/7/21 15:04, Robbie Harwood wrote: >> Nicholas Vinson writes: >> >>> Wouldn't it be better to modify configure.ac so the location could >>> be passed in instead of having one-off patches for alternate >>> locations? Something like >>>

Re: [PATCH v4 2/7] cryptodisk: Refactor to discard have_it global

2021-12-08 Thread Glenn Washburn
On Wed, 8 Dec 2021 17:37:19 +0100 Daniel Kiper wrote: > On Sat, Dec 04, 2021 at 01:15:45AM -0600, Glenn Washburn wrote: > > The global "have_it" was never used by the crypto-backends, but was used to > > determine if a crypto-backend successfully mounted a cryptodisk with a given > > uuid. This

Re: [PATCH] configure: Fix misspelled variable BUILD_LDFAGS -> BUILD_LDFLAGS

2021-12-08 Thread Daniel Kiper
On Tue, Dec 07, 2021 at 11:36:31PM -0600, Glenn Washburn wrote: > Signed-off-by: Glenn Washburn Reviewed-by: Daniel Kiper Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

[ANNOUNCEMENT] FOSDEM 2022 - The Open Source Firmware, BMC and Bootloader devroom

2021-12-08 Thread Daniel Kiper
Hi, I am proud to announce that Michał Żygowski from 3mdeb and I are organizing The Open Source Firmware, BMC and Bootloader devroom at FOSDEM 2022 [1]. The Call for Papers is open until 23rd of December 2021, 23:59:59 UTC [2]. We want to encourage you to join us and make a presentation or lead a

Re: [PATCH] grub-mkconfig: restore umask for grub.cfg

2021-12-08 Thread Daniel Kiper
On Fri, Dec 03, 2021 at 04:13:28PM +0800, Michael Chang via Grub-devel wrote: > Since commit: > > ab2e53c8a grub-mkconfig: Honor a symlink when generating configuration > by grub-mkconfig > > has inadvertently discarded umask for creating grub.cfg in the process > of grub-mkconfig. The resulting

Re: [PATCH 2/6] mm: clarify grub_real_malloc

2021-12-08 Thread Daniel Kiper
On Thu, Nov 25, 2021 at 02:22:46AM +1100, Daniel Axtens wrote: > When iterating through the singly linked list of free blocks, > grub_real_malloc uses p and q for the current and previous blocks > respectively. This isn't super clear, so swap to using prev and cur. > > This makes another quirk

Re: [PATCH v4 1/7] luks2: Add debug message to align with luks and geli modules

2021-12-08 Thread Daniel Kiper
On Sat, Dec 04, 2021 at 01:15:44AM -0600, Glenn Washburn wrote: > Signed-off-by: Glenn Washburn Reviewed-by: Daniel Kiper Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH 3/6] mm: grub_real_malloc: make small allocs comment match code

2021-12-08 Thread Daniel Kiper
On Thu, Nov 25, 2021 at 02:22:47AM +1100, Daniel Axtens wrote: > Small allocations move the region's *first pointer. The comment > says that this happens for allocations under 64K. The code says > it's for allocations under 32K. Commit 45bf8b3a7549 changed the > code intentionally: make the

Re: [PATCH 5/6] mm: document grub_mm_init_region

2021-12-08 Thread Daniel Kiper
On Thu, Nov 25, 2021 at 02:22:49AM +1100, Daniel Axtens wrote: > grub_mm_init_region does some things that seem magical, especially > around region merging. Make it a bit clearer. > > Signed-off-by: Daniel Axtens > --- > grub-core/kern/mm.c | 30 +- > 1 file changed,

Re: [PATCH 4/6] mm: document grub_free

2021-12-08 Thread Daniel Kiper
On Thu, Nov 25, 2021 at 02:22:48AM +1100, Daniel Axtens wrote: > grub_free () posesses a surprising number of quirks, and also > uses single-letter variable names confusingly to iterate through > the free list. > > Document what's going on. > > Use prev and cur to iterate over the free list. > >

Re: [PATCH v4 2/7] cryptodisk: Refactor to discard have_it global

2021-12-08 Thread Daniel Kiper
On Sat, Dec 04, 2021 at 01:15:45AM -0600, Glenn Washburn wrote: > The global "have_it" was never used by the crypto-backends, but was used to > determine if a crypto-backend successfully mounted a cryptodisk with a given > uuid. This is not needed however, because grub_device_iterate() will return

Re: [PATCH v4 3/7] cryptodisk: Improve error messaging in cryptomount invocations

2021-12-08 Thread Daniel Kiper
On Sat, Dec 04, 2021 at 01:15:46AM -0600, Glenn Washburn wrote: > Update such that "cryptomount -u UUID" will not print two error messages > when an invalid passphrase is given and the most relevant error message > will be displayed. > > Improve error message which is displayed when a UUID is

Re: [PATCH] Add Fedora location of DejaVu SANS font

2021-12-08 Thread Nicholas Vinson
On 12/8/21 12:58, Robbie Harwood wrote: Nicholas Vinson writes: On 12/7/21 15:04, Robbie Harwood wrote: Nicholas Vinson writes: Wouldn't it be better to modify configure.ac so the location could be passed in instead of having one-off patches for alternate locations? Something like

Re: [PATCH] Add Fedora location of DejaVu SANS font

2021-12-08 Thread Robbie Harwood
Nicholas Vinson writes: > On 12/8/21 12:58, Robbie Harwood wrote: >> Nicholas Vinson writes: >>> On 12/7/21 15:04, Robbie Harwood wrote: Nicholas Vinson writes: > Wouldn't it be better to modify configure.ac so the location could > be passed in instead of having one-off

Re: [PATCH] Add Fedora location of DejaVu SANS font

2021-12-08 Thread Nicholas Vinson
On 12/8/21 18:42, Robbie Harwood wrote: Nicholas Vinson writes: On 12/8/21 12:58, Robbie Harwood wrote: Nicholas Vinson writes: On 12/7/21 15:04, Robbie Harwood wrote: Nicholas Vinson writes: Wouldn't it be better to modify configure.ac so the location could be passed in instead of