Re: Patches to cryptomount (plain support, keyfiles and LUKS detached headers)

2015-06-12 Thread Andrei Borzenkov
В Fri, 12 Jun 2015 20:15:32 +0100 John Lane пишет: > > Sorry, we cannot accept patches which aren't sent to this ml by author. > I've attached the patches here. They apply clean to c945ca75. Sending them as patch series in mail body would make it easier to review and comment on them. > > I'm no

Re: [RFC PATCH 0/3] grub powerpc64 little-endian enablement

2015-06-15 Thread Andrei Borzenkov
В Thu, 28 Aug 2014 16:56:02 -0300 Paulo Flabiano Smorigo пишет: > From: Paulo Flabiano Smorigo > > Hi, > > At the beginning of the year we provide a patchset that enabled GRUB for > little-endian PowerPC. Our approach at the time was to build GRUB itself and > its tools in 64-bit little-endian

Re: Was there a Wiki on what we can do with GRUB2? And what happened to it?

2015-06-16 Thread Andrei Borzenkov
On Tue, May 26, 2015 at 1:05 AM, Vladimir 'phcoder' Serbinenko wrote: > Wiki is gone because of lack of hosting. I still have last dump from it but > at that point all relevant info is probably in the manual > Should we remove reference to grub.enbug.org from README then? Currently this domain do

Re: [RFC PATCH 3/3] Suport for bi-endianess in elf file

2015-06-16 Thread Andrei Borzenkov
On Thu, Aug 28, 2014 at 10:56 PM, Paulo Flabiano Smorigo wrote: > * grub-core/kern/elf.c: check and switch endianess with grub_{be,le}_to > cpu functions. > * grub-core/kern/elfXX.c: Likewise. > As a general comment - currently we need it for one platform only so let's wrap additional code in #

Re: [PATCH 2/4] Cryptomount support key files

2015-06-19 Thread Andrei Borzenkov
В Tue, 16 Jun 2015 10:11:13 +0100 John Lane пишет: > --- > grub-core/disk/cryptodisk.c | 34 +++-- > grub-core/disk/geli.c | 4 +++- > grub-core/disk/luks.c | 46 > +++-- > include/grub/cryptodisk.h | 5 - >

Re: [PATCH 4/4] Cryptomount support for hyphens in UUID

2015-06-19 Thread Andrei Borzenkov
В Tue, 16 Jun 2015 10:11:15 +0100 John Lane пишет: > --- > grub-core/disk/cryptodisk.c | 9 + > grub-core/disk/luks.c | 1 + > include/grub/cryptodisk.h | 3 +++ > 3 files changed, 13 insertions(+) > > diff --git a/grub-core/disk/cryptodisk.c b/grub-core/disk/cryptodisk.c > inde

Re: [PATCH] core/partmap: Add El Torito boot catalog parsing

2015-06-21 Thread Andrei Borzenkov
В Sat, 20 Jun 2015 11:16:47 +0100 Ross Lagerwall пишет: > > GRUB calculates a boot device based on the device path given by the > firmware so: It is not quite true. GRUB will auofill device part if it is not present, keeping partition. > With a normal CD, the firmware gives it something like >

Strange "while" loop in tftp_receive since commit cf8d6bbd

2015-06-21 Thread Andrei Borzenkov
Coverity complains about double free in this function (CID 96690). This happens here: case TFTP_DATA: ... while (cmp_block (grub_be_to_cpu16 (tftph->u.data.block), data->block + 1) == 0) { ... data->block++; ... grub_netbuff_free (nb_top);

Re: [PATCH 2/4] Cryptomount support key files

2015-06-24 Thread Andrei Borzenkov
On Tue, Jun 23, 2015 at 8:27 PM, John Lane wrote: >>> -err = cr->recover_key (source, dev, hdr); >>> +err = cr->recover_key (source, dev, hdr, key, keyfile_size); >> You never clear key variable, so after the first call all subsequent >> invocations will always use it for any device. Movin

Re: [PATCH 2/4] Cryptomount support key files

2015-06-24 Thread Andrei Borzenkov
On Wed, Jun 24, 2015 at 2:26 PM, John Lane wrote: > + > + keyfile_size = grub_file_read (keyfile, key, keyfile_size); > + if (keyfile_size == (grub_size_t)-1) > + return grub_errno; If keyfile size is explicitly given, I expect that short read should be

Re: [PATCH] Fix missing byte order conversion in get_btrfs_fs_prefix function

2015-06-25 Thread Andrei Borzenkov
В Mon, 22 Jun 2015 16:45:27 +0800 Michael Chang пишет: > Since btrfs on-disk format uses little-endian, the searched item types > (ROOT_REF, INODE_REF) need converting the byte order in order to > function properly on big-endian systems. Applied. Thanks! > --- > grub-core/osdep/linux/getroot.c

Re: grub rescue read or write sector outside of partition

2015-06-26 Thread Andrei Borzenkov
В Thu, 25 Jun 2015 17:33:25 -0700 "Dale Carstensen" пишет: > I had a drive fail, and it is the one that had grub on it. > It had parts of two RAID-6 partitions, too. So I bought a > new drive and added partitions on it to replace the failed > RAID-6 parts. That was still booting OK from the fai

Re: grub2 and touch screen

2015-06-26 Thread Andrei Borzenkov
В Wed, 24 Jun 2015 14:06:42 +0200 Theodore Christophe пишет: > hello all, > > First of all, thank-you for your works. > > I have installed Fedora21 on my laptop (Medion all in one) with dual > boot, and every-thing is working fine. > Grub2 give me the choice between win8.1 and FC21, and other

Re: grub2 and touch screen

2015-06-26 Thread Andrei Borzenkov
В Fri, 26 Jun 2015 15:27:35 +0700 "Fajar A. Nugraha" пишет: > On Fri, Jun 26, 2015 at 3:14 PM, Andrei Borzenkov wrote: > > В Wed, 24 Jun 2015 14:06:42 +0200 > > Theodore Christophe пишет: > > > >> hello all, > >> > >> First of all, tha

Re: grub2 and touch screen

2015-06-26 Thread Andrei Borzenkov
В Wed, 24 Jun 2015 20:15:23 +0200 Michael Zimmermann пишет: > doesn't your device have any buttons(volume?) without the keyboad? > That would be way easier then adding touchscreen support especially if UEFI > doesn't provide a API for that(which I guess it doesn't). > Actually UEFI defines both

Re: grub2 and touch screen

2015-06-27 Thread Andrei Borzenkov
tes key up/down on mouse movement which does not fit well into touch screen/tablet design. I'd rather prefer generic framework to associate screen coordinates with GUI elements and define "click events", so that both relative and absolute modes could be used. > On Fri, Jun 26, 2

Re: grub rescue read or write sector outside of partition

2015-06-27 Thread Andrei Borzenkov
В Sat, 27 Jun 2015 15:17:38 -0700 Dale Carstensen пишет: > > The bash history is long gone. My feeble memory is that it > was simply > > grub2-install /dev/sdf > > and it responded there were no errors. > > Eventually I booted from a DVD and used chroot to do > > grub2-install /dev/sdb >

Re: macosx (darwin) fail to boot from Grub2

2015-06-28 Thread Andrei Borzenkov
В Sun, 28 Jun 2015 11:45:49 +0200 dan...@msw.it пишет: > Hi friends, > I've just installed successifully Ubuntu 14.04 on iMac 9.1 (Darwin). > > The partitions are so suddivided: > > > |-EFI-FAT32-|---MAC-HFS+---|--/BOOT-EXT4--|/ROOT-EXT4|/HOME-REISERFS-|---SWAP---| > > > On sd

[RFD] diskfilter stale RAID member detection vs. lazy scanning

2015-06-28 Thread Andrei Borzenkov
I was looking at implementing detection of outdated RAID members. Unfortunately it appears to be fundamentally incompatible with lazy scanning as implemented currently by GRUB. We simply cannot stop scanning for other copies of metadata once "enough" was seen. Because any other disk may contain mor

Re: macosx (darwin) fail to boot from Grub2

2015-06-29 Thread Andrei Borzenkov
В Mon, 29 Jun 2015 12:02:04 +0200 dan...@msw.it пишет: > I've made as suggested, but obtain: > > > "invalid signature" Could you post "efibootmgr -v" output from Linux? > "press enter to go back" > > > > (...) > > > > This does not work on native EFI grub (i.e. when grub platform is > > x86

Help output inconsistency: -v vs. -V

2015-06-29 Thread Andrei Borzenkov
We currently have situation that C converted tools use -V for --version and -v for --verbose while shell based tools (quite a lot left) use -v for --version and most do not have --verbose at all. -V is quite deep in argp, but of course it is possible to get rid of it by basically replicating argp

Re: [PATCH 1/2] Add powerpc little-endian (ppc64le) flags

2015-06-30 Thread Andrei Borzenkov
On Tue, Jun 30, 2015 at 5:03 PM, Vladimir 'phcoder' Serbinenko wrote: > Which compilers support these flags? I'm concerned of breaking old compilers > -static and -mbig-endian are listed in gcc 2.95.3 documentation for PPC. > Le 30 juin 2015 14:57, "Paulo Flabiano Smorigo" > a écrit : >> >> lib

Re: [PATCH 2/2] Suport for bi-endianess in elf file

2015-06-30 Thread Andrei Borzenkov
Did you intentionally ignore my comments to previous version? Отправлено с iPhone > 30 июня 2015 г., в 15:56, Paulo Flabiano Smorigo > написал(а): > > * grub-core/kern/elf.c: check and switch endianess with grub_{be,le}_to > cpu functions. > * grub-core/kern/elfXX.c: Likewise. > > Also-by: To

Re: [PATCH 1/2] Add powerpc little-endian (ppc64le) flags

2015-06-30 Thread Andrei Borzenkov
-O0" \ -DLLVM_HOST_TRIPLE=%{host_triple} \ so as I understand on ppc64le it does not build support for any other target. Actually openSUSE does not even build clang on ppc at all. > > > > Le 30 juin 2015 16:30, "Andrei Borzenkov" > <mailto:arvidj...@gmail

[PATCH] zfs: fix compilation failure with clang due to alignment

2015-07-03 Thread Andrei Borzenkov
I do not claim I understand why clang complains, but this patch does fix it. fs/xfs.c:452:25: error: cast from 'struct grub_xfs_btree_node *' to 'grub_uint64_t *' (aka 'unsigned long long *') increases required alignment from 1 to 8 [-Werror,-Wcast-align] grub_uint64_t *keys = (grub_

Re: [PATCH 1/2] Add powerpc little-endian (ppc64le) flags

2015-07-03 Thread Andrei Borzenkov
all three versions (ppc, ppc64, ppc64le) See below for details. > Le 30 juin 2015 20:29, "Andrei Borzenkov" a écrit : > > > В Tue, 30 Jun 2015 15:05:46 -0300 > > Paulo Flabiano Smorigo пишет: > > > > > On 2015-06-30 11:33, Vladimir 'phcoder'

Re: [PATCH 1/2] Add powerpc little-endian (ppc64le) flags

2015-07-05 Thread Andrei Borzenkov
В Sat, 4 Jul 2015 09:46:59 +0300 Andrei Borzenkov пишет: > В Tue, 30 Jun 2015 21:34:10 +0200 > "Vladimir 'phcoder' Serbinenko" пишет: > > > I think those flags disable only runtime libraries, not the code generation > > Yes, you are right. Clang se

Re: Set a bootdrive environment variable.

2015-07-06 Thread Andrei Borzenkov
В Mon, 6 Jul 2015 15:44:44 -0400 Mathieu Trudel-Lapierre пишет: > On Sun, May 31, 2015 at 2:42 AM, Andrei Borzenkov > wrote: > > > > > The problem is that $cmdpath had been around for long enough. If > > $cmdpath is used only after loading normal (that are cases I&

Re: how-to build ethernet drivers

2015-07-07 Thread Andrei Borzenkov
В Tue, 7 Jul 2015 19:16:02 +0200 Francesco Lucconi пишет: > Hi guys, > I'm working with grub bootloader (version 2.00) for target i386-pc and I > can compile and install it without any errors. > Now I want to enable ethernet drivers within grub but I haven't found yet > the configure options that

Re: [PATCH 0/4] Implement the 'setkey' command to allow changing the keyboard map

2015-07-12 Thread Andrei Borzenkov
В Sat, 11 Jul 2015 20:28:20 +0200 Luc Van Rompaey пишет: > Legacy GRUB had a 'setkey' command to remap the keyboard keys. > GRUB2 no longer has this command. Instead, it provides an 'at_keyboard' > input terminal module, which can load a GRUB keymap. > Unfortunately, at least on the i386-pc plat

Re: Rewrite of OS-prober module?

2015-07-13 Thread Andrei Borzenkov
В Mon, 13 Jul 2015 14:09:04 +0100 Tom Davies пишет: > Hi :) > I have a fairly shy friend who has done a re-write of the os-prober module > for his own needs after doing a lot of study about EFI systems. > os-prober itself is not part of grub. > He is already moving on to other things but i th

Re: [PATCH v2 2/3] util/grub.d/20_linux_xen.in: Add arm64 support

2015-07-13 Thread Andrei Borzenkov
В Mon, 13 Jul 2015 16:53:59 +0800 fu@linaro.org пишет: > From: Fu Wei > > This patch adds the support of boot command on arm64 for XEN: > xen_hypervisor > xen_module > > Signed-off-by: Fu Wei > --- > util/grub.d/20_linux_xen.in | 14 +++--- > 1 file changed, 11 insertions(

Re: [RFD] diskfilter stale RAID member detection vs. lazy scanning

2015-07-15 Thread Andrei Borzenkov
В Wed, 15 Jul 2015 20:05:56 +0200 Vladimir 'φ-coder/phcoder' Serbinenko пишет: > On 28.06.2015 20:06, Andrei Borzenkov wrote: > > I was looking at implementing detection of outdated RAID members. > > Unfortunately it appears to be fundamentally incompatible with lazy &g

Re: [PATCH] zfs: fix compilation failure with clang due to alignment

2015-07-15 Thread Andrei Borzenkov
В Wed, 15 Jul 2015 17:49:30 +0200 Vladimir 'φ-coder/phcoder' Serbinenko пишет: > > On 03.07.2015 21:05, Andrei Borzenkov wrote: > > I do not claim I understand why clang complains, but this patch does > > fix it. > > > > fs/xfs.c:452:25: error: cas

Re: [PATCH 1/2] Add powerpc little-endian (ppc64le) flags

2015-07-16 Thread Andrei Borzenkov
В Wed, 15 Jul 2015 19:42:39 +0200 Vladimir 'φ-coder/phcoder' Serbinenko пишет: > > > It is possible to compile using "--target=powerpc -Wl,-EB" - this works > > on all three ppc, ppc64 and ppc64le, but this means hardcoding GNU ld > > dependency. > > > Thanks for this info. > See attached patch

Re: [PATCH 1/2] Add powerpc little-endian (ppc64le) flags

2015-07-16 Thread Andrei Borzenkov
В Thu, 16 Jul 2015 21:05:07 +0200 Vladimir 'φ-coder/phcoder' Serbinenko пишет: > On 16.07.2015 20:55, Andrei Borzenkov wrote: > > В Wed, 15 Jul 2015 19:42:39 +0200 > > Vladimir 'φ-coder/phcoder' Serbinenko пишет: > > > >> > >>> It

Re: [PATCH] ofnet: Do not set SUFFIX for sun4v network devices

2015-07-17 Thread Andrei Borzenkov
В Thu, 16 Jul 2015 10:21:41 +0300 Stanislav Kholmanskikh пишет: > sun4v vnet devices do not implement the support of duplex and speed > instance attributes. An attempt to open such a device with > the attributes will fail: > > ok select net:speed=auto,duplex=auto > Unknown key 'speed' > Unknown

On MIPS clang default to different arch than GNU

2015-07-19 Thread Andrei Borzenkov
clang -cc1 version 3.8.0 based upon LLVM 3.8.0svn default target x86_64-unknown-linux-gnu ignoring nonexistent directory "/include" #include "..." search starts here: #include <...> search starts here: /usr/local/include /home/bor/build/clang/bin/../lib/clang/3.8.0/include /usr/include End of s

Re: Wimboot fails to get initrd data (probably regression)

2015-07-20 Thread Andrei Borzenkov
On Mon, Jul 20, 2015 at 3:38 PM, Bernhard Übelacker wrote: > > > @@ -213,6 +213,7 @@ grub_initrd_init (int argc, char *argv[], > >if (newc) > { > + initrd_ctx->size = ALIGN_UP (initrd_ctx->size, 4); >initrd_ctx->size += ALIGN_UP (sizeof (struct newc_head)

Re: Wimboot fails to get initrd data (probably regression)

2015-07-20 Thread Andrei Borzenkov
On Mon, Jul 20, 2015 at 4:47 PM, Andrei Borzenkov wrote: > > But code already does exactly the same. > Ignore this. I see. Thank you! ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: Wimboot fails to get initrd data (probably regression)

2015-07-20 Thread Andrei Borzenkov
В Mon, 20 Jul 2015 14:38:39 +0200 Bernhard Übelacker пишет: > This makes the boot succeed again (Also attached as patch to current grub > git): > Applied. ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-dev

Re: [PATCH v2 2/6] relocator: Do not use memory region if its starta is smaller than size

2015-07-20 Thread Andrei Borzenkov
On Mon, Jul 20, 2015 at 5:35 PM, Daniel Kiper wrote: > malloc_in_range() should not use memory region if its starta is smaller > than size. Otherwise target wraps around and points to region which is > usually not a RAM, e.g.: > > loader/multiboot.c:93: segment 0: paddr=0x80, memsz=0x3f80,

Re: [PATCH 1/2] Add powerpc little-endian (ppc64le) flags

2015-07-21 Thread Andrei Borzenkov
В Wed, 15 Jul 2015 19:42:39 +0200 Vladimir 'φ-coder/phcoder' Serbinenko пишет: > > > It is possible to compile using "--target=powerpc -Wl,-EB" - this works > > on all three ppc, ppc64 and ppc64le, but this means hardcoding GNU ld > > dependency. > > > Thanks for this info. > See attached patch

Re: On MIPS clang default to different arch than GNU

2015-07-21 Thread Andrei Borzenkov
В Wed, 22 Jul 2015 02:05:29 +0200 Vladimir 'φ-coder/phcoder' Serbinenko пишет: > On 19.07.2015 09:33, Andrei Borzenkov wrote: > > clang -cc1 version 3.8.0 based upon LLVM 3.8.0svn default target > > x86_64-unknown-linux-gnu > > ignoring nonexistent directory "

Re: GRUB release schedule?

2015-07-23 Thread Andrei Borzenkov
В Mon, 20 Jul 2015 14:22:45 -0400 Peter Jones пишет: > Hi everyone, > Is there a plan for when upcoming GNU GRUB releases will happen? > > As far as I can tell, the last official release on > ftp://ftp.gnu.org/gnu/grub/ was 2.00 on 28-Jun-2012, and the last beta > on http://alpha.gnu.org/pub/gnu

Re: GRUB release schedule?

2015-07-24 Thread Andrei Borzenkov
On Fri, Jul 24, 2015 at 11:03 AM, Vladimir 'phcoder' Serbinenko wrote: > > Le 24 juil. 2015 06:20, "Andrei Borzenkov" a écrit : >> >> В Mon, 20 Jul 2015 14:22:45 -0400 >> Peter Jones пишет: >> >> > Hi everyone, >> > Is there

Re: [PATCH v2] Suport for bi-endianess in elf file

2015-07-24 Thread Andrei Borzenkov
В Thu, 23 Jul 2015 11:10:36 -0300 Paulo Flabiano Smorigo пишет: > Updated version with the suggestions from Andrei Borzenkov. > > * grub-core/kern/elf.c: check and switch endianess with grub_{be,le}_to > cpu functions. > * grub-core/kern/elfXX.c: Likewise. > Could you add

ELF check: GRUB_ERR_BAD_FILE_TYPE vs. GRUB_ERR_BAD_OS

2015-07-24 Thread Andrei Borzenkov
There are two places using GRUB_ERR_BAD_FILE_TYPE and other are using GRUB_ERR_BAD_OS when EFL class check fails. I am not sure about exact semantics of either but probably they should be the same? ___ Grub-devel mailing list Grub-devel@gnu.org https://l

Re: [PATCH v2] Suport for bi-endianess in elf file

2015-07-24 Thread Andrei Borzenkov
В Fri, 24 Jul 2015 21:00:50 +0200 "Vladimir 'phcoder' Serbinenko" пишет: > Le 23 juil. 2015 16:11, "Paulo Flabiano Smorigo" < > pfsmor...@linux.vnet.ibm.com> a écrit : > > > > Updated version with the suggestions from Andrei Borzenkov. >

Re: [PATCH v2] Suport for bi-endianess in elf file

2015-07-24 Thread Andrei Borzenkov
В Fri, 24 Jul 2015 21:00:50 +0200 "Vladimir 'phcoder' Serbinenko" пишет: > Le 23 juil. 2015 16:11, "Paulo Flabiano Smorigo" < > pfsmor...@linux.vnet.ibm.com> a écrit : > > > > Updated version with the suggestions from Andrei Borzenkov. >

Re: [PATCH v2] Suport for bi-endianess in elf file

2015-07-25 Thread Andrei Borzenkov
В Fri, 24 Jul 2015 21:48:22 +0300 Andrei Borzenkov пишет: > В Thu, 23 Jul 2015 11:10:36 -0300 > Paulo Flabiano Smorigo пишет: > > > Updated version with the suggestions from Andrei Borzenkov. > > > > * grub-core/kern/elf.c: check and switch endianess with grub_{

Re: Be File System identified as bfs

2015-07-28 Thread Andrei Borzenkov
В Tue, 28 Jul 2015 19:10:39 +0200 Jeroen Oortwijn пишет: > Hello, > > Currently Grub identifies the Be File System as 'bfs'. > In Linux however, 'bfs' refers to the Boot File System [1] and 'befs' > refers to the Be File System. > > As a result, the os-prober utility (which uses grub-probe) wh

Re: [PATCH 5/5] Cryptomount support for hyphens in UUID

2015-07-28 Thread Andrei Borzenkov
I still believe that generally ignoring hyphens for every future crypto implementation is wrong. In future we simply should avoid mangling UUID. So this should be restricted to LUKS only, where the problem exists. В Mon, 29 Jun 2015 15:31:00 +0100 John Lane пишет: > From: John Lane > > --- >

Re: [PATCH 5/5] Cryptomount support for hyphens in UUID

2015-07-29 Thread Andrei Borzenkov
В Wed, 29 Jul 2015 07:51:44 +0100 John Lane пишет: > On 29/07/15 04:08, Andrei Borzenkov wrote: > > I still believe that generally ignoring hyphens for every future crypto > > implementation is wrong. In future we simply should avoid mangling > > UUID. So this should be re

Re: Cryptomount enhancements - revised

2015-07-29 Thread Andrei Borzenkov
В Wed, 29 Jul 2015 07:48:41 +0100 John Lane пишет: > On 28/07/15 22:38, Vladimir 'phcoder' Serbinenko wrote: > > > > Other than 3 and 5 they require difficult configuration. Mapping > > devices in GRUB isn't trivial. Those features are difficult to > > autoconfigure. Consider "plain" mode: how wi

Re: [PATCH] ofdisk: Recognizes SAS disks automatically

2015-08-01 Thread Andrei Borzenkov
В Fri, 31 Jul 2015 10:34:25 -0300 Paulo Flabiano Smorigo пишет: > Read all children from sas path and add it to the device list. Examples of paths and names would be useful for reference. > > --- > grub-core/disk/ieee1275/ofdisk.c | 51 > > include/gr

Re: [bug #39591] grub-mkconfig fails on btrfs raid

2015-08-02 Thread Andrei Borzenkov
В Sat, 1 Aug 2015 08:35:53 -0700 Konstantin Svist пишет: > On 08/01/2015 01:01 AM, Andrei Borzenkov wrote: > > В Fri, 31 Jul 2015 23:41:44 -0700 > > Konstantin Svist пишет: > > > >> On 07/31/2015 11:12 PM, Andrei Borzenkov wrote: > >>> [Adding grub-dev

Re: [PATCH 1/3] efinet: handle get_status() properly

2015-08-05 Thread Andrei Borzenkov
В Wed, 5 Aug 2015 14:36:37 -0400 Josef Bacik пишет: > The EFI SNP documentation isn't super clear on the value that is returned in > txbuf when calling into GetStatus. The documentation says its the pointer to > the recycle buffer, but the documentation for Transmit() says that it should > be >

Re: [PATCH 1/3] efinet: handle get_status() properly

2015-08-05 Thread Andrei Borzenkov
. iPXE opens SNP exclusively and assumes anything != NULL means transmit completed (it seems to start off with gPXE model). > Le 5 août 2015 10:28 PM, "Josef Bacik" a écrit : > > > On 08/05/2015 04:04 PM, Andrei Borzenkov wrote: > > > >> В Wed, 5 Aug 2015 14:36:37 -

Re: [PATCH 2/3] net: add local route when creating link local ipv6 interface

2015-08-07 Thread Andrei Borzenkov
On Wed, Aug 5, 2015 at 9:36 PM, Josef Bacik wrote: > In order to talk to link local ipv6 addresses we need to have a route out of > the > link local interface for this to work. Thanks, > > Signed-off-by: Josef Bacik > --- > grub-core/net/net.c | 14 +- > 1 file changed, 13 insertio

Re: [PATCH] ofnet: Do not set SUFFIX for sun4v network devices

2015-08-08 Thread Andrei Borzenkov
В Thu, 16 Jul 2015 10:21:41 +0300 Stanislav Kholmanskikh пишет: > sun4v vnet devices do not implement the support of duplex and speed > instance attributes. An attempt to open such a device with > the attributes will fail: > > ok select net:speed=auto,duplex=auto > Unknown key 'speed' > Unknown

Re: Changing default keyboard layout

2015-08-09 Thread Andrei Borzenkov
Please in future send such mails to grub-devel or open bug on savannah. В Sat, 8 Aug 2015 19:36:58 +0200 Hervé Werner пишет: > Hello > > I'm trying to change the default US keyboard layout on > Grub2 but I don't manage to get it working. Here is basically what I did > : > $ ckbcomp fr bepo |g

Re: [PATCH V2] efinet: handle get_status() on buggy firmware properly

2015-08-09 Thread Andrei Borzenkov
В Thu, 6 Aug 2015 10:49:46 -0700 Josef Bacik пишет: > The EFI spec indicates that get_status() should return the address of the > buffer > we passed into transmit to indicate the the buffer was transmitted. However > we > have boxes where the firmware returns some arbitrary address instead, w

Re: [PATCH 3/3] net: fix ipv6 routing

2015-08-09 Thread Andrei Borzenkov
В Wed, 5 Aug 2015 14:36:39 -0400 Josef Bacik пишет: > Currently we cannot talk to ipv6 addresses outside of our local link area > because we don't setup our routes properly nor do we talk to the router > properly. Currently net_ipv6_autoconf adds routes for the local link prefix > and > ties it

Re: [PATCH 3/3] net: fix ipv6 routing

2015-08-10 Thread Andrei Borzenkov
On Mon, Aug 10, 2015 at 5:00 PM, Josef Bacik wrote: > On 08/09/2015 10:58 AM, Andrei Borzenkov wrote: >> >> В Wed, 5 Aug 2015 14:36:39 -0400 >> Josef Bacik пишет: >> >>> Currently we cannot talk to ipv6 addresses outside of our local link area >>> b

Re: [PATCH] progress: Check for NULL filename

2015-08-13 Thread Andrei Borzenkov
On Wed, Aug 12, 2015 at 6:53 PM, dann frazier wrote: > Avoid a NULL pointer dereference if the upper fs layer hasn't set the > file->name field. Files opened through the grub_net_fs interface currently do > not have this field set (though perhaps they should?). > file->name is set in grub_file_op

Re: [PATCH] tcp: ack when we get an OOO/lost packet

2015-08-13 Thread Andrei Borzenkov
On Wed, Aug 12, 2015 at 6:16 PM, Josef Bacik wrote: > While adding tcp window scaling support I was finding that I'd get some packet > loss or reordering when transferring from large distances and grub would just > timeout. This is because we weren't ack'ing when we got our OOO packet, so > the

Re: [PATCH] tcp: ack when we get an OOO/lost packet

2015-08-13 Thread Andrei Borzenkov
On 13.08.2015 16:59, Josef Bacik wrote: On 08/13/2015 04:19 AM, Andrei Borzenkov wrote: On Wed, Aug 12, 2015 at 6:16 PM, Josef Bacik wrote: While adding tcp window scaling support I was finding that I'd get some packet loss or reordering when transferring from large distances and grub

Re: Changing default keyboard layout

2015-08-13 Thread Andrei Borzenkov
On 12.08.2015 22:17, Hervé Werner wrote: As requested I compiled the latest development version of Grub and installed it on a test laptop. Without any further configuration, Grub works fine, it is able to boot as intended but the keyboard mapping is us. I then added the following snippet : g

Re: Bug with the locale path

2015-08-13 Thread Andrei Borzenkov
On 13.08.2015 08:55, Goofy wrote: Hello, i play around with the grub 2.02~Beta2 and i think there is a litte bug ? i configure the paket with the following line ./configure --prefix= --datarootdir=/usr/share --localedir=/usr/share/locale but if i want to install grub with # grub-install /de

Re: Bug with the locale path

2015-08-13 Thread Andrei Borzenkov
translations but wrong locale path. I do not have grub translations either (actually I did not even install grub in the first place, I run grub-install from the build dir). rgds, toomas On 13.08.2015, at 20:48, Andrei Borzenkov wrote: On 13.08.2015 08:55, Goofy wrote: Hello, i play around

Re: i386-pc target and no block lists

2015-08-14 Thread Andrei Borzenkov
And the question is? On Fri, Aug 14, 2015 at 3:32 PM, Olaf Hering wrote: > On Fri, Aug 14, Olaf Hering wrote: > >> /usr/lib64/grub2-chainloader/sbin/grub-install: error: will not proceed with >> blocklists. > > Forgot to post also remaining output with --do-it-anyway: > > /usr/lib64/grub2-chainl

Re: i386-pc target and no block lists

2015-08-14 Thread Andrei Borzenkov
On Fri, Aug 14, 2015 at 3:29 PM, Olaf Hering wrote: > Last night I finally got around to update my grub1 chainloader to grub2. > During install of the bootloader I ran into this issue: > > grub-install: warning: Embedding is not possible. GRUB can only be installed > in this setup by using block

Re: i386-pc target and no block lists

2015-08-14 Thread Andrei Borzenkov
On 14.08.2015 19:44, Lennart Sorensen wrote: Certainly Debian by default installs grub to the MBR (aka the disk), not to the partition. I would be surprised if any other distribution does it differently. openSUSE suggests partition by default. It makes sense for dual boot with Windows as

Re: Kernel panics (in QEMU) when booting with GRUB2 + OVMF + QEMU.

2015-08-14 Thread Andrei Borzenkov
On 14.08.2015 09:45, Mark Lee wrote: To all, I've encountered a bug when using GRUB2 + OVMF + QEMU on Arch Linux 64 bit. The issue can be reproduced when running the latest git code from grub as well. ISSUE: Kernel panics (in QEMU) when booting with GRUB2 + OVMF + QEMU. Once kernel is loaded,

Re: [PATCH] tcp: ack when we get an OOO/lost packet

2015-08-17 Thread Andrei Borzenkov
On Thu, Aug 13, 2015 at 4:59 PM, Josef Bacik wrote: > On 08/13/2015 04:19 AM, Andrei Borzenkov wrote: >> >> On Wed, Aug 12, 2015 at 6:16 PM, Josef Bacik wrote: >>> >>> While adding tcp window scaling support I was finding that I'd get some >>> packe

Re: Kernel panics (in QEMU) when booting with GRUB2 + OVMF + QEMU.

2015-08-17 Thread Andrei Borzenkov
On Sun, Aug 16, 2015 at 8:25 AM, Mark Lee wrote: > On Saturday, August 15, 2015 08:31:42 PM Jordan Uggla wrote: >> Specifically, while Mark entered something like "initrd >> /boot/initramfs-foo-bar", and everything he had typed was echoed back >> to him on screen as expected, the error message he

Re: [PATCH] tcp: add window scaling support

2015-08-17 Thread Andrei Borzenkov
12.08.2015 18:57, Josef Bacik пишет: Sometimes we have to provision boxes across regions, such as California to Sweden. The http server has a 10 minute timeout, so if we can't get our 250mb image transferred fast enough our provisioning fails, which is not ideal. So add tcp window scaling on op

Re: yeeloong: cs5536 (Geode companion) not working in grub master

2015-08-17 Thread Andrei Borzenkov
15.08.2015 19:38, Mark H Weaver пишет: I'm attempting to get grub working on the Lemote Yeeloong 8101B (Loongson 2F) as a second-stage bootloader from PMON. I have grub-2.02-beta2-499-g4fe8e6d mostly working, with one exception: none of the devices on the cs5536 (Geode companion) are accessible,

Re: Keyboard not working with QEMU and coreboot and GRUB payload

2015-08-18 Thread Andrei Borzenkov
On Tue, Aug 18, 2015 at 12:41 AM, Paul Menzel wrote: > Dear GRUB folks, > > > just a note that using QEMU with coreboot and GRUB payload, I am unable > to enter anything. > > Using libpayload based payloads, the keyboard works, so I think it’s > GRUB related. > Does it work with any earlier GRUB

Re: [PATCH] progress: Check for NULL filename

2015-08-18 Thread Andrei Borzenkov
14.08.2015 00:04, dann frazier пишет: On Thu, Aug 13, 2015 at 10:52:19AM +0300, Andrei Borzenkov wrote: On Wed, Aug 12, 2015 at 6:53 PM, dann frazier wrote: Avoid a NULL pointer dereference if the upper fs layer hasn't set the file->name field. Files opened through the grub_net_fs i

Re: Grub2 bug report

2015-08-19 Thread Andrei Borzenkov
19.08.2015 13:00, du pingping пишет: I think that the grub2 needs to work for many grub shell commands. But critical error is occurred as follow.Bug scenario is as following.- at the grub menu, press C key. - enter "linux /vmlinuz" command to "grub>" shell - enter above command once more. - grub

Re: [PATCH] Avoid NULL pointer dereference in progress module.

2015-08-20 Thread Andrei Borzenkov
); grub_free (file->device->net->name); grub_free (file); return err; @@ -1414,6 +1425,7 @@ grub_net_fs_open (struct grub_file *file_out, const char *name) grub_net_remove_packet (file->device->net->packs.first); } file->device->net->protocol-&g

Re: [PATCH] net: don't free uninitialized sockets in dns

2015-08-20 Thread Andrei Borzenkov
grub_free (data.name); grub_netbuff_free (nb); for (j = 0; j < send_servers; j++) -grub_net_udp_close (sockets[j]); +{ + if (sockets[j]) + grub_net_udp_close (sockets[j]); +} grub_free (sockets); From: Andrei Borzenkov Subject: [PATCH] net: avoid closing NULL

Re: [PATCH] Ensure that MIPS target code is compiled for the O32 ABI.

2015-08-20 Thread Andrei Borzenkov
19.08.2015 21:35, Mark H Weaver пишет: Include -mabi=32 in CFLAGS_PLATFORM and CCASFLAGS_PLATFORM to compile code for the O32 ABI when targetting MIPS, since the MIPS assembly code in GRUB assumes this. This flag is also needed when compiling asm-tests/mips.S from configure, because GNU as rejec

Re: [PATCH v4 1/2] Add support for SMBIOS3 entry point structures

2015-08-21 Thread Andrei Borzenkov
On Sun, Aug 16, 2015 at 5:26 AM, David Michael wrote: > If both SMBIOS v2 and v3 entry point structures are found, both are > registered instead of preferring one version since they can point > to different tables at different memory locations. > > This also modifies the fakebios command so that t

Re: GRUB release schedule?

2015-08-21 Thread Andrei Borzenkov
21.08.2015 20:11, Konrad Rzeszutek Wilk пишет: On Fri, Aug 21, 2015 at 09:56:59AM -0700, Josef Bacik wrote: On 07/20/2015 11:22 AM, Peter Jones wrote: Hi everyone, Is there a plan for when upcoming GNU GRUB releases will happen? As far as I can tell, the last official release on ftp://ftp.gnu.

Re: GRUB release schedule?

2015-08-21 Thread Andrei Borzenkov
21.08.2015 21:41, Konrad Rzeszutek Wilk пишет: Lets start with a list of priorities: - What are the most important platforms after x86? I suppose distribution-wise they are ARM and PPC. This means 5 different GRUB builds. MIPS seems to be still in use, at least there are patches and bug re

Re: GRUB release schedule?

2015-08-21 Thread Andrei Borzenkov
21.08.2015 22:55, Bruce Dubbs пишет: but hangs after test_unset. Yes, I noticed this as well. This smells like real bug as it just loads and runs several GRUB modules, there is no external dependency. ___ Grub-devel mailing list Grub-devel@gnu.org

Re: [PATCH] Ensure that MIPS target code is compiled for the O32 ABI.

2015-08-23 Thread Andrei Borzenkov
22.08.2015 21:04, Mark H Weaver пишет: Andrei Borzenkov writes: 19.08.2015 21:35, Mark H Weaver пишет: Include -mabi=32 in CFLAGS_PLATFORM and CCASFLAGS_PLATFORM to compile code for the O32 ABI when targetting MIPS, since the MIPS assembly code in GRUB assumes this. This flag is also needed

Re: [PATCH] Ensure that MIPS target code is compiled for the O32 ABI.

2015-08-24 Thread Andrei Borzenkov
24.08.2015 10:57, Mark H Weaver пишет: Andrei Borzenkov writes: Could you paste "clang -v" output for both cases? I believe I understand what's going on. Okay, I've included it below. It might be relevant to mention that the MIPS port of GNU Guix is not a 'mult

Re: [PATCH] Ensure that MIPS target code is compiled for the O32 ABI.

2015-08-24 Thread Andrei Borzenkov
24.08.2015 11:12, Andrei Borzenkov пишет: 24.08.2015 10:57, Mark H Weaver пишет: Andrei Borzenkov writes: Could you paste "clang -v" output for both cases? I believe I understand what's going on. Okay, I've included it below. It might be relevant to mention that the M

Re: [PATCH] Ensure that MIPS target code is compiled for the O32 ABI.

2015-08-24 Thread Andrei Borzenkov
22.08.2015 21:04, Mark H Weaver пишет: Andrei Borzenkov writes: 19.08.2015 21:35, Mark H Weaver пишет: Include -mabi=32 in CFLAGS_PLATFORM and CCASFLAGS_PLATFORM to compile code for the O32 ABI when targetting MIPS, since the MIPS assembly code in GRUB assumes this. This flag is also needed

Re: cryptodisk: teach grub_cryptodisk_insert() about partitions (bug #45889)

2015-09-11 Thread Andrei Borzenkov
09.09.2015 04:18, TJ пишет: On 08-09-2015 17:38, Vladimir 'φ-coder/phcoder' Serbinenko wrote: On 06.09.2015 21:10, TJ wrote: https://savannah.gnu.org/bugs/index.php?45889 + if ((disk->partition && disk->partition->number == dev->partition_number) || + (!disk->partition && dev->par

Re: Development practices?

2015-09-11 Thread Andrei Borzenkov
09.09.2015 20:47, Felix Zielcke пишет: Am Dienstag, den 08.09.2015, 13:57 -0400 schrieb Konrad Rzeszutek Wilk: On Thu, Sep 03, 2015 at 03:34:29PM -0400, Konrad Rzeszutek Wilk wrote: I don't know enough about the community (or the history) to understand it but would very much appreciate input

Re: [PATCH] Make EFI watchdog behaviour configurable

2015-09-11 Thread Andrei Borzenkov
10.09.2015 03:11, Arthur Mesh пишет: Starting with d9a0c9413e81d3c0affc6383693bdd28dc863a5c, GRUB unconditionally disables watchdog on EFI platforms. This opens up a window (starting at GRUB's grub_efi_init(), until OS re-enables it) when EFI system operates w/o watchdog. If an EFI system gets st

Re: [PATCH] Ensure that MIPS target code is compiled for the O32 ABI.

2015-09-11 Thread Andrei Borzenkov
25.08.2015 21:18, Mark H Weaver пишет: Andrei Borzenkov writes: 24.08.2015 11:12, Andrei Borzenkov пишет: Could you test attached patch for both gcc and clang? Use configure TARGET_CC=clang Sorry, was broken, fixed version attached. Your patch works for me with gcc, although config.log

Re: Development practices?

2015-09-11 Thread Andrei Borzenkov
11.09.2015 17:48, Konrad Rzeszutek Wilk пишет: On Fri, Sep 11, 2015 at 05:34:45PM +0300, Andrei Borzenkov wrote: 09.09.2015 20:47, Felix Zielcke пишет: Am Dienstag, den 08.09.2015, 13:57 -0400 schrieb Konrad Rzeszutek Wilk: On Thu, Sep 03, 2015 at 03:34:29PM -0400, Konrad Rzeszutek Wilk wrote

Re: [PATCH] Make EFI watchdog behaviour configurable

2015-09-11 Thread Andrei Borzenkov
11.09.2015 17:53, Arthur Mesh пишет: On 9/11/15, 7:32 AM, "grub-devel-bounces+amesh=juniper@gnu.org on behalf of Andrei Borzenkov" wrote: 10.09.2015 03:11, Arthur Mesh пишет: Add `--enable-efi-watchdog' configure argument, which defaults to Off. When enabled, efi wa

Re: [PATCH] efinet: retransmit if our device is busy

2015-09-11 Thread Andrei Borzenkov
31.08.2015 20:34, Josef Bacik пишет: When I fixed the txbuf handling I ripped out the retransmission code since it was flooding our network when we had the buggy behavior. Turns out this was too heavy handed as we can still have transient tx timeouts. So instead make sure we retry our transmiss

  1   2   3   4   5   6   7   8   9   10   >