Re: [RFC PATCH 0/2] grub-probe: improve message when disk cannot be opened

2016-09-05 Thread Antonio Ospite
Ping. two weeks ago I sent the patches referenced in the message below and I haven't received a reply yet. Maybe sending them in the middle of August was not the best choice. :) Can anyone please take a look? Thanks. Ciao, Antonio On Tue, 23 Aug 2016 12:17:26 +0200 Antonio Ospite <a...@

[RFC PATCH 0/2] grub-probe: improve message when disk cannot be opened

2016-08-23 Thread Antonio Ospite
is the final effect I am aiming for but I am not 100% sure my solution is complete. Thanks, Antonio Antonio Ospite (2): * grub-core/kern/disk.c: don't override grub_errmsg when grub_disk_open fails * util/getroot.c: improve error message when a disk cannot be opened grub-core/ker

[RFC PATCH 2/2] * util/getroot.c: improve error message when a disk cannot be opened

2016-08-23 Thread Antonio Ospite
Opening a disk can fail for two reasons: 1. the device does not exist; 2. the device exists but cannot be accessed for some reason. The current error message assumes always 1. and this can misled users when they look for the actual cause of the failure. So, reuse the error message from

[RFC PATCH 1/2] * grub-core/kern/disk.c: don't override grub_errmsg when grub_disk_open fails

2016-08-23 Thread Antonio Ospite
In grub_disk_open() don't override error message when no _valid_ device can be found, instead use the one set from the last function which failed, which is more informative. The current message "disk not found" discards precious info about the reason of the failure; for instance the disk may

Re: [RFC PATCH 0/2] grub-probe: improve message when disk cannot be opened

2016-10-12 Thread Antonio Ospite
On Mon, 5 Sep 2016 21:40:30 +0200 Antonio Ospite <a...@ao2.it> wrote: > Ping. > > two weeks ago I sent the patches referenced in the message below and > I haven't received a reply yet. > Hi, another month has passed, has anyone had a chance to take a look? As said in

Re: [RFC PATCH 0/2] grub-probe: improve message when disk cannot be opened

2017-04-28 Thread Antonio Ospite
On Tue, 23 Aug 2016 12:17:26 +0200 Antonio Ospite <a...@ao2.it> wrote: > Hi, > > right now when running grub-probe and the disk cannot be opened the > error message can be misleading, it always says "disk not found" but in > some case the disk may exist but the