[PATCH] fix grub-probe fail on by-(id|uuid|path) device names

2012-04-20 Thread Michael Chang
This patch fixes grub-probe fails on probing devices under /dev/disk/by-id and other similar mount-by alias names. The method used to determine the whole disk is by it's name without numeric character end, but this may be wrong for the by-(id|uuid|path) names as they are not necessary ended

Re: [PATCH] fix grub-probe fail on by-(id|uuid|path) device names

2012-04-23 Thread Michael Chang
, Michael 在 2012年4月20日下午9:04,Vladimir 'φ-coder/phcoder' Serbinenko phco...@gmail.com 寫道: On 20.04.2012 13:40, Michael Chang wrote: This patch fixes grub-probe fails on probing devices under /dev/disk/by-id and other similar mount-by alias names. The method used to determine the whole disk is by it's

[PATCH 2/2] Fix font color not set for booting message

2012-09-07 Thread Michael Chang
and not resetting afterwards. This ensures persistence of user's setting to terminal's font color. Signed-off-by: Michael Chang mch...@suse.com --- grub-core/term/gfxterm.c | 10 +++--- 1 files changed, 7 insertions(+), 3 deletions(-) diff --git a/grub-core/term/gfxterm.c b/grub-core/term/gfxterm.c index

[PATCH 1/2] Fix terminal-box not displaying background

2012-09-07 Thread Michael Chang
windows's background theme-able. Signed-off-by: Michael Chang mch...@suse.com --- grub-core/gfxmenu/view.c |2 ++ grub-core/gfxmenu/widget-box.c |7 +++ grub-core/term/gfxterm.c | 15 ++- include/grub/gfxterm.h |1 + include/grub/gfxwidgets.h

Re: [PATCH 3/5] msdos-part: allow embedding in extended partition

2012-09-12 Thread Michael Chang
2012/9/5 Vladimir 'φ-coder/phcoder' Serbinenko phco...@gmail.com: On 09.07.2012 22:02, Jiri Slaby wrote: From: Michael Chang mch...@suse.com The same as in the previous patch, add a support for installing grub into an extended partition. Here, we do not ignore extended partitions anymore

Re: [PATCH 3/5] msdos-part: allow embedding in extended partition

2012-09-12 Thread Michael Chang
2012/9/13 Lennart Sorensen lsore...@csclub.uwaterloo.ca: On Wed, Sep 12, 2012 at 03:25:43PM +0800, Michael Chang wrote: Installing on extended partition is one of scenarios for SUSE and openSUSE installation. If the /boot resides in a logical partition, the installer would propose installing

[PATCH] suppress error message /grub2/locale/en.mo.gz not found

2012-09-24 Thread Michael Chang
We don't insert gettext module if message catalog file missing to prevent error message from being logged. Signed-off-by: Michael Chang mch...@suse.com --- util/grub.d/00_header.in | 10 +++--- 1 files changed, 7 insertions(+), 3 deletions(-) diff --git a/util/grub.d/00_header.in b/util

Re: [PATCH] suppress error message /grub2/locale/en.mo.gz not found

2012-09-24 Thread Michael Chang
2012/9/24 Mads Kiilerich m...@kiilerich.com: On 09/24/2012 08:51 AM, Michael Chang wrote: We don't insert gettext module if message catalog file missing to prevent error message from being logged. Signed-off-by: Michael Chang mch...@suse.com --- util/grub.d/00_header.in | 10

Re: [PATCH] suppress error message /grub2/locale/en.mo.gz not found

2012-09-24 Thread Michael Chang
2012/9/25 Andrey Borzenkov arvidj...@gmail.com: В Пн., 24/09/2012 в 11:37 +0200, Mads Kiilerich пишет: On 09/24/2012 08:51 AM, Michael Chang wrote: We don't insert gettext module if message catalog file missing to prevent error message from being logged. Signed-off-by: Michael Chang mch

Re: [PATCH] suppress error message /grub2/locale/en.mo.gz not found

2012-09-26 Thread Michael Chang
2012/9/26 Colin Watson cjwat...@ubuntu.com: On Tue, Sep 25, 2012 at 12:46:15PM +0800, Michael Chang wrote: I agree with you. IMHO the problem is it's not emitted directly from gettext module but from common underlying fs level, removing it would lead to other message which is fatal be ignored

Re: GRUB2 msdos logical partition numbering mismatch with Linux partitions

2012-10-17 Thread Michael Chang
2012/10/17 Andrey Borzenkov arvidj...@gmail.com: В Вт., 16/10/2012 в 20:51 +0400, Andrey Borzenkov пишет: It appears that in case of logical partitions GRUB2 counts each glue entry (that points to the next EBR) as fully fledged partition which results in bor@opensuse:~/src/grub sudo

Re: GRUB and the risk of block list corruption in extX

2013-02-19 Thread Michael Chang
2013/2/19 Chris Murphy li...@colorremedies.com: On Feb 18, 2013, at 10:02 PM, Andrey Borzenkov arvidj...@gmail.com wrote: Chainloading is actually the only sane way to do multiboot. While it may have started due to BIOS limitations, today chainloading is simply passing control to another

i386/pc/chainloader.c fails with syntax like chainloader (hd1, msdos1)+1

2013-06-21 Thread Michael Chang
Hi, The i386/pc/chainloader.c hangs when attempting to chainload other disk's boot sector (or mbr) with a syntax like this. Say if current environment setting root=hd0,msdos2. $ chainloader (hd1,msdos1)+1 However doing it this way always works. $ set root=hd1,msdos1 $ chainloader +1 I

Re: i386/pc/chainloader.c fails with syntax like chainloader (hd1, msdos1)+1

2013-06-23 Thread Michael Chang
2013/6/21 Vladimir 'φ-coder/phcoder' Serbinenko phco...@gmail.com: On 21.06.2013 11:23, Michael Chang wrote: Hi, The i386/pc/chainloader.c hangs when attempting to chainload other disk's boot sector (or mbr) with a syntax like this. Say if current environment setting root=hd0,msdos2

Re: GRUB_CRYPTODISK_ENABLE undocumented

2013-08-28 Thread Michael Chang
Hi Andrey, 2013/3/29 Andrey Borzenkov arvidj...@gmail.com: Is it intentional? I hit it when testing grub on encrypted partition. When no, I'll submit a patch. Do you have any progress on this? Besides document it, IMHO why not we consider to remove it or make it default enable to receive more

Re: GRUB_CRYPTODISK_ENABLE undocumented

2013-08-28 Thread Michael Chang
Hi Andrey, 2013/3/29 Andrey Borzenkov arvidj...@gmail.com: Is it intentional? I hit it when testing grub on encrypted partition. When no, I'll submit a patch. Do you have any progress on this? Besides document it, IMHO why not we consider to remove it or make it default enable to receive more

Re: GRUB_CRYPTODISK_ENABLE undocumented

2013-08-29 Thread Michael Chang
On Wed, Aug 28, 2013 at 04:51:00PM +0200, Vladimir 'φ-coder/phcoder' Serbinenko wrote: On 28.08.2013 09:05, Michael Chang wrote: Hi Andrey, 2013/3/29 Andrey Borzenkov arvidj...@gmail.com: Is it intentional? I hit it when testing grub on encrypted partition. When no, I'll submit

Re: EFI and multiboot2 devlopment work for Xen

2013-10-23 Thread Michael Chang
2013/10/23 Konrad Rzeszutek Wilk konrad.w...@oracle.com: On Tue, Oct 22, 2013 at 03:25:39PM +, Woodhouse, David wrote: On Tue, 2013-10-22 at 10:43 -0400, Konrad Rzeszutek Wilk wrote: And looking at bit deeper in the x86/linux boot spec: EFI HANDOVER PROTOCOL This protocol

Re: EFI and multiboot2 devlopment work for Xen

2013-10-23 Thread Michael Chang
2013/10/23 Michael Chang mch...@suse.com: 2013/10/23 Konrad Rzeszutek Wilk konrad.w...@oracle.com: On Tue, Oct 22, 2013 at 03:25:39PM +, Woodhouse, David wrote: On Tue, 2013-10-22 at 10:43 -0400, Konrad Rzeszutek Wilk wrote: And looking at bit deeper in the x86/linux boot spec

Re: booting btrfs

2013-12-20 Thread Michael Chang
2013/12/20 Vladimir 'φ-coder/phcoder' Serbinenko phco...@gmail.com: On 19.12.2013 17:13, Andrey Borzenkov wrote: В Mon, 28 Oct 2013 01:44:26 +0100 Vladimir 'φ-coder/phcoder' Serbinenko phco...@gmail.com пишет: I changed in trunk to make / refer to real root and modified grub-mkrelpath to

Re: booting btrfs

2013-12-23 Thread Michael Chang
2013/12/24 Vladimir 'φ-coder/phcoder' Serbinenko phco...@gmail.com: On 24.12.2013 07:12, Chris Murphy wrote: On Dec 23, 2013, at 9:20 PM, Vladimir 'φ-coder/phcoder' Serbinenko phco...@gmail.com wrote: On 24.12.2013 04:43, Chris Murphy wrote: d point. Your snapshot tool could first create a

Re: booting btrfs

2013-12-30 Thread Michael Chang
On Mon, Dec 23, 2013 at 08:43:34PM -0700, Chris Murphy wrote: On Dec 23, 2013, at 7:26 PM, Michael Chang mch...@suse.com wrote: Now I tend to agree that supporting config for snapshot booting shouldn't be upstream's consideration due to it's compliexity and dependency to system, Despite

Re: booting btrfs

2013-12-30 Thread Michael Chang
On Mon, Dec 30, 2013 at 12:28:44PM +0100, Vladimir 'φ-coder/phcoder' Serbinenko wrote: On 30.12.2013 11:18, Michael Chang wrote: On Mon, Dec 23, 2013 at 08:43:34PM -0700, Chris Murphy wrote: On Dec 23, 2013, at 7:26 PM, Michael Chang mch...@suse.com wrote: Now I tend to agree

Re: booting btrfs

2013-12-30 Thread Michael Chang
On Tue, Dec 24, 2013 at 11:46:00AM +0400, Andrey Borzenkov wrote: On Tue, Dec 24, 2013 at 11:28 AM, Michael Chang mch...@suse.com wrote: And very thankful for the $1 magic, it heals my headache of variable assignment per each (sub)menu entries. $1 is always menu entry title, you

Re: booting btrfs

2013-12-30 Thread Michael Chang
On Mon, Dec 30, 2013 at 03:52:36PM +0400, Andrey Borzenkov wrote: On Mon, Dec 30, 2013 at 3:28 PM, Vladimir 'φ-coder/phcoder' Serbinenko phco...@gmail.com wrote: On 30.12.2013 11:18, Michael Chang wrote: On Mon, Dec 23, 2013 at 08:43:34PM -0700, Chris Murphy wrote: On Dec 23, 2013, at 7

Re: booting btrfs

2014-01-01 Thread Michael Chang
2014/1/1 Chris Murphy li...@colorremedies.com: On Dec 31, 2013, at 12:50 AM, Michael Chang mch...@suse.com wrote: On Mon, Dec 30, 2013 at 03:52:36PM +0400, Andrey Borzenkov wrote: On Mon, Dec 30, 2013 at 3:28 PM, Vladimir 'φ-coder/phcoder' Serbinenko phco...@gmail.com wrote: On 30.12.2013

Re: booting btrfs

2014-01-09 Thread Michael Chang
2014/1/9 Chris Murphy li...@colorremedies.com: On Jan 7, 2014, at 10:55 AM, Chris Murphy li...@colorremedies.com wrote: On Jan 1, 2014, at 10:17 PM, Michael Chang mch...@suse.com wrote: We snapshot /boot for kernel and initrd, otherwise the rollback would encounter problem of incompatible

Re: booting btrfs

2014-01-12 Thread Michael Chang
2014/1/11 Andrey Borzenkov arvidj...@gmail.com: В Tue, 24 Dec 2013 05:20:19 +0100 Vladimir 'φ-coder/phcoder' Serbinenko phco...@gmail.com пишет: On 24.12.2013 04:43, Chris Murphy wrote: d point. Your snapshot tool could first create a read only snapshot, then for no space cost also

Re: booting btrfs

2014-01-12 Thread Michael Chang
2014/1/10 Chris Murphy li...@colorremedies.com: On Jan 9, 2014, at 3:03 AM, Michael Chang mch...@suse.com wrote: 2014/1/9 Chris Murphy li...@colorremedies.com: On Jan 7, 2014, at 10:55 AM, Chris Murphy li...@colorremedies.com wrote: On Jan 1, 2014, at 10:17 PM, Michael Chang mch

Re: booting btrfs

2014-01-13 Thread Michael Chang
2014/1/13 Andrey Borzenkov arvidj...@gmail.com: On Mon, Jan 13, 2014 at 9:05 AM, Michael Chang mch...@suse.com wrote: 2014/1/11 Andrey Borzenkov arvidj...@gmail.com: В Tue, 24 Dec 2013 05:20:19 +0100 Vladimir 'φ-coder/phcoder' Serbinenko phco...@gmail.com пишет: On 24.12.2013 04:43, Chris

Re: booting btrfs

2014-01-13 Thread Michael Chang
On Mon, Jan 13, 2014 at 05:08:49PM +0400, Andrey Borzenkov wrote: On Mon, Jan 13, 2014 at 1:12 PM, Michael Chang mch...@suse.com wrote: OK. To be more verbose, the question of mine is that I'm uncertain if we don't explicitly install to a partition using blocklists, the /fs/core.img would

Re: booting btrfs

2014-01-21 Thread Michael Chang
On Tue, Jan 21, 2014 at 09:09:34AM +0100, Vladimir 'φ-coder/phcoder' Serbinenko wrote: On 13.01.2014 06:05, Michael Chang wrote: --split --run=10_linux,20_linux_xen You shouldn't assume that only files you installed are the ones available. E.g. memtest adds its own config to /etc/grub.d

pvgrub2 and old grub menu.lst

2014-04-01 Thread Michael Chang
While trying to boot xen pv guest with old grub config (menu.lst), the pvgrub2 loads it's menu successfully, but when you attemp to boot the kernel it failed with the following message. error: couldn't load file /boot/vmlinuz-3.0.76-0.11-xen. error: you need to load the kernel first.

Re: pvgrub2 and old grub menu.lst

2014-04-02 Thread Michael Chang
On Tue, Apr 01, 2014 at 08:06:44PM +0400, Andrey Borzenkov wrote: В Tue, 1 Apr 2014 15:46:22 +0800 Michael Chang mch...@suse.com пишет: While trying to boot xen pv guest with old grub config (menu.lst), the pvgrub2 loads it's menu successfully, but when you attemp to boot the kernel

Re: pvgrub2 and old grub menu.lst

2014-04-03 Thread Michael Chang
On Wed, Apr 02, 2014 at 08:13:14PM +0400, Andrey Borzenkov wrote: В Wed, 2 Apr 2014 14:29:50 +0400 Andrey Borzenkov arvidj...@gmail.com пишет: On Wed, Apr 2, 2014 at 12:43 PM, Michael Chang mch...@suse.com wrote: On Tue, Apr 01, 2014 at 08:06:44PM +0400, Andrey Borzenkov wrote: В Tue

Re: pvgrub2 and old grub menu.lst

2014-04-03 Thread Michael Chang
On Thu, Apr 03, 2014 at 12:25:19PM +0400, Andrey Borzenkov wrote: On Thu, Apr 3, 2014 at 10:50 AM, Michael Chang mch...@suse.com wrote: I also setup two disks for testing, and set root=hdX,Y to list the file in repective disk correct. Then swapping the disk order in xen config and again

[PATCH] Fix incorrect address reference in btrfs

2014-08-14 Thread Michael Chang
We encountered a weird random kernel initrd unpacking error on btrfs and finally found it was caused by incorrect address reference in range check for type GRUB_BTRFS_EXTENT_REGULAR and the entire result is unpredictable. This is a quick fix to make the address reference to the

Re: [PATCH] Fix incorrect address reference in btrfs

2014-08-14 Thread Michael Chang
CC Takashi and Jeff On Thu, Aug 14, 2014 at 06:17:45PM +0800, Michael Chang wrote: We encountered a weird random kernel initrd unpacking error on btrfs and finally found it was caused by incorrect address reference in range check for type GRUB_BTRFS_EXTENT_REGULAR and the entire result

[PATCH] Fix extraous comma in printf

2014-09-11 Thread Michael Chang
This patch is to get intended output from printf shell command, as the comma is not used as separator for it's arguments, they will eventually be outputted together with the variables. Though it does not affect or break any function currently, I'd like to address this hidden problem and hope to

[PATCH] fix booting xenlinux kerenl error not on a xen domain

2014-09-18 Thread Michael Chang
There are two types of xen enabled kernel in linux, one is called xenlinux which is older and can only boot on xen domain but not on any real hardware without xen hypervisor. The other is called pvops which can boot on xen domain as well as real hardware. This patch is to prevent booting xenlinux

Re: [PATCH] fix booting xenlinux kerenl error not on a xen domain

2014-09-23 Thread Michael Chang
On Sun, Sep 21, 2014 at 05:27:02PM +0200, Vladimir 'φ-coder/phcoder' Serbinenko wrote: On 18.09.2014 10:58, Michael Chang wrote: There are two types of xen enabled kernel in linux, one is called xenlinux which is older and can only boot on xen domain but not on any real hardware without

workaround install boot on btrfs with windows partition scheme

2014-10-30 Thread Michael Chang
Many shipped Windows created it's first partition aligned in 63 (cylinder) and therefore can't offer enough room for core.img. Even worse the partitions has been created as logical. sudo /sbin/fdisk -l Disk /dev/sda: 64.4 GB, 64424509440 bytes, 125829120 sectors Units = sectors of 1 * 512 =

Re: workaround install boot on btrfs with windows partition scheme

2014-11-02 Thread Michael Chang
On Thu, Oct 30, 2014 at 03:42:29PM +0300, Andrei Borzenkov wrote: On Thu, Oct 30, 2014 at 11:32 AM, Michael Chang mch...@suse.com wrote: Many shipped Windows created it's first partition aligned in 63 (cylinder) and therefore can't offer enough room for core.img. Even worse the partitions

[PATCH] icmp6 fix no respond to neighbor solicit message

2014-11-03 Thread Michael Chang
The structure size used in grub_netbuff_pull to get the pointer to option header is apparently wrong, which leads to subsequent range check failed and therefore not responding to any neighbor solicit message in my testing. --- grub-core/net/icmp6.c |2 +- 1 files changed, 1 insertions(+), 1

Re: workaround install boot on btrfs with windows partition scheme

2014-11-03 Thread Michael Chang
On Mon, Nov 03, 2014 at 01:04:33PM -0700, Chris Murphy wrote: On Nov 2, 2014, at 9:17 PM, Michael Chang mch...@suse.com wrote: On Thu, Oct 30, 2014 at 03:42:29PM +0300, Andrei Borzenkov wrote: On Thu, Oct 30, 2014 at 11:32 AM, Michael Chang mch...@suse.com wrote: Many shipped Windows

[PATCH] send router solicitation for ipv6 address autoconf

2014-11-13 Thread Michael Chang
Many routers have long router advertisment interval configured by default. The Neighbor Discovery protocol (RFC4861) has defined default MaxRtrAdvInterval value as 600 seconds and MinRtrAdvInterval as 0.33*MaxRtrAdvInterval. This makes net_ipv6_autoconf fails more often than not as currently it

Re: [PATCH] send router solicitation for ipv6 address autoconf

2014-11-18 Thread Michael Chang
On Sat, Nov 15, 2014 at 07:54:42PM +0300, Andrei Borzenkov wrote: В Thu, 13 Nov 2014 17:42:23 +0800 Michael Chang mch...@suse.com пишет: Many routers have long router advertisment interval configured by default. The Neighbor Discovery protocol (RFC4861) has defined default

Re: [edk2] [PATCH 2/2] efinet: fix lost packets due to active MNP instances

2015-04-21 Thread Michael Chang
On Mon, Apr 20, 2015 at 02:30:00PM +0800, Michael Chang wrote: On Sun, Apr 19, 2015 at 11:01:11AM +0300, Andrei Borzenkov wrote: EDK2 network stack is based on Managed Network Protocol which is layered on top of Simple Management Protocol and does background polling. This polling races

Re: [edk2] [PATCH 2/2] efinet: fix lost packets due to active MNP instances

2015-04-21 Thread Michael Chang
On Tue, Apr 21, 2015 at 02:12:54PM +0800, Michael Chang wrote: On Mon, Apr 20, 2015 at 02:30:00PM +0800, Michael Chang wrote: On Sun, Apr 19, 2015 at 11:01:11AM +0300, Andrei Borzenkov wrote: EDK2 network stack is based on Managed Network Protocol which is layered on top of Simple

Re: [PATCH 1/3] Added net_bootp6 command

2015-04-19 Thread Michael Chang
On Sun, Apr 19, 2015 at 11:15:21AM +0300, Andrei Borzenkov wrote: В Fri, 17 Apr 2015 13:04:27 +0800 Michael Chang mch...@suse.com пишет: +static const struct grub_dhcpv6_option* +find_dhcpv6_option (const struct grub_net_dhcpv6_packet *packet, + grub_uint16_t

Re: [PATCH 2/2] efinet: fix lost packets due to active MNP instances

2015-04-20 Thread Michael Chang
); + match = grub_efi_compare_device_paths (dup_dp, cdp) == 0; + grub_free (dup_dp); + if (!match) + continue; + } pxe = grub_efi_open_protocol (hnd, pxe_io_guid, GRUB_EFI_OPEN_PROTOCOL_GET_PROTOCOL); if (! pxe) -- 2.1.4 -- Michael

Re: [edk2] [PATCH 2/2] efinet: fix lost packets due to active MNP instances

2015-04-27 Thread Michael Chang
On Sat, Apr 25, 2015 at 05:12:33PM +0300, Andrei Borzenkov wrote: В Tue, 21 Apr 2015 14:12:54 +0800 Michael Chang mch...@suse.com пишет: +static grub_err_t +open_card (struct grub_net_card *dev) +{ + grub_efi_simple_network_t *net; I'm not sure about adding null

Re: [edk2] [PATCH 2/2] efinet: fix lost packets due to active MNP instances

2015-04-27 Thread Michael Chang
On Sun, Apr 26, 2015 at 09:42:52AM +0300, Andrei Borzenkov wrote: В Tue, 21 Apr 2015 14:12:54 +0800 Michael Chang mch...@suse.com пишет: 3. Even I can add the card open earler before hadling the dhcpv6 packets, it will freeze at grub_efi_open_protocol if the option in use

Re: [edk2] [PATCH 2/2] efinet: fix lost packets due to active MNP instances

2015-04-28 Thread Michael Chang
On Mon, Apr 27, 2015 at 02:47:16PM +0800, Michael Chang wrote: On Sun, Apr 26, 2015 at 09:42:52AM +0300, Andrei Borzenkov wrote: В Tue, 21 Apr 2015 14:12:54 +0800 Michael Chang mch...@suse.com пишет: 3. Even I can add the card open earler before hadling the dhcpv6 packets

Re: [edk2] [PATCH 2/2] efinet: fix lost packets due to active MNP instances

2015-04-28 Thread Michael Chang
On Tue, Apr 28, 2015 at 02:03:02PM +0800, Michael Chang wrote: On Mon, Apr 27, 2015 at 02:47:16PM +0800, Michael Chang wrote: Apparently I made a mistake here, the exclusive open still fails. It's in your new patch that can survive the failed exlusive open by keep using the non-exclusive

Re: passing options to grub in xen,openfirmware and efi

2015-05-08 Thread Michael Chang
2015-05-07 23:03 GMT+08:00 Andrei Borzenkov arvidj...@gmail.com: On Thu, May 7, 2015 at 5:59 PM, Vladimir 'φ-coder/phcoder' Serbinenko phco...@gmail.com wrote: On 07.05.2015 16:54, Olaf Hering wrote: On Thu, May 07, Vladimir 'φ-coder/phcoder' Serbinenko wrote: The way pv-grub2 is built by

Re: [PATCH] Parse commandline in grub-xen

2015-05-11 Thread Michael Chang
On Mon, May 11, 2015 at 01:01:43PM +0200, Olaf Hering wrote: On Mon, May 11, Vladimir 'phcoder' Serbinenko wrote: Do you really own all those installs to be able to speak on behalf of all of them? Since there is zero upstream support for anything regarding grub xen distros are forced to

Re: [RFC] grub-install: allow none or multiple install devices on PC BIOS

2015-05-12 Thread Michael Chang
On Fri, May 08, 2015 at 09:53:41PM +0300, Andrei Borzenkov wrote: There are two main applications. 1. Omit install device to create generic image intended for chainloading from other master loader. Such image can be put on any device (or file system) and will still be able to find its $root.

[PATCH 1/3] Added net_bootp6 command

2015-05-12 Thread Michael Chang
The net_bootp6 is used to configure the ipv6 network interface through the DHCPv6 protocol Solict/Advertise/Request/Reply. --- grub-core/net/bootp.c | 895 - grub-core/net/ip.c| 35 ++ include/grub/net.h| 19 + 3 files changed, 948

[PATCH 3/3] Update document for net_bootp6 command

2015-05-12 Thread Michael Chang
Update document for net_bootp6 command --- docs/grub.texi | 17 + 1 files changed, 17 insertions(+), 0 deletions(-) diff --git a/docs/grub.texi b/docs/grub.texi index 4af22af..72780e3 100644 --- a/docs/grub.texi +++ b/docs/grub.texi @@ -5110,6 +5110,7 @@ List available video

[PATCH v1] Support DHCPv6 and UEFI IPv6 PXE

2015-05-12 Thread Michael Chang
This patch set tries to make support of configuring IPv6 network interface through the DHCPv6 protocol. A new command, net_bootp6, is therefore introduced to serve the purpose. You can think it as DHCPv6/IPv6 version of the existing net_bootp command. In addition to that, the UEFI IPv6 PXE

[PATCH 2/3] UEFI IPv6 PXE support

2015-05-12 Thread Michael Chang
When system is booted from UEFI IPv6 PXE, the network interface can be configured directly by cached DHCPv6 packet in firmware without doing it all over again by contacting DHCP server. --- grub-core/net/drivers/efi/efinet.c | 24 --- include/grub/efi/api.h | 55

Re: [PATCH 1/3] Added net_bootp6 command

2015-05-15 Thread Michael Chang
On Fri, May 15, 2015 at 09:26:06AM +0300, Andrei Borzenkov wrote: В Tue, 12 May 2015 16:49:48 +0800 Michael Chang mch...@suse.com пишет: The net_bootp6 is used to configure the ipv6 network interface through the DHCPv6 protocol Solict/Advertise/Request/Reply. --- grub-core/net/bootp.c

Re: [PATCH v1] Support DHCPv6 and UEFI IPv6 PXE

2015-05-15 Thread Michael Chang
On Fri, May 15, 2015 at 09:40:26AM +0300, Andrei Borzenkov wrote: В Tue, 12 May 2015 16:49:47 +0800 Michael Chang mch...@suse.com пишет: This patch set tries to make support of configuring IPv6 network interface through the DHCPv6 protocol. A new command, net_bootp6, is therefore

Re: [PATCH 1/3] Added net_bootp6 command

2015-05-19 Thread Michael Chang
Michael Chang mch...@suse.com пишет: The net_bootp6 is used to configure the ipv6 network interface through the DHCPv6 protocol Solict/Advertise/Request/Reply. --- grub-core/net/bootp.c | 895 - grub-core/net/ip.c| 35

Re: [RFC] grub-install: allow none or multiple install devices on PC BIOS

2015-05-12 Thread Michael Chang
On Tue, May 12, 2015 at 02:57:00PM +0300, Andrei Borzenkov wrote: В Tue, 12 May 2015 18:52:22 +0800 Michael Chang mch...@suse.com пишет: On Fri, May 08, 2015 at 09:53:41PM +0300, Andrei Borzenkov wrote: There are two main applications. It will abort, unfortunately. Changing

Re: [RFC] grub-install: allow none or multiple install devices on PC BIOS

2015-05-12 Thread Michael Chang
On Tue, May 12, 2015 at 02:57:00PM +0300, Andrei Borzenkov wrote: В Tue, 12 May 2015 18:52:22 +0800 Michael Chang mch...@suse.com пишет: On Fri, May 08, 2015 at 09:53:41PM +0300, Andrei Borzenkov wrote: There are two main applications. 1. Omit install device to create generic image

Re: [PATCH 1/3] Added net_bootp6 command

2015-04-16 Thread Michael Chang
Hi Andrei, Please see my comments and please let me know any problems remains. I'll submit next version soon. Thanks a lot for your detailed review. Regards, Michael On Thu, Apr 16, 2015 at 05:40:56PM +0300, Andrei Borzenkov wrote: В Wed, 15 Apr 2015 17:05:07 +0800 Michael Chang mch

Re: [PATCH 3/3] Use UEFI MAC device as default configured by net_bootp6

2015-04-17 Thread Michael Chang
On Thu, Apr 16, 2015 at 10:58:19PM +0300, Andrei Borzenkov wrote: В Wed, 15 Apr 2015 17:05:09 +0800 Michael Chang mch...@suse.com пишет: The grub_efinet_findcards will register cards by checking if it can support EFI Simple Netowork Protocol which create more than one device

[PATCH 1/3] Added net_bootp6 command

2015-04-15 Thread Michael Chang
The net_bootp6 is used to configure the ipv6 network interface through the DHCPv6 protocol Solict/Advertise/Request/Reply. --- grub-core/net/bootp.c | 885 +++- grub-core/net/ip.c | 35 ++ include/grub/efi/api.h | 56 +++- include/grub/net.h

[RFC] Support DHCPv6 and UEFI IPv6 PXE

2015-04-15 Thread Michael Chang
Hi, This patch set tries to make support of configuring IPv6 network interface through the DHCPv6 protocol. A new command, net_bootp6, is therefore introduced to serve the purpose. You can think it as DHCPv6/IPv6 version of the existing net_bootp command. In addition to that, the UEFI IPv6 PXE

[PATCH 3/3] Use UEFI MAC device as default configured by net_bootp6

2015-04-15 Thread Michael Chang
The grub_efinet_findcards will register cards by checking if it can support EFI Simple Netowork Protocol which create more than one device to a physical NIC device. If without specifying any device to be configured by net_bootp6, it should pick up one from them but not all. In my case three

[PATCH 2/3] UEFI IPv6 PXE support

2015-04-15 Thread Michael Chang
When system is booted from UEFI IPv6 PXE, the network interface can be configured directly by cached DHCPv6 packet in firmware without doing it all over again by contacting DHCP server. --- grub-core/net/drivers/efi/efinet.c | 24 +++- 1 files changed, 19 insertions(+), 5

[PATCH] Fix missing byte order conversion in get_btrfs_fs_prefix function

2015-06-22 Thread Michael Chang
Since btrfs on-disk format uses little-endian, the searched item types (ROOT_REF, INODE_REF) need converting the byte order in order to function properly on big-endian systems. --- grub-core/osdep/linux/getroot.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git

Re: [RFC] Support menuentry options in simple configuration interface

2015-06-10 Thread Michael Chang
On Mon, Jun 01, 2015 at 11:35:49AM +0800, Michael Chang wrote: On Sat, May 30, 2015 at 10:39:06AM +0300, Andrei Borzenkov wrote: В Tue, 26 May 2015 15:53:14 +0800 Michael Chang mch...@suse.com пишет: This patch provides settings in simple configuration interface that can set

Re: [RFC] Support menuentry options in simple configuration interface

2015-05-31 Thread Michael Chang
On Sat, May 30, 2015 at 10:39:06AM +0300, Andrei Borzenkov wrote: В Tue, 26 May 2015 15:53:14 +0800 Michael Chang mch...@suse.com пишет: This patch provides settings in simple configuration interface that can set common options to menuentry. One of the use cases is specifying the security

[RFC] Support menuentry options in simple configuration interface

2015-05-26 Thread Michael Chang
This patch provides settings in simple configuration interface that can set common options to menuentry. One of the use cases is specifying the security settings thus it won't be overwritten by grub-mkconfig. For eg. GRUB_MENU_ENTRY_OPTION_LINUX=--unrestricted

Re: [PATCH 0/3] fix ipv6 support

2015-08-05 Thread Michael Chang
On Wed, Aug 05, 2015 at 10:50:37AM -0700, Josef Bacik wrote: These patches are on top of Michael Chang's bootp6 code (which we also really need so it would be great if those could go in as well). At Facebook we have ipv6 only clusters that we need to be able to provision over the network. The

Re: [PATCH] Use UEFI Time Service to calibrate TSC

2015-11-11 Thread Michael Chang
On Mon, Nov 09, 2015 at 03:21:37PM +0100, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > On 09.11.2015 14:23, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > > On 09.11.2015 09:03, Michael Chang wrote: > Attached proof-of-concept. It's all in one file but different methods > sho

Re: [PATCH] Use UEFI Time Service to calibrate TSC

2015-11-12 Thread Michael Chang
On Thu, Nov 12, 2015 at 11:52:24AM +0300, Andrei Borzenkov wrote: > On Thu, Nov 12, 2015 at 10:34 AM, Michael Chang <mch...@suse.com> wrote: > > On Mon, Nov 09, 2015 at 03:21:37PM +0100, Vladimir 'φ-coder/phcoder' > > Serbinenko wrote: > >> On 09.11.2015 14

Re: [PATCH] Use UEFI Time Service to calibrate TSC

2015-11-09 Thread Michael Chang
On Mon, Nov 09, 2015 at 10:29:55AM +0300, Andrei Borzenkov wrote: > On Mon, Nov 9, 2015 at 10:07 AM, Michael Chang <mch...@suse.com> wrote: > > This patch tries to detect PIT timer is broken and use UEFI Time Service > > to calibrate TSC. > > Second try :) > > h

[PATCH] emu: fix unusable terminal after exit

2015-12-23 Thread Michael Chang
The grub-emu's grub_exit function will exit immediately without any housekeeping work for restoring terminal settings and leaves unusable terminal in the end. Fix the problem by calling grub_reboot to allow doing the housekeeping work and restoring the terminal settings. ---

[PATCH] normal: fix get_logical_num_lines

2015-12-22 Thread Michael Chang
In menu editing mode, grub2 shows bogus line if the character being edited is at last column of entry. This patch fixes the problem by having the get_logical_num_lines function to calculate correct number of lines. --- grub-core/normal/menu_entry.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH] normal: fix get_logical_num_lines

2015-12-27 Thread Michael Chang
On Mon, Dec 28, 2015 at 12:09:58PM +0800, Michael Chang wrote: > On Thu, Dec 24, 2015 at 02:48:34PM +0300, Andrei Borzenkov wrote: > > It sounds like we need > > > > string_width = grub_getstringwidth (linep->buf, linep->buf + > > linep->len, term_

Re: [PATCH] normal: fix get_logical_num_lines

2015-12-27 Thread Michael Chang
On Thu, Dec 24, 2015 at 02:48:34PM +0300, Andrei Borzenkov wrote: > On Wed, Dec 23, 2015 at 7:45 AM, Michael Chang <mch...@suse.com> wrote: > > In menu editing mode, grub2 shows bogus line if the character being > > edited is at last column of entry. This patch fixes the

Re: [PATCH] emu: fix unusable terminal after exit

2015-12-28 Thread Michael Chang
On Wed, Dec 23, 2015 at 02:45:20PM +0300, Andrei Borzenkov wrote: > On Wed, Dec 23, 2015 at 12:49 PM, Michael Chang <mch...@suse.com> wrote: > > The grub-emu's grub_exit function will exit immediately without any > > housekeeping work for restoring terminal setting

Re: [PATCH] normal: fix get_logical_num_lines

2015-12-23 Thread Michael Chang
On Wed, Dec 23, 2015 at 09:26:43AM +0300, Andrei Borzenkov wrote: > On Wed, Dec 23, 2015 at 7:45 AM, Michael Chang <mch...@suse.com> wrote: > > In menu editing mode, grub2 shows bogus line if the character being > > edited is at last column of entry. This patch fixes the

Re: [PATCH] calibrate_tsc(): use the Stall() EFI boot service on GRUB_MACHINE_EFI

2015-11-30 Thread Michael Chang
On Mon, Nov 30, 2015 at 08:34:18PM +0300, Andrei Borzenkov wrote: > 30.11.2015 19:50, Andrei Borzenkov пишет: > > 30.11.2015 19:31, Vitaly Kuznetsov пишет: > >> Andrei Borzenkov writes: > >> > >>> 26.11.2014 11:59, Laszlo Ersek пишет: > HyperV Gen2 virtual machines have

Re: [PATCH] 10_linux: avoid multi-device root= kernel argument

2016-01-28 Thread Michael Chang
On Thu, Jan 28, 2016 at 07:46:41PM +0300, Andrei Borzenkov wrote: > If root filesystem is multidev btrfs, do not attempt to pass all devices as > kernel root= argument. This results in splitting command line in GRUB due to > embedded newline and even if we managed to quote it, kernel does not know

Re: [RFC] grub-install: allow none or multiple install devices on PC BIOS

2016-02-15 Thread Michael Chang
On Sat, Feb 13, 2016 at 10:29:58AM +0300, Andrei Borzenkov wrote: > 12.05.2015 18:22, Michael Chang пишет: > > On Tue, May 12, 2015 at 02:57:00PM +0300, Andrei Borzenkov wrote: > >> В Tue, 12 May 2015 18:52:22 +0800 > >> Michael Chang <mch...@suse.com> пишет: >

[PATCH] http: fix superfluous null line in range request header

2016-04-06 Thread Michael Chang
At least the apache sever is very unhappy with that extra null line and will take more than ten seconds in responding to each range request, which slows down a lot the entire http file transfer process or even time out. --- grub-core/net/http.c | 3 +-- 1 file changed, 1 insertion(+), 2

Re: [PATCH] grub-file: fix segmentation fault

2016-04-12 Thread Michael Chang
On Mon, Apr 11, 2016 at 12:28:35PM +0300, Andrei Borzenkov wrote: > On Mon, Apr 11, 2016 at 7:00 AM, Michael Chang <mch...@suse.com> wrote: > > On Sat, Apr 09, 2016 at 07:01:50AM +0300, Andrei Borzenkov wrote: > >> 08.04.2016 09:43, Michael Chang пишет: > >> &g

[PATCH v2] grub-file: fix segmentation fault

2016-04-12 Thread Michael Chang
In grub_file_open the file handle returned by file filters has no file->name set which leads to segmentation fault later referenced by grub_elf_file. This patch tries to fix the problem. gdb --args ./grub-file --is-x86_64-xen-domu /boot/vmlinux-4.1.12-1-default.gz (gdb) bt #0

Re: [PATCH] grub-file: fix segmentation fault

2016-04-10 Thread Michael Chang
On Sat, Apr 09, 2016 at 07:01:50AM +0300, Andrei Borzenkov wrote: > 08.04.2016 09:43, Michael Chang пишет: > > In grub_file_open the file handle returned by file filters has no file->name > > set which leads to segmentation fault later referenced by grub_elf_file. We > > m

[PATCH] grub-file: fix segmentation fault

2016-04-08 Thread Michael Chang
In grub_file_open the file handle returned by file filters has no file->name set which leads to segmentation fault later referenced by grub_elf_file. We move the file->name value assignment after file filters to make sure it will be set and returned. The stack backtrace for reference. gdb

Re: Bugs and tasks for 2.02[~rc1]

2016-03-07 Thread Michael Chang
On Mon, Mar 07, 2016 at 10:07:58PM +, Vladimir 'phcoder' Serbinenko wrote: > Le lun. 7 mars 2016 23:01, Peter Jones a écrit : > > > On Tue, Mar 08, 2016 at 12:29:14AM +0300, Andrei Borzenkov wrote: > > > 08.03.2016 00:20, Peter Jones пишет: > > > > On Mon, Mar 07, 2016 at

Re: Bugs and tasks for 2.02[~rc1]

2016-03-07 Thread Michael Chang
On Mon, Mar 07, 2016 at 05:01:33PM -0500, Peter Jones wrote: > On Tue, Mar 08, 2016 at 12:29:14AM +0300, Andrei Borzenkov wrote: > > 08.03.2016 00:20, Peter Jones пишет: > > > On Mon, Mar 07, 2016 at 11:57:33PM +0300, Andrei Borzenkov wrote: > > >> > > >>> How big part of it is related to secure

Re: [PATCH] fix attempt to seek outside of the file error when parsing xen ELF notes

2016-03-03 Thread Michael Chang
On Thu, Mar 03, 2016 at 09:17:27PM +0300, Andrei Borzenkov wrote: > 03.03.2016 10:33, Michael Chang пишет: > > The kernel bzImage payload length appears to be incorrectly minus by 4 when > > trying to grub_file_offset_open for the uncompressed vmlinux image. If gzip > &g

[PATCH] fix attempt to seek outside of the file error when parsing xen ELF notes

2016-03-02 Thread Michael Chang
The kernel bzImage payload length appears to be incorrectly minus by 4 when trying to grub_file_offset_open for the uncompressed vmlinux image. If gzip used as compressor it will lead to the file->size read from offset of crc32 instead of the uncompressed image size. [1]

Re: Bugs and tasks for 2.02[~rc1]

2016-03-09 Thread Michael Chang
On Wed, Mar 09, 2016 at 07:38:45AM +0100, Olaf Hering wrote: > On Wed, Mar 02, Vladimir 'phcoder' Serbinenko wrote: > > > I would like to come up with a complete list of 2.02 blockers in one week > > time, > > so that we can have a reasonable timeline > > Did anyone took the time to fix btrfs

  1   2   3   4   >