[PATCH] * grub-core/fs/udf.c: Add support for UUID

2017-04-10 Thread Pali Rohár
Use same algorithm as in libblkid from util-linux. --- grub-core/fs/udf.c | 136 ++-- 1 file changed, 131 insertions(+), 5 deletions(-) diff --git a/grub-core/fs/udf.c b/grub-core/fs/udf.c index 839bff8..a4baa4c 100644 --- a/grub-core/fs/udf.c +++

Re: [PATCH] * grub-core/fs/udf.c: Add support for UUID

2017-04-19 Thread Pali Rohár
supported by Windows, Linux and Mac OS X kernels. Which is a good benefit for multi-boot environment. On Monday 10 April 2017 20:35:30 Pali Rohár wrote: > Use same algorithm as in libblkid from util-linux. > --- > grub-core/fs/udf.c | 136 > ++

Re: [PATCH] * grub-core/fs/udf.c: Fix reading label, lvd.ident is dstring

2017-07-02 Thread Pali Rohár
On Thursday 22 June 2017 14:33:17 Pali Rohár wrote: > UDF dstring has stored length in the last byte of buffer. Therefore > last byte is not part of recorded characters. And empty string in > dstring is encoded as empty buffer, including first byte > (compression id). > --- >

Re: [PATCH] * grub-core/fs/udf.c: Fix reading label, lvd.ident is dstring

2017-08-08 Thread Pali Rohár
Thanks a lot! On Monday 07 August 2017 15:40:15 Vladimir 'phcoder' Serbinenko wrote: > Committed with fixes and simplifications. The biggest problem was lack of > check whether grub_malloc succeeded > > Le Thu, Jun 22, 2017 à 2:34 PM, Pali Rohár <pali.ro...@gmail.com> a

Re: [PATCH] * grub-core/fs/udf.c: Add support for UUID

2017-05-11 Thread Pali Rohár
On Monday 08 May 2017 16:24:24 Pali Rohár wrote: > On Monday 08 May 2017 15:13:28 Vladimir 'phcoder' Serbinenko wrote: > > On Mon, Apr 10, 2017, 23:17 Pali Rohár <pali.ro...@gmail.com> wrote: > > > char *outbuf, int normalize_utf8) > > > > Normalize isn'

Re: [PATCH] * grub-core/fs/udf.c: Add support for UUID

2017-05-12 Thread Pali Rohár
On Monday 08 May 2017 15:13:28 Vladimir 'phcoder' Serbinenko wrote: > On Mon, Apr 10, 2017, 23:17 Pali Rohár <pali.ro...@gmail.com> wrote: > > -read_string (const grub_uint8_t *raw, grub_size_t sz, char > > *outbuf) +read_string (const grub_uint8_t *raw, grub_size_t sz,

[PATCH] * grub-core/fs/udf.c: Fix reading label, lvd.ident is dstring

2017-06-22 Thread Pali Rohár
UDF dstring has stored length in the last byte of buffer. Therefore last byte is not part of recorded characters. And empty string in dstring is encoded as empty buffer, including first byte (compression id). --- I'm not sure how Grub2 should handle empty label. Current patch set empty buffer for

[PATCH v2] * grub-core/fs/udf.c: Add support for UUID

2017-06-22 Thread Pali Rohár
Use same algorithm as in libblkid from util-linux v2.30. 1. Take first 16 bytes from UTF-8 encoded string of VolumeSetIdentifier 2. If all bytes are hexadecimal digits, convert to lowercase and use as UUID 3. If first 8 bytes are not all hexadecimal digits, convert those 8 bytes to their

Re: [PATCH] * grub-core/fs/udf.c: Add support for UUID

2017-05-08 Thread Pali Rohár
On Monday 08 May 2017 15:13:28 Vladimir 'phcoder' Serbinenko wrote: > On Mon, Apr 10, 2017, 23:17 Pali Rohár <pali.ro...@gmail.com> wrote: > > char *outbuf, int normalize_utf8) > > Normalize isn't the right word. And it's not utf-8 but latin1 (called > compressed utf-1

Re: [PATCH] * grub-core/fs/udf.c: Add support for UUID

2017-05-08 Thread Pali Rohár
Gentle PING for this patch! On Wednesday 19 April 2017 19:48:39 Pali Rohár wrote: > Hi! I would like to remind this patch. It allows to use UUID of UDF > partition in grub2. Linux tool blkid is already able to handle it, so it > is possible to specify UUID of UDF partition in /etc/fstab.