On Fri, 2005-07-01 at 12:35 +0200, Marco Gerards wrote:
Ludovic Drolez [EMAIL PROTECTED] writes:
Ludovic Drolez wrote:
I think it's really important to fix grub's code (by stealing code
from isolinux ?),
Also, I've just found that for the linux kernel, they also used
sys/isolinux's
On Thu, 2005-12-08 at 19:25 +0100, Yoshinori K. Okuji wrote:
There's a major point of contention being ignored here. OS vendors
don't want to ship executables which require an executable stack. Full
stop.
I'd like to hear your opinion as a distributor about the trend of prohibiting
On Mon, 2006-01-09 at 16:06 +0100, Yoshinori K. Okuji wrote:
On Wednesday 28 December 2005 09:08 am, Peter Jones wrote:
That's taking the very unrealistic point of view that using nested
functions isn't broken. It is, in a great many ways which have already
been discussed in depth
The old code gives arguments to a printf function which can't work
correctly, and the compiler complains.
---
grub-core/tests/example_functional_test.c |2 +-
grub-core/tests/lib/test.c| 88 +++--
include/grub/test.h | 10 ++-
a/ChangeLog b/ChangeLog
index ce52576..29ebcbd 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,11 @@
+2012-05-24 Peter Jones pjo...@redhat.com
+
+ * grub-core/Makefile.core.def: add efifwsetup module
+ * grub-core/commands/efi/efifwsetup.c: add code for fwsetup command
+ * grub
a/ChangeLog b/ChangeLog
index ce52576..29ebcbd 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,11 @@
+2012-05-24 Peter Jones pjo...@redhat.com
+
+ * grub-core/Makefile.core.def: add efifwsetup module
+ * grub-core/commands/efi/efifwsetup.c: add code for fwsetup command
+ * grub
efi_mmap_hi and efi_system_table_hi were implemented when bootloader
version was 0x0208, so require that to access them, and also fail to
boot if they're needed but unsupported. This way the bootloader will
give you an error instead of the system starting to boot and crashing.
---
On Wed, Apr 03, 2013 at 11:03:46PM +0400, Andrey Borzenkov wrote:
В Wed, 3 Apr 2013 11:53:06 -0400
Peter Jones pjo...@redhat.com пишет:
When we have 4kB sectors instead of 512b sectors, hd.partition_start and
grub_partition_get_start() won't match - the latter assumes 512-byte
sectors
On Mon, Oct 21, 2013 at 02:57:56PM +0200, Daniel Kiper wrote:
Hi,
During work on multiboot2 protocol support for Xen it was discovered
that memory map passed via relevant tag could not represent wide range
of memory types available on EFI platforms. Additionally, GRUB2
implementation calls
On Tue, Oct 22, 2013 at 10:51:40AM -0400, Konrad Rzeszutek Wilk wrote:
And I still haven't found the module that can launch any PE/COFF
image from GRUB2. Maybe that is a myth.
chainload will do this. In fact, it doesn't do much:
static grub_err_t
grub_chainloader_boot (void)
{
Signed-off-by: Peter Jones pjo...@redhat.com
---
grub-core/term/efi/console.c | 119 +++
include/grub/efi/api.h | 65 ++-
2 files changed, 174 insertions(+), 10 deletions(-)
diff --git a/grub-core/term/efi/console.c b/grub-core
This is version 2. Changes from version 1:
- handles SHIFT as a modifier
- handles F11 and F12 keys
- uses the handle provided by the system table to find our _EX protocol.
Signed-off-by: Peter Jones pjo...@redhat.com
---
grub-core/term/efi/console.c | 104
This is version 3.
Changes from version 1:
- handles SHIFT as a modifier
- handles F11 and F12 keys
- uses the handle provided by the system table to find our _EX protocol.
Changes from version 2:
- eliminate duplicate keycode translation.
Signed-off-by: Peter Jones pjo...@redhat.com
---
grub
, it stops
being recognized whatsoever.
Signed-off-by: Peter Jones pjo...@redhat.com
---
grub-core/term/efi/console.c | 119 +++
include/grub/efi/api.h | 65 ++-
2 files changed, 162 insertions(+), 22 deletions(-)
diff --git
, it stops
being recognized whatsoever.
Changes from version 4:
- Always initialize term-data from locate protocol (i.e. make it
unconditional.)
Signed-off-by: Peter Jones pjo...@redhat.com
---
grub-core/term/efi/console.c | 118 +++
include/grub/efi
This lets us make /boot/grub2/grubenv a symlink to
/boot/efi/EFI/fedora/grubenv even though they're different mount points,
which allows /usr/bin/grub2-editenv to be the same across platforms
(i.e. UEFI vs BIOS).
Signed-off-by: Peter Jones pjo...@redhat.com
Reviewed-by: Adam Jackson
Add grub_util_readlink(). This requires pulling in stat and readlink from
gnulib, which pulls in stat and related headers, but after that the
implementation is straightforward.
Signed-off-by: Peter Jones pjo...@redhat.com
Reviewed-by: Adam Jackson a...@redhat.com
---
grub-core/gnulib
Hi,
This is a patch series to allow grub-editenv and related utilities to
follow symbolic links when finding its config file. This allows, for
example, the ability to have two builds of grub for different platforms
that have different prefixes set, but still use the same userland grub
utilities.
a
stale *address* there that matches a recent allocation, then you'll get a
double free later.
So initialize the memory up front.
Signed-off-by: Peter Jones pjo...@redhat.com
---
grub-core/loader/arm/linux.c | 2 +-
grub-core/loader/arm64/linux.c| 2 +-
grub-core/loader
Hi everyone,
Is there a plan for when upcoming GNU GRUB releases will happen?
As far as I can tell, the last official release on
ftp://ftp.gnu.org/gnu/grub/ was 2.00 on 28-Jun-2012, and the last beta
on http://alpha.gnu.org/pub/gnu/grub/ for the next version was
2.02~beta2 on 24-Dec-2013 . There
On Sat, Oct 10, 2015 at 09:48:58PM +0300, Andrei Borzenkov wrote:
Sorry - realized I should have addressed your question and said one more
thing.
> Are there open issues with this patch? Is it used by Fedora? The part about
> SHIFT state bothers me, what happens for non-ASCII printable
On Sat, Oct 10, 2015 at 09:48:58PM +0300, Andrei Borzenkov wrote:
> 26.02.2014 02:12, Peter Jones пишет:
> >This is version 4.
> >
> >Changes from version 1:
> >- handles SHIFT as a modifier
> >- handles F11 and F12 keys
> >- uses the handle provided by th
here are reasons to adjust it sometimes, but let's start
with a plan.
Thoughts?
> Le 20 juil. 2015 20:23, "Peter Jones" <pjo...@redhat.com> a écrit :
>
> > Hi everyone,
> > Is there a plan for when upcoming GNU GRUB releases will happen?
> >
> &
On Sun, Feb 28, 2016 at 03:21:44PM +0100, Vladimir 'φ-coder/phcoder' Serbinenko
wrote:
> Hello, all. I've just released 2.02~beta3. The goal of this release is
> to chase bugs so that we can move to 2.02 release. So from now on if you
> think that your patch should be included in 2.02 rather than
On Tue, Mar 08, 2016 at 08:57:16PM +0300, Andrei Borzenkov wrote:
> 07.03.2016 22:00, Peter Jones пишет:
> ...
> >
> >>> And these are hardware specific. They're not critical, in the sense
> >>> that I can keep carrying them if you have any problems and we
On Tue, Mar 15, 2016 at 10:38:32AM -0700, Vladimir 'phcoder' Serbinenko wrote:
> Can somebody prepare a patch for this minimally changing current linux.c?
Sure, I can do that - sorry for the delay here, I had some family things
come up and had to spend last week away. So it'll still be a bit
On Wed, Mar 02, 2016 at 03:01:03PM +, Vladimir 'phcoder' Serbinenko wrote:
> Hello, all. I went through the list of bugs and created a shortlist of bugs
> that need to be looked at for 2.02. I have marked them with plan_release_id
> set to 2.02.
> Statistics: [1]
> Search (with loads of false
On Sat, Mar 05, 2016 at 11:38:00AM +0300, Andrei Borzenkov wrote:
> 04.03.2016 23:06, Peter Jones пишет:
> > On Wed, Mar 02, 2016 at 03:01:03PM +, Vladimir 'phcoder' Serbinenko
> > wrote:
> >> Hello, all. I went through the list of bugs and created a shortlis
On Mon, Mar 07, 2016 at 11:57:33PM +0300, Andrei Borzenkov wrote:
>
> > How big part of it is related to secure boot? Just
> > changing Linux boot protocol doesn't need FSF involvement. Accepting secure
>
> Patches currently use EFI stub to launch kernel but I think this is done
> simply to make
On Mon, Mar 07, 2016 at 07:57:21PM +, Vladimir 'phcoder' Serbinenko wrote:
> > > > Well, I have a bunch of patches that need to be clean up (or even
> > > > re-examined), and I've also got the secure-boot branch here:
> > > >
> > > > https://github.com/vathpela/grub2-fedora/tree/sb
> > > >
> >
On Mon, Mar 07, 2016 at 08:40:58PM +, Vladimir 'phcoder' Serbinenko wrote:
> Le lun. 7 mars 2016 21:33, Andrei Borzenkov a écrit :
>
> > 07.03.2016 22:57, Vladimir 'phcoder' Serbinenko пишет:
> > >>
> > > I would also appreciate if distros would tell which patches
On Mon, Mar 07, 2016 at 11:33:52PM +0300, Andrei Borzenkov wrote:
> 07.03.2016 22:57, Vladimir 'phcoder' Serbinenko пишет:
> >>
> > I would also appreciate if distros would tell which patches they would
> > carry if 2.02 was released as it is now. If some patches are in more
> >> than 1
>
On Tue, Mar 08, 2016 at 12:08:22AM +0300, Andrei Borzenkov wrote:
> 08.03.2016 00:03, Peter Jones пишет:
>
> > I'm curious as to why you think "linux16" doesn't work for Linux,
> > though. We use it 100% of the time in Fedora and RHEL, and upstream x86
> >
On Tue, Mar 08, 2016 at 12:29:14AM +0300, Andrei Borzenkov wrote:
> 08.03.2016 00:20, Peter Jones пишет:
> > On Mon, Mar 07, 2016 at 11:57:33PM +0300, Andrei Borzenkov wrote:
> >>
> >>> How big part of it is related to secure boot? Just
> >>> cha
From: Rob Clark <rcl...@redhat.com>
when protocols_per_handle returns error, we can't use the pointers we
passed to it, and that includes trusting num_protocols.
Signed-off-by: Peter Jones <pjo...@redhat.com>
---
grub-core/commands/efi/lsefi.c | 4 +++-
1 file changed, 3 inse
so we don't bother waiting for the test if what we're seeing is dead
pins with no response at all.
Signed-off-by: Peter Jones <pjo...@redhat.com>
---
grub-core/kern/i386/tsc_pmtimer.c | 43 ++-
1 file changed, 33 insertions(+), 10 deletions(-)
diff --git
On Thu, Jan 18, 2018 at 11:52:53PM +0100, Daniel Kiper wrote:
> On Tue, Jan 16, 2018 at 01:16:17PM -0500, Peter Jones wrote:
> > On my laptop running at 2.4GHz, if I run a VM where tsc calibration
> > using pmtimer will fail presuming a broken pmtimer, it takes ~51 secon
now -msoft-float -mno-stack-arg-probe -mcmodel=large -mno-red-zone -m64
-mtune=generic -march=x86-64 -g3 -Os -freg-struct-return -fno-stack-protector
-ffreestanding -funwind-tables -fasynchronous-unwind-tables
-fno-strict-aliasing -fstack-clash-protection -fno-ident -fplugin=annobin
Signed-off
This way debuginfo built from the .module will still include this
information, but the final result won't have the data we don't actually
need in the modules, either on-disk, loaded at runtime, or in prebuilt
images.
Signed-off-by: Peter Jones <pjo...@redhat.com>
---
grub-core/genmod.sh.
On Tue, Feb 20, 2018 at 03:48:44PM +0100, Daniel Kiper wrote:
> On Wed, Jan 31, 2018 at 11:26:59AM -0500, Peter Jones wrote:
> > +static int
> > +SUFFIX (is_kept_section) (Elf_Shdr *s, const struct
> > grub_install_image_target_desc *image_target);
> &
for section_addresses directly either.
This shouldn't change the binary file output or the "grub-mkimage -v"
output in any way.
Signed-off-by: Peter Jones <pjo...@redhat.com>
---
util/grub-mkimagexx.c | 282 ++
1 file changed, 123 insertions(+
now -msoft-float -mno-stack-arg-probe -mcmodel=large -mno-red-zone -m64
-mtune=generic -march=x86-64 -g3 -Os -freg-struct-return -fno-stack-protector
-ffreestanding -funwind-tables -fasynchronous-unwind-tables
-fno-strict-aliasing -fstack-clash-protection -fno-ident -fplugin=annobin
Signed-off
This way debuginfo built from the .module will still include this
information, but the final result won't have the data we don't actually
need in the modules, either on-disk, loaded at runtime, or in prebuilt
images.
Signed-off-by: Peter Jones <pjo...@redhat.com>
---
grub-core/genmod.sh.
On Tue, Feb 20, 2018 at 03:51:59PM +0100, Daniel Kiper wrote:
> On Wed, Jan 31, 2018 at 11:27:00AM -0500, Peter Jones wrote:
> > This way debuginfo built from the .module will still include this
> > information, but the final result won't have the data we don't actually
> >
Anyone want to have a look at this patchset to make gcc > 7.2.1 (with
optional plugins enabled) work?
On Wed, Jan 31, 2018 at 11:26:59AM -0500, Peter Jones wrote:
> Some versions of gcc include a plugin called "annobin", and in some
> build systems this is enabled by de
On Fri, Feb 23, 2018 at 03:51:07PM +0100, Daniel Kiper wrote:
> On Wed, Feb 21, 2018 at 03:20:27PM -0500, Peter Jones wrote:
> > This basically moves a bunch of the section information we pass around a
> > lot into a struct, and passes a pointer to a single one of th
This puts both kinds of address initialization at the same place, and also lets
us iterate through the section list one time fewer.
Signed-off-by: Peter Jones <pjo...@redhat.com>
---
util/grub-mkimagexx.c | 49 -
1 file changed, 24 inse
rs, which -W options we use, etc., but this makes it so you
can do the checking on the file you're editing, rather than on a
different file.
Signed-off-by: Peter Jones <pjo...@redhat.com>
---
util/grub-mkimage32.c | 2 ++
util/grub-mkimage64.c | 2 ++
util/grub-mkimagexx.c | 9 +
3 fi
now -msoft-float -mno-stack-arg-probe -mcmodel=large -mno-red-zone -m64
-mtune=generic -march=x86-64 -g3 -Os -freg-struct-return -fno-stack-protector
-ffreestanding -funwind-tables -fasynchronous-unwind-tables
-fno-strict-aliasing -fstack-clash-protection -fno-ident -fplugin=annobin
Signed-off
unctions are changed to also
be called section_vaddresses"inside those functions, so I get less confused
when I put addresses and vaddresses in a struct in a later patch.
Signed-off-by: Peter Jones <pjo...@redhat.com>
---
util/grub-mkimagexx.c | 20 ++--
1 file changed, 1
for section_addresses directly either.
This shouldn't change the binary file output or the "grub-mkimage -v"
output in any way.
Signed-off-by: Peter Jones <pjo...@redhat.com>
---
util/grub-mkimagexx.c | 273 ++
1 file changed, 121 insertions(+
On Wed, Feb 21, 2018 at 12:07:42PM +0100, Daniel Kiper wrote:
> This change does not seem to be logical part of this patch.
Okay, I've rolled all these things up into my local tree, get ready for
another volley of patches.
This version starts with 2 patches that are only vaguely related, that
grub_aout_load() has a grub_file_t parameter, and depending on what order
includes land in, it's sometimes not defined. This patch explicitly adds
file.h to aout.h so that it will always be defined.
Signed-off-by: Peter Jones <pjo...@redhat.com>
---
include/grub/aout.h | 1 +
1 file chan
This way debuginfo built from the .module will still include this
information, but the final result won't have the data we don't actually
need in the modules, either on-disk, loaded at runtime, or in prebuilt
images.
Signed-off-by: Peter Jones <pjo...@redhat.com>
---
grub-core/genmod.sh.
options: -machine pc-i440fx-2.4 -cpu Broadwell-noTSX
I've also tested this outcome on a real Intel Xeon E3-1275v3 on an Intel
Server Board S1200V3RPS using the SDV.RP.B8 "Release" build here:
https://firmware.intel.com/sites/default/files/UEFIDevKit_S1200RP_vB8.zip
Signed-off-by:
Make it so that when grub-module-verifier complains of an issue, it tells you
which module the issue was with.
Signed-off-by: Peter Jones
---
util/grub-module-verifier.c| 6 ++--
util/grub-module-verifierXX.c | 58 ++
include/grub/module_verifier.h | 4
clude dirs, which -W options we use, etc., but this makes it so you can do
the checking on the file you're editing, rather than on a different file.
Signed-off-by: Peter Jones
---
util/grub-module-verifier32.c | 2 ++
util/grub-module-verifier64.c | 2 ++
util/grub-module-verifierXX.c | 9 ++
Signed-off-by: Peter Jones
---
configure.ac | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure.ac b/configure.ac
index 5f47a9265f3..9ab683fefac 100644
--- a/configure.ac
+++ b/configure.ac
@@ -307,7 +307,7 @@ fi
AC_SUBST(bootdirname)
AC_DEFINE_UNQUOTED
clude dirs, which -W options we use, etc., but this makes it so you can do
the checking on the file you're editing, rather than on a different file.
v2: fix the typo in the #else clause in util/grub-module-verifierXX.c
Signed-off-by: Peter Jones
---
util/grub-module-verifier32.c | 2 ++
util/grub
On Tue, Mar 06, 2018 at 01:38:58PM -0800, Eric Snowberg wrote:
> The grub_mkimage_load_image function (commit 7542af6, mkimage: refactor a
> bunch
> of section data into a struct.) introduces a build regression on SPARC:
>
> cc1: warnings being treated as errors
> In file included from
On Mon, Jan 14, 2019 at 08:07:34AM +0100, Ard Biesheuvel wrote:
> > 3. The Shim's fallback mode has been used to recreate boot entries
> > after firmware update for x86, not sure if that any problem for ARM.
>
> It thought fallback was a separate binary? If the distros sign that,
> there is no
On Mon, Jan 14, 2019 at 05:14:21PM +0800, Michael Chang wrote:
> > > 3. The Shim's fallback mode has been used to recreate boot entries after
> > > firmware update for x86, not sure if that any problem for ARM.
> >
> > It thought fallback was a separate binary? If the distros sign that,
> > there
On Tue, Aug 06, 2019 at 09:44:14AM +0100, Leif Lindholm wrote:
> +Peter Jones (sorry Peter)
+ Javier Martinez Canillas
> On Tue, Aug 06, 2019 at 08:34:58AM +0200, Heinrich Schuchardt wrote:
> > iPXE uses the EFI simple network protocol to execute DHCP.
>
> OK.
>
&g
.
Signed-off-by: Peter Jones
---
grub-core/fs/squash4.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/grub-core/fs/squash4.c b/grub-core/fs/squash4.c
index 95d5c1e1ff4..0583aeab8e8 100644
--- a/grub-core/fs/squash4.c
+++ b/grub-core/fs/squash4.c
@@ -746,7 +746,7 @@ direct_read
gcc 9 using 'gcc -W -Wall -Wextra' (and that /much/ of it behaves
correctly), with the exception of grub-core/osdep/aros/hostdisk.c ,
which I have no idea how to build.
Signed-off-by: Peter Jones
---
grub-core/commands/date.c | 3 ++-
grub-core/commands/i386/cmostest.c
On Tue, Feb 04, 2020 at 08:04:30PM -0500, Nicholas Vinson wrote:
> On 2/4/20 16:02, Peter Jones wrote:
> > grub_strtoul() and grub_strtoull() don't make the /pointer/ to "end" be
> > const like normal implementations do, and as a result, at many places in
>
> g
On Tue, Feb 18, 2020 at 10:39:07PM -0500, Nicholas Vinson wrote:
> On 2/18/20 19:32, Peter Jones wrote:
> > On Tue, Feb 04, 2020 at 08:04:30PM -0500, Nicholas Vinson wrote:
> > > On 2/4/20 16:02, Peter Jones wrote:
> > > > grub_strtoul() and grub_strtoull() do
On Tue, Nov 30, 2021 at 05:08:20PM +0100, Daniel Kiper wrote:
> On Mon, Nov 29, 2021 at 06:11:36PM -0500, Robbie Harwood wrote:
> > Daniel Kiper writes:
> >
> > > On Wed, Nov 03, 2021 at 02:22:07PM -0400, Robbie Harwood wrote:
> > >> From: Peter Jones
>
On Fri, Feb 25, 2022 at 01:03:48PM +0100, Daniel Kiper wrote:
> On Fri, Feb 25, 2022 at 11:33:09AM +0100, Javier Martinez Canillas wrote:
> > Hello Peter,
> >
> > Thanks a lot for your patch.
> >
> > On 2/24/22 22:55, Peter Jones wrote:
> > > ChangeLog-20
with __COUNTER__ (A GNU C cpp extension) and token pasting to
create uniquely named internal variables.
Signed-off-by: Peter Jones
---
grub-core/fs/reiserfs.c| 28 +---
grub-core/loader/multiboot_elfxx.c | 4 +---
include/grub/misc.h| 25
On Thu, Mar 09, 2023 at 06:00:04PM -0500, Robbie Harwood wrote:
> Glenn Washburn writes:
> > 2. Why should the load command not be printed when secure boot is enabled?
> >* This was also requested by Daniel, I assume because of infomation
> > leakage
> > that may be a security concern.
; attributes.
>
> Fixes: bb4aa6e06 (efi: Drop all uses of efi_call_XX() wrappers)
>
> Reported-by: Christian Hesse
> Reported-by: Robin Candau
> Signed-off-by: Daniel Kiper
These all look like correct additions to me.
Reviewed-by: Peter Jones
> ---
> inc
72 matches
Mail list logo