Re: [PATCH 1/4] luks: fix out-of-bounds copy of UUID

Hi, Reviewed-by: Petr Vorel Kind regards, Petr ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

[PATCH 0/4] Fix Travis CI

Hi, although grub does not use Travis CI (or at least not publicly) some developers might welcome fixed .travis.yml for testing their patches. I haven't figured out how to fix riscv32 and mips. Kind regards, Petr Petr Vorel (4): travis: Run bootstrap to fix build travis: Fix sparc64

[PATCH 3/4] travis: Remove mips builds

Remove mips builds fix configure error: configure: error: could not force big-endian) Signed-off-by: Petr Vorel --- .travis.yml | 4 1 file changed, 4 deletions(-) diff --git a/.travis.yml b/.travis.yml index d019a0172..ca2a1fa5a 100644 --- a/.travis.yml +++ b/.travis.yml @@ -87,10 +87,6

[PATCH 2/4] travis: Fix sparc64 build

Instead non-existing sparc64-ieee1275 format use all 3 sparc64 formats: sparc64-ieee1275-{aout,cdcore,raw}. Signed-off-by: Petr Vorel --- .travis.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.travis.yml b/.travis.yml index 4bd05a30a..d019a0172 100644 --- a

[PATCH 1/4] travis: Run bootstrap to fix build

autogen.sh isn't enough: $ ./autogen.sh Gnulib not yet bootstrapped; run ./bootstrap instead. The command "./autogen.sh" exited with 1. Using bootstrap requires to install autopoint package. Signed-off-by: Petr Vorel --- .travis.yml | 3 ++- 1 file changed, 2 insertions(+), 1 de

[PATCH 4/4] travis: Remove riscv32 build

To fix travis error: grub-mkimage: error: target 1036 not reachable from pc=ba. Signed-off-by: Petr Vorel --- .travis.yml | 4 1 file changed, 4 deletions(-) diff --git a/.travis.yml b/.travis.yml index ca2a1fa5a..8628c526f 100644 --- a/.travis.yml +++ b/.travis.yml @@ -95,10 +95,6

Re: [PATCH 3/4] travis: Remove mips builds

Hi Daniel, > On Wed, Sep 09, 2020 at 10:02:20PM +0200, Petr Vorel wrote: > > Remove mips builds fix configure error: > > configure: error: could not force big-endian) > Could you try to fix mips and risc5 builds instead of removing them? Right, I'll try and send

Re: [PATCH 2/4] travis: Fix sparc64 build

Hi Daniel, thanks for merging first commit. > On Wed, Sep 09, 2020 at 10:02:19PM +0200, Petr Vorel wrote: > > Instead non-existing sparc64-ieee1275 format use all 3 sparc64 formats: > > sparc64-ieee1275-{aout,cdcore,raw}. > > Signed-off-by: Petr Vorel > > --- > &g

Re: [PATCH 3/4] travis: Remove mips builds

> On Wed, Sep 09, 2020 at 10:02:20PM +0200, Petr Vorel wrote: > > Remove mips builds fix configure error: > > configure: error: could not force big-endian) > Could you try to fix mips and risc5 builds instead of removing them? mips fails due using compiler [1] which lacks lacks

Re: [PATCH 4/4] travis: Remove riscv32 build

Hi Daniel, > To fix travis error: > grub-mkimage: error: target 1036 not reachable from pc=ba. https://travis-ci.org/github/pevik/grub/jobs/729143844 $ for target in $GRUB_TARGETS; do grub-mkimage -c grub.cfg -p / -O $target -o grub-$target echo reboot normal; done grub-mkimage: error: target 10

Re: [PATCH 2/4] travis: Fix sparc64 build

Hi Daniel, ... > > ># Build all selected GRUB targets. > > >- for target in $GRUB_TARGETS; do > > > - plat=${target#*-}; > > > - arch=${target%-*}; > > > + arch=$(echo $target | cut -d- -f1); > > > + plat=$(echo $target | cut -d- -f2); > > I think it should be: plat=$(

Re: [PATCH 4/4] travis: Remove riscv32 build

Hi Glenn, > On Tue, 27 Oct 2020 21:06:45 +0100 > Daniel Kiper wrote: > > Adding Alex... > > On Tue, Sep 22, 2020 at 11:20:12AM +0200, Petr Vorel wrote: > > > Hi Daniel, > > > > To fix travis error: > > > > grub-mkimage: error: target 1036 not

Re: [PATCH v3 3/5] argon2: Import Argon2 from cryptsetup

Hi Patrick, I know that this patchset needs some changes and is not planned to be included in 2.06. But anyway, testing it I found: ... > +++ b/grub-core/lib/argon2/core.c > +/* for explicit_bzero() on glibc */ > +#define _DEFAULT_SOURCE ... > +#if defined(__OpenBSD__) > +#define HAVE_EXPLICIT_BZ

Re: [PATCH v3 3/5] argon2: Import Argon2 from cryptsetup

ses it and it has to be converted after installation with Live CD / connecting HDD on different machine. Therefore postponing Argon2 to another release means users will have it in 2+ years after 2.06 release (unless distros backport it). Kind regards, Petr > Dmitry > вт, 19 янв. 2021 г. в 03:0

Re: [PATCH v3 3/5] argon2: Import Argon2 from cryptsetup

Hi Patrick, > On Tue, Jan 19, 2021 at 02:06:15PM +0100, Petr Vorel wrote: > > Hi, > > > Please try to build only for the "efi-64" platform. (not "pc") > > right, I'll test it, but we need to support also legacy bios. > I wasn't aware

Re: [PATCH] Fix potential truncation of mdraid device list

. > Fixes: 49de079bbe1c ("... (grub_util_raid_getmembers): Handle "removed" > disks") > Fixes: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1912043 > Fixes: https://savannah.gnu.org/bugs/index.php?59887 > Signed-off-by: Kees Cook Reviewed-by: Petr Vorel Ki

Re: IS: GRUB release cycle: WAS: Re: [PATCH v3 3/5] argon2: Import Argon2 from cryptsetup

Hi Daniel, [Cc Vladimir] ... > > > I don't really know about the release cycle, but personally I wouldn't > > > mind to accelerate it. That's only my two cents though as somebody who > > > hasn't been involved in the project that deeply. > > +1 (that would allow to greatly reduce number of patches

Re: IS: GRUB release cycle: WAS: Re: [PATCH v3 3/5] argon2: Import Argon2 from cryptsetup

> On Thu, Jan 21, 2021 at 10:30:11PM +0100, Petr Vorel wrote: > > Hi Daniel, > > [Cc Vladimir] > > ... > > > > > I don't really know about the release cycle, but personally I wouldn't > > > > > mind to accelerate it. That's only

[PATCH 1/1] docs: luks2: Mention key derival function support

To give users hint why Argon2 (the default in cryptsetup for LUKS2) does not work. Signed-off-by: Petr Vorel --- Hi, it'd be nice to have it for Grub 2.06. Kind regards, Petr docs/grub.texi | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/docs/grub.texi b/docs/grub

Re: [PATCH 1/1] docs: luks2: Mention key derival function support

Hi Paul, Patrick, > Dear Petr, > Thank you for your patch. thanks for your review! ... > > -before this command can be used. > > +before this command can be used. For LUKS2 only the PBKDF2 key derival > > +function is supported (Argon2 is not yet supported). > Nit: I’d get rid of the parenthes

[PATCH v2 1/1] docs: luks2: Mention key derival function support

To give users hint why Argon2 (the default in cryptsetup for LUKS2) does not work. Reviewed-by: Patrick Steinhardt Acked-by: Paul Menzel Signed-off-by: Petr Vorel --- Changes v1->v2: * remove parentheses (suggested by Paul Menzel) Kind regards, Petr docs/grub.texi | 3 ++- 1 file changed

Re: [PATCH 1/1] docs: luks2: Mention key derival function support

Hi Milan, ... > > GRUB suports devices encrypted using LUKS, LUKS2 and geli. Note that > > necessary > > modules (@var{luks}, @var{luks2} and @var{geli}) have to be loaded manually > > -before this command can be used. > > +before this command can be used. For LUKS2 only the PBKDF2 key derival

[PATCH v3 1/1] docs: luks2: Mention key derivation function support

To give users hint why Argon2 (the default in cryptsetup for LUKS2) does not work. Reviewed-by: Patrick Steinhardt Acked-by: Paul Menzel Signed-off-by: Petr Vorel --- Changes v2->v3 * Use proper term (pointed out by Milan Broz) s/derival/derivation/ Kind regards, Petr docs/grub.texi

[PATCH 0/2] linux: use stat instead of udevadm for partition lookup + cleanup

Hi, I'm backporting Jeff's patch from openSUSE + adding little cleanup. Kind regards, Petr Jeff Mahoney (1): grub2: use stat instead of udevadm for partition lookup Petr Vorel (1): osdep: Introduce major.h and use it grub-core/osdep/devmapper/getroot.c | 7 +-- grub-

[PATCH 1/2] osdep: Introduce major.h and use it

Signed-off-by: Petr Vorel --- grub-core/osdep/devmapper/getroot.c | 7 +-- grub-core/osdep/devmapper/hostdisk.c | 7 +-- grub-core/osdep/linux/getroot.c | 7 +-- grub-core/osdep/unix/getroot.c | 7 +-- include/grub/osdep/major.h | 30

[PATCH 2/2] grub2: use stat instead of udevadm for partition lookup

. Signed-off-by: Jeff Mahoney [ pvorel: include grub/osdep/major.h ] Signed-off-by: Petr Vorel --- grub-core/osdep/linux/hostdisk.c | 8 1 file changed, 8 insertions(+) diff --git a/grub-core/osdep/linux/hostdisk.c b/grub-core/osdep/linux/hostdisk.c index da62f924e..43dc4b0ba 100644

Re: [PATCH 2/2] grub2: use stat instead of udevadm for partition lookup

Hi Paul, > Dear Petr, dear Jeff, > Am 08.07.21 um 17:55 schrieb Petr Vorel: > > From: Jeff Mahoney > > sysfs_partition_path calls udevadm to resolve the sysfs path for > > a block device. That can be accomplished by stating the device node > > and using the majo

Re: [PATCH 1/2] osdep: Introduce major.h and use it

> On Thu, Jul 08, 2021 at 05:55:57PM +0200, Petr Vorel wrote: > > Signed-off-by: Petr Vorel > > --- > > grub-core/osdep/devmapper/getroot.c | 7 +-- > > grub-core/osdep/devmapper/hostdisk.c | 7 +-- > > grub-core/osdep/linux/getroot.c | 7

Re: [PATCH 2/2] grub2: use stat instead of udevadm for partition lookup

Hi all, > On 7/13/21 1:48 PM, Daniel Kiper wrote: > > On Thu, Jul 08, 2021 at 05:55:58PM +0200, Petr Vorel wrote: > >> From: Jeff Mahoney > >> sysfs_partition_path calls udevadm to resolve the sysfs path for > >> a block device. That can be accomplished by st

Re: [PATCH 2/2] grub2: use stat instead of udevadm for partition lookup

Hi Michael, > On Tue, Jul 13, 2021 at 12:52:12PM +0200, Petr Vorel wrote: > > Hi Paul, > > > Dear Petr, dear Jeff, > > > Am 08.07.21 um 17:55 schrieb Petr Vorel: > > > > From: Jeff Mahoney > > > > sysfs_partition_path calls udevadm to reso

Re: [PATCH 1/2] osdep: Introduce major.h and use it

Hi Daniel, > > On Thu, Jul 08, 2021 at 05:55:57PM +0200, Petr Vorel wrote: > > > Signed-off-by: Petr Vorel > > > --- > > > grub-core/osdep/devmapper/getroot.c | 7 +-- > > > grub-core/osdep/devmapper/hostdisk.c | 7 +-- > &

Re: [PATCH 1/2] osdep: Introduce major.h and use it

Hi Daniel, > On Wed, Jul 14, 2021 at 08:54:29AM +0200, Petr Vorel wrote: > > Hi Daniel, > > > > On Thu, Jul 08, 2021 at 05:55:57PM +0200, Petr Vorel wrote: > > > > > Signed-off-by: Petr Vorel > > > > > --- > > > > > grub-core/

Re: [PATCH 1/2] osdep: Introduce major.h and use it

Hi Daniel, ... > > > +/* > > > + * Fix for glibc 2.25 is deprecating the namespace pollution of > > > sys/types.h > > > + * injecting major(), minor(), and makedev() into the compilation > > > environment. > > > + * See configure.ac. > > It seems to me "See configure.ac." is not relevant in the

[PATCH v2 2/2] linux/hostdisk: use stat() instead of udevadm for partition lookup

system without LVM (which uses libdevmapper instead sysfs_partition_path()). Signed-off-by: Jeff Mahoney [ pvorel: remove udevadm fallback as it does not help us more than calling stat() directly; include , update commit message. ] Signed-off-by: Petr Vorel --- changes v1->v2: * remove udev

[PATCH v2 1/2] osdep: Introduce major.h and use it

to factor out fix for glibc 2.25 introduced in 7a5b301e3 ("build: Use AC_HEADER_MAJOR to find device macros"). NOTE: Once glibc 2.25 is old enough and this fix is not needed also AC_HEADER_MAJOR in configure.ac should be removed. Signed-off-by: Petr Vorel --- changes v1->v2: * im

[PATCH v2 0/2] linux: use stat instead of udevadm for partition lookup

isk: use stat() instead of udevadm for partition lookup Petr Vorel (1): osdep: Introduce major.h and use it configure.ac | 2 +- grub-core/osdep/devmapper/getroot.c | 7 +--- grub-core/osdep/devmapper/hostdisk.c | 7 +--- grub-core/osdep/linux/getroot.c | 7 +--- g

[PATCH 1/2] bootstrap: Require patch

bootstrap.conf uses patch, let's require it. Better than multiple messages: ./bootstrap.conf: line 84: patch: command not found Signed-off-by: Petr Vorel --- bootstrap.conf | 1 + 1 file changed, 1 insertion(+) diff --git a/bootstrap.conf b/bootstrap.conf index 6b043fc35..0dd893c5c 1

[PATCH 2/2] autogen.sh: Detect python

It help to avoid error on distros which has only python3 binary: ./autogen.sh: line 20: python: command not found Using bash builtin 'command -v' to avoid requiring which as extra dependency (usable on containers). Keep the possibility to define PYTHON. Signed-off-by:

Re: [PATCH v4 1/5] kern: dl: Allow modules under CC0 license

Hi Patrick, Reviewed-by: Petr Vorel Kind regards, Petr ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH 2/2] autogen.sh: Detect python

Hi Daniel, sorry for longer time to reply (vacation). > On Fri, Aug 06, 2021 at 08:45:08AM +0200, Petr Vorel wrote: > > It help to avoid error on distros which has only python3 binary: > > ./autogen.sh: line 20: python: command not found > > Using bash builtin 'comm

Re: [PATCH 2/2] autogen.sh: Detect python

> On Mon, Aug 09, 2021 at 01:52:29PM +0200, Daniel Kiper wrote: > > On Fri, Aug 06, 2021 at 08:45:08AM +0200, Petr Vorel wrote: > > > It help to avoid error on distros which has only python3 binary: > > > ./autogen.sh: line 20: python: command not found > > >

Re: [PATCH 2/2] autogen.sh: Detect python

> Hi Daniel, > sorry for longer time to reply (vacation). > > On Fri, Aug 06, 2021 at 08:45:08AM +0200, Petr Vorel wrote: > > > It help to avoid error on distros which has only python3 binary: > > > ./autogen.sh: line 20: python: command not found > > > U

Re: [PATCH 2/2] autogen.sh: Detect python

Hi, > Personally I would just change it to "set PYTHON to python3 if not set" and > that's it. Why bothering user to set environment variable when autodetection is possible? > Python2 is irrelevant. Fair enough for me to drop python 2 from autodetection. There probably aren't many people who woul

Re: [PATCH 2/2] autogen.sh: Detect python

Hi Daniel, > On Wed, Aug 18, 2021 at 09:19:23AM +0200, Petr Vorel wrote: > > > On Mon, Aug 09, 2021 at 01:52:29PM +0200, Daniel Kiper wrote: > > > > On Fri, Aug 06, 2021 at 08:45:08AM +0200, Petr Vorel wrote: > > > > > It help to avoid error o

[PATCH v2 2/2] autogen.sh: Detect python

not be needed keep the possibility to define PYTHON. For detection use "command -v" which is POSIX [3] and supported on all common shells (bash, zsh, dash, busybox sh, mksh) instead requiring "which" as extra dependency (usable on containers). Update INSTALL. Signe

[PATCH v2 1/2] bootstrap: INSTALL: Require GNU patch

bootstrap.conf uses patch, let's require it. Better than multiple messages: ./bootstrap.conf: line 84: patch: command not found Mention it also in INSTALL. Signed-off-by: Petr Vorel --- Changes v1->v2: * mention patch in INSTALL INSTALL| 1 + bootstrap.conf | 1 + 2 files ch

Re: [PATCH v2 2/2] autogen.sh: Detect python

Hi Daniel, > On Mon, Aug 30, 2021 at 11:53:17AM +0200, Petr Vorel wrote: > > It help to avoid error on distros which has only python3 binary: > > ./autogen.sh: line 20: python: command not found > > Use python3 as the default as python2 is EOL since Jan 2020, but check >

Re: [PATCH] osdep/linux: Fix md array device enumeration

; (1 << MD_DISK_ACTIVE))) > > + continue; > > + > > + devicelist[j++] = grub_find_device (NULL, makedev (disk.major, > > +disk.minor)); > I would prefer if you leave

Re: [PATCH] osdep/linux: Fix md array device enumeration

Hi Kees, > Hi Petr, > On Wed, Oct 06, 2021 at 09:28:32AM +0200, Petr Vorel wrote: > > Hi Kees, Daniel, > > > On Sat, Sep 25, 2021 at 07:03:35PM -0700, k...@ubuntu.com wrote: > > > > From: Kees Cook > > > > GET_ARRAY_INFO's info.nr_disks d